[jira] Commented: (TOMAHAWK-127) Some components do not render valid html

[Mike Kienenberger (JIRA)]

[ 
https://issues.apache.org/jira/browse/TOMAHAWK-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485327
 ] 

Mike Kienenberger commented on TOMAHAWK-127:


Cancelling patch since it hasn't been valid for 6 months.


 Some components do not render valid html
 

 Key: TOMAHAWK-127
 URL: https://issues.apache.org/jira/browse/TOMAHAWK-127
 Project: MyFaces Tomahawk
  Issue Type: Bug
  Components: Panel Navigation2
 Environment: tested on jboss4.0.3/sun jdk 1.5.0_r05/linux with 
 myFaces 1.1.1 and nightly build 20051230
Reporter: Carsten Stiller
 Assigned To: Martin Marinschek
Priority: Minor
 Attachments: HtmlNavigationMenuRendererUtils.java.diff


 Some components do not render valid html (checked with w3c-validator against 
 HTML4.01strict and XHTML1.0)
 h:form /: The hidden input /-Tag has to be inside a block-element (a  
 div / or whatever)
 rendered code:
 form
 ...
   input name=form_SUBMIT value=1 type=hidden /
 /form
 w3c-validator message: document type does not allow element INPUT here; 
 missing one of P, H1, H2, H3, H4, H5, H6, PRE, DIV, 
 ADDRESS start-tag.
 h:selectManyListbox /: Attribute is rendered as 'multiple=true'  instead 
 of 'multiple=multiple'
 rendered code: 
 select id=... name=... multiple=true
 ...
 /select
 w3c-validator message: value of attribute MULTIPLE cannot be TRUE; must 
 be one of MULTIPLE.
 t:panelNavigation2 /: When layout=list is selected and nested menus  are 
 used, non-active parts of the menu-trees include empty ul /-tags.  (At 
 least one li / is required inside of ul/ul).
 jsf-code:
 t:panelNavigation2 id=... layout=...
   t:commandNavigation2 id=... action=... value=...
   t:commandNavigation2 id=... value=... action=... /
   t:commandNavigation2 id=... value=... action=... /  
 
   /t:commandNavigation2 
   t:commandNavigation2 id=... action=... value=... /
 /t:panelNavigation2
 rendered code, when menu-tree is closed:
 ul
 lia href=... id=.. /aul/ul/li
 lia href=... id=../a/li
 /ul
 w3c-validator message: end tag for UL which is not finished.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (TOMAHAWK-127) Some components do not render valid html

[Martin Marinschek (JIRA)]

[ 
http://issues.apache.org/jira/browse/TOMAHAWK-127?page=comments#action_12436670 
] 

Martin Marinschek commented on TOMAHAWK-127:


The patch is not valid anymore, and can't be applied automatically (it's in a 
strange format). I'm not sure about the correct position where to apply the 
changes manually. Can you do this patch again?

thanks,

regards,

Martin

 Some components do not render valid html
 

 Key: TOMAHAWK-127
 URL: http://issues.apache.org/jira/browse/TOMAHAWK-127
 Project: MyFaces Tomahawk
  Issue Type: Bug
  Components: Panel Navigation2
 Environment: tested on jboss4.0.3/sun jdk 1.5.0_r05/linux with 
 myFaces 1.1.1 and nightly build 20051230
Reporter: Carsten Stiller
 Assigned To: Martin Marinschek
Priority: Minor
 Attachments: HtmlNavigationMenuRendererUtils.java.diff


 Some components do not render valid html (checked with w3c-validator against 
 HTML4.01strict and XHTML1.0)
 h:form /: The hidden input /-Tag has to be inside a block-element (a  
 div / or whatever)
 rendered code:
 form
 ...
   input name=form_SUBMIT value=1 type=hidden /
 /form
 w3c-validator message: document type does not allow element INPUT here; 
 missing one of P, H1, H2, H3, H4, H5, H6, PRE, DIV, 
 ADDRESS start-tag.
 h:selectManyListbox /: Attribute is rendered as 'multiple=true'  instead 
 of 'multiple=multiple'
 rendered code: 
 select id=... name=... multiple=true
 ...
 /select
 w3c-validator message: value of attribute MULTIPLE cannot be TRUE; must 
 be one of MULTIPLE.
 t:panelNavigation2 /: When layout=list is selected and nested menus  are 
 used, non-active parts of the menu-trees include empty ul /-tags.  (At 
 least one li / is required inside of ul/ul).
 jsf-code:
 t:panelNavigation2 id=... layout=...
   t:commandNavigation2 id=... action=... value=...
   t:commandNavigation2 id=... value=... action=... /
   t:commandNavigation2 id=... value=... action=... /  
 
   /t:commandNavigation2 
   t:commandNavigation2 id=... action=... value=... /
 /t:panelNavigation2
 rendered code, when menu-tree is closed:
 ul
 lia href=... id=.. /aul/ul/li
 lia href=... id=../a/li
 /ul
 w3c-validator message: end tag for UL which is not finished.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira