[jira] Commented: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project
[ http://issues.apache.org/jira/browse/TOMAHAWK-516?page=comments#action_12446762 ] Matt Tyson commented on TOMAHAWK-516: - I am attempting to use this functionality. From looking at the code, the renderer appears to be incorrectly assigning the JSCookMenu target attribute to the FORM instead of a window target: // Change here to allow the use of non dummy form. writer.append(formName); Also, when I enclose the JSCookMenu in a adf form, it doesn't appear to be recognized, the menu is renderered with 'dummyLinkForm': [null, 'Log Off', null, 'linkDummyForm', null] So there appears to be these two issues still (this is on the 1.1.5 snapshot from about 10/28/06) JSCookMenu problems in a Trinidad project - Key: TOMAHAWK-516 URL: http://issues.apache.org/jira/browse/TOMAHAWK-516 Project: MyFaces Tomahawk Issue Type: Bug Components: JS Cook Menu Environment: Any project configured to use both Trinidad and MyFaces Tomahawk Reporter: Cosma Colanicchia Assigned To: Matthias Weßendorf Fix For: 1.1.5-SNAPSHOT Attachments: JSCookMenu-with-Trinidad-refactored.patch, JSCookMenu-with-Trinidad.patch Using JSCookMenu in a MyFaces+Trinidad project leads to some problems. 1) HtmlJSCookMenuRenderer tries to find the parent form searching for an UIForm component, but the Trinidad CoreForm doesn't extend UIForm. The enclosing so isn't recognized, and another dummyform gets rendered in the page. 2) HtmlJSCookMenuRenderer also call HtmlFormRendererBase.addHiddenCommandParameter to add an hidden fields, needed by JSCookMenu, in the form. That field however doesn't get rendered and a javascript error happens when trying to use the menu. This is probably caused by the Trinidad renderer that override the MyFaces one, and happens using either h:form or af:form. Problem 1) also makes it impossible to use the af:form's targetFrame feature to load the action result in another target/frame. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project
[ http://issues.apache.org/jira/browse/TOMAHAWK-516?page=comments#action_12435832 ] Cosma Colanicchia commented on TOMAHAWK-516: Sorry guys, sources for my test projects was on a pc that now is in assistance, and my schedule doesn't allow me to replicate that situation from scratch.. I remember that the problem not solved by the Martin's commit was due to JSCookMenu usage of the addHiddenCommandParameter method (the one described above as #2). It should be easy to check if JSCookMenu now works when used in a Trinidad projects with latest jars. JSCookMenu problems in a Trinidad project - Key: TOMAHAWK-516 URL: http://issues.apache.org/jira/browse/TOMAHAWK-516 Project: MyFaces Tomahawk Issue Type: Bug Components: JS Cook Menu Environment: Any project configured to use both Trinidad and MyFaces Tomahawk Reporter: Cosma Colanicchia Assigned To: Matthias Weßendorf Fix For: 1.1.5-SNAPSHOT Attachments: JSCookMenu-with-Trinidad-refactored.patch, JSCookMenu-with-Trinidad.patch Using JSCookMenu in a MyFaces+Trinidad project leads to some problems. 1) HtmlJSCookMenuRenderer tries to find the parent form searching for an UIForm component, but the Trinidad CoreForm doesn't extend UIForm. The enclosing so isn't recognized, and another dummyform gets rendered in the page. 2) HtmlJSCookMenuRenderer also call HtmlFormRendererBase.addHiddenCommandParameter to add an hidden fields, needed by JSCookMenu, in the form. That field however doesn't get rendered and a javascript error happens when trying to use the menu. This is probably caused by the Trinidad renderer that override the MyFaces one, and happens using either h:form or af:form. Problem 1) also makes it impossible to use the af:form's targetFrame feature to load the action result in another target/frame. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project
[ http://issues.apache.org/jira/browse/TOMAHAWK-516?page=comments#action_12435660 ] Martin Marinschek commented on TOMAHAWK-516: Cosma, can we have an update of you in how far my latest changes have fixed this problem? regards, Martin JSCookMenu problems in a Trinidad project - Key: TOMAHAWK-516 URL: http://issues.apache.org/jira/browse/TOMAHAWK-516 Project: MyFaces Tomahawk Issue Type: Bug Components: JS Cook Menu Environment: Any project configured to use both Trinidad and MyFaces Tomahawk Reporter: Cosma Colanicchia Assigned To: Matthias Weßendorf Attachments: JSCookMenu-with-Trinidad-refactored.patch, JSCookMenu-with-Trinidad.patch Using JSCookMenu in a MyFaces+Trinidad project leads to some problems. 1) HtmlJSCookMenuRenderer tries to find the parent form searching for an UIForm component, but the Trinidad CoreForm doesn't extend UIForm. The enclosing so isn't recognized, and another dummyform gets rendered in the page. 2) HtmlJSCookMenuRenderer also call HtmlFormRendererBase.addHiddenCommandParameter to add an hidden fields, needed by JSCookMenu, in the form. That field however doesn't get rendered and a javascript error happens when trying to use the menu. This is probably caused by the Trinidad renderer that override the MyFaces one, and happens using either h:form or af:form. Problem 1) also makes it impossible to use the af:form's targetFrame feature to load the action result in another target/frame. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project
[ http://issues.apache.org/jira/browse/TOMAHAWK-516?page=comments#action_12421993 ] Cosma Colanicchia commented on TOMAHAWK-516: The findNestingForm refactoring has already been coded and committed in the meantime by Martin Marinschek, while a discussion on some a possible generic solution for the HtmlFormRendererBase.addHiddenCommandParameter problem has started. See this thread http://mail-archives.apache.org/mod_mbox/incubator-adffaces-user/200607.mbox/[EMAIL PROTECTED] for detail. Note that the current patch should not be applied IMO, it will likely cause many conflicts. The MyFacesHack.js modification is the only thing that still could be submitted to allow at least JSCookMenu to work, in case a generic solution will not be found in a reasonable time. JSCookMenu problems in a Trinidad project - Key: TOMAHAWK-516 URL: http://issues.apache.org/jira/browse/TOMAHAWK-516 Project: MyFaces Tomahawk Issue Type: Bug Components: JS Cook Menu Environment: Any project configured to use both Trinidad and MyFaces Tomahawk Reporter: Cosma Colanicchia Assigned To: Matthias Weßendorf Attachments: JSCookMenu-with-Trinidad-refactored.patch, JSCookMenu-with-Trinidad.patch Using JSCookMenu in a MyFaces+Trinidad project leads to some problems. 1) HtmlJSCookMenuRenderer tries to find the parent form searching for an UIForm component, but the Trinidad CoreForm doesn't extend UIForm. The enclosing so isn't recognized, and another dummyform gets rendered in the page. 2) HtmlJSCookMenuRenderer also call HtmlFormRendererBase.addHiddenCommandParameter to add an hidden fields, needed by JSCookMenu, in the form. That field however doesn't get rendered and a javascript error happens when trying to use the menu. This is probably caused by the Trinidad renderer that override the MyFaces one, and happens using either h:form or af:form. Problem 1) also makes it impossible to use the af:form's targetFrame feature to load the action result in another target/frame. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
