[jira] [Commented] (MYFACES-4345) ClientWindow url rendering doesn't follow the specs
[ https://issues.apache.org/jira/browse/MYFACES-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142749#comment-17142749 ] Thomas Andraschko commented on MYFACES-4345: See: https://github.com/primefaces/primefaces/issues/6030 > ClientWindow url rendering doesn't follow the specs > --- > > Key: MYFACES-4345 > URL: https://issues.apache.org/jira/browse/MYFACES-4345 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.2.12, 2.3.6, 2.3-next-M2 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.2.13, 2.3.7, 3.0.0, 2.3-next-M3 > > > The specs says that the ClientWindow Id always has to be appended to the > URLs, if the ClientWindow != null and isClientWindowRenderModeEnabled. > This means that #getQueryURLParameters is just something additional (as you > can read the javadoc on it). > Currently we only rely on #getQueryURLParameters -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4340) Managed converter can not be injected into other CDI bean
[
https://issues.apache.org/jira/browse/MYFACES-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4340.
Resolution: Fixed
> Managed converter can not be injected into other CDI bean
> -
>
> Key: MYFACES-4340
> URL: https://issues.apache.org/jira/browse/MYFACES-4340
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.6
>Reporter: Jan Krpata
>Priority: Major
> Fix For: 2.3-next-M3
>
>
> If CDI bean injects a managed converter with @FacesConverter @Qualifier,
> AmbiguousResolutionException will be thrown
>
> {code:java}
> org.apache.webbeans.exception.WebBeansDeploymentException:
> javax.enterprise.inject.AmbiguousResolutionException: There is more than one
> Bean with type cz.krpata.jsf23.UserConverter Qualifiers:
> [@javax.faces.convert.FacesConverter(value=, forClass=class
> cz.krpata.jsf23.User, managed=true)]
> for injection into Field Injection Point, field name : userConverter, Bean
> Owner : [InjectConverterIntoBean, WebBeansType:MANAGED,
> Name:injectConverterIntoBean, API
> Types:[cz.krpata.jsf23.InjectConverterIntoBean,java.lang.Object],
> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any,javax.inject.Named]]
> found beans:
> UserConverter, WebBeansType:THIRDPARTY, Name:null, API
> Types:[cz.krpata.jsf23.UserConverter,java.lang.Object],
> Qualifiers:[javax.enterprise.inject.Any,javax.faces.convert.FacesConverter]
> from
> file:/C:/Users/krpata/eclipse-2020-03-workspace/.metadata/.plugins/org.eclipse.wst.server.core/tmp4/wtpwebapps/PFCsvTest-myfaces/WEB-INF/classes/cz/krpata/jsf23/UserConverter.class
> UserConverter, WebBeansType:MANAGED, Name:null, API
> Types:[cz.krpata.jsf23.UserConverter,java.lang.Object,javax.faces.convert.Converter],
> Qualifiers:[javax.enterprise.inject.Any,javax.faces.convert.FacesConverter]
> from
> file:/C:/Users/krpata/eclipse-2020-03-workspace/.metadata/.plugins/org.eclipse.wst.server.core/tmp4/wtpwebapps/PFCsvTest-myfaces/WEB-INF/classes/cz/krpata/jsf23/UserConverter.class
> {code}
>
> Dependencies:
> * MyFaces 2.3.6
> * CDI (OWB) 2.0.14
> Classes:
>
> {code:java}
> @FacesConverter(forClass=User.class, managed = true)
> public class UserConverter implements Converter { @Inject
> private UserDAO userDAO;
>
> @Override
> public User getAsObject(final FacesContext facesContext, final
> UIComponent uiComponent, final String name) {
> return userDAO.getUserByName(name);
> }
> @Override
> public String getAsString(final FacesContext facesContext, final
> UIComponent uiComponent, final User user) {
> return user.getFirstname() + " " + user.getSurname();
> }
> }
> {code}
> {code:java}
> @RequestScoped
> @Named
> public class InjectConverterIntoBean {
>
> @Inject
> @FacesConverter(forClass=User.class, managed = true)
> private UserConverter userConverter;
> ...
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MYFACES-4345) ClientWindow url rendering doesn't follow the specs
Thomas Andraschko created MYFACES-4345: -- Summary: ClientWindow url rendering doesn't follow the specs Key: MYFACES-4345 URL: https://issues.apache.org/jira/browse/MYFACES-4345 Project: MyFaces Core Issue Type: Bug Reporter: Thomas Andraschko Assignee: Thomas Andraschko The specs says that the ClientWindow Id always has to be appended to the URLs, if the ClientWindow != null and isClientWindowRenderModeEnabled. This means that #getQueryURLParameters is just something additional (as you can read the javadoc on it). Currently we only rely on #getQueryURLParameters -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4345) ClientWindow url rendering doesn't follow the specs
[ https://issues.apache.org/jira/browse/MYFACES-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4345. Resolution: Fixed > ClientWindow url rendering doesn't follow the specs > --- > > Key: MYFACES-4345 > URL: https://issues.apache.org/jira/browse/MYFACES-4345 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.2.12, 2.3.6, 2.3-next-M2 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.2.13, 2.3.7, 3.0.0, 2.3-next-M3 > > > The specs says that the ClientWindow Id always has to be appended to the > URLs, if the ClientWindow != null and isClientWindowRenderModeEnabled. > This means that #getQueryURLParameters is just something additional (as you > can read the javadoc on it). > Currently we only rely on #getQueryURLParameters -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4346) The ClientBehaviorContext.Parameter is not available from requestParameterMap
[
https://issues.apache.org/jira/browse/MYFACES-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4346.
Assignee: Thomas Andraschko
Resolution: Fixed
> The ClientBehaviorContext.Parameter is not available from requestParameterMap
> -
>
> Key: MYFACES-4346
> URL: https://issues.apache.org/jira/browse/MYFACES-4346
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3-next-M2
>Reporter: Jan Krpata
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 2.3-next-M3
>
>
>
> The ClientBehaviorContext.Parameter is not available from requestParameterMap.
>
> This is part of my component renderer.
>
> {code:java}
> public String onclick(UIComponent component, FacesContext context) {
> Collection paramList = new ArrayList<>();
> paramList.add(new
> javax.faces.component.behavior.ClientBehaviorContext.Parameter("my_param",
> "my_value"));
> Map> behaviors = ((ClientBehaviorHolder)
> component).getClientBehaviors();
> String onclick = ClientBehaviorRendererUtils.buildBehaviorChain(context,
> component, component.getClientId(), ClientBehaviorEvents.CLICK, paramList,
> ClientBehaviorEvents.ACTION, paramList, behaviors, null , null);
> return onclick;
> }
> {code}
> When i decode component parameter value is not available in
> requestParameterMap.
>
>
> {code:java}
> Map paramMap =
> facesContext.getExternalContext().getRequestParameterMap();
> // this works in 2.2.8
> String myParamValue = paramMap.get("my_param"); // null
> // in 2.3-next parameters are wrapped in params
> String paramValue = paramMap.get("params"); // [object Object]{code}
> This is because the paramater is wrapped in params in AjaxScriptBuilder.
>
> {code:java}
> params: {
> my_param: my_value
> }
> {code}
> During parameter processing in the jsf send method, the
> encodeURIComponent(val) is called, where var is just 'my_param: "my_value"'.
> The result of this method is '[object=Object]'.
>
> If I locally canceled the wrapping of parameters in AjaxScritBuilder into
> params, then everything started working again as in my old MyFaces version
> 2.2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4346) The ClientBehaviorContext.Parameter is not available from requestParameterMap
[
https://issues.apache.org/jira/browse/MYFACES-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143054#comment-17143054
]
Thomas Andraschko commented on MYFACES-4346:
ok, reverted it to 100% the old behavior
can you try it again?
> The ClientBehaviorContext.Parameter is not available from requestParameterMap
> -
>
> Key: MYFACES-4346
> URL: https://issues.apache.org/jira/browse/MYFACES-4346
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3-next-M2
>Reporter: Jan Krpata
>Priority: Major
>
>
> The ClientBehaviorContext.Parameter is not available from requestParameterMap.
>
> This is part of my component renderer.
>
> {code:java}
> public String onclick(UIComponent component, FacesContext context) {
> Collection paramList = new ArrayList<>();
> paramList.add(new
> javax.faces.component.behavior.ClientBehaviorContext.Parameter("my_param",
> "my_value"));
> Map> behaviors = ((ClientBehaviorHolder)
> component).getClientBehaviors();
> String onclick = ClientBehaviorRendererUtils.buildBehaviorChain(context,
> component, component.getClientId(), ClientBehaviorEvents.CLICK, paramList,
> ClientBehaviorEvents.ACTION, paramList, behaviors, null , null);
> return onclick;
> }
> {code}
> When i decode component parameter value is not available in
> requestParameterMap.
>
>
> {code:java}
> Map paramMap =
> facesContext.getExternalContext().getRequestParameterMap();
> // this works in 2.2.8
> String myParamValue = paramMap.get("my_param"); // null
> // in 2.3-next parameters are wrapped in params
> String paramValue = paramMap.get("params"); // [object Object]{code}
> This is because the paramater is wrapped in params in AjaxScriptBuilder.
>
> {code:java}
> params: {
> my_param: my_value
> }
> {code}
> During parameter processing in the jsf send method, the
> encodeURIComponent(val) is called, where var is just 'my_param: "my_value"'.
> The result of this method is '[object=Object]'.
>
> If I locally canceled the wrapping of parameters in AjaxScritBuilder into
> params, then everything started working again as in my old MyFaces version
> 2.2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MYFACES-4346) The ClientBehaviorContext.Parameter is not available from requestParameterMap
[
https://issues.apache.org/jira/browse/MYFACES-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143024#comment-17143024
]
Thomas Andraschko edited comment on MYFACES-4346 at 6/23/20, 3:26 PM:
--
AFAICS it worked in 2.3 but i refactored the whole code for 2.3-next.
However, it seems that Mojarra does the same.
So is it ok for you to close it as won't fix and aligned with Mojarra?
UPDATE: will also check its posted now, but the rendering of the AJAX script is
the same
was (Author: tandraschko):
AFAICS it worked in 2.3 but i refactored the whole code for 2.3-next.
However, it seems that Mojarra does the same.
So is it ok for you to close it as won't fix and aligned with Mojarra?
> The ClientBehaviorContext.Parameter is not available from requestParameterMap
> -
>
> Key: MYFACES-4346
> URL: https://issues.apache.org/jira/browse/MYFACES-4346
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3-next-M2
>Reporter: Jan Krpata
>Priority: Major
>
>
> The ClientBehaviorContext.Parameter is not available from requestParameterMap.
>
> This is part of my component renderer.
>
> {code:java}
> public String onclick(UIComponent component, FacesContext context) {
> Collection paramList = new ArrayList<>();
> paramList.add(new
> javax.faces.component.behavior.ClientBehaviorContext.Parameter("my_param",
> "my_value"));
> Map> behaviors = ((ClientBehaviorHolder)
> component).getClientBehaviors();
> String onclick = ClientBehaviorRendererUtils.buildBehaviorChain(context,
> component, component.getClientId(), ClientBehaviorEvents.CLICK, paramList,
> ClientBehaviorEvents.ACTION, paramList, behaviors, null , null);
> return onclick;
> }
> {code}
> When i decode component parameter value is not available in
> requestParameterMap.
>
>
> {code:java}
> Map paramMap =
> facesContext.getExternalContext().getRequestParameterMap();
> // this works in 2.2.8
> String myParamValue = paramMap.get("my_param"); // null
> // in 2.3-next parameters are wrapped in params
> String paramValue = paramMap.get("params"); // [object Object]{code}
> This is because the paramater is wrapped in params in AjaxScriptBuilder.
>
> {code:java}
> params: {
> my_param: my_value
> }
> {code}
> During parameter processing in the jsf send method, the
> encodeURIComponent(val) is called, where var is just 'my_param: "my_value"'.
> The result of this method is '[object=Object]'.
>
> If I locally canceled the wrapping of parameters in AjaxScritBuilder into
> params, then everything started working again as in my old MyFaces version
> 2.2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4346) The ClientBehaviorContext.Parameter is not available from requestParameterMap
[
https://issues.apache.org/jira/browse/MYFACES-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143024#comment-17143024
]
Thomas Andraschko commented on MYFACES-4346:
AFAICS it worked in 2.3 but i refactored the whole code for 2.3-next.
However, it seems that Mojarra does the same.
So is it ok for you to close it as won't fix and aligned with Mojarra?
> The ClientBehaviorContext.Parameter is not available from requestParameterMap
> -
>
> Key: MYFACES-4346
> URL: https://issues.apache.org/jira/browse/MYFACES-4346
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3-next-M2
>Reporter: Jan Krpata
>Priority: Major
>
>
> The ClientBehaviorContext.Parameter is not available from requestParameterMap.
>
> This is part of my component renderer.
>
> {code:java}
> public String onclick(UIComponent component, FacesContext context) {
> Collection paramList = new ArrayList<>();
> paramList.add(new
> javax.faces.component.behavior.ClientBehaviorContext.Parameter("my_param",
> "my_value"));
> Map> behaviors = ((ClientBehaviorHolder)
> component).getClientBehaviors();
> String onclick = ClientBehaviorRendererUtils.buildBehaviorChain(context,
> component, component.getClientId(), ClientBehaviorEvents.CLICK, paramList,
> ClientBehaviorEvents.ACTION, paramList, behaviors, null , null);
> return onclick;
> }
> {code}
> When i decode component parameter value is not available in
> requestParameterMap.
>
>
> {code:java}
> Map paramMap =
> facesContext.getExternalContext().getRequestParameterMap();
> // this works in 2.2.8
> String myParamValue = paramMap.get("my_param"); // null
> // in 2.3-next parameters are wrapped in params
> String paramValue = paramMap.get("params"); // [object Object]{code}
> This is because the paramater is wrapped in params in AjaxScriptBuilder.
>
> {code:java}
> params: {
> my_param: my_value
> }
> {code}
> During parameter processing in the jsf send method, the
> encodeURIComponent(val) is called, where var is just 'my_param: "my_value"'.
> The result of this method is '[object=Object]'.
>
> If I locally canceled the wrapping of parameters in AjaxScritBuilder into
> params, then everything started working again as in my old MyFaces version
> 2.2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4340) Managed converter can not be injected into other CDI bean
[
https://issues.apache.org/jira/browse/MYFACES-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17137913#comment-17137913
]
Thomas Andraschko commented on MYFACES-4340:
JFYI: the code was a bit unclear in 2.3.x and i completely refactored it in
trunk (2.3-next)
it would be great if you could give 2.3.next a try (checkit in github and do a
mvn clean install -DskipTests - we need to release the newer version soon), to
check if its fixed there.
> Managed converter can not be injected into other CDI bean
> -
>
> Key: MYFACES-4340
> URL: https://issues.apache.org/jira/browse/MYFACES-4340
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.6
>Reporter: Jan Krpata
>Priority: Major
>
> If CDI bean injects a managed converter with @FacesConverter @Qualifier,
> AmbiguousResolutionException will be thrown
>
> {code:java}
> org.apache.webbeans.exception.WebBeansDeploymentException:
> javax.enterprise.inject.AmbiguousResolutionException: There is more than one
> Bean with type cz.krpata.jsf23.UserConverter Qualifiers:
> [@javax.faces.convert.FacesConverter(value=, forClass=class
> cz.krpata.jsf23.User, managed=true)]
> for injection into Field Injection Point, field name : userConverter, Bean
> Owner : [InjectConverterIntoBean, WebBeansType:MANAGED,
> Name:injectConverterIntoBean, API
> Types:[cz.krpata.jsf23.InjectConverterIntoBean,java.lang.Object],
> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any,javax.inject.Named]]
> found beans:
> UserConverter, WebBeansType:THIRDPARTY, Name:null, API
> Types:[cz.krpata.jsf23.UserConverter,java.lang.Object],
> Qualifiers:[javax.enterprise.inject.Any,javax.faces.convert.FacesConverter]
> from
> file:/C:/Users/krpata/eclipse-2020-03-workspace/.metadata/.plugins/org.eclipse.wst.server.core/tmp4/wtpwebapps/PFCsvTest-myfaces/WEB-INF/classes/cz/krpata/jsf23/UserConverter.class
> UserConverter, WebBeansType:MANAGED, Name:null, API
> Types:[cz.krpata.jsf23.UserConverter,java.lang.Object,javax.faces.convert.Converter],
> Qualifiers:[javax.enterprise.inject.Any,javax.faces.convert.FacesConverter]
> from
> file:/C:/Users/krpata/eclipse-2020-03-workspace/.metadata/.plugins/org.eclipse.wst.server.core/tmp4/wtpwebapps/PFCsvTest-myfaces/WEB-INF/classes/cz/krpata/jsf23/UserConverter.class
> {code}
>
> Dependencies:
> * MyFaces 2.3.6
> * CDI (OWB) 2.0.14
> Classes:
>
> {code:java}
> @FacesConverter(forClass=User.class, managed = true)
> public class UserConverter implements Converter { @Inject
> private UserDAO userDAO;
>
> @Override
> public User getAsObject(final FacesContext facesContext, final
> UIComponent uiComponent, final String name) {
> return userDAO.getUserByName(name);
> }
> @Override
> public String getAsString(final FacesContext facesContext, final
> UIComponent uiComponent, final User user) {
> return user.getFirstname() + " " + user.getSurname();
> }
> }
> {code}
> {code:java}
> @RequestScoped
> @Named
> public class InjectConverterIntoBean {
>
> @Inject
> @FacesConverter(forClass=User.class, managed = true)
> private UserConverter userConverter;
> ...
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4337) [perf] avoid lambda instances / computeIfAbsent
[ https://issues.apache.org/jira/browse/MYFACES-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4337. Resolution: Fixed > [perf] avoid lambda instances / computeIfAbsent > --- > > Key: MYFACES-4337 > URL: https://issues.apache.org/jira/browse/MYFACES-4337 > Project: MyFaces Core > Issue Type: Task >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.3-next-M3 > > > In places which are called many many times per request, its to better to > avoid computeIfAbsend as each time a new lambda instance is created > for our test view in the quarkus showcase (methodHandle xhtml) with 2 > rows in a repeat, we now save around 1.000.000 object instances -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4337) [perf] avoid lambda instances / computeIfAbsend
Thomas Andraschko created MYFACES-4337: -- Summary: [perf] avoid lambda instances / computeIfAbsend Key: MYFACES-4337 URL: https://issues.apache.org/jira/browse/MYFACES-4337 Project: MyFaces Core Issue Type: Task Reporter: Thomas Andraschko Assignee: Thomas Andraschko In places which are called many many times per request, its to better to avoid computeIfAbsend as each time a new lambda instance is created for our test view in the quarkus showcase (methodHandle xhtml) with 2 rows in a repeat, we now save around 1.000.000 object instances -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4338) [perf] optimize CommonPropertyUtils
[ https://issues.apache.org/jira/browse/MYFACES-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4338. Resolution: Fixed > [perf] optimize CommonPropertyUtils > --- > > Key: MYFACES-4338 > URL: https://issues.apache.org/jira/browse/MYFACES-4338 > Project: MyFaces Core > Issue Type: Task >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.3-next-M3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4338) [perf] optimize CommonPropertyUtils
Thomas Andraschko created MYFACES-4338: -- Summary: [perf] optimize CommonPropertyUtils Key: MYFACES-4338 URL: https://issues.apache.org/jira/browse/MYFACES-4338 Project: MyFaces Core Issue Type: Task Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4339) Fileupload doesnt work on quarkus / upgrade to quarkus 1.5.1
[ https://issues.apache.org/jira/browse/MYFACES-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4339. Resolution: Fixed > Fileupload doesnt work on quarkus / upgrade to quarkus 1.5.1 > > > Key: MYFACES-4339 > URL: https://issues.apache.org/jira/browse/MYFACES-4339 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.3-next-M3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4339) Fileupload doesnt work on quarkus / upgrade to quarkus 1.5.1
Thomas Andraschko created MYFACES-4339: -- Summary: Fileupload doesnt work on quarkus / upgrade to quarkus 1.5.1 Key: MYFACES-4339 URL: https://issues.apache.org/jira/browse/MYFACES-4339 Project: MyFaces Core Issue Type: Bug Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4347) FlowScoped assumed to be passivating, causing exception on Quarkus
[
https://issues.apache.org/jira/browse/MYFACES-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164498#comment-17164498
]
Thomas Andraschko commented on MYFACES-4347:
[~mulk] i refactored many code regarding scopes - it would be great if you can
do some testing on trunk
i will release the M4 in ~2 weeks
> FlowScoped assumed to be passivating, causing exception on Quarkus
> --
>
> Key: MYFACES-4347
> URL: https://issues.apache.org/jira/browse/MYFACES-4347
> Project: MyFaces Core
> Issue Type: Bug
>Reporter: Matthias Benkard
>Priority: Major
> Fix For: 2.3-next-M4
>
>
> Quarkus does not have passivation and its {{BeanManager#isPassivatingScope}}
> implementation therefore always returns {{false}}. {{FlowScopeBeanHolder}}
> ignores this and assumes that {{@FlowScoped}} is always passivating (which is
> presumably true everywhere but Quarkus). This makes attempts to use
> {{@FlowScoped}} beans fail with a {{ClassCastException}} during
> {{ContextualStorage#getBeanKey}}'s attempt to cast the passed bean to
> {{javax.enterprise.inject.spi.PassivationCapable}}.
> Proposed fix: [https://github.com/apache/myfaces/pull/110]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MYFACES-4355) faces-config.xml node content is not trimmed
Thomas Andraschko created MYFACES-4355: -- Summary: faces-config.xml node content is not trimmed Key: MYFACES-4355 URL: https://issues.apache.org/jira/browse/MYFACES-4355 Project: MyFaces Core Issue Type: Bug Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4355) faces-config.xml node content is not trimmed
[ https://issues.apache.org/jira/browse/MYFACES-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4355. Resolution: Fixed > faces-config.xml node content is not trimmed > > > Key: MYFACES-4355 > URL: https://issues.apache.org/jira/browse/MYFACES-4355 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.3-next-M4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MYFACES-4354) ExternalContext#redirect is not add the windowId to url params.
[
https://issues.apache.org/jira/browse/MYFACES-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159097#comment-17159097
]
Thomas Andraschko edited comment on MYFACES-4354 at 7/16/20, 10:28 AM:
---
i dont think so. Also Mojarra doesn't append it, so i think its not in the
specs.
Its only appended if you use the NavigationHandler, to navigate to another JSF
view.
was (Author: tandraschko):
i dont think so. Also Mojarra doesn't append it, so i think its not in the
specs.
> ExternalContext#redirect is not add the windowId to url params.
> ---
>
> Key: MYFACES-4354
> URL: https://issues.apache.org/jira/browse/MYFACES-4354
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-372
>Affects Versions: 2.3-next-M3
> Environment: MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
>Reporter: Jan Krpata
>Priority: Major
>
> When I navigate to another view from standard navigation, windowId is a part
> of url.
>
> {code:java}
> action="/AnotherView.xhtml"{code}
>
> URL contains windowId {{...AnotherView.xhtml?jfwid=}}
>
> But when i redirect from code like this
>
> {code:java}
> String requestContextPath =
> facesContext.getExternalContext().getRequestContextPath();
> facesContext.getExternalContext().redirect(requestContextPath + "/myTarget");
> {code}
> in my HttpServlet request does not contain a windowId parameter.
>
> {code:java}
> @WebServlet(name = "MyServlet", urlPatterns = { "/myTarget" })
> public class MyServlet extends HttpServlet {
> @Override
> public void doGet(HttpServletRequest request, HttpServletResponse response)
> throws ServletException, IOException {
> final String windowId =
> request.getParameter(ConversationConsts.WINDOW_ID_PARAM); // null
> //
> }
> {code}
>
>
>
> The ExternalContext#redirect method should add jfwid parameter to the url if
> the URL does not already contain jfwid parameter.
> This patch works for me.
>
> {code:java}
> public void redirect(String url) throws IOException
> {
> FacesContext facesContext = getCurrentFacesContext();
> PartialViewContext partialViewContext =
> facesContext.getPartialViewContext();
> if (partialViewContext.isPartialRequest())
> {
> PartialResponseWriter writer =
> partialViewContext.getPartialResponseWriter();
> this.setResponseContentType("text/xml");
> this.setResponseCharacterEncoding("UTF-8");
> this.addResponseHeader("Cache-control", "no-cache");
> writer.startDocument();
> writer.redirect(url);
> writer.endDocument();
> facesContext.responseComplete();
> }
> else if (_servletResponse instanceof HttpServletResponse)
> {
> ExternalContext externalContext = facesContext.getExternalContext();
> Map requestParameterMap =
> externalContext.getRequestParameterMap();
> String windowId =
> requestParameterMap.get(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> if (windowId != null)
> {
> url = addWindowIdIfNecessary(url, windowId);
> }
> ((HttpServletResponse) _servletResponse).sendRedirect(url);
> facesContext.responseComplete();
> }
> else
> {
> throw new IllegalArgumentException("Only HttpServletResponse supported");
> }
> }
> private String addWindowIdIfNecessary(String url, String windowId)
> {
> if(url.contains(ResponseStateManager.CLIENT_WINDOW_URL_PARAM + "="))
> {
> return url;
> }
>
> StringBuilder newUrl = new StringBuilder(url);
> if(url.contains("?"))
> {
> newUrl.append("&");
> }
> else
> {
> newUrl.append("?");
> }
> newUrl.append(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> newUrl.append("=");
> newUrl.append(windowId);
> return newUrl.toString();
> }
> {code}
>
>
>
> My settings:
> {code:java}
>
>
> org.primefaces.clientwindow.PrimeClientWindowLifecycleFactory
>
> {code}
> {code:java}
>
> javax.faces.CLIENT_WINDOW_MODE
> url
>
> {code}
> MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4354) ExternalContext#redirect is not add the windowId to url params.
[
https://issues.apache.org/jira/browse/MYFACES-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159097#comment-17159097
]
Thomas Andraschko commented on MYFACES-4354:
i dont think so. Also Mojarra doesn't append it, so i think its not in the
specs.
> ExternalContext#redirect is not add the windowId to url params.
> ---
>
> Key: MYFACES-4354
> URL: https://issues.apache.org/jira/browse/MYFACES-4354
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-372
>Affects Versions: 2.3-next-M3
> Environment: MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
>Reporter: Jan Krpata
>Priority: Major
>
> When I navigate to another view from standard navigation, windowId is a part
> of url.
>
> {code:java}
> action="/AnotherView.xhtml"{code}
>
> URL contains windowId {{...AnotherView.xhtml?jfwid=}}
>
> But when i redirect from code like this
>
> {code:java}
> String requestContextPath =
> facesContext.getExternalContext().getRequestContextPath();
> facesContext.getExternalContext().redirect(requestContextPath + "/myTarget");
> {code}
> in my HttpServlet request does not contain a windowId parameter.
>
> {code:java}
> @WebServlet(name = "MyServlet", urlPatterns = { "/myTarget" })
> public class MyServlet extends HttpServlet {
> @Override
> public void doGet(HttpServletRequest request, HttpServletResponse response)
> throws ServletException, IOException {
> final String windowId =
> request.getParameter(ConversationConsts.WINDOW_ID_PARAM); // null
> //
> }
> {code}
>
>
>
> The ExternalContext#redirect method should add jfwid parameter to the url if
> the URL does not already contain jfwid parameter.
> This patch works for me.
>
> {code:java}
> public void redirect(String url) throws IOException
> {
> FacesContext facesContext = getCurrentFacesContext();
> PartialViewContext partialViewContext =
> facesContext.getPartialViewContext();
> if (partialViewContext.isPartialRequest())
> {
> PartialResponseWriter writer =
> partialViewContext.getPartialResponseWriter();
> this.setResponseContentType("text/xml");
> this.setResponseCharacterEncoding("UTF-8");
> this.addResponseHeader("Cache-control", "no-cache");
> writer.startDocument();
> writer.redirect(url);
> writer.endDocument();
> facesContext.responseComplete();
> }
> else if (_servletResponse instanceof HttpServletResponse)
> {
> ExternalContext externalContext = facesContext.getExternalContext();
> Map requestParameterMap =
> externalContext.getRequestParameterMap();
> String windowId =
> requestParameterMap.get(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> if (windowId != null)
> {
> url = addWindowIdIfNecessary(url, windowId);
> }
> ((HttpServletResponse) _servletResponse).sendRedirect(url);
> facesContext.responseComplete();
> }
> else
> {
> throw new IllegalArgumentException("Only HttpServletResponse supported");
> }
> }
> private String addWindowIdIfNecessary(String url, String windowId)
> {
> if(url.contains(ResponseStateManager.CLIENT_WINDOW_URL_PARAM + "="))
> {
> return url;
> }
>
> StringBuilder newUrl = new StringBuilder(url);
> if(url.contains("?"))
> {
> newUrl.append("&");
> }
> else
> {
> newUrl.append("?");
> }
> newUrl.append(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> newUrl.append("=");
> newUrl.append(windowId);
> return newUrl.toString();
> }
> {code}
>
>
>
> My settings:
> {code:java}
>
>
> org.primefaces.clientwindow.PrimeClientWindowLifecycleFactory
>
> {code}
> {code:java}
>
> javax.faces.CLIENT_WINDOW_MODE
> url
>
> {code}
> MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4354) ExternalContext#redirect is not add the windowId to url params.
[
https://issues.apache.org/jira/browse/MYFACES-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159100#comment-17159100
]
Thomas Andraschko commented on MYFACES-4354:
and if you use org.primefaces.clientwindow.PrimeClientWindowLifecycleFactory,
you should NOT set javax.faces.CLIENT_WINDOW_MODE
> ExternalContext#redirect is not add the windowId to url params.
> ---
>
> Key: MYFACES-4354
> URL: https://issues.apache.org/jira/browse/MYFACES-4354
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-372
>Affects Versions: 2.3-next-M3
> Environment: MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
>Reporter: Jan Krpata
>Priority: Major
>
> When I navigate to another view from standard navigation, windowId is a part
> of url.
>
> {code:java}
> action="/AnotherView.xhtml"{code}
>
> URL contains windowId {{...AnotherView.xhtml?jfwid=}}
>
> But when i redirect from code like this
>
> {code:java}
> String requestContextPath =
> facesContext.getExternalContext().getRequestContextPath();
> facesContext.getExternalContext().redirect(requestContextPath + "/myTarget");
> {code}
> in my HttpServlet request does not contain a windowId parameter.
>
> {code:java}
> @WebServlet(name = "MyServlet", urlPatterns = { "/myTarget" })
> public class MyServlet extends HttpServlet {
> @Override
> public void doGet(HttpServletRequest request, HttpServletResponse response)
> throws ServletException, IOException {
> final String windowId =
> request.getParameter(ConversationConsts.WINDOW_ID_PARAM); // null
> //
> }
> {code}
>
>
>
> The ExternalContext#redirect method should add jfwid parameter to the url if
> the URL does not already contain jfwid parameter.
> This patch works for me.
>
> {code:java}
> public void redirect(String url) throws IOException
> {
> FacesContext facesContext = getCurrentFacesContext();
> PartialViewContext partialViewContext =
> facesContext.getPartialViewContext();
> if (partialViewContext.isPartialRequest())
> {
> PartialResponseWriter writer =
> partialViewContext.getPartialResponseWriter();
> this.setResponseContentType("text/xml");
> this.setResponseCharacterEncoding("UTF-8");
> this.addResponseHeader("Cache-control", "no-cache");
> writer.startDocument();
> writer.redirect(url);
> writer.endDocument();
> facesContext.responseComplete();
> }
> else if (_servletResponse instanceof HttpServletResponse)
> {
> ExternalContext externalContext = facesContext.getExternalContext();
> Map requestParameterMap =
> externalContext.getRequestParameterMap();
> String windowId =
> requestParameterMap.get(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> if (windowId != null)
> {
> url = addWindowIdIfNecessary(url, windowId);
> }
> ((HttpServletResponse) _servletResponse).sendRedirect(url);
> facesContext.responseComplete();
> }
> else
> {
> throw new IllegalArgumentException("Only HttpServletResponse supported");
> }
> }
> private String addWindowIdIfNecessary(String url, String windowId)
> {
> if(url.contains(ResponseStateManager.CLIENT_WINDOW_URL_PARAM + "="))
> {
> return url;
> }
>
> StringBuilder newUrl = new StringBuilder(url);
> if(url.contains("?"))
> {
> newUrl.append("&");
> }
> else
> {
> newUrl.append("?");
> }
> newUrl.append(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> newUrl.append("=");
> newUrl.append(windowId);
> return newUrl.toString();
> }
> {code}
>
>
>
> My settings:
> {code:java}
>
>
> org.primefaces.clientwindow.PrimeClientWindowLifecycleFactory
>
> {code}
> {code:java}
>
> javax.faces.CLIENT_WINDOW_MODE
> url
>
> {code}
> MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4354) ExternalContext#redirect is not add the windowId to url params.
[
https://issues.apache.org/jira/browse/MYFACES-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159166#comment-17159166
]
Thomas Andraschko commented on MYFACES-4354:
I think you can simple call encodeRedirectURL before
> ExternalContext#redirect is not add the windowId to url params.
> ---
>
> Key: MYFACES-4354
> URL: https://issues.apache.org/jira/browse/MYFACES-4354
> Project: MyFaces Core
> Issue Type: Wish
> Components: JSR-372
>Affects Versions: 2.3-next-M3
> Environment: MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
>Reporter: Jan Krpata
>Priority: Major
>
> When I navigate to another view from standard navigation, windowId is a part
> of url.
>
> {code:java}
> action="/AnotherView.xhtml"{code}
>
> URL contains windowId {{...AnotherView.xhtml?jfwid=}}
>
> But when i redirect from code like this
>
> {code:java}
> String requestContextPath =
> facesContext.getExternalContext().getRequestContextPath();
> facesContext.getExternalContext().redirect(requestContextPath + "/myTarget");
> {code}
> in my HttpServlet request does not contain a windowId parameter.
>
> {code:java}
> @WebServlet(name = "MyServlet", urlPatterns = { "/myTarget" })
> public class MyServlet extends HttpServlet {
> @Override
> public void doGet(HttpServletRequest request, HttpServletResponse response)
> throws ServletException, IOException {
> final String windowId =
> request.getParameter(ConversationConsts.WINDOW_ID_PARAM); // null
> //
> }
> {code}
>
>
>
> The ExternalContext#redirect method should add jfwid parameter to the url if
> the URL does not already contain jfwid parameter.
> This patch works for me.
>
> {code:java}
> public void redirect(String url) throws IOException
> {
> FacesContext facesContext = getCurrentFacesContext();
> PartialViewContext partialViewContext =
> facesContext.getPartialViewContext();
> if (partialViewContext.isPartialRequest())
> {
> PartialResponseWriter writer =
> partialViewContext.getPartialResponseWriter();
> this.setResponseContentType("text/xml");
> this.setResponseCharacterEncoding("UTF-8");
> this.addResponseHeader("Cache-control", "no-cache");
> writer.startDocument();
> writer.redirect(url);
> writer.endDocument();
> facesContext.responseComplete();
> }
> else if (_servletResponse instanceof HttpServletResponse)
> {
> ExternalContext externalContext = facesContext.getExternalContext();
> Map requestParameterMap =
> externalContext.getRequestParameterMap();
> String windowId =
> requestParameterMap.get(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> if (windowId != null)
> {
> url = addWindowIdIfNecessary(url, windowId);
> }
> ((HttpServletResponse) _servletResponse).sendRedirect(url);
> facesContext.responseComplete();
> }
> else
> {
> throw new IllegalArgumentException("Only HttpServletResponse supported");
> }
> }
> private String addWindowIdIfNecessary(String url, String windowId)
> {
> if(url.contains(ResponseStateManager.CLIENT_WINDOW_URL_PARAM + "="))
> {
> return url;
> }
>
> StringBuilder newUrl = new StringBuilder(url);
> if(url.contains("?"))
> {
> newUrl.append("&");
> }
> else
> {
> newUrl.append("?");
> }
> newUrl.append(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> newUrl.append("=");
> newUrl.append(windowId);
> return newUrl.toString();
> }
> {code}
>
>
>
> My settings:
> {code:java}
>
>
> org.primefaces.clientwindow.PrimeClientWindowLifecycleFactory
>
> {code}
> {code:java}
>
> javax.faces.CLIENT_WINDOW_MODE
> url
>
> {code}
> MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MYFACES-4354) ExternalContext#redirect is not add the windowId to url params.
[
https://issues.apache.org/jira/browse/MYFACES-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159166#comment-17159166
]
Thomas Andraschko edited comment on MYFACES-4354 at 7/16/20, 12:26 PM:
---
I think you can simple call encodeActionURL before
was (Author: tandraschko):
I think you can simple call encodeRedirectURL before
> ExternalContext#redirect is not add the windowId to url params.
> ---
>
> Key: MYFACES-4354
> URL: https://issues.apache.org/jira/browse/MYFACES-4354
> Project: MyFaces Core
> Issue Type: Wish
> Components: JSR-372
>Affects Versions: 2.3-next-M3
> Environment: MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
>Reporter: Jan Krpata
>Priority: Major
>
> When I navigate to another view from standard navigation, windowId is a part
> of url.
>
> {code:java}
> action="/AnotherView.xhtml"{code}
>
> URL contains windowId {{...AnotherView.xhtml?jfwid=}}
>
> But when i redirect from code like this
>
> {code:java}
> String requestContextPath =
> facesContext.getExternalContext().getRequestContextPath();
> facesContext.getExternalContext().redirect(requestContextPath + "/myTarget");
> {code}
> in my HttpServlet request does not contain a windowId parameter.
>
> {code:java}
> @WebServlet(name = "MyServlet", urlPatterns = { "/myTarget" })
> public class MyServlet extends HttpServlet {
> @Override
> public void doGet(HttpServletRequest request, HttpServletResponse response)
> throws ServletException, IOException {
> final String windowId =
> request.getParameter(ConversationConsts.WINDOW_ID_PARAM); // null
> //
> }
> {code}
>
>
>
> The ExternalContext#redirect method should add jfwid parameter to the url if
> the URL does not already contain jfwid parameter.
> This patch works for me.
>
> {code:java}
> public void redirect(String url) throws IOException
> {
> FacesContext facesContext = getCurrentFacesContext();
> PartialViewContext partialViewContext =
> facesContext.getPartialViewContext();
> if (partialViewContext.isPartialRequest())
> {
> PartialResponseWriter writer =
> partialViewContext.getPartialResponseWriter();
> this.setResponseContentType("text/xml");
> this.setResponseCharacterEncoding("UTF-8");
> this.addResponseHeader("Cache-control", "no-cache");
> writer.startDocument();
> writer.redirect(url);
> writer.endDocument();
> facesContext.responseComplete();
> }
> else if (_servletResponse instanceof HttpServletResponse)
> {
> ExternalContext externalContext = facesContext.getExternalContext();
> Map requestParameterMap =
> externalContext.getRequestParameterMap();
> String windowId =
> requestParameterMap.get(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> if (windowId != null)
> {
> url = addWindowIdIfNecessary(url, windowId);
> }
> ((HttpServletResponse) _servletResponse).sendRedirect(url);
> facesContext.responseComplete();
> }
> else
> {
> throw new IllegalArgumentException("Only HttpServletResponse supported");
> }
> }
> private String addWindowIdIfNecessary(String url, String windowId)
> {
> if(url.contains(ResponseStateManager.CLIENT_WINDOW_URL_PARAM + "="))
> {
> return url;
> }
>
> StringBuilder newUrl = new StringBuilder(url);
> if(url.contains("?"))
> {
> newUrl.append("&");
> }
> else
> {
> newUrl.append("?");
> }
> newUrl.append(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> newUrl.append("=");
> newUrl.append(windowId);
> return newUrl.toString();
> }
> {code}
>
>
>
> My settings:
> {code:java}
>
>
> org.primefaces.clientwindow.PrimeClientWindowLifecycleFactory
>
> {code}
> {code:java}
>
> javax.faces.CLIENT_WINDOW_MODE
> url
>
> {code}
> MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4354) ExternalContext#redirect is not add the windowId to url params.
[
https://issues.apache.org/jira/browse/MYFACES-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159167#comment-17159167
]
Thomas Andraschko commented on MYFACES-4354:
Otherwise feel free to create a spec issue but i think current behavior is by
design.
> ExternalContext#redirect is not add the windowId to url params.
> ---
>
> Key: MYFACES-4354
> URL: https://issues.apache.org/jira/browse/MYFACES-4354
> Project: MyFaces Core
> Issue Type: Wish
> Components: JSR-372
>Affects Versions: 2.3-next-M3
> Environment: MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
>Reporter: Jan Krpata
>Priority: Major
>
> When I navigate to another view from standard navigation, windowId is a part
> of url.
>
> {code:java}
> action="/AnotherView.xhtml"{code}
>
> URL contains windowId {{...AnotherView.xhtml?jfwid=}}
>
> But when i redirect from code like this
>
> {code:java}
> String requestContextPath =
> facesContext.getExternalContext().getRequestContextPath();
> facesContext.getExternalContext().redirect(requestContextPath + "/myTarget");
> {code}
> in my HttpServlet request does not contain a windowId parameter.
>
> {code:java}
> @WebServlet(name = "MyServlet", urlPatterns = { "/myTarget" })
> public class MyServlet extends HttpServlet {
> @Override
> public void doGet(HttpServletRequest request, HttpServletResponse response)
> throws ServletException, IOException {
> final String windowId =
> request.getParameter(ConversationConsts.WINDOW_ID_PARAM); // null
> //
> }
> {code}
>
>
>
> The ExternalContext#redirect method should add jfwid parameter to the url if
> the URL does not already contain jfwid parameter.
> This patch works for me.
>
> {code:java}
> public void redirect(String url) throws IOException
> {
> FacesContext facesContext = getCurrentFacesContext();
> PartialViewContext partialViewContext =
> facesContext.getPartialViewContext();
> if (partialViewContext.isPartialRequest())
> {
> PartialResponseWriter writer =
> partialViewContext.getPartialResponseWriter();
> this.setResponseContentType("text/xml");
> this.setResponseCharacterEncoding("UTF-8");
> this.addResponseHeader("Cache-control", "no-cache");
> writer.startDocument();
> writer.redirect(url);
> writer.endDocument();
> facesContext.responseComplete();
> }
> else if (_servletResponse instanceof HttpServletResponse)
> {
> ExternalContext externalContext = facesContext.getExternalContext();
> Map requestParameterMap =
> externalContext.getRequestParameterMap();
> String windowId =
> requestParameterMap.get(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> if (windowId != null)
> {
> url = addWindowIdIfNecessary(url, windowId);
> }
> ((HttpServletResponse) _servletResponse).sendRedirect(url);
> facesContext.responseComplete();
> }
> else
> {
> throw new IllegalArgumentException("Only HttpServletResponse supported");
> }
> }
> private String addWindowIdIfNecessary(String url, String windowId)
> {
> if(url.contains(ResponseStateManager.CLIENT_WINDOW_URL_PARAM + "="))
> {
> return url;
> }
>
> StringBuilder newUrl = new StringBuilder(url);
> if(url.contains("?"))
> {
> newUrl.append("&");
> }
> else
> {
> newUrl.append("?");
> }
> newUrl.append(ResponseStateManager.CLIENT_WINDOW_URL_PARAM);
> newUrl.append("=");
> newUrl.append(windowId);
> return newUrl.toString();
> }
> {code}
>
>
>
> My settings:
> {code:java}
>
>
> org.primefaces.clientwindow.PrimeClientWindowLifecycleFactory
>
> {code}
> {code:java}
>
> javax.faces.CLIENT_WINDOW_MODE
> url
>
> {code}
> MyFaces 2.3-next-M3
> PrimeFaces 9.0-SNAPSHOT (local install from
> https://github.com/primefaces/primefaces)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MYFACES-4349) Use Reflection as fallback for MethodHandles, when not accesible
Thomas Andraschko created MYFACES-4349: -- Summary: Use Reflection as fallback for MethodHandles, when not accesible Key: MYFACES-4349 URL: https://issues.apache.org/jira/browse/MYFACES-4349 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko e.g. a TimeZone#ID acessed by EL would throw a IllegelAcessException -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4349) Use Reflection as fallback for MethodHandles, when not accesible
[ https://issues.apache.org/jira/browse/MYFACES-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4349. Resolution: Fixed > Use Reflection as fallback for MethodHandles, when not accesible > > > Key: MYFACES-4349 > URL: https://issues.apache.org/jira/browse/MYFACES-4349 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.3-next-M4 > > > e.g. a TimeZone#ID acessed by EL would throw a IllegelAcessException -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4318) [docs] c:forEach problem with client side state saving
[
https://issues.apache.org/jira/browse/MYFACES-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4318.
Resolution: Fixed
> [docs] c:forEach problem with client side state saving
> --
>
> Key: MYFACES-4318
> URL: https://issues.apache.org/jira/browse/MYFACES-4318
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.2.12, 2.3.6
>Reporter: Bill Lucy
>Priority: Major
> Attachments: jsf_foreach_client_state.war,
> jsf_foreach_client_state_mvn.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There appears to be a problem with c:forEach when client side state saving is
> enabled - component states are not restored correctly after a submit. For
> example, the text entered into this inputText is lost:
> {{{color:#80} {color:#ff}var{color}{color:#00}={color}{color:#ff}"current"{color}
>
> {color:#ff}items{color}{color:#00}={color}{color:#ff}"#\{list.items}"{color}{color:#80}>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"#\{current.value}"{color}{color:#80}/>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"submit"{color}{color:#80}/>{color}}}
> {{{color:#80}{color}}}
>
> This example works (the inputText is not lost) with server side state saving
> enabled, and it also works on Mojarra with client side state saving. I
> haven't figured out what exactly is causing this behavior yet - if anyone
> else has insight in this area I'd appreciate hints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4363) XML Schema Validation Fails
[ https://issues.apache.org/jira/browse/MYFACES-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253602#comment-17253602 ] Thomas Andraschko commented on MYFACES-4363: still not ported to 4.0/master > XML Schema Validation Fails > --- > > Key: MYFACES-4363 > URL: https://issues.apache.org/jira/browse/MYFACES-4363 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.2.13, 2.3.6, 2.3-next-M4 >Reporter: Volodymyr Siedlecki >Priority: Minor > > Adding the parameter (false by default) to an app identifies schema failures. > > org.apache.myfaces.VALIDATE_XML > true > > 2.3 > org.xml.sax.SAXParseException; lineNumber: 6; columnNumber: 19; cvc-elt.1.a: > Cannot find the declaration of element 'faces-config'. > at > java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204) > > 2.2 > [ERROR ] cvc-elt.1.a: Cannot find the declaration of element 'faces-config'. > cvc-elt.1.a: Cannot find the declaration of element 'faces-config'. > 2.0 seems to work fine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4360) JSF3: check namespace updates of mojarra
[ https://issues.apache.org/jira/browse/MYFACES-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4360. Resolution: Fixed > JSF3: check namespace updates of mojarra > > > Key: MYFACES-4360 > URL: https://issues.apache.org/jira/browse/MYFACES-4360 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 3.0.0-RC1 >Reporter: Thomas Andraschko >Priority: Major > Fix For: 3.0.0-RC2 > > > https://github.com/eclipse-ee4j/mojarra/commits/3.0.0-RC4 > - We must probably also add the new namespaces to FacesConfigurator.java > - add 3.0 in faces-config-versionType in web-facesconfig_3_0.xsd > - we often has stuff like public final static String NAMESPACE = > "http://xmlns.jcp.org/jsp/jstl/functions;; > we musst adjust this, too -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4371) Resources: set cache-control-header instead of expires-header
[
https://issues.apache.org/jira/browse/MYFACES-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253606#comment-17253606
]
Thomas Andraschko commented on MYFACES-4371:
[~christophs78] if you would like to contribute to MyFaces, a PR would be great
on master(4.0)
or should we also merge it back to 2.3.x and 3.0.x? i assume this changes are
not necessary but only more mordern
> Resources: set cache-control-header instead of expires-header
> -
>
> Key: MYFACES-4371
> URL: https://issues.apache.org/jira/browse/MYFACES-4371
> Project: MyFaces Core
> Issue Type: Wish
>Reporter: Christoph Straßer
>Priority: Trivial
>
> [https://github.com/apache/myfaces/blob/master/impl/src/main/java/org/apache/myfaces/resource/ResourceImpl.java#L208]
> currently set´s expires-header.
> IMO it´s today state-of-the-art to set {{cache-control: max-age=XXX}} instead
> of {{expires}} for resources which should be cached. And set {{cache-control:
> no-cache}} for resources which should not be cached.
> Details:
> [https://developer.mozilla.org/de/docs/Web/HTTP/Headers/Cache-Control]
> This would also simplify code a bit.
> Also opened a mojarra-issue:
> https://github.com/eclipse-ee4j/mojarra/issues/4800
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4372) Updated Deprecated classes and methods / Fix String Consants
[
https://issues.apache.org/jira/browse/MYFACES-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4372.
Resolution: Fixed
> Updated Deprecated classes and methods / Fix String Consants
>
>
> Key: MYFACES-4372
> URL: https://issues.apache.org/jira/browse/MYFACES-4372
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 4.0.0-RC1
>Reporter: Volodymyr Siedlecki
>Priority: Minor
> Fix For: 3.0.0-RC2, 4.0.0-RC1
>
>
> {color:#0e101a}Hello,{color}
> Our MyFaces code has numerous "@deprecated" comments, but the actual
> annotations are not added.
> Note that 4.0 was already updated so the list of new annotations is much
> smaller.
> Additionally, there were a few minor updates:
> String Constants Changed: (To Match Reference Mojarra API)
> - ProjectStage#PROJECT_STAGE_JNDI_NAME
> - UIViewRoot#METADATA_FACET_NAME
> Newly Added Deprecations:
> - ActionSource#setActionListener
> - UIComponent#CURRENT_COMPONENT
> - UIComponent#CURRENT_COMPOSITE_COMPONENT
> Removed Deprecation Comments:
> - UIInput#setValueChangeListener (See Mojarra
> here:https://github.com/eclipse-ee4j/mojarra/blob/3.0/impl/src/main/java/jakarta/faces/component/UIInput.java#L575-L576)
>
> See the following PRs:
> 3.0 [++
> https://github.com/apache/myfaces/pull/124|https://github.com/apache/myfaces/pull/124]
> 4.0 {color:#4a6ee0}[https://github.com/apache/myfaces/pull/125
> |https://github.com/apache/myfaces/pull/125]{color}
>
> Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4363) XML Schema Validation Fails
[ https://issues.apache.org/jira/browse/MYFACES-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4363. Fix Version/s: 4.0.0-RC1 3.0.0-RC2 Resolution: Fixed > XML Schema Validation Fails > --- > > Key: MYFACES-4363 > URL: https://issues.apache.org/jira/browse/MYFACES-4363 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.2.13, 2.3.6, 2.3-next-M4 >Reporter: Volodymyr Siedlecki >Priority: Minor > Fix For: 3.0.0-RC2, 4.0.0-RC1 > > > Adding the parameter (false by default) to an app identifies schema failures. > > org.apache.myfaces.VALIDATE_XML > true > > 2.3 > org.xml.sax.SAXParseException; lineNumber: 6; columnNumber: 19; cvc-elt.1.a: > Cannot find the declaration of element 'faces-config'. > at > java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204) > > 2.2 > [ERROR ] cvc-elt.1.a: Cannot find the declaration of element 'faces-config'. > cvc-elt.1.a: Cannot find the declaration of element 'faces-config'. > 2.0 seems to work fine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4369) Create 2.3-next branch and make master 4.0
[ https://issues.apache.org/jira/browse/MYFACES-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4369. Resolution: Fixed > Create 2.3-next branch and make master 4.0 > -- > > Key: MYFACES-4369 > URL: https://issues.apache.org/jira/browse/MYFACES-4369 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4370) javax -> jakarta
[ https://issues.apache.org/jira/browse/MYFACES-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4370. Resolution: Fixed > javax -> jakarta > > > Key: MYFACES-4370 > URL: https://issues.apache.org/jira/browse/MYFACES-4370 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4366) Remove JSP support
[ https://issues.apache.org/jira/browse/MYFACES-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4366. Resolution: Fixed > Remove JSP support > -- > > Key: MYFACES-4366 > URL: https://issues.apache.org/jira/browse/MYFACES-4366 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > > - Tag-Files > - ViewHandler > - .jsp mappings -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4367) Remove ManagedBeans completely
[ https://issues.apache.org/jira/browse/MYFACES-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4367. Resolution: Fixed > Remove ManagedBeans completely > -- > > Key: MYFACES-4367 > URL: https://issues.apache.org/jira/browse/MYFACES-4367 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MYFACES-4364) Missing javax renames to jakarta
[ https://issues.apache.org/jira/browse/MYFACES-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko updated MYFACES-4364: --- Fix Version/s: 3.0.0-RC2 Resolution: Fixed Status: Resolved (was: Patch Available) > Missing javax renames to jakarta > > > Key: MYFACES-4364 > URL: https://issues.apache.org/jira/browse/MYFACES-4364 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1 > Environment: OS X Catalina locally but pretty much all environments > could run into the issue >Reporter: Isaac A Rivera Rivas >Priority: Minor > Fix For: 3.0.0-RC2 > > Attachments: 0001-Rename-left-out-javax-references-to-jakarta.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Jakarta renames for missing javax references. Updates to > [this|https://github.com/apache/myfaces/blob/3.0.x/shared/src/main/java/org/apache/myfaces/shared/webapp/webxml/WebXmlParser.java#L58] > and > [this|https://github.com/apache/myfaces/blob/3.0.x/shared/src/main/java/org/apache/myfaces/shared/webapp/webxml/WebXmlParser.java#L61] > think need to happen as done > [here.|https://github.com/apache/myfaces/blob/3.0.x/impl/src/main/java/org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java#L61-L64] > Possible update also for > [this|https://github.com/apache/myfaces/blob/3.0.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java#L2893] > as well could be needed. Could I get some opinions on if the change should > happen? Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4368) Remove FacesEL API
[ https://issues.apache.org/jira/browse/MYFACES-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4368. Resolution: Fixed > Remove FacesEL API > -- > > Key: MYFACES-4368 > URL: https://issues.apache.org/jira/browse/MYFACES-4368 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > impl was already removed in 2.3-next -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4318) c:forEach problem with client side state saving
[
https://issues.apache.org/jira/browse/MYFACES-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257870#comment-17257870
]
Thomas Andraschko commented on MYFACES-4318:
[~wtlucy] could you add a sector in our new homepage
http://myfaces.apache.org/#/coreConcepts? maybe some general JSTL / and why we
have legacy and non-legacy, too. would be great.
> c:forEach problem with client side state saving
> ---
>
> Key: MYFACES-4318
> URL: https://issues.apache.org/jira/browse/MYFACES-4318
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.12, 2.3.6
>Reporter: Bill Lucy
>Priority: Major
> Attachments: jsf_foreach_client_state.war,
> jsf_foreach_client_state_mvn.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There appears to be a problem with c:forEach when client side state saving is
> enabled - component states are not restored correctly after a submit. For
> example, the text entered into this inputText is lost:
> {{{color:#80} {color:#ff}var{color}{color:#00}={color}{color:#ff}"current"{color}
>
> {color:#ff}items{color}{color:#00}={color}{color:#ff}"#\{list.items}"{color}{color:#80}>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"#\{current.value}"{color}{color:#80}/>{color}}}
> {{{color:#80} {color:#ff}value{color}{color:#00}={color}{color:#ff}"submit"{color}{color:#80}/>{color}}}
> {{{color:#80}{color}}}
>
> This example works (the inputText is not lost) with server side state saving
> enabled, and it also works on Mojarra with client side state saving. I
> haven't figured out what exactly is causing this behavior yet - if anyone
> else has insight in this area I'd appreciate hints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4378. Resolution: Cannot Reproduce Will close it for now until we have a reproducer > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 2.3.7, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
Thomas Andraschko created MYFACES-4378: -- Summary: onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page Key: MYFACES-4378 URL: https://issues.apache.org/jira/browse/MYFACES-4378 Project: MyFaces Core Issue Type: Task Reporter: Thomas Andraschko See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267876#comment-17267876 ] Thomas Andraschko commented on MYFACES-4378: added unittest and even the reproducer sample with jetty works fine (mvn clean package jetty:run-exploded -Pmyfaces23) > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 2.3.7, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267876#comment-17267876 ] Thomas Andraschko edited comment on MYFACES-4378 at 1/19/21, 1:18 PM: -- added unittest in master (https://github.com/apache/myfaces/commit/0b641610962fe5829bb95fba65f38a5a798de2fe) and even the reproducer sample with jetty works fine (mvn clean package jetty:run-exploded -Pmyfaces23) was (Author: tandraschko): added unittest and even the reproducer sample with jetty works fine (mvn clean package jetty:run-exploded -Pmyfaces23) > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 2.3.7, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267272#comment-17267272 ] Thomas Andraschko edited comment on MYFACES-4375 at 1/18/21, 1:07 PM: -- It seems that the underlying IS is closed https://github.com/apache/myfaces/blob/8bb2ddf9f0dce365f4082a03d3d3272710854e11/impl/src/main/java/org/apache/myfaces/resource/ResourceLoaderUtils.java#L101 is that enough for the JAR case? In non-jar case, it isnt closed, right. was (Author: tandraschko): It seems that the underlying IS is closed https://github.com/apache/myfaces/blob/8bb2ddf9f0dce365f4082a03d3d3272710854e11/impl/src/main/java/org/apache/myfaces/resource/ResourceLoaderUtils.java#L101 isnt that enough? > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Priority: Critical > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4375. Resolution: Fixed > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Assignee: Thomas Andraschko >Priority: Critical > Fix For: 2.3-next-M5, 4.0.0-RC1, 2.3.8, 3.0.0 > > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4373) Use SecureRandom for Token Generation
[ https://issues.apache.org/jira/browse/MYFACES-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264389#comment-17264389 ] Thomas Andraschko commented on MYFACES-4373: Merged all, looks good. Thanks! Please set the "fix versions" here and update the homepage! > Use SecureRandom for Token Generation > - > > Key: MYFACES-4373 > URL: https://issues.apache.org/jira/browse/MYFACES-4373 > Project: MyFaces Core > Issue Type: Bug >Reporter: Bill Lucy >Assignee: Bill Lucy >Priority: Major > > We should default to using _java.security.SecureRandom_ instead of > _java.util.Random_ for ViewState and CSRF token generation. The default > values for the following two props will be updated: > org.apache.myfaces.RANDOM_KEY_IN_CSRF_SESSION_TOKEN to "secureRandom" > org.apache.myfaces.RANDOM_KEY_IN_VIEW_STATE_SESSION_TOKEN to "secureRandom" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267783#comment-17267783 ] Thomas Andraschko commented on MYFACES-4375: We may release something next month, but not sure yet > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Assignee: Thomas Andraschko >Priority: Critical > Fix For: 2.3-next-M5, 3.0.0, 4.0.0-RC1, 2.3.8 > > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267272#comment-17267272 ] Thomas Andraschko commented on MYFACES-4375: It seems that the underlying IS is closed https://github.com/apache/myfaces/blob/8bb2ddf9f0dce365f4082a03d3d3272710854e11/impl/src/main/java/org/apache/myfaces/resource/ResourceLoaderUtils.java#L101 isnt that enough? > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Priority: Critical > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4379) FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
[
https://issues.apache.org/jira/browse/MYFACES-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272365#comment-17272365
]
Thomas Andraschko commented on MYFACES-4379:
i commited something to the 2.3-next branch
> FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
> --
>
> Key: MYFACES-4379
> URL: https://issues.apache.org/jira/browse/MYFACES-4379
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M3, 2.3-next-M4, 4.0.0-RC1
>Reporter: Milan Siebenbürger
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 2.3-next-M5, 4.0.0-RC1
>
> Attachments: image-2021-01-26-18-01-58-622.png,
> image-2021-01-26-18-02-38-773.png
>
>
> Hello,
> could you please check FacesConfigUnmarshallerImpl, we discovered some issues
> in navigation rules parsing, especially view-param / redirect-param. Is there
> is something wrong on our side?
> The specific configuration of navigation rules xml looks like this
> {code:java}
>
>
> cid
>
>
>
> {code}
> Issue 1. - viewParams are not handled correctly:
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
> r.addViewParam(vp);
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> });
> {code}
> If I understand it correctly, empty ViewParamImpl si created, added to r
> (RedirectImpl), and after that it is filled with xml values.
> In RedirectImpl, method addViewParam, is ViewParam attribute transformed to
> key/value combination and added to local HashMap. Because it is empty (yet),
> empty key is created in local HashMap, and no values are filled.
> {code:java}
> public void addViewParam(ViewParamImpl viewParam)
> {
> if (viewParams == null)
> {
> viewParams = new HashMap<>(3, 1f);
> }
> List params = viewParams.computeIfAbsent(viewParam.getName(), k
> -> new ArrayList<>(3));
> params.add(viewParam.getValue());
> }{code}
> Rest of implementation is irrelevant.
> What do you think about changing order of command like that ->
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
>
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> r.addViewParam(vp); // moved down
> });
> {code}
> same, with redirect-param .. and maybe others ..
>
> Issue 2. - empty value in view-param parameter
> As is seen in example above, we need to pass empty value to view-param. But
> method getTextContent returns null as a value.
> After that, NPE is throwed:
> {noformat}
> java.lang.NullPointerException: null
> at java.net.URLEncoder.encode(URLEncoder.java:204)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeURL(ServletExternalContextImpl.java:990)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeRedirectURL(ServletExternalContextImpl.java:455)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getRedirectURL(ViewHandlerImpl.java:175)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142)
> at
> org.apache.webbeans.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:89)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142){noformat}
> Is it possible to pass empty value somehow?
> Thanks
> Milan Siebenbürger
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4379) FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
[
https://issues.apache.org/jira/browse/MYFACES-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272386#comment-17272386
]
Thomas Andraschko commented on MYFACES-4379:
commited a possible fix, please try again
> FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
> --
>
> Key: MYFACES-4379
> URL: https://issues.apache.org/jira/browse/MYFACES-4379
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M3, 2.3-next-M4, 4.0.0-RC1
>Reporter: Milan Siebenbürger
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 2.3-next-M5, 4.0.0-RC1
>
> Attachments: image-2021-01-26-18-01-58-622.png,
> image-2021-01-26-18-02-38-773.png
>
>
> Hello,
> could you please check FacesConfigUnmarshallerImpl, we discovered some issues
> in navigation rules parsing, especially view-param / redirect-param. Is there
> is something wrong on our side?
> The specific configuration of navigation rules xml looks like this
> {code:java}
>
>
> cid
>
>
>
> {code}
> Issue 1. - viewParams are not handled correctly:
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
> r.addViewParam(vp);
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> });
> {code}
> If I understand it correctly, empty ViewParamImpl si created, added to r
> (RedirectImpl), and after that it is filled with xml values.
> In RedirectImpl, method addViewParam, is ViewParam attribute transformed to
> key/value combination and added to local HashMap. Because it is empty (yet),
> empty key is created in local HashMap, and no values are filled.
> {code:java}
> public void addViewParam(ViewParamImpl viewParam)
> {
> if (viewParams == null)
> {
> viewParams = new HashMap<>(3, 1f);
> }
> List params = viewParams.computeIfAbsent(viewParam.getName(), k
> -> new ArrayList<>(3));
> params.add(viewParam.getValue());
> }{code}
> Rest of implementation is irrelevant.
> What do you think about changing order of command like that ->
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
>
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> r.addViewParam(vp); // moved down
> });
> {code}
> same, with redirect-param .. and maybe others ..
>
> Issue 2. - empty value in view-param parameter
> As is seen in example above, we need to pass empty value to view-param. But
> method getTextContent returns null as a value.
> After that, NPE is throwed:
> {noformat}
> java.lang.NullPointerException: null
> at java.net.URLEncoder.encode(URLEncoder.java:204)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeURL(ServletExternalContextImpl.java:990)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeRedirectURL(ServletExternalContextImpl.java:455)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getRedirectURL(ViewHandlerImpl.java:175)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142)
> at
> org.apache.webbeans.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:89)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142){noformat}
> Is it possible to pass empty value somehow?
> Thanks
> Milan Siebenbürger
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4379) FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
[
https://issues.apache.org/jira/browse/MYFACES-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272337#comment-17272337
]
Thomas Andraschko commented on MYFACES-4379:
can you try again? And always please post your stacktrace
null values are ok IMO because there should not be a difference in handling a
null or empty string url param, so therefore i dont plan to change
getTextContent
> FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
> --
>
> Key: MYFACES-4379
> URL: https://issues.apache.org/jira/browse/MYFACES-4379
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M3, 2.3-next-M4, 4.0.0-RC1
>Reporter: Milan Siebenbürger
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 2.3-next-M5, 4.0.0-RC1
>
> Attachments: image-2021-01-26-18-01-58-622.png,
> image-2021-01-26-18-02-38-773.png
>
>
> Hello,
> could you please check FacesConfigUnmarshallerImpl, we discovered some issues
> in navigation rules parsing, especially view-param / redirect-param. Is there
> is something wrong on our side?
> The specific configuration of navigation rules xml looks like this
> {code:java}
>
>
> cid
>
>
>
> {code}
> Issue 1. - viewParams are not handled correctly:
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
> r.addViewParam(vp);
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> });
> {code}
> If I understand it correctly, empty ViewParamImpl si created, added to r
> (RedirectImpl), and after that it is filled with xml values.
> In RedirectImpl, method addViewParam, is ViewParam attribute transformed to
> key/value combination and added to local HashMap. Because it is empty (yet),
> empty key is created in local HashMap, and no values are filled.
> {code:java}
> public void addViewParam(ViewParamImpl viewParam)
> {
> if (viewParams == null)
> {
> viewParams = new HashMap<>(3, 1f);
> }
> List params = viewParams.computeIfAbsent(viewParam.getName(), k
> -> new ArrayList<>(3));
> params.add(viewParam.getValue());
> }{code}
> Rest of implementation is irrelevant.
> What do you think about changing order of command like that ->
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
>
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> r.addViewParam(vp); // moved down
> });
> {code}
> same, with redirect-param .. and maybe others ..
>
> Issue 2. - empty value in view-param parameter
> As is seen in example above, we need to pass empty value to view-param. But
> method getTextContent returns null as a value.
> After that, NPE is throwed:
> {noformat}
> java.lang.NullPointerException: null
> at java.net.URLEncoder.encode(URLEncoder.java:204)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeURL(ServletExternalContextImpl.java:990)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeRedirectURL(ServletExternalContextImpl.java:455)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getRedirectURL(ViewHandlerImpl.java:175)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142)
> at
> org.apache.webbeans.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:89)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142){noformat}
> Is it possible to pass empty value somehow?
> Thanks
> Milan Siebenbürger
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4379) FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
[
https://issues.apache.org/jira/browse/MYFACES-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272153#comment-17272153
]
Thomas Andraschko commented on MYFACES-4379:
I think i fixed 1) easily but can you provide the whole stacktrace for 2?
> FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
> --
>
> Key: MYFACES-4379
> URL: https://issues.apache.org/jira/browse/MYFACES-4379
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0
>Reporter: Milan Siebenbürger
>Priority: Major
>
> Hello,
> could you please check FacesConfigUnmarshallerImpl, we discovered some issues
> in navigation rules parsing, especially view-param / redirect-param. Is there
> is something wrong on our side?
> The specific configuration of navigation rules xml looks like this
> {code:java}
>
>
> cid
>
>
>
> {code}
> Issue 1. - viewParams are not handled correctly:
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
> r.addViewParam(vp);
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> });
> {code}
> If I understand it correctly, empty ViewParamImpl si created, added to r
> (RedirectImpl), and after that it is filled with xml values.
> In RedirectImpl, method addViewParam, is ViewParam attribute transformed to
> key/value combination and added to local HashMap. Because it is empty (yet),
> empty key is created in local HashMap, and no values are filled.
> {code:java}
> public void addViewParam(ViewParamImpl viewParam)
> {
> if (viewParams == null)
> {
> viewParams = new HashMap<>(3, 1f);
> }
> List params = viewParams.computeIfAbsent(viewParam.getName(), k
> -> new ArrayList<>(3));
> params.add(viewParam.getValue());
> }{code}
> Rest of implementation is irrelevant.
> What do you think about changing order of command like that ->
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
>
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> r.addViewParam(vp); // moved down
> });
> {code}
> same, with redirect-param .. and maybe others ..
>
> Issue 2. - empty value in view-param parameter
> As is seen in example above, we need to pass empty value to view-param. But
> method getTextContent returns null as a value.
> After that, NPE is throwed:
> {noformat}
> java.lang.NullPointerException: null
> at java.net.URLEncoder.encode(URLEncoder.java:204)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeURL(ServletExternalContextImpl.java:990)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeRedirectURL(ServletExternalContextImpl.java:455)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getRedirectURL(ViewHandlerImpl.java:175)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142)
> at
> org.apache.webbeans.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:89)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142){noformat}
> Is it possible to pass empty value somehow?
> Thanks
> Milan Siebenbürger
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4379) FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
[
https://issues.apache.org/jira/browse/MYFACES-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272138#comment-17272138
]
Thomas Andraschko commented on MYFACES-4379:
i think its only 2.3-next and 4.0/master? onChild is new and not ported to
2.3/3.0.
can you check if your stuff is working on 2.3 but not 2.3-next? If yes, would
be great if you can provide unit tests.
> FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
> --
>
> Key: MYFACES-4379
> URL: https://issues.apache.org/jira/browse/MYFACES-4379
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0
>Reporter: Milan Siebenbürger
>Priority: Major
>
> Hello,
> could you please check FacesConfigUnmarshallerImpl, we discovered some issues
> in navigation rules parsing, especially view-param / redirect-param. Is there
> is something wrong on our side?
> The specific configuration of navigation rules xml looks like this
> {code:java}
>
>
> cid
>
>
>
> {code}
> Issue 1. - viewParams are not handled correctly:
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
> r.addViewParam(vp);
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> });
> {code}
> If I understand it correctly, empty ViewParamImpl si created, added to r
> (RedirectImpl), and after that it is filled with xml values.
> In RedirectImpl, method addViewParam, is ViewParam attribute transformed to
> key/value combination and added to local HashMap. Because it is empty (yet),
> empty key is created in local HashMap, and no values are filled.
> {code:java}
> public void addViewParam(ViewParamImpl viewParam)
> {
> if (viewParams == null)
> {
> viewParams = new HashMap<>(3, 1f);
> }
> List params = viewParams.computeIfAbsent(viewParam.getName(), k
> -> new ArrayList<>(3));
> params.add(viewParam.getValue());
> }{code}
> Rest of implementation is irrelevant.
> What do you think about changing order of command like that ->
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
>
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> r.addViewParam(vp); // moved down
> });
> {code}
> same, with redirect-param .. and maybe others ..
>
> Issue 2. - empty value in view-param parameter
> As is seen in example above, we need to pass empty value to view-param. But
> method getTextContent returns null as a value.
> After that, NPE is throwed:
> {noformat}
> java.lang.NullPointerException: null
> at java.net.URLEncoder.encode(URLEncoder.java:204)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeURL(ServletExternalContextImpl.java:990)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeRedirectURL(ServletExternalContextImpl.java:455)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getRedirectURL(ViewHandlerImpl.java:175)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142)
> at
> org.apache.webbeans.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:89)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142){noformat}
> Is it possible to pass empty value somehow?
> Thanks
> Milan Siebenbürger
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4404) Log ViewState String Before Sending Response
[ https://issues.apache.org/jira/browse/MYFACES-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368937#comment-17368937 ] Thomas Andraschko commented on MYFACES-4404: As i said in github the will spam the logfile heavily with client side state saving > Log ViewState String Before Sending Response > > > Key: MYFACES-4404 > URL: https://issues.apache.org/jira/browse/MYFACES-4404 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-344, JSR-372 >Affects Versions: 2.2.14, 2.3.9 >Reporter: Volodymyr Siedlecki >Priority: Trivial > > When debugging JSF, it's very useful to know of the viewstate string has been > altered in any way. Users can have filters that change that viewstate > (filter out ='s, for example). This then causes decoding/decryption errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4400) Download page must mention verification and KEYS
[ https://issues.apache.org/jira/browse/MYFACES-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344092#comment-17344092 ] Thomas Andraschko commented on MYFACES-4400: just some thoughts: we currently have the download on each version-page (2.0, 2.1, 2...) and therefore also the checksum info but the checksum info is currently missing in some versions maybe we should add a seperate download page and remove the download from the version-page? > Download page must mention verification and KEYS > > > Key: MYFACES-4400 > URL: https://issues.apache.org/jira/browse/MYFACES-4400 > Project: MyFaces Core > Issue Type: Bug >Reporter: Sebb >Priority: Major > > The download page at https://myfaces.apache.org/#/core20?id=downloads does > not have a link to the KEYS file, nor does it refer to the need to verify > downloads, nor how to do so. > Please fix the page ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MYFACES-4406) dto.MyDTO/org.apache.myfaces.core.api.shared.lang.PropertyDescriptorUtils does not have full privilege access
[
https://issues.apache.org/jira/browse/MYFACES-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377192#comment-17377192
]
Thomas Andraschko edited comment on MYFACES-4406 at 7/8/21, 8:09 AM:
-
Related to: https://github.com/eclipse-openj9/openj9/issues/8571
I can explain what we do:
take e.g. #{bean.myProperty}
EL and JSF uses reflection to call the getter and setter which is quite ok as
the methods are public and reflection isnt as slow as rumored on the net 10
years ago
in 2.3 i added a actually expirimental feature, which uses the lambda factory
instead of reflection
this feature is nice and performs better but might not work in all cases
you can deactivate it via: org.apache.myfaces.USE_LAMBDA_METAFACTORY = false
However, it would be great if you can check the link and try to solve it
somehow. I didnt get this errors, maybe related to newer JVMs or modules?
Would be great if you can investigate and contribute.
was (Author: tandraschko):
Related to: https://github.com/eclipse-openj9/openj9/issues/8571
I can explain what we do:
take e.g. #{bean.myProperty}
EL and JSF uses reflection to call the getter and setter which is quite ok as
the methods are public and reflection isnt as slow as rumored on the net 10
years ago
in 2.3 i added a actually expirimental feature, which uses the lambda factory
instead of reflection
this is features but might not work in all cases
you can deactivate it via: org.apache.myfaces.USE_LAMBDA_METAFACTORY = false
However, it would be great if you can check the link and try to solve it
somehow. I didnt get this errors, maybe related to newer JVMs or modules?
Would be great if you can investigate and contribute.
> dto.MyDTO/org.apache.myfaces.core.api.shared.lang.PropertyDescriptorUtils
> does not have full privilege access
> -
>
> Key: MYFACES-4406
> URL: https://issues.apache.org/jira/browse/MYFACES-4406
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M6
> Environment: Windows 10 1909, Java 16, Quarkus 2.0.0.Final,
> 2.3-next-M6, IDE IntelliJ 2021.1.3
>Reporter: Mateus Scheper
>Priority: Minor
> Attachments: pom.xml, stacktrace.txt
>
>
> Hi!
> I couldn't find anything on Google so I decided to look for some help here.
> I'm getting "PropertyDescriptorUtils does not have full privilege access" in
> some of my objects in my web bean and I'm not sure why.
> As far as I tested, nothing is breaking, so I'm not sure what the error is
> about.
> Can anyone give me a hand?
> Thanks in advance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4406) dto.MyDTO/org.apache.myfaces.core.api.shared.lang.PropertyDescriptorUtils does not have full privilege access
[
https://issues.apache.org/jira/browse/MYFACES-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377192#comment-17377192
]
Thomas Andraschko commented on MYFACES-4406:
Related to: https://github.com/eclipse-openj9/openj9/issues/8571
I can explain what we do:
take e.g. #{bean.myProperty}
EL and JSF uses reflection to call the getter and setter which is quite ok as
the methods are public and reflection isnt as slow as rumored on the net 10
years ago
in 2.3 i added a actually expirimental feature, which uses the lambda factory
instead of reflection
this is features but might not work in all cases
you can deactivate it via: org.apache.myfaces.USE_LAMBDA_METAFACTORY = false
However, it would be great if you can check the link and try to solve it
somehow. I didnt get this errors, maybe related to newer JVMs or modules?
Would be great if you can investigate and contribute.
> dto.MyDTO/org.apache.myfaces.core.api.shared.lang.PropertyDescriptorUtils
> does not have full privilege access
> -
>
> Key: MYFACES-4406
> URL: https://issues.apache.org/jira/browse/MYFACES-4406
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M6
> Environment: Windows 10 1909, Java 16, Quarkus 2.0.0.Final,
> 2.3-next-M6, IDE IntelliJ 2021.1.3
>Reporter: Mateus Scheper
>Priority: Minor
> Attachments: pom.xml, stacktrace.txt
>
>
> Hi!
> I couldn't find anything on Google so I decided to look for some help here.
> I'm getting "PropertyDescriptorUtils does not have full privilege access" in
> some of my objects in my web bean and I'm not sure why.
> As far as I tested, nothing is breaking, so I'm not sure what the error is
> about.
> Can anyone give me a hand?
> Thanks in advance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4405) Wrong translation on myfaces/api/src/main/resources/javax/faces/Messages_pt.properties and pt_BR for DoubleRangeValidator.NOT_IN_RANGE
[
https://issues.apache.org/jira/browse/MYFACES-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4405.
Resolution: Fixed
Thanks for the great first contribution!
> Wrong translation on
> myfaces/api/src/main/resources/javax/faces/Messages_pt.properties and pt_BR
> for DoubleRangeValidator.NOT_IN_RANGE
> --
>
> Key: MYFACES-4405
> URL: https://issues.apache.org/jira/browse/MYFACES-4405
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 1.2.0, 2.0.24, 2.1.18, 2.2.14, 4.0.0-RC1, 3.0.1, 2.3.9,
> 2.3-next-M6
> Environment: Any platform
>Reporter: Gabriel Marinello Moura Leite
>Priority: Trivial
> Fix For: 4.0.0-RC1, 2.3.10, 2.3-next-M7, 3.0.2
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> I was working on showing the validation message
> "{color:#4c9aff}javax.faces.validator.DoubleRangeValidator.NOT_IN_RANGE{color}"
> and I saw that on the folder
> "{color:#4c9aff}myfaces/api/src/main/resources/javax/faces/{color}",
> the english version of the message had the right message and the portuguese
> (pt and pt_BR) didn't have the same message nor does it have the same number
> of Varargs , and this message is replicated on every branch (also happens on
> the renamed "jakarta" folder on branches after 3.0.X):
>
> English: \{2}: Validation Error: Specified attribute is not between the
> expected values of \{0} and \{1}.
>
> Portuguese: \{2}: Erro de valida\u00e7\u00e3o: O atributo especificado
> n\u00e3o pode ser convertido para o tipo apropriado.
>
> The message "javax.faces.validator.NOT_IN_RANGE" has the right validation
> message that should also be on the DoubleRangeValidator.NOT_IN_RANGE.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4407) "WELD-001303: No active contexts..." when MyFaces/JSF calls CDI/Weld on HTTP session cleanup
[
https://issues.apache.org/jira/browse/MYFACES-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379297#comment-17379297
]
Thomas Andraschko commented on MYFACES-4407:
Duplicate of https://issues.apache.org/jira/browse/MYFACES-4382
?
Can you try a build from git?
> "WELD-001303: No active contexts..." when MyFaces/JSF calls CDI/Weld on HTTP
> session cleanup
>
>
> Key: MYFACES-4407
> URL: https://issues.apache.org/jira/browse/MYFACES-4407
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.8
>Reporter: Daniel Platz
>Priority: Minor
>
> We see below exception when Jetty cleans expired HTTP sessions:
> {code:java}
> 2021-07-06 22:32:30,016 WARN [org.eclipse.jetty.server.session]
> (Session-HouseKeeper-4f4e375c-1):
> org.jboss.weld.contexts.ContextNotActiveException: WELD-001303: No active
> contexts for scope type javax.enterprise.context.SessionScoped
> at
> org.jboss.weld.manager.BeanManagerImpl.getContext(BeanManagerImpl.java:647)
> at
> org.jboss.weld.bean.ContextualInstanceStrategy$DefaultContextualInstanceStrategy.getIfExists(ContextualInstanceStrategy.java:89)
> at
> org.jboss.weld.bean.ContextualInstanceStrategy$CachingContextualInstanceStrategy.getIfExists(ContextualInstanceStrategy.java:164)
> at
> org.jboss.weld.bean.ContextualInstance.getIfExists(ContextualInstance.java:63)
> at
> org.jboss.weld.bean.proxy.ContextBeanInstance.getInstance(ContextBeanInstance.java:87)
> at
> org.jboss.weld.bean.proxy.ProxyMethodHandler.getInstance(ProxyMethodHandler.java:131)
> at
> org.apache.myfaces.cdi.view.ViewScopeBeanHolder$Proxy$_$$_WeldClientProxy.destroyBeans(Unknown
> Source)
> at
> org.apache.myfaces.cdi.impl.CDIManagedBeanHandlerImpl.onSessionDestroyed(CDIManagedBeanHandlerImpl.java:113)
> at
> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.sessionDestroyed(ManagedBeanDestroyerListener.java:201)
> at
> org.eclipse.jetty.server.session.SessionHandler$2.run(SessionHandler.java:312)
> at
> org.eclipse.jetty.server.handler.ContextHandler.handle(ContextHandler.java:1520)
> at
> org.eclipse.jetty.server.handler.ContextHandler.handle(ContextHandler.java:1539)
> at
> org.eclipse.jetty.server.session.SessionContext.run(SessionContext.java:92)
> at
> org.eclipse.jetty.server.session.SessionHandler.callSessionDestroyedListeners(SessionHandler.java:316)
> at
> org.eclipse.jetty.server.session.SessionHandler.invalidate(SessionHandler.java:1216)
> at
> org.eclipse.jetty.server.session.DefaultSessionIdManager.expireAll(DefaultSessionIdManager.java:436)
> at
> org.eclipse.jetty.server.session.SessionHandler.scavenge(SessionHandler.java:1267)
> at
> org.eclipse.jetty.server.session.HouseKeeper.scavenge(HouseKeeper.java:250)
> at
> org.eclipse.jetty.server.session.HouseKeeper$Runner.run(HouseKeeper.java:62)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> First analysis was already done by the Jetty guys:
> [https://github.com/eclipse/jetty.project/issues/6506]
> I am facing the issue on jetty together with MyFaces 2.3.8 and Weld
> 3.1.5.Final. The jetty maintainers where able to reproduce this issue also on
> tomcat. So, it seems to be no issue with these specific version but maybe a
> general mismatch between weld and myfaces and the suggestion was to create an
> issue here and on myfaces to continue the discussion.
> Weld issue: [https://issues.redhat.com/browse/WELD-2676]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MYFACES-4398) possible NPE in ErrorPage
Thomas Andraschko created MYFACES-4398: -- Summary: possible NPE in ErrorPage Key: MYFACES-4398 URL: https://issues.apache.org/jira/browse/MYFACES-4398 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.3-next-M5, 4.0.0-RC1 Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4398) possible NPE in ErrorPage
[ https://issues.apache.org/jira/browse/MYFACES-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4398. Resolution: Fixed > possible NPE in ErrorPage > - > > Key: MYFACES-4398 > URL: https://issues.apache.org/jira/browse/MYFACES-4398 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M5, 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1, 2.3-next-M6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4377) Disable the parsing of external general entities and external parameter entities in XML parsing code
[ https://issues.apache.org/jira/browse/MYFACES-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281135#comment-17281135 ] Thomas Andraschko commented on MYFACES-4377: [~bommel] we already commited it? can you please add the "fix versions" and resolve this issue? > Disable the parsing of external general entities and external parameter > entities in XML parsing code > > > Key: MYFACES-4377 > URL: https://issues.apache.org/jira/browse/MYFACES-4377 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.3-next-M4, 4.0.0-RC1 >Reporter: Bernd Bohmann >Assignee: Bernd Bohmann >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4377) Disable the parsing of external general entities and external parameter entities in XML parsing code
[ https://issues.apache.org/jira/browse/MYFACES-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4377. Resolution: Fixed > Disable the parsing of external general entities and external parameter > entities in XML parsing code > > > Key: MYFACES-4377 > URL: https://issues.apache.org/jira/browse/MYFACES-4377 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.3-next-M4, 4.0.0-RC1 >Reporter: Bernd Bohmann >Assignee: Bernd Bohmann >Priority: Major > Fix For: 2.3-next-M5, 4.0.0-RC1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4376) Update Cryptographic algorithm in StateUtils to a stronger version
[ https://issues.apache.org/jira/browse/MYFACES-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4376. Resolution: Fixed > Update Cryptographic algorithm in StateUtils to a stronger version > -- > > Key: MYFACES-4376 > URL: https://issues.apache.org/jira/browse/MYFACES-4376 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M4, 4.0.0-RC1 >Reporter: Bernd Bohmann >Assignee: Bernd Bohmann >Priority: Major > Fix For: 2.3-next-M5, 2.3.8, 3.0.0, 2.2.14 > > > Change the parameters > org.apache.myfaces.ALGORITHM from DES to AES > and > org.apache.MAC_ALGORITHM from HmacSHA1 to HmacSHA256 > DES and HmacSHA1 are considered to be weak > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4379) FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
[
https://issues.apache.org/jira/browse/MYFACES-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4379.
Resolution: Fixed
> FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
> --
>
> Key: MYFACES-4379
> URL: https://issues.apache.org/jira/browse/MYFACES-4379
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M3, 2.3-next-M4, 4.0.0-RC1
>Reporter: Milan Siebenbürger
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 2.3-next-M5, 4.0.0-RC1
>
> Attachments: image-2021-01-26-18-01-58-622.png,
> image-2021-01-26-18-02-38-773.png
>
>
> Hello,
> could you please check FacesConfigUnmarshallerImpl, we discovered some issues
> in navigation rules parsing, especially view-param / redirect-param. Is there
> is something wrong on our side?
> The specific configuration of navigation rules xml looks like this
> {code:java}
>
>
> cid
>
>
>
> {code}
> Issue 1. - viewParams are not handled correctly:
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
> r.addViewParam(vp);
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> });
> {code}
> If I understand it correctly, empty ViewParamImpl si created, added to r
> (RedirectImpl), and after that it is filled with xml values.
> In RedirectImpl, method addViewParam, is ViewParam attribute transformed to
> key/value combination and added to local HashMap. Because it is empty (yet),
> empty key is created in local HashMap, and no values are filled.
> {code:java}
> public void addViewParam(ViewParamImpl viewParam)
> {
> if (viewParams == null)
> {
> viewParams = new HashMap<>(3, 1f);
> }
> List params = viewParams.computeIfAbsent(viewParam.getName(), k
> -> new ArrayList<>(3));
> params.add(viewParam.getValue());
> }{code}
> Rest of implementation is irrelevant.
> What do you think about changing order of command like that ->
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
>
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> r.addViewParam(vp); // moved down
> });
> {code}
> same, with redirect-param .. and maybe others ..
>
> Issue 2. - empty value in view-param parameter
> As is seen in example above, we need to pass empty value to view-param. But
> method getTextContent returns null as a value.
> After that, NPE is throwed:
> {noformat}
> java.lang.NullPointerException: null
> at java.net.URLEncoder.encode(URLEncoder.java:204)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeURL(ServletExternalContextImpl.java:990)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeRedirectURL(ServletExternalContextImpl.java:455)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getRedirectURL(ViewHandlerImpl.java:175)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142)
> at
> org.apache.webbeans.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:89)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142){noformat}
> Is it possible to pass empty value somehow?
> Thanks
> Milan Siebenbürger
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4379) FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
[
https://issues.apache.org/jira/browse/MYFACES-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272649#comment-17272649
]
Thomas Andraschko commented on MYFACES-4379:
thanks, merge it to 4.0.
feel free to sponsor me a beer via github sponsors :)
> FacesConfigUnmarshallerImpl - navigation-rules, view-param parsing
> --
>
> Key: MYFACES-4379
> URL: https://issues.apache.org/jira/browse/MYFACES-4379
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.3-next-M3, 2.3-next-M4, 4.0.0-RC1
>Reporter: Milan Siebenbürger
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 2.3-next-M5, 4.0.0-RC1
>
> Attachments: image-2021-01-26-18-01-58-622.png,
> image-2021-01-26-18-02-38-773.png
>
>
> Hello,
> could you please check FacesConfigUnmarshallerImpl, we discovered some issues
> in navigation rules parsing, especially view-param / redirect-param. Is there
> is something wrong on our side?
> The specific configuration of navigation rules xml looks like this
> {code:java}
>
>
> cid
>
>
>
> {code}
> Issue 1. - viewParams are not handled correctly:
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
> r.addViewParam(vp);
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> });
> {code}
> If I understand it correctly, empty ViewParamImpl si created, added to r
> (RedirectImpl), and after that it is filled with xml values.
> In RedirectImpl, method addViewParam, is ViewParam attribute transformed to
> key/value combination and added to local HashMap. Because it is empty (yet),
> empty key is created in local HashMap, and no values are filled.
> {code:java}
> public void addViewParam(ViewParamImpl viewParam)
> {
> if (viewParams == null)
> {
> viewParams = new HashMap<>(3, 1f);
> }
> List params = viewParams.computeIfAbsent(viewParam.getName(), k
> -> new ArrayList<>(3));
> params.add(viewParam.getValue());
> }{code}
> Rest of implementation is irrelevant.
> What do you think about changing order of command like that ->
> {code:java}
> onChild("view-param", n, (cn) -> {
> ViewParamImpl vp = new ViewParamImpl();
>
> onChild("name", cn, (ccn) -> {
> vp.setName(ccn.getTextContent()); });
> onChild("value", cn, (ccn) -> {
> vp.setValue(ccn.getTextContent()); });
> r.addViewParam(vp); // moved down
> });
> {code}
> same, with redirect-param .. and maybe others ..
>
> Issue 2. - empty value in view-param parameter
> As is seen in example above, we need to pass empty value to view-param. But
> method getTextContent returns null as a value.
> After that, NPE is throwed:
> {noformat}
> java.lang.NullPointerException: null
> at java.net.URLEncoder.encode(URLEncoder.java:204)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeURL(ServletExternalContextImpl.java:990)
> at
> org.apache.myfaces.context.servlet.ServletExternalContextImpl.encodeRedirectURL(ServletExternalContextImpl.java:455)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> javax.faces.context.ExternalContextWrapper.encodeRedirectURL(ExternalContextWrapper.java:101)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getRedirectURL(ViewHandlerImpl.java:175)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142)
> at
> org.apache.webbeans.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:89)
> at
> javax.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:142){noformat}
> Is it possible to pass empty value somehow?
> Thanks
> Milan Siebenbürger
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TRINIDAD-2567) Trinidad secret generation is not thread-safe
[
https://issues.apache.org/jira/browse/TRINIDAD-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283189#comment-17283189
]
Thomas Andraschko commented on TRINIDAD-2567:
-
Hi Kyle,
you may know that we dont have any active trinidad developers since years.
feel to to create a PR but even unsure if someone of us will do a release
> Trinidad secret generation is not thread-safe
> -
>
> Key: TRINIDAD-2567
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2567
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components, Facelets, Infrastructure, Plugins
>Affects Versions: 2.2.1-core
>Reporter: Kyle Stiemann
>Priority: Minor
>
> Sending multiple requests in rapid succession to a Trinidad application that
> has just started will cause multiple different secret keys to be generated.
> If multiple {{POST}} s are sent, all but 1 will fail with a
> {{ViewExpiredException}}. Trinidad generates the secret keys in
> {{StateUtils}} somewhat like this:
> {code}
> private static SecretKey getSecret(ExternalContext ctx) {
> SecretKey secretKey = (SecretKey)
> ctx.getApplicationMap().get(INIT_SECRET_KEY_CACHE);
> if (secretKey == null) {
> secretKey =
> createSecretKey(KeyGenerator.getInstance(getAlgorithm(ctx)).generateKey().getEncoded());
> ctx.getApplicationMap().put(INIT_SECRET_KEY_CACHE, secretKey);
> }
> return secretKey;
> }
> {code}
> {{FormRenderer}} calls {{ViewHandler.writeState()}} which calls the
> {{StateUtils.getSecret()}} method on each request. If more than 1 request
> calls {{getSecret()}} before the secret key is set in
> {{INIT_SECRET_KEY_CACHE}}, each call to {{getSecret()}} has the chance to see
> a {{null}} value for {{INIT_SECRET_KEY_CACHE}}, generate a new secret key,
> and replace any existing secret in {{INIT_SECRET_KEY_CACHE}}. Any view state
> that was generated using the discarded secrets will be unusable and cause a
> {{ViewExpiredException}}.
> h2. Workarounds
> The simplest workaround is to set values for the secret keys as
> {{init-param}} s:
> https://cwiki.apache.org/confluence/display/MYFACES2/Secure+Your+Application.
> For example, in the {{web.xml}} (*note that the provided values are examples
> and should not be used in a production application*):
> {code:xml}
>
> org.apache.myfaces.SECRET
>
> VEVTVF9LRVk=
>
>
> org.apache.myfaces.MAC_SECRET
>
> VFJJTklEQURfVEVTVF9NQUNfU0VDUkVU
>
> {code}
> h2. Potential Fixes
> # Save 1 generated key in the application scope using either
> {{Map.putIfAbsent()}} or some other kind of synchronization. Use only the key
> from the application scope to generate the {{SecretKey}} object. Even if
> secret object caching is disabled, only 1 key would be used to generate the
> secret object, so the application would still function.
> # Use {{Map.putIfAbsent()}} to ensure only 1 secret is ever cached in the
> application. If secret caching is disabled, the application would still not
> function (which is the same as the existing behavior).
> h2. Steps to Reproduce:
> # Create 1 WAR with a simple {{ping.xhtml}} endpoint:
> {code:xml}
>xmlns:h="http://java.sun.com/jsf/html;
> xmlns="http://www.w3.org/1999/xhtml;>
>
>
> pong
>
>
> {code}
> # Create another Trinidad WAR with the following view and bean:
> *{{hello.xhtml}}:*
> {code:xml}
>
>xmlns:tr="http://myfaces.apache.org/trinidad;
> title="hello">
>
> required="true" value="#{helloBean.name}" />
>
>
>
>
> {code}
> *{{HelloBean.java}}:*
> {code:java}
> @ManagedBean
> @RequestScoped
> public final class HelloBean {
> private String name;
> public String getName() {
> return name;
> }
> public void setName(String name) {
> this.name = name;
> }
> }
> {code}
> # Start up an app server like Tomcat with both WARs deployed.
> # Using a script:
> ## {{GET}} the {{ping.xhtml}} endpoint to cause the app server to initialize.
> ## {{GET}} the {{hello.xhtml}} endpoint to obtain the view state and session
> id.
> ## Use the view state and session id to {{POST}} a name to the
> {{hello.xhtml}} form.
> ## Repeat the {{GET}} and {{POST}} 5 times in rapid succession with different
> sessions.
> Here's an example {{bash}} script which uses {{curl}} to execute the above
> steps:
> {code:sh}
> #!/bin/bash
> sendPost() {
> ENCODED_VIEW_STATE="$(curl -s --cookie-jar /tmp/cookie-jar-$1 --cookie
> /tmp/cookie-jar-$1 \
> 'http://localhost:8080/trinidad-2.2/faces/hello.xhtml' | \
> tr -d '\n' | sed
> 's/.*name="javax.faces.ViewState".*value="\([^"][^"]*\)".*/\1/' | \
> sed -e 's|/|\%2F|g' -e 's/+/%2B/g' -e 's/=/%3D/g')"
> curl --cookie-jar /tmp/cookie-jar-$1 --cookie /tmp/cookie-jar-$1 \
> -d
>
[jira] [Resolved] (MYFACES-4384) Faces 4.0: Add FacesContext#getLifecycle()
[ https://issues.apache.org/jira/browse/MYFACES-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4384. Resolution: Fixed > Faces 4.0: Add FacesContext#getLifecycle() > -- > > Key: MYFACES-4384 > URL: https://issues.apache.org/jira/browse/MYFACES-4384 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4385) Faces 4.0: make UIComponent#subscribeToEvent() more convenient 4.0
[ https://issues.apache.org/jira/browse/MYFACES-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4385. Resolution: Fixed seems already be implemented like this in MyFaces > Faces 4.0: make UIComponent#subscribeToEvent() more convenient 4.0 > --- > > Key: MYFACES-4385 > URL: https://issues.apache.org/jira/browse/MYFACES-4385 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4385) Faces 4.0: make UIComponent#subscribeToEvent() more convenient 4.0
Thomas Andraschko created MYFACES-4385: -- Summary: Faces 4.0: make UIComponent#subscribeToEvent() more convenient 4.0 Key: MYFACES-4385 URL: https://issues.apache.org/jira/browse/MYFACES-4385 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4384) Faces 4.0: Add FacesContext#getLifecycle()
Thomas Andraschko created MYFACES-4384: -- Summary: Faces 4.0: Add FacesContext#getLifecycle() Key: MYFACES-4384 URL: https://issues.apache.org/jira/browse/MYFACES-4384 Project: MyFaces Core Issue Type: Bug Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4386) Faces 4.0: h:inputFile accept="..."
Thomas Andraschko created MYFACES-4386: -- Summary: Faces 4.0: h:inputFile accept="..." Key: MYFACES-4386 URL: https://issues.apache.org/jira/browse/MYFACES-4386 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4386) Faces 4.0: h:inputFile accept="..."
[ https://issues.apache.org/jira/browse/MYFACES-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4386. Resolution: Fixed > Faces 4.0: h:inputFile accept="..." > --- > > Key: MYFACES-4386 > URL: https://issues.apache.org/jira/browse/MYFACES-4386 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > https://github.com/eclipse-ee4j/faces-api/issues/1556 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4387) Faces 4.0: rename "jsf" throughout source code to "faces"
Thomas Andraschko created MYFACES-4387: -- Summary: Faces 4.0: rename "jsf" throughout source code to "faces" Key: MYFACES-4387 URL: https://issues.apache.org/jira/browse/MYFACES-4387 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4389) Faces 4.0: add f:selectItemGroups
Thomas Andraschko created MYFACES-4389: -- Summary: Faces 4.0: add f:selectItemGroups Key: MYFACES-4389 URL: https://issues.apache.org/jira/browse/MYFACES-4389 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko https://github.com/eclipse-ee4j/faces-api/issues/1559 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4388) Faces 4.0: rename xmlns.jcp.org taglib URIs
Thomas Andraschko created MYFACES-4388: -- Summary: Faces 4.0: rename xmlns.jcp.org taglib URIs Key: MYFACES-4388 URL: https://issues.apache.org/jira/browse/MYFACES-4388 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4390) Faces 4.0: h:inputFile multiple="true"
Thomas Andraschko created MYFACES-4390: -- Summary: Faces 4.0: h:inputFile multiple="true" Key: MYFACES-4390 URL: https://issues.apache.org/jira/browse/MYFACES-4390 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko https://github.com/eclipse-ee4j/faces-api/issues/1555 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean
[
https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312415#comment-17312415
]
Thomas Andraschko commented on MYFACES-4391:
should we port this to other branches?
> Disabled/ReadOnly HTML attributes should not use boolean
>
>
> Key: MYFACES-4391
> URL: https://issues.apache.org/jira/browse/MYFACES-4391
> Project: MyFaces Core
> Issue Type: Improvement
>Reporter: Melloware
>Priority: Major
>
> For `readonly` and `disabled` attributes MyFaces is sending "true" when the
> right value is `readonly="readoly"`
> Current:
> {code:java}
> if (inputFile.isDisabled())
> {
> writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
> } {code}
>
> Should be:
> {code:java}
> if (inputFile.isDisabled())
> {
>writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4390) Faces 4.0: h:inputFile multiple="true"
[ https://issues.apache.org/jira/browse/MYFACES-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4390. Assignee: (was: Thomas Andraschko) Resolution: Fixed > Faces 4.0: h:inputFile multiple="true" > -- > > Key: MYFACES-4390 > URL: https://issues.apache.org/jira/browse/MYFACES-4390 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > https://github.com/eclipse-ee4j/faces-api/issues/1555 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4390) Faces 4.0: h:inputFile multiple="true"
[ https://issues.apache.org/jira/browse/MYFACES-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312288#comment-17312288 ] Thomas Andraschko commented on MYFACES-4390: Thanks for your contribution - well done > Faces 4.0: h:inputFile multiple="true" > -- > > Key: MYFACES-4390 > URL: https://issues.apache.org/jira/browse/MYFACES-4390 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > https://github.com/eclipse-ee4j/faces-api/issues/1555 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean
[
https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312426#comment-17312426
]
Thomas Andraschko commented on MYFACES-4391:
yep
the current "well maintained" branches are 2.3, 2.3-next, 3.0 and master
> Disabled/ReadOnly HTML attributes should not use boolean
>
>
> Key: MYFACES-4391
> URL: https://issues.apache.org/jira/browse/MYFACES-4391
> Project: MyFaces Core
> Issue Type: Improvement
>Reporter: Melloware
>Priority: Major
> Fix For: 4.0.0-RC1
>
>
> For `readonly` and `disabled` attributes MyFaces is sending "true" when the
> right value is `readonly="readoly"`
> Current:
> {code:java}
> if (inputFile.isDisabled())
> {
> writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
> } {code}
>
> Should be:
> {code:java}
> if (inputFile.isDisabled())
> {
>writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4393) Faces 4.0: Add docType and optionally render type="javascript"
[ https://issues.apache.org/jira/browse/MYFACES-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315399#comment-17315399 ] Thomas Andraschko commented on MYFACES-4393: [~melloware] added doctype to viewroot, would be great if you can provide a PR for the type=javascript > Faces 4.0: Add docType and optionally render type="javascript" > -- > > Key: MYFACES-4393 > URL: https://issues.apache.org/jira/browse/MYFACES-4393 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.0.0-RC1 >Reporter: Melloware >Priority: Major > > Faces API: https://github.com/eclipse-ee4j/faces-api/issues/1568 > Mojarra DocType: https://github.com/eclipse-ee4j/mojarra/pull/4898 > Mojarra Script: https://github.com/eclipse-ee4j/mojarra/pull/4902/files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4392) Update to quarkus 1.13.0.Final
[ https://issues.apache.org/jira/browse/MYFACES-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4392. Resolution: Fixed > Update to quarkus 1.13.0.Final > -- > > Key: MYFACES-4392 > URL: https://issues.apache.org/jira/browse/MYFACES-4392 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 2.3-next-M5 >Reporter: Bernd Bohmann >Assignee: Bernd Bohmann >Priority: Major > Fix For: 2.3-next-M6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean
[
https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312957#comment-17312957
]
Thomas Andraschko commented on MYFACES-4391:
Thanks for another great contribution!
> Disabled/ReadOnly HTML attributes should not use boolean
>
>
> Key: MYFACES-4391
> URL: https://issues.apache.org/jira/browse/MYFACES-4391
> Project: MyFaces Core
> Issue Type: Improvement
>Reporter: Melloware
>Priority: Major
> Fix For: 4.0.0-RC1, 3.0.1, 2.3.9, 2.3-next-M6
>
>
> For `readonly` and `disabled` attributes MyFaces is sending "true" when the
> right value is `readonly="readoly"`
> Current:
> {code:java}
> if (inputFile.isDisabled())
> {
> writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
> } {code}
>
> Should be:
> {code:java}
> if (inputFile.isDisabled())
> {
>writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean
[
https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4391.
Resolution: Fixed
> Disabled/ReadOnly HTML attributes should not use boolean
>
>
> Key: MYFACES-4391
> URL: https://issues.apache.org/jira/browse/MYFACES-4391
> Project: MyFaces Core
> Issue Type: Improvement
>Reporter: Melloware
>Priority: Major
> Fix For: 4.0.0-RC1, 3.0.1, 2.3.9, 2.3-next-M6
>
>
> For `readonly` and `disabled` attributes MyFaces is sending "true" when the
> right value is `readonly="readoly"`
> Current:
> {code:java}
> if (inputFile.isDisabled())
> {
> writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
> } {code}
>
> Should be:
> {code:java}
> if (inputFile.isDisabled())
> {
>writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4393) Faces 4.0: Add docType and optionally render type="javascript"
[ https://issues.apache.org/jira/browse/MYFACES-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4393. Resolution: Fixed > Faces 4.0: Add docType and optionally render type="javascript" > -- > > Key: MYFACES-4393 > URL: https://issues.apache.org/jira/browse/MYFACES-4393 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.0.0-RC1 >Reporter: Melloware >Priority: Major > Fix For: 4.0.0-RC1 > > > Faces API: https://github.com/eclipse-ee4j/faces-api/issues/1568 > Mojarra DocType: https://github.com/eclipse-ee4j/mojarra/pull/4898 > Mojarra Script: https://github.com/eclipse-ee4j/mojarra/pull/4902/files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4371) Resources: set cache-control-header instead of expires-header
[
https://issues.apache.org/jira/browse/MYFACES-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301462#comment-17301462
]
Thomas Andraschko commented on MYFACES-4371:
would be great if you can provide PRs! please also add 2.3-next
> Resources: set cache-control-header instead of expires-header
> -
>
> Key: MYFACES-4371
> URL: https://issues.apache.org/jira/browse/MYFACES-4371
> Project: MyFaces Core
> Issue Type: Wish
>Reporter: Christoph Straßer
>Priority: Trivial
>
> [https://github.com/apache/myfaces/blob/master/impl/src/main/java/org/apache/myfaces/resource/ResourceImpl.java#L208]
> currently set´s expires-header.
> IMO it´s today state-of-the-art to set {{cache-control: max-age=XXX}} instead
> of {{expires}} for resources which should be cached. And set {{cache-control:
> no-cache}} for resources which should not be cached.
> Details:
> [https://developer.mozilla.org/de/docs/Web/HTTP/Headers/Cache-Control]
> This would also simplify code a bit.
> Also opened a mojarra-issue:
> https://github.com/eclipse-ee4j/mojarra/issues/4800
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4371) Resources: set cache-control-header instead of expires-header
[
https://issues.apache.org/jira/browse/MYFACES-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301456#comment-17301456
]
Thomas Andraschko commented on MYFACES-4371:
Thanks!
As the change is quite easy, should we port it to other branches?
> Resources: set cache-control-header instead of expires-header
> -
>
> Key: MYFACES-4371
> URL: https://issues.apache.org/jira/browse/MYFACES-4371
> Project: MyFaces Core
> Issue Type: Wish
>Reporter: Christoph Straßer
>Priority: Trivial
>
> [https://github.com/apache/myfaces/blob/master/impl/src/main/java/org/apache/myfaces/resource/ResourceImpl.java#L208]
> currently set´s expires-header.
> IMO it´s today state-of-the-art to set {{cache-control: max-age=XXX}} instead
> of {{expires}} for resources which should be cached. And set {{cache-control:
> no-cache}} for resources which should not be cached.
> Details:
> [https://developer.mozilla.org/de/docs/Web/HTTP/Headers/Cache-Control]
> This would also simplify code a bit.
> Also opened a mojarra-issue:
> https://github.com/eclipse-ee4j/mojarra/issues/4800
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4382) Missing check in CDIManagedBeanHandlerImpl causes high amounts of "@SessionScoped does not exist within current thread" exceptions
[
https://issues.apache.org/jira/browse/MYFACES-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4382.
Resolution: Fixed
Thanks for the tests and PR!
> Missing check in CDIManagedBeanHandlerImpl causes high amounts of
> "@SessionScoped does not exist within current thread" exceptions
> --
>
> Key: MYFACES-4382
> URL: https://issues.apache.org/jira/browse/MYFACES-4382
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.8
> Environment: Tomcat 9.0.43
> OpenWebBeans 2.0.21
>Reporter: Juri Berlanda
>Priority: Major
> Fix For: 3.0.1, 2.3.9, 2.2.15, 2.3-next-M6
>
>
> Since upgrading from 2.3.4 to 2.3.8 we noticed a huge amount of
> {{@SessionScoped does not exist within current thread}} exceptions in our
> logs.
> As [~tandraschko] pointed out on the mailing list this could be a side effect
> of MYFACES-4353.
> Will create some PRs for {{2.2, 2.3, 3.0 and 2.3-next}} shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MYFACES-4371) Resources: set cache-control-header instead of expires-header
[
https://issues.apache.org/jira/browse/MYFACES-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko updated MYFACES-4371:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for your contributions
> Resources: set cache-control-header instead of expires-header
> -
>
> Key: MYFACES-4371
> URL: https://issues.apache.org/jira/browse/MYFACES-4371
> Project: MyFaces Core
> Issue Type: Wish
>Reporter: Christoph Straßer
>Priority: Trivial
> Fix For: 4.0.0-RC1, 3.0.1, 2.3.9, 2.3.9-SNAPSHOT
>
>
> [https://github.com/apache/myfaces/blob/master/impl/src/main/java/org/apache/myfaces/resource/ResourceImpl.java#L208]
> currently set´s expires-header.
> IMO it´s today state-of-the-art to set {{cache-control: max-age=XXX}} instead
> of {{expires}} for resources which should be cached. And set {{cache-control:
> no-cache}} for resources which should not be cached.
> Details:
> [https://developer.mozilla.org/de/docs/Web/HTTP/Headers/Cache-Control]
> This would also simplify code a bit.
> Also opened a mojarra-issue:
> https://github.com/eclipse-ee4j/mojarra/issues/4800
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MYFACES-4381) Invalid ID is created when facet contains invalid (id) chars
[
https://issues.apache.org/jira/browse/MYFACES-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4381.
Resolution: Fixed
> Invalid ID is created when facet contains invalid (id) chars
>
>
> Key: MYFACES-4381
> URL: https://issues.apache.org/jira/browse/MYFACES-4381
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.14, 2.3-next-M5, 3.0.0, 2.3.8
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 4.0.0-RC1, 3.0.1, 2.3.9, 2.2.15, 2.3-next-M6
>
>
> e.g.
> f:facet name="{Exporter}" seems valid from spec perspective
> but in MyFaces this name is reused in the UIPanel facet instance and
> therefore we throw a expcetion later, that it contains { or }
> Mojarra doesnt set a ID to the facet, therefore it doenst occur
> for now . is replaced with _, i will enhance this to replace {}
> i general a regex would be better here but also slower
> see: https://github.com/primefaces/primefaces/issues/7060
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MYFACES-4381) Invalid ID is created when facet contains invalid (id) chars
Thomas Andraschko created MYFACES-4381:
--
Summary: Invalid ID is created when facet contains invalid (id)
chars
Key: MYFACES-4381
URL: https://issues.apache.org/jira/browse/MYFACES-4381
Project: MyFaces Core
Issue Type: Bug
Reporter: Thomas Andraschko
Assignee: Thomas Andraschko
e.g.
f:facet name="{Exporter}" seems valid from spec perspective
but in MyFaces this name is reused in the UIPanel facet instance and therefore
we throw a expcetion later, that it contains { or }
Mojarra doesnt set a ID to the facet, therefore it doenst occur
for now . is replaced with _, i will enhance this to replace {}
i general a regex would be better here but also slower
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MYFACES-4285) NullPointerException because of 4099
[
https://issues.apache.org/jira/browse/MYFACES-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295418#comment-17295418
]
Thomas Andraschko commented on MYFACES-4285:
[~ivy-arus] sure, would be great if you can provide a PR!
> NullPointerException because of 4099
>
>
> Key: MYFACES-4285
> URL: https://issues.apache.org/jira/browse/MYFACES-4285
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.0-beta, 2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4
>Reporter: Jiyan Akgül
>Assignee: Thomas Andraschko
>Priority: Major
> Fix For: 2.3-next-M1, 2.3.4
>
> Attachments: mf4285.zip
>
>
> The improvement 4099 introduced with version 2.3 leads to a
> NullPointerException in +TagAttributeImpl.java:550 [View File on
> Github|https://github.com/apache/myfaces/blob/myfaces-core-module-2.3.3/impl/src/main/java/org/apache/myfaces/view/facelets/tag/TagAttributeImpl.java#L550]+
>
> {code:java}
> Location ccLocation = (Location) actx.getFaceletCompositionContext().
> getCompositeComponentFromStack().getAttributes().get(
> CompositeComponentELUtils.LOCATION_KEY);{code}
> getCompositeComponentFromStack() returns null, because there is no stack.
> The composite component is not calling any child components and used inside a
> ui:composition
>
> Usage of composite component in test.xhtml (simplified)
>
> {code:java}
>
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;>
> http://www.w3.org/1999/xhtml;
> xmlns:cw="http://xmlns.jcp.org/jsf/composite/components;
> xmlns:ui="http://java.sun.com/jsf/facelets;>
> saveListener="#{customerBean.updateAttributeContainer(cc.wrapper)}"
> wrapper="#{attributeGroup}" />
> {code}
> The problem is caused because of "cc.wrapper". This worked in 2.2 and now we
> can't update.
>
> Error displayed on page (not helpful)
>
> {code:java}
> /test.xhtml at line 16 and column 37
> saveListener="#{customerBean.updateAttributeContainer(cc.wrapper)}" null
> viewId=/test.xhtml
> location=C:\data\workspace-eclipse\.metadata\.plugins\org.eclipse.wst.server.core\tmp0\wtpwebapps\provDB-webapp\test.xhtml
> phaseId=RENDER_RESPONSE(6)
> Caused by:
> java.lang.NullPointerException - /test.xhtml at line 16 and column 37
> saveListener="#{customerBean.updateAttributeContainer(cc.wrapper)}" null
> at
> org.apache.myfaces.view.facelets.tag.TagAttributeImpl.getValueExpression(TagAttributeImpl.java:550)
> {code}
> Stack Trace
>
> {code:java}
> javax.faces.view.facelets.TagAttributeException: /test.xhtml at line 16 and
> column 37 saveListener="#{customerBean.updateAttributeContainer(cc.wrapper)}"
> null
> at
> org.apache.myfaces.view.facelets.tag.TagAttributeImpl.getValueExpression(TagAttributeImpl.java:578)
> at
> org.apache.myfaces.view.facelets.tag.composite.CompositeComponentRule$ValueExpressionMetadata.applyMetadata(CompositeComponentRule.java:101)
> at
> org.apache.myfaces.view.facelets.tag.MetadataImpl.applyMetadata(MetadataImpl.java:45)
> at
> org.apache.myfaces.view.facelets.tag.composite.CompositeComponentResourceTagHandler.setAttributes(CompositeComponentResourceTagHandler.java:488)
> at
> org.apache.myfaces.view.facelets.tag.jsf.ComponentTagHandlerDelegate.apply(ComponentTagHandlerDelegate.java:290)
> at
> javax.faces.view.facelets.DelegatingMetaTagHandler.apply(DelegatingMetaTagHandler.java:51)
> at
> org.apache.myfaces.view.facelets.tag.ui.CompositionHandler.apply(CompositionHandler.java:160)
> at
> org.apache.myfaces.view.facelets.compiler.NamespaceHandler.apply(NamespaceHandler.java:59)
> at
> org.apache.myfaces.view.facelets.compiler.EncodingHandler.apply(EncodingHandler.java:48)
> at
> org.apache.myfaces.view.facelets.impl.DefaultFacelet.apply(DefaultFacelet.java:187)
> at
> org.apache.myfaces.view.facelets.FaceletViewDeclarationLanguage.buildView(FaceletViewDeclarationLanguage.java:483)
> at
> org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:79)
> at
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:266)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:206)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at
> org.apache.shiro.web.servlet.ProxiedFilterChain.doFilter(ProxiedFilterChain.java:61)
> at
[jira] [Resolved] (MYFACES-4389) Faces 4.0: add f:selectItemGroups
[ https://issues.apache.org/jira/browse/MYFACES-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4389. Resolution: Fixed > Faces 4.0: add f:selectItemGroups > - > > Key: MYFACES-4389 > URL: https://issues.apache.org/jira/browse/MYFACES-4389 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > https://github.com/eclipse-ee4j/faces-api/issues/1559 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4387) Faces 4.0: rename "jsf" throughout source code to "faces"
[ https://issues.apache.org/jira/browse/MYFACES-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4387. Resolution: Fixed > Faces 4.0: rename "jsf" throughout source code to "faces" > - > > Key: MYFACES-4387 > URL: https://issues.apache.org/jira/browse/MYFACES-4387 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > https://github.com/eclipse-ee4j/faces-api/issues/1552 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4396) Faces 4.0: execute="@this" and render="@this" does not behave as expected when nested in composite component
Thomas Andraschko created MYFACES-4396: -- Summary: Faces 4.0: execute="@this" and render="@this" does not behave as expected when nested in composite component Key: MYFACES-4396 URL: https://issues.apache.org/jira/browse/MYFACES-4396 Project: MyFaces Core Issue Type: Improvement Reporter: Thomas Andraschko Assignee: Thomas Andraschko https://github.com/eclipse-ee4j/faces-api/issues/1567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MYFACES-4397) Faces 4.0: remove deprecated "current component" constants from UIComponent
Thomas Andraschko created MYFACES-4397: -- Summary: Faces 4.0: remove deprecated "current component" constants from UIComponent Key: MYFACES-4397 URL: https://issues.apache.org/jira/browse/MYFACES-4397 Project: MyFaces Core Issue Type: Improvement Affects Versions: 4.0.0-RC1 Reporter: Thomas Andraschko Assignee: Thomas Andraschko https://github.com/eclipse-ee4j/faces-api/issues/1571 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4396) Faces 4.0: execute="@this" and render="@this" does not behave as expected when nested in composite component
[ https://issues.apache.org/jira/browse/MYFACES-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4396. Resolution: Fixed > Faces 4.0: execute="@this" and render="@this" does not behave as > expected when nested in composite component > - > > Key: MYFACES-4396 > URL: https://issues.apache.org/jira/browse/MYFACES-4396 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > https://github.com/eclipse-ee4j/faces-api/issues/1567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4395) Faces 4.0: execute="@this" and render="@this" does not behave as expected when nested in composite component
[ https://issues.apache.org/jira/browse/MYFACES-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4395. Resolution: Fixed > Faces 4.0: execute="@this" and render="@this" does not behave as > expected when nested in composite component > - > > Key: MYFACES-4395 > URL: https://issues.apache.org/jira/browse/MYFACES-4395 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Priority: Major > Fix For: 4.0.0-RC1 > > > https://github.com/eclipse-ee4j/faces-api/issues/1567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MYFACES-4397) Faces 4.0: remove deprecated "current component" constants from UIComponent
[ https://issues.apache.org/jira/browse/MYFACES-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4397. Resolution: Fixed > Faces 4.0: remove deprecated "current component" constants from UIComponent > --- > > Key: MYFACES-4397 > URL: https://issues.apache.org/jira/browse/MYFACES-4397 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.0.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > > https://github.com/eclipse-ee4j/faces-api/issues/1571 -- This message was sent by Atlassian Jira (v8.3.4#803005)
