Re: PRs and reviews

2015-11-04 Thread Adam Bordelon
FYI, I asked the infrastructure-dev mailing list about merging github PRs,
and these are the answers I got:
http://mail-archives.apache.org/mod_mbox/www-infrastructure-dev/201510.mbox/%3CCANyrgveNjTDWOXj6fM4v2hRhJXwB%3DS2ko8rZ_2if6AY2c-Knyw%40mail.gmail.com%3E
and
http://mail-archives.apache.org/mod_mbox/www-infrastructure-dev/201510.mbox/%3CCAPbPdOY%2BYq0VACKbqXx3%2B0zquD3Ro9t7ciECqEEiUtZ6JExrvw%40mail.gmail.com%3E

TL;DR:
- Cloudstack has a git-pr script:
https://github.com/apache/cloudstack/tree/master/tools/git
- jfarrell created a rbt extension: https://github.com/jfarrell/rbt-github
- Including "Fixes #123" in the commit message will tell asfbot to close
the PR/issue.


On Wed, Nov 4, 2015 at 4:18 PM, Jim Klucar  wrote:

> I'd like to discuss how we do PRs and code reviews. Right now we are using
> github most likely because that's how we did it before Apache. Now the code
> lives in the Apache hosted repo and we have Review Board available to us.
> My assumption is that we are individually more familiar with one way or the
> other and we could argue their virtues here, but I have another suggestion.
> Why not after this release goes out, we switch off github and use review
> board for the next release and then discuss?
>


PRs and reviews

2015-11-04 Thread Jim Klucar
I'd like to discuss how we do PRs and code reviews. Right now we are using
github most likely because that's how we did it before Apache. Now the code
lives in the Apache hosted repo and we have Review Board available to us.
My assumption is that we are individually more familiar with one way or the
other and we could argue their virtues here, but I have another suggestion.
Why not after this release goes out, we switch off github and use review
board for the next release and then discuss?


[jira] [Resolved] (MYRIAD-114) Automatic dashboard building

2015-11-04 Thread Santosh Marella (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYRIAD-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Marella resolved MYRIAD-114.

Resolution: Fixed

> Automatic dashboard building
> 
>
> Key: MYRIAD-114
> URL: https://issues.apache.org/jira/browse/MYRIAD-114
> Project: Myriad
>  Issue Type: Bug
>Reporter: Jim Klucar
>Assignee: Jim Klucar
> Fix For: Myriad 0.1.0
>
>
> Build the dashboard as part of the Myriad build process.  This would require:
> - [ ] npm install of dashboard dependencies
> - [ ] removing files under webapp/public (could be part of gulp)
> - [ ] running gulp script
> Benefits: 
> Can remove myriad-scheduler/src/main/resources/webapp/public/* from git. This 
> is auto-generated each time gulp is run, so any diffs in this directory don't 
> mean anything and are just noise.
> Drawbacks:
> Users must have npm/node installed to build Myriad. (maybe we only build if 
> they have node installed?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (MYRIAD-98) Move from 4 spaces to 2 spaces for indentation

2015-11-04 Thread Santosh Marella (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYRIAD-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Marella resolved MYRIAD-98.
---
Resolution: Fixed
  Assignee: Jim Klucar

Fixed with following PRs:

https://github.com/apache/incubator-myriad/pull/26
https://github.com/apache/incubator-myriad/pull/22

> Move from 4 spaces to 2 spaces for indentation
> --
>
> Key: MYRIAD-98
> URL: https://issues.apache.org/jira/browse/MYRIAD-98
> Project: Myriad
>  Issue Type: Bug
>Reporter: Santosh Marella
>Assignee: Jim Klucar
> Fix For: Myriad 0.1.0
>
>
> A lot of open source java projects use 2 spaces for indentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MYRIAD-32) Vagrant instructions incomplete/ambiguous

2015-11-04 Thread Santosh Marella (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYRIAD-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Marella updated MYRIAD-32:
--
Fix Version/s: (was: Myriad 0.1.0)

> Vagrant instructions incomplete/ambiguous
> -
>
> Key: MYRIAD-32
> URL: https://issues.apache.org/jira/browse/MYRIAD-32
> Project: Myriad
>  Issue Type: Bug
>Reporter: Michael Hausenblas
>Assignee: Ken Sipe
>
> Following exactly the steps in vagrant.md yields a Gradle error:
>   FAILURE: Build failed with an exception.
>   * What went wrong:
>   Could not create service of type TaskArtifactStateCacheAccess using 
> TaskExecutionServices.createCacheAccess().
>   > Failed to create parent directory '/vagrant/.gradle' when creating 
> directory '/vagrant/.gradle/2.1/taskArtifacts'
> The reason is that right before _To build myriad scheduler inside VM, you can 
> do following:_ there should be an instruction to {{exit}}, in other words, 
> not execute {{./gradlew build}} as user {{hduser}}.
> Alternatively, the prompt could be added throughout to make it unambiguous 
> under which user each command is executed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)