Re: Where am I going wrong in building NetBeans source

2019-06-03 Thread Antonio
Is this an "ant" you've installed with apt? I think someone reported 
problems with the ant version that was bundled with Ubuntu/Debian.


I use 1.10.5 (from ant.apache.org) on Debian stretch (9.9) and I can 
build without problems.


Cheers,
Antonio

El 3/6/19 a las 23:13, mark stephens escribió:

I am running 1.10.0

https://github.com/apache/netbeans says to use Ant 1.9.9 or above

Kind Regards,

MArk





On 3 Jun 2019, at 19:18, Geertjan Wielenga 
mailto:geert...@apache.org>> wrote:

What version of Ant is installed needs to be checked.

Gj

On Mon, 3 Jun 2019 at 18:56, Jose Ch 
mailto:pepnes...@gmail.com>> wrote:

Hi Mark,

I just compile the sources an hour ago without problems, I use
openJ9-8u212 JDK and *ant -Dcluster.confg=release *to build the sources.
Perhaps there is a newer commit that broke the building.

Regards
José.

El lun., 3 jun. 2019 a las 11:35, mark stephens (<
marksteph...@idrsolutions.com>) escribió:

I redownloaded the master and ran under Java8 to check I had not
donwloaded the wrong jars and I now get this

Kind Regards,

MArk

compile-bridge:
[mkdir] Created dir:
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
[javac] Compiling 7 source files to
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
   [repeat] warning: [options] bootstrap class path not set in
conjunction with -source 1.6
   [repeat]
/Users/markee/Downloads/netbeans-master/nbbuild/build/public-package-jars/org-netbeans-api-annotations-common.jar(org/netbeans/api/annotations/common/NonNull.class):
warning: Cannot find annotation method 'when()' in type 'Nonnull': class
file for javax.annotation.Nonnull not found
   [repeat] warning: unknown enum constant When.ALWAYS
   [repeat]   reason: class file for javax.annotation.meta.When not found
   [repeat]
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:149:
error: cannot assign a value to final variable systemClasspath
   [repeat] Path.systemClasspath = new Path(null,
AntBridge.getMainClassPath());
   [repeat] ^
   [repeat]
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/NbInputHandler.java:107:
warning: [unchecked] unchecked call to JComboBox(Vector) as a member of
the raw type JComboBox
   [repeat] combo = new
JComboBox(((MultipleChoiceInputRequest)request).getChoices());
   [repeat] ^
   [repeat]   where E is a type-variable:
   [repeat] E extends Object declared in class JComboBox
   [repeat] 1 error
   [repeat] 4 warnings
  [nbmerge] Failed to build target: all-o.apache.tools.ant.module

BUILD FAILED
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The
following error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The
following error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The
following error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build.xml:38:
Compile failed; see the compiler error output for details.

Total time: 3 minutes 3 seconds


-
To unsubscribe, e-mail: 
dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: 
dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Where am I going wrong in building NetBeans source

2019-06-03 Thread Tushar Joshi
Do you have multiple JDKs installed on your machine?
I had issues with multiple JDKs on my Macbook as Ant was somehow using
another JDL always

I am currently using jenv to set global JDK for macOS and then the source
build works properly for me

with regards
Tushar


Re: Apache NetBeans 11.0 Java EE 8 Support (Ready for Testing)

2019-06-03 Thread Josh Juneau
Thanks Jose, I appreciate the feedback.  I'll take a look at the duplicate
GlassFish options.

Josh Juneau
juneau...@gmail.com
http://jj-blogger.blogspot.com
https://www.apress.com/us/search?query=Juneau




On Mon, Jun 3, 2019 at 3:50 PM Jose Ch  wrote:

> Hi Josh,
>
> I re-test a creation of a JEE8 Maven Web App and it was a success, great
> work!.
>
> I found that when you add a new server instance the Glassfish Server
> option appears twice(Capture-3.png). I will now test my projects and will
> inform how it goes.
>
>
> Regards.
> José.
>
> El dom., 2 jun. 2019 a las 9:24, Josh Juneau ()
> escribió:
>
>> Hi Jose/All,
>>
>> I updated the Java EE 8 Maven Archetype groupId, as there were some
>> Sonatype issues with the original.  In order to test, please grab the
>> latest copy of the sources located in the GitHub repository (
>> https://github.com/juneau001/netbeans-javaee8-inprogress) and rebuild.
>> Specifically, the source files that were changed to repair the archetype
>> groupId are located within the
>>
>> enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ui/wizard/archetype
>> package.
>>
>> Please re-test and let me know if there are any issues creating a new Java
>> EE 8 Web Project.
>>
>> Thanks for all of your assistance.
>> Josh Juneau
>> juneau...@gmail.com
>> http://jj-blogger.blogspot.com
>> https://www.apress.com/us/search?query=Juneau
>> 
>>
>>
>>
>> On Fri, May 31, 2019 at 2:07 PM Josh Juneau  wrote:
>>
>> > Thanks for the feedback Jose...let me take a look into this.  It looks
>> > like the Java EE 8 maven archetype may need to be updated.
>> >
>> >
>> > Josh Juneau
>> > juneau...@gmail.com
>> > http://jj-blogger.blogspot.com
>> > https://www.apress.com/us/search?query=Juneau
>> > 
>> >
>> >
>> >
>> > On Fri, May 31, 2019 at 1:55 PM Jose Ch  wrote:
>> >
>> >> Hi Josh,
>> >>
>> >> I followed the instructions and had an error while Netbeans try to
>> create
>> >> a Maven Java Web JEE8 application:
>> >>
>> >> Scanning for projects...
>> >>
>> >> --< org.apache.maven:standalone-pom
>> >---
>> >> Building Maven Stub Project (No POM) 1
>> >> [ pom
>> ]-
>> >>
>> >> >>> maven-archetype-plugin:2.4:generate (default-cli) >
>> generate-sources
>> >> @ standalone-pom >>>
>> >>
>> >> <<< maven-archetype-plugin:2.4:generate (default-cli) <
>> generate-sources
>> >> @ standalone-pom <<<
>> >>
>> >>
>> >> --- maven-archetype-plugin:2.4:generate (default-cli) @ standalone-pom
>> ---
>> >> Generating project in Batch mode
>> >> Archetype defined by properties
>> >> Downloading from webapp-javaee8-repo:
>> >>
>> https://repo.maven.apache.org/maven2/org/apache/netbeans/webapp-javaee8/1.0/webapp-javaee8-1.0.jar
>> >>
>> 
>> >> BUILD FAILURE
>> >>
>> 
>> >> Total time:  1.797 s
>> >> Finished at: 2019-05-31T13:27:59-05:00
>> >>
>> 
>> >> Failed to execute goal
>> >> org.apache.maven.plugins:maven-archetype-plugin:2.4:generate
>> (default-cli)
>> >> on project standalone-pom: The desired archetype does not exist
>> >> (org.apache.netbeans:webapp-javaee8:1.0) -> [Help 1]
>> >>
>> >> To see the full stack trace of the errors, re-run Maven with the -e
>> >> switch.
>> >> Re-run Maven using the -X switch to enable full debug logging.
>> >>
>> >> For more information about the errors and possible solutions, please
>> read
>> >> the following articles:
>> >> [Help 1]
>> >> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> >>
>> >>
>> >> I appended some screenshots.
>> >>
>> >> Jose.
>> >>
>> >> El jue., 30 may. 2019 a las 23:23, Josh Juneau ()
>> >> escribió:
>> >>
>> >>> Thanks for all of the great feedback on the Java EE 8  support for
>> Apache
>> >>> NetBeans thus far.  I have updated the README to direct individuals to
>> >>> install the "Oracle JS Parser" and "nbjavac" after building and
>> running
>> >>> the
>> >>> IDE using a new userdir.  Once completed, the IDE should allow one to
>> add
>> >>> GlassFish 5, GlassFish 5.0.1, or GlassFish 5.1 server.  The IDE will
>> also
>> >>> allow one to create a new Java EE 8 project or convert an existing
>> >>> project
>> >>> to Java EE 8.
>> >>>
>> >>> Let me know if you have any questions.  I will work on putting
>> together a
>> >>> PR to get these features added to Apache NetBeans proper.
>> >>>
>> >>> Thanks
>> >>>
>> >>> Josh Juneau
>> >>> juneau...@gmail.com
>> >>> http://jj-blogger.blogspot.com
>> >>> https://www.apress.com/us/search?query=Juneau
>> >>> 
>> >>>
>> >>>
>> >>>
>> >

Re: Where am I going wrong in building NetBeans source

2019-06-03 Thread Geertjan Wielenga
So try a higher version and see if it helps.

Gj

On Mon, 3 Jun 2019 at 23:13, mark stephens 
wrote:

> I am running 1.10.0
>
> https://github.com/apache/netbeans says to use Ant 1.9.9 or above
>
> Kind Regards,
>
> MArk
>
>
>
>
>
> On 3 Jun 2019, at 19:18, Geertjan Wielenga  geert...@apache.org>> wrote:
>
> What version of Ant is installed needs to be checked.
>
> Gj
>
> On Mon, 3 Jun 2019 at 18:56, Jose Ch  pepnes...@gmail.com>> wrote:
>
> Hi Mark,
>
> I just compile the sources an hour ago without problems, I use
> openJ9-8u212 JDK and *ant -Dcluster.confg=release *to build the sources.
> Perhaps there is a newer commit that broke the building.
>
> Regards
> José.
>
> El lun., 3 jun. 2019 a las 11:35, mark stephens (<
> marksteph...@idrsolutions.com>)
> escribió:
>
> I redownloaded the master and ran under Java8 to check I had not
> donwloaded the wrong jars and I now get this
>
> Kind Regards,
>
> MArk
>
> compile-bridge:
>[mkdir] Created dir:
>
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
>[javac] Compiling 7 source files to
>
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
>   [repeat] warning: [options] bootstrap class path not set in
> conjunction with -source 1.6
>   [repeat]
>
> /Users/markee/Downloads/netbeans-master/nbbuild/build/public-package-jars/org-netbeans-api-annotations-common.jar(org/netbeans/api/annotations/common/NonNull.class):
> warning: Cannot find annotation method 'when()' in type 'Nonnull': class
> file for javax.annotation.Nonnull not found
>   [repeat] warning: unknown enum constant When.ALWAYS
>   [repeat]   reason: class file for javax.annotation.meta.When not found
>   [repeat]
>
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:149:
> error: cannot assign a value to final variable systemClasspath
>   [repeat] Path.systemClasspath = new Path(null,
> AntBridge.getMainClassPath());
>   [repeat] ^
>   [repeat]
>
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/NbInputHandler.java:107:
> warning: [unchecked] unchecked call to JComboBox(Vector) as a member of
> the raw type JComboBox
>   [repeat] combo = new
> JComboBox(((MultipleChoiceInputRequest)request).getChoices());
>   [repeat] ^
>   [repeat]   where E is a type-variable:
>   [repeat] E extends Object declared in class JComboBox
>   [repeat] 1 error
>   [repeat] 4 warnings
>  [nbmerge] Failed to build target: all-o.apache.tools.ant.module
>
> BUILD FAILED
> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The
> following error occurred while executing this line:
> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The
> following error occurred while executing this line:
> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The
> following error occurred while executing this line:
>
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build.xml:38:
> Compile failed; see the compiler error output for details.
>
> Total time: 3 minutes 3 seconds
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org dev-unsubscr...@netbeans.apache.org>
> For additional commands, e-mail: dev-h...@netbeans.apache.org dev-h...@netbeans.apache.org>
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>


Re: Where am I going wrong in building NetBeans source

2019-06-03 Thread mark stephens
I am running 1.10.0

https://github.com/apache/netbeans says to use Ant 1.9.9 or above

Kind Regards,

MArk





On 3 Jun 2019, at 19:18, Geertjan Wielenga 
mailto:geert...@apache.org>> wrote:

What version of Ant is installed needs to be checked.

Gj

On Mon, 3 Jun 2019 at 18:56, Jose Ch 
mailto:pepnes...@gmail.com>> wrote:

Hi Mark,

I just compile the sources an hour ago without problems, I use
openJ9-8u212 JDK and *ant -Dcluster.confg=release *to build the sources.
Perhaps there is a newer commit that broke the building.

Regards
José.

El lun., 3 jun. 2019 a las 11:35, mark stephens (<
marksteph...@idrsolutions.com>) escribió:

I redownloaded the master and ran under Java8 to check I had not
donwloaded the wrong jars and I now get this

Kind Regards,

MArk

compile-bridge:
   [mkdir] Created dir:
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
   [javac] Compiling 7 source files to
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
  [repeat] warning: [options] bootstrap class path not set in
conjunction with -source 1.6
  [repeat]
/Users/markee/Downloads/netbeans-master/nbbuild/build/public-package-jars/org-netbeans-api-annotations-common.jar(org/netbeans/api/annotations/common/NonNull.class):
warning: Cannot find annotation method 'when()' in type 'Nonnull': class
file for javax.annotation.Nonnull not found
  [repeat] warning: unknown enum constant When.ALWAYS
  [repeat]   reason: class file for javax.annotation.meta.When not found
  [repeat]
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:149:
error: cannot assign a value to final variable systemClasspath
  [repeat] Path.systemClasspath = new Path(null,
AntBridge.getMainClassPath());
  [repeat] ^
  [repeat]
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/NbInputHandler.java:107:
warning: [unchecked] unchecked call to JComboBox(Vector) as a member of
the raw type JComboBox
  [repeat] combo = new
JComboBox(((MultipleChoiceInputRequest)request).getChoices());
  [repeat] ^
  [repeat]   where E is a type-variable:
  [repeat] E extends Object declared in class JComboBox
  [repeat] 1 error
  [repeat] 4 warnings
 [nbmerge] Failed to build target: all-o.apache.tools.ant.module

BUILD FAILED
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The
following error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The
following error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The
following error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build.xml:38:
Compile failed; see the compiler error output for details.

Total time: 3 minutes 3 seconds


-
To unsubscribe, e-mail: 
dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: 
dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Apache NetBeans 11.0 Java EE 8 Support (Ready for Testing)

2019-06-03 Thread Jose Ch
Hi Josh,

I re-test a creation of a JEE8 Maven Web App and it was a success, great
work!.

I found that when you add a new server instance the Glassfish Server option
appears twice(Capture-3.png). I will now test my projects and will inform
how it goes.


Regards.
José.

El dom., 2 jun. 2019 a las 9:24, Josh Juneau ()
escribió:

> Hi Jose/All,
>
> I updated the Java EE 8 Maven Archetype groupId, as there were some
> Sonatype issues with the original.  In order to test, please grab the
> latest copy of the sources located in the GitHub repository (
> https://github.com/juneau001/netbeans-javaee8-inprogress) and rebuild.
> Specifically, the source files that were changed to repair the archetype
> groupId are located within the
>
> enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ui/wizard/archetype
> package.
>
> Please re-test and let me know if there are any issues creating a new Java
> EE 8 Web Project.
>
> Thanks for all of your assistance.
> Josh Juneau
> juneau...@gmail.com
> http://jj-blogger.blogspot.com
> https://www.apress.com/us/search?query=Juneau
> 
>
>
>
> On Fri, May 31, 2019 at 2:07 PM Josh Juneau  wrote:
>
> > Thanks for the feedback Jose...let me take a look into this.  It looks
> > like the Java EE 8 maven archetype may need to be updated.
> >
> >
> > Josh Juneau
> > juneau...@gmail.com
> > http://jj-blogger.blogspot.com
> > https://www.apress.com/us/search?query=Juneau
> > 
> >
> >
> >
> > On Fri, May 31, 2019 at 1:55 PM Jose Ch  wrote:
> >
> >> Hi Josh,
> >>
> >> I followed the instructions and had an error while Netbeans try to
> create
> >> a Maven Java Web JEE8 application:
> >>
> >> Scanning for projects...
> >>
> >> --< org.apache.maven:standalone-pom >---
> >> Building Maven Stub Project (No POM) 1
> >> [ pom ]-
> >>
> >> >>> maven-archetype-plugin:2.4:generate (default-cli) > generate-sources
> >> @ standalone-pom >>>
> >>
> >> <<< maven-archetype-plugin:2.4:generate (default-cli) < generate-sources
> >> @ standalone-pom <<<
> >>
> >>
> >> --- maven-archetype-plugin:2.4:generate (default-cli) @ standalone-pom
> ---
> >> Generating project in Batch mode
> >> Archetype defined by properties
> >> Downloading from webapp-javaee8-repo:
> >>
> https://repo.maven.apache.org/maven2/org/apache/netbeans/webapp-javaee8/1.0/webapp-javaee8-1.0.jar
> >> 
> >> BUILD FAILURE
> >> 
> >> Total time:  1.797 s
> >> Finished at: 2019-05-31T13:27:59-05:00
> >> 
> >> Failed to execute goal
> >> org.apache.maven.plugins:maven-archetype-plugin:2.4:generate
> (default-cli)
> >> on project standalone-pom: The desired archetype does not exist
> >> (org.apache.netbeans:webapp-javaee8:1.0) -> [Help 1]
> >>
> >> To see the full stack trace of the errors, re-run Maven with the -e
> >> switch.
> >> Re-run Maven using the -X switch to enable full debug logging.
> >>
> >> For more information about the errors and possible solutions, please
> read
> >> the following articles:
> >> [Help 1]
> >> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> >>
> >>
> >> I appended some screenshots.
> >>
> >> Jose.
> >>
> >> El jue., 30 may. 2019 a las 23:23, Josh Juneau ()
> >> escribió:
> >>
> >>> Thanks for all of the great feedback on the Java EE 8  support for
> Apache
> >>> NetBeans thus far.  I have updated the README to direct individuals to
> >>> install the "Oracle JS Parser" and "nbjavac" after building and running
> >>> the
> >>> IDE using a new userdir.  Once completed, the IDE should allow one to
> add
> >>> GlassFish 5, GlassFish 5.0.1, or GlassFish 5.1 server.  The IDE will
> also
> >>> allow one to create a new Java EE 8 project or convert an existing
> >>> project
> >>> to Java EE 8.
> >>>
> >>> Let me know if you have any questions.  I will work on putting
> together a
> >>> PR to get these features added to Apache NetBeans proper.
> >>>
> >>> Thanks
> >>>
> >>> Josh Juneau
> >>> juneau...@gmail.com
> >>> http://jj-blogger.blogspot.com
> >>> https://www.apress.com/us/search?query=Juneau
> >>> 
> >>>
> >>>
> >>>
> >>> On Wed, May 29, 2019 at 9:46 PM Josh Juneau 
> wrote:
> >>>
> >>> > I have completed the modifications required to add Java EE 8,
> >>> GlassFish 5,
> >>> > GlassFish 5.0.1, and Eclipse GlassFish 5.1  support to Apache
> NetBeans
> >>> > 11.0.  I have checked the sources into my own repository, located on
> >>> GitHub
> >>> > at the following URL:
> >>> >
> >>> > GitHub Repository:
> >>> > https://github.com/juneau001/netbeans-javaee8-inprogress
> >>> >
> >>> > Please take a look and

Re: Where am I going wrong in building NetBeans source

2019-06-03 Thread Geertjan Wielenga
What version of Ant is installed needs to be checked.

Gj

On Mon, 3 Jun 2019 at 18:56, Jose Ch  wrote:

> Hi Mark,
>
> I just compile the sources an hour ago without problems, I use
> openJ9-8u212 JDK and *ant -Dcluster.confg=release *to build the sources.
> Perhaps there is a newer commit that broke the building.
>
> Regards
> José.
>
> El lun., 3 jun. 2019 a las 11:35, mark stephens (<
> marksteph...@idrsolutions.com>) escribió:
>
>> I redownloaded the master and ran under Java8 to check I had not
>> donwloaded the wrong jars and I now get this
>>
>> Kind Regards,
>>
>> MArk
>>
>> compile-bridge:
>> [mkdir] Created dir:
>> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
>> [javac] Compiling 7 source files to
>> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
>>[repeat] warning: [options] bootstrap class path not set in
>> conjunction with -source 1.6
>>[repeat]
>> /Users/markee/Downloads/netbeans-master/nbbuild/build/public-package-jars/org-netbeans-api-annotations-common.jar(org/netbeans/api/annotations/common/NonNull.class):
>> warning: Cannot find annotation method 'when()' in type 'Nonnull': class
>> file for javax.annotation.Nonnull not found
>>[repeat] warning: unknown enum constant When.ALWAYS
>>[repeat]   reason: class file for javax.annotation.meta.When not found
>>[repeat]
>> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:149:
>> error: cannot assign a value to final variable systemClasspath
>>[repeat] Path.systemClasspath = new Path(null,
>> AntBridge.getMainClassPath());
>>[repeat] ^
>>[repeat]
>> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/NbInputHandler.java:107:
>> warning: [unchecked] unchecked call to JComboBox(Vector) as a member of
>> the raw type JComboBox
>>[repeat] combo = new
>> JComboBox(((MultipleChoiceInputRequest)request).getChoices());
>>[repeat] ^
>>[repeat]   where E is a type-variable:
>>[repeat] E extends Object declared in class JComboBox
>>[repeat] 1 error
>>[repeat] 4 warnings
>>   [nbmerge] Failed to build target: all-o.apache.tools.ant.module
>>
>> BUILD FAILED
>> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The
>> following error occurred while executing this line:
>> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The
>> following error occurred while executing this line:
>> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The
>> following error occurred while executing this line:
>> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build.xml:38:
>> Compile failed; see the compiler error output for details.
>>
>> Total time: 3 minutes 3 seconds
>>
>>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>


travis is stuck again..

2019-06-03 Thread Brad Walker
I think Travis is stuck again on my build..

https://travis-ci.org/apache/netbeans/builds/540875347?utm_source=github_status&utm_medium=notification

This is for my Iterator changes to remove some of the warnings..

[NETBEANS-2621] cleanup generic class iterator

Thanks.

-brad w.


Re: Where am I going wrong in building NetBeans source

2019-06-03 Thread Jose Ch
Hi Mark,

I just compile the sources an hour ago without problems, I use openJ9-8u212
JDK and *ant -Dcluster.confg=release *to build the sources. Perhaps there
is a newer commit that broke the building.

Regards
José.

El lun., 3 jun. 2019 a las 11:35, mark stephens (<
marksteph...@idrsolutions.com>) escribió:

> I redownloaded the master and ran under Java8 to check I had not
> donwloaded the wrong jars and I now get this
>
> Kind Regards,
>
> MArk
>
> compile-bridge:
> [mkdir] Created dir:
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
> [javac] Compiling 7 source files to
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
>[repeat] warning: [options] bootstrap class path not set in conjunction
> with -source 1.6
>[repeat]
> /Users/markee/Downloads/netbeans-master/nbbuild/build/public-package-jars/org-netbeans-api-annotations-common.jar(org/netbeans/api/annotations/common/NonNull.class):
> warning: Cannot find annotation method 'when()' in type 'Nonnull': class
> file for javax.annotation.Nonnull not found
>[repeat] warning: unknown enum constant When.ALWAYS
>[repeat]   reason: class file for javax.annotation.meta.When not found
>[repeat]
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:149:
> error: cannot assign a value to final variable systemClasspath
>[repeat] Path.systemClasspath = new Path(null,
> AntBridge.getMainClassPath());
>[repeat] ^
>[repeat]
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/NbInputHandler.java:107:
> warning: [unchecked] unchecked call to JComboBox(Vector) as a member of
> the raw type JComboBox
>[repeat] combo = new
> JComboBox(((MultipleChoiceInputRequest)request).getChoices());
>[repeat] ^
>[repeat]   where E is a type-variable:
>[repeat] E extends Object declared in class JComboBox
>[repeat] 1 error
>[repeat] 4 warnings
>   [nbmerge] Failed to build target: all-o.apache.tools.ant.module
>
> BUILD FAILED
> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The
> following error occurred while executing this line:
> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The
> following error occurred while executing this line:
> /Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The
> following error occurred while executing this line:
> /Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build.xml:38:
> Compile failed; see the compiler error output for details.
>
> Total time: 3 minutes 3 seconds
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Re: Where am I going wrong in building NetBeans source

2019-06-03 Thread mark stephens
I redownloaded the master and ran under Java8 to check I had not donwloaded the 
wrong jars and I now get this

Kind Regards,

MArk

compile-bridge:
[mkdir] Created dir: 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
[javac] Compiling 7 source files to 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
   [repeat] warning: [options] bootstrap class path not set in conjunction with 
-source 1.6
   [repeat] 
/Users/markee/Downloads/netbeans-master/nbbuild/build/public-package-jars/org-netbeans-api-annotations-common.jar(org/netbeans/api/annotations/common/NonNull.class):
 warning: Cannot find annotation method 'when()' in type 'Nonnull': class file 
for javax.annotation.Nonnull not found
   [repeat] warning: unknown enum constant When.ALWAYS
   [repeat]   reason: class file for javax.annotation.meta.When not found
   [repeat] 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:149:
 error: cannot assign a value to final variable systemClasspath
   [repeat] Path.systemClasspath = new Path(null, 
AntBridge.getMainClassPath());
   [repeat] ^
   [repeat] 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/NbInputHandler.java:107:
 warning: [unchecked] unchecked call to JComboBox(Vector) as a member of the 
raw type JComboBox
   [repeat] combo = new 
JComboBox(((MultipleChoiceInputRequest)request).getChoices());
   [repeat] ^
   [repeat]   where E is a type-variable:
   [repeat] E extends Object declared in class JComboBox
   [repeat] 1 error
   [repeat] 4 warnings
  [nbmerge] Failed to build target: all-o.apache.tools.ant.module

BUILD FAILED
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build.xml:38:
 Compile failed; see the compiler error output for details.

Total time: 3 minutes 3 seconds



Where am I going wrong in building NetBeans source

2019-06-03 Thread mark stephens
I am trying ot build the NetBeans source on my Mac.

I have downloaded master from https://github.com/apache/netbeans and run 

ant build-nozip -Dpermit.jdk9.builds=true with Java 11 I get 

compile-bridge:
[javac] Compiling 7 source files to 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build/bridge-classes
   [repeat] warning: [options] bootstrap class path not set in conjunction with 
-source 6
   [repeat] warning: [options] source value 6 is obsolete and will be removed 
in a future release
   [repeat] warning: [options] target value 1.6 is obsolete and will be removed 
in a future release
   [repeat] warning: [options] To suppress warnings about obsolete options, use 
-Xlint:-options.
   [repeat] warning: unknown enum constant When.ALWAYS
   [repeat]   reason: class file for javax.annotation.meta.When not found
   [repeat] 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:123:
 warning: [deprecation] newInstance() in Class has been deprecated
   [repeat] return 
((EnumeratedAttribute)c.newInstance()).getValues();
   [repeat]   ^
   [repeat]   where T is a type-variable:
   [repeat] T extends Object declared in class Class
   [repeat] 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java:149:
 error: cannot assign a value to final variable systemClasspath
   [repeat] Path.systemClasspath = new Path(null, 
AntBridge.getMainClassPath());
   [repeat] ^
   [repeat] 
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/NbInputHandler.java:107:
 warning: [unchecked] unchecked call to JComboBox(Vector) as a member of the 
raw type JComboBox
   [repeat] combo = new 
JComboBox(((MultipleChoiceInputRequest)request).getChoices());
   [repeat] ^
   [repeat]   where E is a type-variable:
   [repeat] E extends Object declared in class JComboBox
   [repeat] 1 error
   [repeat] 7 warnings
  [nbmerge] Failed to build target: all-o.apache.tools.ant.module

Under JAva11 I can build the platform with ant -Dcluster.config=platform but 
not the IDE with ant -Dcluster.config=basic or ant -Dcluster.config=full

BUILD FAILED
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/extide/o.apache.tools.ant.module/build.xml:38:
 Compile failed; see the compiler error output for details.

I switch to Java 8 , delete everything in netbeans and start again with ant and 
I get 

jar-lib:
[nb-ext-jar] Building jar: 
/Users/markee/Downloads/netbeans-master/nbbuild/netbeans/ide/modules/ext/ddl.jar

up-to-date:

projectized-common.compile:
   [depend] The class org.netbeans.modules.db.explorer.node.Bundle in file 
/Users/markee/Downloads/netbeans-master/ide/db/build/classes/org/netbeans/modules/db/explorer/node/Bundle.class
 is out of date due to org.netbeans.modules.db.explorer.node.Bundle but has not 
been deleted because its source file could not be determined
   [depend] Deleted 118 out of date files in 0 seconds
 [nb-javac] Compiling 131 source files to 
/Users/markee/Downloads/netbeans-master/ide/db/build/classes
   [repeat] warning: [options] bootstrap class path not set in conjunction with 
-source 1.7
   [repeat] 
/Users/markee/Downloads/netbeans-master/ide/db/src/org/netbeans/api/db/explorer/ConnectionManager.java:24:
 error: cannot access DBConnection
   [repeat] import org.netbeans.lib.ddl.DBConnection;
   [repeat]^
   [repeat]   bad class file: 
/Users/markee/Downloads/netbeans-master/nbbuild/netbeans/ide/modules/ext/ddl.jar(org/netbeans/lib/ddl/DBConnection.class)
   [repeat] class file has wrong version 55.0, should be 52.0
   [repeat] Please remove or make sure it appears in the correct 
subdirectory of the classpath.
  [nbmerge] Failed to build target: all-db

BUILD FAILED
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:512: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:507: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/build.xml:554: The following 
error occurred while executing this line:
/Users/markee/Downloads/netbeans-master/nbbuild/templates/common.xml:201: 
Compile failed; see the compiler error output for details.

Any advice on what am I doing wrong or missing?

Kind Regards,


MArk




RE: NetBeans GUI icons, who drew them?

2019-06-03 Thread Eirik Bakke
> I think IDEA has white-on-black icons when in dark mode, and only some of the 
> icons seem to be colored. That avoids overwhelming the user with colors. A 
> good IDEA, I think ;-)

Those kinds of tricks are actually very easy to apply as an 
ImageFilter--ImageUtilities alreadys supports it (via the "nb.imageicon.filter" 
UIManager property).

For instance, you can convert each pixel color to the LAB color space, and only 
invert the L component. That makes icons white-on-black, but keeps the hue 
(e.g. green remains green). If the colors are still too intense, you can also 
go through the HSB color space and decrease the saturation by some percentage. 
With the latest PRs, this works for every single icon in the IDE, both SVG and 
bitmap.

-- Eirik

-Original Message-
From: Antonio  
Sent: Monday, June 3, 2019 9:56 AM
To: dev@netbeans.apache.org
Subject: Re: NetBeans GUI icons, who drew them?

Sounds reasonable to go for SVG first and tackle redesign later, if required.

I think IDEA has white-on-black icons when in dark mode, and only some of the 
icons seem to be colored. That avoids overwhelming the user with colors. A good 
IDEA, I think ;-)

Cheers,
Antonio

El 03/06/2019 a las 15:36, Eirik Bakke escribió:
>> I was wondering how we're going to create SVG from the PNGs, if we want to 
>> do it by hand, and if so if we want to define a "color set" for icons, or 
>> some sort of guidelines for creating them.
> 
> I proposed some guidelines here: 
> https://issues.apache.org/jira/browse/NETBEANS-2617
> 
> It seems most of the current icons were made by a single graphic designer 
> (Leos Tronicek), who already did the work to come up with a consistent set of 
> colors and shapes. So my proposal is to keep new SVG icons mostly the same as 
> the old ones, only "modernizing" them in ways that make vectorization easier: 
> namely by removing gradients, bevels, and unnecessary drop shadows.
> 
> The proposed approach has a number of advantages:
> * The job of vectorizing icons will be much easier when basing them on 
> existing icons than if creating entirely new shapes and colors. (I've 
> tried both approaches myself.)
> * The new icons will still get a modernized feel.
> * For the many years during which we will have a mix of vector and bitmap 
> icons, the two types of icons will look consistent next to each other.
> * A proposal to replace icons X, Y, and Z will always be 
> uncontroversial, because the new icons will be strictly better than 
> the old ones--mostly same, but better resolution. Any significant 
> redesign, on the other hand, is bound to generate "I liked the old 
> ones better!" or "They don't match the other icons" type responses. 
> (Including from me :-)
> * Once a large number of icons have been converted to SVG, it will be fairly 
> easy to adjust the color scheme in one go, while seeing all the icons next to 
> each other.
> 
> -- Eirik
> 
> -Original Message-
> From: Antonio 
> Sent: Monday, June 3, 2019 7:37 AM
> To: dev@netbeans.apache.org
> Subject: Re: NetBeans GUI icons, who drew them?
> 
> Pretty cool!!
> 
> I was wondering how we're going to create SVG from the PNGs, if we want to do 
> it by hand, and if so if we want to define a "color set" for icons, or some 
> sort of guidelines for creating them.
> 
> Right now we seem to have many different icon styles together...
> 
> Cheers,
> Antonio
> 
> El 01/06/2019 a las 17:23, Eirik Bakke escribió:
>> Thanks!
>>
>> I've now added three HiDPI-related Pull Requests (feel free to comment):
>> * Improved scaling quality for existing low-resolution bitmap icons:
>> https://github.com/apache/netbeans/pull/1273
>> * Support loading and painting of scalable SVG icons (via
>> ImageUtilities): https://github.com/apache/netbeans/pull/1278
>> * Make the splash screen look good on HiDPI displays:
>> https://github.com/apache/netbeans/pull/1246
>>
>> For now, I've kept the ImageUtilities API the same as before. Tim, feel free 
>> to see if my caching approach in the SVG loader PR above satisfies your 
>> performance concerns. IntelliJ also uses Batik to load SVG icons at runtime, 
>> so I figured if it works for them, it should work for us as well. Though 
>> I've taken care to make sure the Batik JARs (3.6MB) are loaded lazily in a 
>> separate service provider module, so they don't have to become part of the 
>> core openide.util.ui module .
>>
>> I have also made a list of icons that would be good to prioritize for future 
>> replacement with SVG versions, and a proposed style guide in the related 
>> JIRA issue:
>> https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.h
>> t
>> ml
>> https://issues.apache.org/jira/browse/NETBEANS-2617
>>
>> -- Eirik
>>
>> -Original Message-
>> From: Christian Lenz 
>> Sent: Thursday, April 11, 2019 3:13 AM
>> To: d...@netbeans.incubator.apache.org
>> Subject: AW: NetBeans GUI icons, who drew them?
>>
>> If you have a public repo or a public package with all Icons,

Re: NetBeans GUI icons, who drew them?

2019-06-03 Thread Antonio
Sounds reasonable to go for SVG first and tackle redesign later, if 
required.


I think IDEA has white-on-black icons when in dark mode, and only some 
of the icons seem to be colored. That avoids overwhelming the user with 
colors. A good IDEA, I think ;-)


Cheers,
Antonio

El 03/06/2019 a las 15:36, Eirik Bakke escribió:

I was wondering how we're going to create SVG from the PNGs, if we want to do it by hand, 
and if so if we want to define a "color set" for icons, or some sort of 
guidelines for creating them.


I proposed some guidelines here: 
https://issues.apache.org/jira/browse/NETBEANS-2617

It seems most of the current icons were made by a single graphic designer (Leos 
Tronicek), who already did the work to come up with a consistent set of colors and 
shapes. So my proposal is to keep new SVG icons mostly the same as the old ones, only 
"modernizing" them in ways that make vectorization easier: namely by removing 
gradients, bevels, and unnecessary drop shadows.

The proposed approach has a number of advantages:
* The job of vectorizing icons will be much easier when basing them on existing 
icons than if creating entirely new shapes and colors. (I've tried both 
approaches myself.)
* The new icons will still get a modernized feel.
* For the many years during which we will have a mix of vector and bitmap 
icons, the two types of icons will look consistent next to each other.
* A proposal to replace icons X, Y, and Z will always be uncontroversial, because the new icons 
will be strictly better than the old ones--mostly same, but better resolution. Any significant 
redesign, on the other hand, is bound to generate "I liked the old ones better!" or 
"They don't match the other icons" type responses. (Including from me :-)
* Once a large number of icons have been converted to SVG, it will be fairly 
easy to adjust the color scheme in one go, while seeing all the icons next to 
each other.

-- Eirik

-Original Message-
From: Antonio 
Sent: Monday, June 3, 2019 7:37 AM
To: dev@netbeans.apache.org
Subject: Re: NetBeans GUI icons, who drew them?

Pretty cool!!

I was wondering how we're going to create SVG from the PNGs, if we want to do it by hand, 
and if so if we want to define a "color set" for icons, or some sort of 
guidelines for creating them.

Right now we seem to have many different icon styles together...

Cheers,
Antonio

El 01/06/2019 a las 17:23, Eirik Bakke escribió:

Thanks!

I've now added three HiDPI-related Pull Requests (feel free to comment):
* Improved scaling quality for existing low-resolution bitmap icons:
https://github.com/apache/netbeans/pull/1273
* Support loading and painting of scalable SVG icons (via
ImageUtilities): https://github.com/apache/netbeans/pull/1278
* Make the splash screen look good on HiDPI displays:
https://github.com/apache/netbeans/pull/1246

For now, I've kept the ImageUtilities API the same as before. Tim, feel free to 
see if my caching approach in the SVG loader PR above satisfies your 
performance concerns. IntelliJ also uses Batik to load SVG icons at runtime, so 
I figured if it works for them, it should work for us as well. Though I've 
taken care to make sure the Batik JARs (3.6MB) are loaded lazily in a separate 
service provider module, so they don't have to become part of the core 
openide.util.ui module .

I have also made a list of icons that would be good to prioritize for future 
replacement with SVG versions, and a proposed style guide in the related JIRA 
issue:
https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.ht
ml
https://issues.apache.org/jira/browse/NETBEANS-2617

-- Eirik

-Original Message-
From: Christian Lenz 
Sent: Thursday, April 11, 2019 3:13 AM
To: d...@netbeans.incubator.apache.org
Subject: AW: NetBeans GUI icons, who drew them?

If you have a public repo or a public package with all Icons, you will not have 
that much duplicates or you have a good chance to find duplicate Icons easily. 
Now we can have mulitple times the same Icon for different stuff or different 
Icons for the same action. The magnify can look different in different packages 
but it should be the same if it is about searching. So you can Change one icon 
for search and each package, which uses this Icon changes. You don’t need to 
find out where to change exact that Icon which is a mess now.


Cheers

Chris



Von: Tim Boudreau
Gesendet: Mittwoch, 10. April 2019 23:05
An: d...@netbeans.incubator.apache.org
Betreff: Re: NetBeans GUI icons, who drew them?

== Precompiling



As Tim points out we don't want to waste CPU/GPU time rendering
gradients for icons at runtime.

We could define some "standard" sizes for icons and precompile them
to these sizes. Very much like native mobile apps do for Android an iOS.
In iOS, for example, they have @1x, @2x, @3x suffixes for different
icons sizes.

That, of course will require a project/repository of its own.



I don't think so, regarding a repo.  Either:
   - Compile them to im

RE: NetBeans GUI icons, who drew them?

2019-06-03 Thread Eirik Bakke
> I was wondering how we're going to create SVG from the PNGs, if we want to do 
> it by hand, and if so if we want to define a "color set" for icons, or some 
> sort of guidelines for creating them.

I proposed some guidelines here: 
https://issues.apache.org/jira/browse/NETBEANS-2617

It seems most of the current icons were made by a single graphic designer (Leos 
Tronicek), who already did the work to come up with a consistent set of colors 
and shapes. So my proposal is to keep new SVG icons mostly the same as the old 
ones, only "modernizing" them in ways that make vectorization easier: namely by 
removing gradients, bevels, and unnecessary drop shadows.

The proposed approach has a number of advantages:
* The job of vectorizing icons will be much easier when basing them on existing 
icons than if creating entirely new shapes and colors. (I've tried both 
approaches myself.)
* The new icons will still get a modernized feel.
* For the many years during which we will have a mix of vector and bitmap 
icons, the two types of icons will look consistent next to each other.
* A proposal to replace icons X, Y, and Z will always be uncontroversial, 
because the new icons will be strictly better than the old ones--mostly same, 
but better resolution. Any significant redesign, on the other hand, is bound to 
generate "I liked the old ones better!" or "They don't match the other icons" 
type responses. (Including from me :-)
* Once a large number of icons have been converted to SVG, it will be fairly 
easy to adjust the color scheme in one go, while seeing all the icons next to 
each other.

-- Eirik

-Original Message-
From: Antonio  
Sent: Monday, June 3, 2019 7:37 AM
To: dev@netbeans.apache.org
Subject: Re: NetBeans GUI icons, who drew them?

Pretty cool!!

I was wondering how we're going to create SVG from the PNGs, if we want to do 
it by hand, and if so if we want to define a "color set" for icons, or some 
sort of guidelines for creating them.

Right now we seem to have many different icon styles together...

Cheers,
Antonio

El 01/06/2019 a las 17:23, Eirik Bakke escribió:
> Thanks!
> 
> I've now added three HiDPI-related Pull Requests (feel free to comment):
> * Improved scaling quality for existing low-resolution bitmap icons: 
> https://github.com/apache/netbeans/pull/1273
> * Support loading and painting of scalable SVG icons (via 
> ImageUtilities): https://github.com/apache/netbeans/pull/1278
> * Make the splash screen look good on HiDPI displays: 
> https://github.com/apache/netbeans/pull/1246
> 
> For now, I've kept the ImageUtilities API the same as before. Tim, feel free 
> to see if my caching approach in the SVG loader PR above satisfies your 
> performance concerns. IntelliJ also uses Batik to load SVG icons at runtime, 
> so I figured if it works for them, it should work for us as well. Though I've 
> taken care to make sure the Batik JARs (3.6MB) are loaded lazily in a 
> separate service provider module, so they don't have to become part of the 
> core openide.util.ui module .
> 
> I have also made a list of icons that would be good to prioritize for future 
> replacement with SVG versions, and a proposed style guide in the related JIRA 
> issue:
> https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.ht
> ml
> https://issues.apache.org/jira/browse/NETBEANS-2617
> 
> -- Eirik
> 
> -Original Message-
> From: Christian Lenz 
> Sent: Thursday, April 11, 2019 3:13 AM
> To: d...@netbeans.incubator.apache.org
> Subject: AW: NetBeans GUI icons, who drew them?
> 
> If you have a public repo or a public package with all Icons, you will not 
> have that much duplicates or you have a good chance to find duplicate Icons 
> easily. Now we can have mulitple times the same Icon for different stuff or 
> different Icons for the same action. The magnify can look different in 
> different packages but it should be the same if it is about searching. So you 
> can Change one icon for search and each package, which uses this Icon 
> changes. You don’t need to find out where to change exact that Icon which is 
> a mess now.
> 
> 
> Cheers
> 
> Chris
> 
> 
> 
> Von: Tim Boudreau
> Gesendet: Mittwoch, 10. April 2019 23:05
> An: d...@netbeans.incubator.apache.org
> Betreff: Re: NetBeans GUI icons, who drew them?
> 
> == Precompiling
> 
>>
>> As Tim points out we don't want to waste CPU/GPU time rendering 
>> gradients for icons at runtime.
>>
>> We could define some "standard" sizes for icons and precompile them 
>> to these sizes. Very much like native mobile apps do for Android an iOS.
>> In iOS, for example, they have @1x, @2x, @3x suffixes for different 
>> icons sizes.
>>
>> That, of course will require a project/repository of its own.
>>
> 
> I don't think so, regarding a repo.  Either:
>   - Compile them to images of several sizes when building the module jar 
> (from reading the comments in VectorIcon, it sounds like particularly on 
> Windows hidpi, this can vary wildly, so I

RE: NetBeans GUI icons, who drew them?

2019-06-03 Thread Eirik Bakke
> I'm somewhat -1 to the SVGLoader SPI approach checking by extension I think.

Yeah, it's a little controversial to load "icon.svg" when the client requested 
"icon.png". Perhaps I'll require the SVG file to be named explicitly for now.

> Why not a generic IconLoader SPI and first loader that handles the URL wins?

I think that would be a separate feature that could be added later. The main 
reason for the SVGLoader SPI is to delay loading of the Batik SVG library JARs 
until after the core startup modules have loaded (e.g. the splash screen). In 
fact, I'd love for the SVGLoader SPI to be a non-public implementation 
detail--is there a way I can do this?

In your proposed IconLoader SPI, how do you image that implementation modules 
will specify which URLs they can handle? If the implementation modules must do 
this programmatically, then they cannot be loaded lazily. So in that case the 
IconLoader SPI ends up being separate from the SVGLoader SPI in any case. Any 
thoughts on this?

-- Eirik

-Original Message-
From: Neil C Smith  
Sent: Monday, June 3, 2019 6:24 AM
To: dev 
Cc: d...@netbeans.incubator.apache.org
Subject: Re: NetBeans GUI icons, who drew them?

Hi,

This looks great! Was going to comment on one of the PR but I've only had a 
chance to glance at the code so far. A query ...

On Sat, 1 Jun 2019, 17:23 Eirik Bakke,  wrote:

> For now, I've kept the ImageUtilities API the same as before.
>

I'm somewhat -1 to the SVGLoader SPI approach checking by extension I think. 
Why not a generic IconLoader SPI and first loader that handles the URL wins? 
This allows other extension in future, for which I can think of a few uses, and 
removes handler specific logic.

Best wishes,

Neil

>


Re: NetBeans GUI icons, who drew them?

2019-06-03 Thread Antonio

Pretty cool!!

I was wondering how we're going to create SVG from the PNGs, if we want 
to do it by hand, and if so if we want to define a "color set" for 
icons, or some sort of guidelines for creating them.


Right now we seem to have many different icon styles together...

Cheers,
Antonio

El 01/06/2019 a las 17:23, Eirik Bakke escribió:

Thanks!

I've now added three HiDPI-related Pull Requests (feel free to comment):
* Improved scaling quality for existing low-resolution bitmap icons: 
https://github.com/apache/netbeans/pull/1273
* Support loading and painting of scalable SVG icons (via ImageUtilities): 
https://github.com/apache/netbeans/pull/1278
* Make the splash screen look good on HiDPI displays: 
https://github.com/apache/netbeans/pull/1246

For now, I've kept the ImageUtilities API the same as before. Tim, feel free to 
see if my caching approach in the SVG loader PR above satisfies your 
performance concerns. IntelliJ also uses Batik to load SVG icons at runtime, so 
I figured if it works for them, it should work for us as well. Though I've 
taken care to make sure the Batik JARs (3.6MB) are loaded lazily in a separate 
service provider module, so they don't have to become part of the core 
openide.util.ui module .

I have also made a list of icons that would be good to prioritize for future 
replacement with SVG versions, and a proposed style guide in the related JIRA 
issue:
https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html
https://issues.apache.org/jira/browse/NETBEANS-2617

-- Eirik

-Original Message-
From: Christian Lenz 
Sent: Thursday, April 11, 2019 3:13 AM
To: d...@netbeans.incubator.apache.org
Subject: AW: NetBeans GUI icons, who drew them?

If you have a public repo or a public package with all Icons, you will not have 
that much duplicates or you have a good chance to find duplicate Icons easily. 
Now we can have mulitple times the same Icon for different stuff or different 
Icons for the same action. The magnify can look different in different packages 
but it should be the same if it is about searching. So you can Change one icon 
for search and each package, which uses this Icon changes. You don’t need to 
find out where to change exact that Icon which is a mess now.


Cheers

Chris



Von: Tim Boudreau
Gesendet: Mittwoch, 10. April 2019 23:05
An: d...@netbeans.incubator.apache.org
Betreff: Re: NetBeans GUI icons, who drew them?

== Precompiling



As Tim points out we don't want to waste CPU/GPU time rendering
gradients for icons at runtime.

We could define some "standard" sizes for icons and precompile them to
these sizes. Very much like native mobile apps do for Android an iOS.
In iOS, for example, they have @1x, @2x, @3x suffixes for different
icons sizes.

That, of course will require a project/repository of its own.



I don't think so, regarding a repo.  Either:
  - Compile them to images of several sizes when building the module jar (from 
reading the comments in VectorIcon, it sounds like particularly on Windows 
hidpi, this can vary wildly, so I'm not sure this is a perfect solution), or
  - Compile them to a Java class that adds up to "painting instructions"
(much faster load time and no dep on batik) - it's not that hard to write a 
Graphics2D implementation that outputs Java code for everything done to it, so 
you could load an SVG image into Batik, and have it paint into that and 
generate a class from the result); on first load, load it, paint it into a 
BufferedImage and save that to the IDE's cache directory, subdirectory by 
screen resolution, with the SHA-1 hash of the original SVG as the name.
- Or, let the installer do this at the end of install - it actually knows 
the screen resolution likely to be needed, so that is the perfect time to do 
it, and let the IDE do the above for anything missing

I don't think a repository just for icons solves much of anything, and probably 
creates some new problems.  If you have a checkout of the IDE, `find . -name 
*.svg` does a fine job for locating everying; disconnect them from the code 
that uses them, and you're guaranteed to wind up with a pile of old icons used 
by nothing that nobody is sure if are unused or not.

-Tim




== Standardizing

If we're to precompile icons we may also want to standardize them
somehow. We could separate icons by cluster (in the repository above),
and create a cluster-specific module responsible for returning icons
(of appropriate size depending on DPI) for all modules in that cluster.

The objective being making all "folder" icons look similar. We now
have blue folders and yellow folders all around.

== Generating SVG from PNG

See Tim's response in another thread [1]. I think Emilian set up a
website in 2017 to do this [2].

I don't think automatic conversion is worth the effort: we'll end up
having to fine-tune the results by hand, as Emilian tried to do back
in 2017.

Also note that Adobe Illustrator seems to have a way to do this:

https://www

Re: NetBeans GUI icons, who drew them?

2019-06-03 Thread Neil C Smith
Hi,

This looks great! Was going to comment on one of the PR but I've only had a
chance to glance at the code so far. A query ...

On Sat, 1 Jun 2019, 17:23 Eirik Bakke,  wrote:

> For now, I've kept the ImageUtilities API the same as before.
>

I'm somewhat -1 to the SVGLoader SPI approach checking by extension I
think. Why not a generic IconLoader SPI and first loader that handles the
URL wins? This allows other extension in future, for which I can think of a
few uses, and removes handler specific logic.

Best wishes,

Neil

>