Re: Review PR-s! Please! We have 9 days to 11.3 feature freeze!

2019-12-06 Thread Josh Juneau
+1 for shifting

Josh Juneau
juneau...@gmail.com
http://jj-blogger.blogspot.com
https://www.apress.com/us/search?query=Juneau

> On Dec 6, 2019, at 3:41 PM, Sven Reimers  wrote:
> 
> +1 for shifting..
> 
> Shall we do an official vote?
> 
> -Sven
> 
> Neil C Smith  schrieb am Fr., 6. Dez. 2019, 21:43:
> 
>>> On Fri, 6 Dec 2019, 19:43 Laszlo Kishalmi, 
>>> wrote:
>>> 
>>> I must missed that. I'd welcome some shift as the January release date
>>> is really conflicts fit the holidays at the year holidays.
>>> 
>> 
>> It was in the thread about release manager where Eric asked about pushing
>> back 11.3 a month. It was always the bit of the schedule that bothered me
>> because of the holidays.
>> 
>> I suggested pushing all the schedule (rather than just 11.3) back for two
>> reasons. One is that there is only a month between 11.3 release and 12.0
>> feature freeze to allow time for NetCAT. The other reason is that 11.2
>> threw up some issues with testing with new JDKs - I think we'd be better
>> having most / all beta testing happen after the new JDKs are readily
>> available.
>> 
>> Best wishes,
>> 
>> Neil
>> 
>>> 
>> 


Re: Review PR-s! Please! We have 9 days to 11.3 feature freeze!

2019-12-06 Thread Sven Reimers
+1 for shifting..

Shall we do an official vote?

-Sven

Neil C Smith  schrieb am Fr., 6. Dez. 2019, 21:43:

> On Fri, 6 Dec 2019, 19:43 Laszlo Kishalmi, 
> wrote:
>
> > I must missed that. I'd welcome some shift as the January release date
> > is really conflicts fit the holidays at the year holidays.
> >
>
> It was in the thread about release manager where Eric asked about pushing
> back 11.3 a month. It was always the bit of the schedule that bothered me
> because of the holidays.
>
> I suggested pushing all the schedule (rather than just 11.3) back for two
> reasons. One is that there is only a month between 11.3 release and 12.0
> feature freeze to allow time for NetCAT. The other reason is that 11.2
> threw up some issues with testing with new JDKs - I think we'd be better
> having most / all beta testing happen after the new JDKs are readily
> available.
>
> Best wishes,
>
> Neil
>
> >
>


Re: Review PR-s! Please! We have 9 days to 11.3 feature freeze!

2019-12-06 Thread Laszlo Kishalmi
I must missed that. I'd welcome some shift as the January release date 
is really conflicts fit the holidays at the year holidays.


Anyhow do we know the state of the C++ donation? Beside of that the C++ 
code has been donated already but its dependency dtrace is still in 
progress...


On 12/6/19 11:35 AM, Neil C Smith wrote:

On Fri, 6 Dec 2019, 19:30 Geertjan Wielenga,  wrote:


I believe Eric Barboni stepped up, provided we delay the release a month or
so, though indeed we need to officially confirm this.


I suggested shifting the whole schedule back a month but no one seems to
have commented on that. We can't just shift 11.3 back without 12.0 as well
anyway. And be good to get C/C++ in 11.3 rather than 12.1.

Best wishes,

Neil



-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Review PR-s! Please! We have 9 days to 11.3 feature freeze!

2019-12-06 Thread Neil C Smith
On Fri, 6 Dec 2019, 19:30 Geertjan Wielenga,  wrote:

> I believe Eric Barboni stepped up, provided we delay the release a month or
> so, though indeed we need to officially confirm this.
>

I suggested shifting the whole schedule back a month but no one seems to
have commented on that. We can't just shift 11.3 back without 12.0 as well
anyway. And be good to get C/C++ in 11.3 rather than 12.1.

Best wishes,

Neil

>


Re: Review PR-s! Please! We have 9 days to 11.3 feature freeze!

2019-12-06 Thread Geertjan Wielenga
I believe Eric Barboni stepped up, provided we delay the release a month or
so, though indeed we need to officially confirm this.

On the C/C++ donation side -- the C/C++ donation is complete, part of the
already donated 4th donation, while we're waiting for the dependent DLight
donation before putting C/C++ into Apache NetBeans GitHub, the news here is
that the auditing is complete and now the DLight donation is being reviewed
prior to signing off and handing the document to Apache. No promises, but
that should be a matter of a few weeks.

Gj


On Fri, Dec 6, 2019 at 8:27 PM Laszlo Kishalmi 
wrote:

> Dear all,
>
> Please take your time and review the changes, most of them warning
> removals, or library changes, but still need a second eye!
>
> Also volunteers on release manager position for 11.3 should step up!
> Then when we have someone, let's the coordination started.
>
> Laszlo Kishalmi
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>


Review PR-s! Please! We have 9 days to 11.3 feature freeze!

2019-12-06 Thread Laszlo Kishalmi

Dear all,

Please take your time and review the changes, most of them warning 
removals, or library changes, but still need a second eye!


Also volunteers on release manager position for 11.3 should step up! 
Then when we have someone, let's the coordination started.


Laszlo Kishalmi



-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: FlatLaf look and feel in main window

2019-12-06 Thread Karl Tauber

Hi,


I will try to focus on an editor color scheme that goes well with
FlatLaf.


It would be good to have some import (or converter) for editor schemes, 
that are available in the internet for other editors/IDEs.


You know that FlatLaf supports using IntelliJ Platform themes, which use 
two files:

- a JSON file that contains UI defaults (colors, borders, ...)
  for the components
- a XML file that contains the editor schemes

FlatLaf can only read the JSON file and converts it on the fly to UI 
defaults that fit for FlatLaf.


Maybe it is possible to convert/import the XML file as well and use as 
editor scheme in NetBeans.


Then we could have many many themes (nearly) for free...


Here are some editor schemes for IntelliJ platform:

https://github.com/Vincent-P/gruvbox-intellij-theme/blob/master/src/main/resources/gruvbox_theme.xml

https://github.com/OlyaB/DarkPurpleTheme/blob/master/resources/themes/darkPurpleScheme.xml


Documentation:
http://www.jetbrains.org/intellij/sdk/docs/reference_guide/ui_themes/themes_extras.html#editor-color-scheme-xml-files


Karl


On 05.12.2019 09:24, Alessandro wrote:

Hi Karl,
   first of all thanks for your stunning work on FlatLaf, it is a great LaF
and if it were for me I would make it the default LaF for NetBeans in a
future release.

I played with Darcula in the past and I even contributed back some small
bits (dialog icons and a fix for baseline alignment of spinners), even if I
can't promise anything, I would gladly help.

I am not working on any of the parts you mentioned so please go ahead and
leave me some time to familiarize with FlatLaf code and its NetBeans
module. I will try to focus on an editor color scheme that goes well with
FlatLaf.

Regards,
Alex

Il giorno mer 4 dic 2019 alle ore 16:36 Karl Tauber 
ha scritto:


Hi there,

I'm Karl, creator of the FlatLaf look and feel.
(https://github.com/JFormDesigner/FlatLaf)

Thanks to Laszlo and Junichi, FlatLaf is now in NetBeans as experimental
LaF.

I'd like to help improving the look of FlatLaf in NetBeans and can spend
some time to work on it.

To avoid duplicate work, I'd like to ask whether someone else is already
working on (parts of) the main window (editor/view tabs, splitter,
minimize/maximize/close buttons, etc)?

If not, I would like to work on these parts.

All work will be done in module org.netbeans.swing.laf.flatlaf.
Other look and feels should be not affected.
All colors, insets, etc will be used from UI defaults, so that it is
customizable and other FlatLaf based themes can be later added.
(https://www.formdev.com/flatlaf/themes/)

Regards,
Karl

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists








-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: FlatLaf look and feel in main window

2019-12-06 Thread Karl Tauber

Hi Eirik,

> Would love for FlatLaF to become the standard dark theme LAF on
> NetBeans in the future (as well as a cross-platform option for light
> themes, even).

Yes, would love that too ;)


Many thanks for the tips and links. They help a lot!
I'm already working on view and editor tabs...

Yes, I have a 40" 4K screen running at 150%.

Thanks,
Karl


On 04.12.2019 17:36, Eirik Bakke wrote:

Hi, Karl.

That's great! Would love for FlatLaF to become the standard dark theme LAF on 
NetBeans in the future (as well as a cross-platform option for light themes, 
even).


the main window (editor/view tabs, splitter, minimize/maximize/close buttons, 
etc)?
If not, I would like to work on these parts.


I did work on the window system icons for the Windows 8 and MacOS Aqua LAFs in 
the past, see https://github.com/apache/netbeans/pull/859 and 
https://github.com/apache/netbeans/commit/8f1f57bdc2552541b9947fd12ac8dd74796539f6
 . Feel free to do the same for FlatLaf! My suggestion would be to copy the 
Windows 8 HiDPI VectorIcon implementations, just changing the colors to match 
whichever FlatLAF theme (dark/light etc.) is selected.

If you have a Windows machine with a HiDPI screen, it's also good to test with 
a non-integral scaling factor (e.g. 150%). Some tweaks are often needed for 
these (e.g. https://github.com/apache/netbeans/pull/1284 on the Windows LAF.)

(Not planning on working on this myself in the next 3 months--though happy to 
answer questions or review PRs.)

-- Eirik

-Original Message-
From: Karl Tauber 
Sent: Wednesday, December 4, 2019 10:36 AM
To: dev@netbeans.apache.org
Subject: FlatLaf look and feel in main window

Hi there,

I'm Karl, creator of the FlatLaf look and feel.
(https://github.com/JFormDesigner/FlatLaf)

Thanks to Laszlo and Junichi, FlatLaf is now in NetBeans as experimental LaF.

I'd like to help improving the look of FlatLaf in NetBeans and can spend some 
time to work on it.

To avoid duplicate work, I'd like to ask whether someone else is already 
working on (parts of) the main window (editor/view tabs, splitter, 
minimize/maximize/close buttons, etc)?

If not, I would like to work on these parts.

All work will be done in module org.netbeans.swing.laf.flatlaf.
Other look and feels should be not affected.
All colors, insets, etc will be used from UI defaults, so that it is 
customizable and other FlatLaf based themes can be later added.
(https://www.formdev.com/flatlaf/themes/)

Regards,
Karl

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists




-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists