Re: 11.1 beta-3 status
Thanks for all of your work on merging the PRs and closing the relevant JIRA issues. Josh Juneau juneau...@gmail.com http://jj-blogger.blogspot.com https://www.apress.com/us/search?query=Juneau > On Jul 3, 2019, at 5:16 AM, Neil C Smith wrote: > > On Wed, 3 Jul 2019 at 10:13, Neil C Smith wrote: >> Looking through and merging now. > > OK, all bar two merged to master, and relevant JIRA issues marked resolved. > > The two pending are - > > https://github.com/apache/netbeans/pull/1285 > https://github.com/apache/netbeans/pull/1338 > > The first is still waiting on a review on requested changes from Jan. > I think all the requested changes are made, so can merge, or someone > else want to check all is ready? > > The second is marked as failing Travis, but I assume just because of > earlier Travis issues - have retriggered the pending test and waiting > for completion. > > Geertjan, you might want to take a look at the stale branches at > https://github.com/apache/netbeans/branches/all I didn't delete any > of yours while merging the PRs, but we might want to remove some of > those temporary branches? > > Best wishes, > > Neil > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > >
Re: 11.1 beta-3 status
On Wed, Jul 3, 2019 at 1:32 PM Neil C Smith wrote: > On pending PRs the following look like possible NB11.1 candidates > although are not marked as such - any thoughts? > > https://github.com/apache/netbeans/pull/1325 > https://github.com/apache/netbeans/pull/1342 FWIW, I think the two above are safe. > https://github.com/apache/netbeans/pull/1352 Less sure about this one (it sits on a path that is used by almost all features that support the Java language), but hopefully will be fine as well. Jan > > Best wishes, > > Neil > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
Re: 11.1 beta-3 status
On Wed, 3 Jul 2019 at 13:03, Neil C Smith wrote: > > On Wed, 3 Jul 2019 at 13:00, Eric Barboni wrote: > > Is it possible to consider this one for 11.1. As the ecosystem of maven > > plugins/archetype is now ready. This may help. > > Should I tag the PR ? > > > > https://github.com/apache/netbeans/pull/1324 > > OK, looking now. Missed it because the NB11.1 label was missing, but > think you'd asked me to look earlier - sorry. Have retriggered the two tests that failed - https://travis-ci.org/apache/netbeans/builds/550323219 Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
On Wed, 3 Jul 2019 at 13:00, Eric Barboni wrote: > Is it possible to consider this one for 11.1. As the ecosystem of maven > plugins/archetype is now ready. This may help. > Should I tag the PR ? > > https://github.com/apache/netbeans/pull/1324 OK, looking now. Missed it because the NB11.1 label was missing, but think you'd asked me to look earlier - sorry. Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: 11.1 beta-3 status
Hi Neil Is it possible to consider this one for 11.1. As the ecosystem of maven plugins/archetype is now ready. This may help. Should I tag the PR ? https://github.com/apache/netbeans/pull/1324 Regards Eric -Message d'origine- De : Neil C Smith Envoyé : mercredi 3 juillet 2019 11:09 À : dev Objet : Re: 11.1 beta-3 status On Tue, 2 Jul 2019 at 23:00, Geertjan Wielenga wrote: > > PS: Sorry, wasn't aware you requested to be added as reviewer to the > nb11.1 tagged PRs, would have done so if I had known, can still do so, > if you like. I think everything tagged as nb11.1 is really important > to include in 11.1, have tried to keep them to a minimum though. No problem! We're all still finding our way on this new release process. I'd suggested all PRs for a release during release window add the release manager as reviewer, and add JIRA reference in title / link in description. Seems to be an easier way for the release manager to track and/or request changes in case of release problems before things hit master now we're doing full merge across. We should review that post-release, and add to / change in release guidelines on the wiki as necessary. Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
On Wed, 3 Jul 2019 at 12:44, Geertjan Wielenga wrote: > Agreed, and all by or approved by jlahoda, so as safe as can be. My thoughts exactly! :-) Created the sync PR - https://github.com/apache/netbeans/pull/1353 Full list of changes from beta2 to beta3 there. Hopefully nothing missing! Time for a break, and to let Travis run on this, then I'll merge and fire up the build task. Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
Agreed, and all by or approved by jlahoda, so as safe as can be. Gj On Wed, 3 Jul 2019 at 13:32, Neil C Smith wrote: > On pending PRs the following look like possible NB11.1 candidates > although are not marked as such - any thoughts? > > https://github.com/apache/netbeans/pull/1325 > https://github.com/apache/netbeans/pull/1342 > https://github.com/apache/netbeans/pull/1352 > > Best wishes, > > Neil > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
Re: 11.1 beta-3 status
On pending PRs the following look like possible NB11.1 candidates although are not marked as such - any thoughts? https://github.com/apache/netbeans/pull/1325 https://github.com/apache/netbeans/pull/1342 https://github.com/apache/netbeans/pull/1352 Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
On Wed, 3 Jul 2019 at 11:30, Geertjan Wielenga wrote: > I think both those two PRs you list can be merged at this point — and > rolled back if needed prior to the vc which (I believe) is the next one > after beta-3. Both are merged. Although I preferred to wait for Travis to go green, which it did. Looks like we're back on track with Travis testing for now, so would rather keep it that way. Would still like to know what caused all the issues with Travis in the first place though. Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
Yes, will do re stale branches. I think both those two PRs you list can be merged at this point — and rolled back if needed prior to the vc which (I believe) is the next one after beta-3. Gj On Wed, 3 Jul 2019 at 12:16, Neil C Smith wrote: > On Wed, 3 Jul 2019 at 10:13, Neil C Smith wrote: > > Looking through and merging now. > > OK, all bar two merged to master, and relevant JIRA issues marked resolved. > > The two pending are - > > https://github.com/apache/netbeans/pull/1285 > https://github.com/apache/netbeans/pull/1338 > > The first is still waiting on a review on requested changes from Jan. > I think all the requested changes are made, so can merge, or someone > else want to check all is ready? > > The second is marked as failing Travis, but I assume just because of > earlier Travis issues - have retriggered the pending test and waiting > for completion. > > Geertjan, you might want to take a look at the stale branches at > https://github.com/apache/netbeans/branches/all I didn't delete any > of yours while merging the PRs, but we might want to remove some of > those temporary branches? > > Best wishes, > > Neil > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
Re: 11.1 beta-3 status
On Wed, 3 Jul 2019 at 10:13, Neil C Smith wrote: > Looking through and merging now. OK, all bar two merged to master, and relevant JIRA issues marked resolved. The two pending are - https://github.com/apache/netbeans/pull/1285 https://github.com/apache/netbeans/pull/1338 The first is still waiting on a review on requested changes from Jan. I think all the requested changes are made, so can merge, or someone else want to check all is ready? The second is marked as failing Travis, but I assume just because of earlier Travis issues - have retriggered the pending test and waiting for completion. Geertjan, you might want to take a look at the stale branches at https://github.com/apache/netbeans/branches/all I didn't delete any of yours while merging the PRs, but we might want to remove some of those temporary branches? Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
On Tue, 2 Jul 2019 at 23:01, Laszlo Kishalmi wrote: > I'm sorry, my bad (as I had a free weekend to form a few PR-s). Not a bad! :-) Looking through and merging now. Unfortunately, having been away since last beta, I'm somewhat behind on merging for this one - no travels between now and release though! Having the release manager as one of the reviewers, but not necessarily have to handle all merging, is probably the right way to go in future. Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
On Tue, 2 Jul 2019 at 23:00, Geertjan Wielenga wrote: > > PS: Sorry, wasn't aware you requested to be added as reviewer to the nb11.1 > tagged PRs, would have done so if I had known, can still do so, if you > like. I think everything tagged as nb11.1 is really important to include in > 11.1, have tried to keep them to a minimum though. No problem! We're all still finding our way on this new release process. I'd suggested all PRs for a release during release window add the release manager as reviewer, and add JIRA reference in title / link in description. Seems to be an easier way for the release manager to track and/or request changes in case of release problems before things hit master now we're doing full merge across. We should review that post-release, and add to / change in release guidelines on the wiki as necessary. Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
I'm sorry, my bad (as I had a free weekend to form a few PR-s). On 7/2/19 2:00 PM, Neil C Smith wrote: On Tue, 2 Jul 2019 at 20:06, Geertjan Wielenga wrote: I reckon we can save him time and merge them ourselves, if we or anyone hasn't yet at the time he gets to it, he'll do the remaining ones that are marked for nb11.1. I've just had a quick look over and seems we have quite a few new ones where I haven't been added as a reviewer (as requested), so would rather work through myself so I know what's merging in, particularly if anything has impacts on subsequent merge to release branch. For NB 11.2+ I think we need to ensure whoever is release managing is added as a reviewer on all PRs, even if they don't necessarily handle merging. Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
PS: Sorry, wasn't aware you requested to be added as reviewer to the nb11.1 tagged PRs, would have done so if I had known, can still do so, if you like. I think everything tagged as nb11.1 is really important to include in 11.1, have tried to keep them to a minimum though. On Tue, Jul 2, 2019 at 11:57 PM Geertjan Wielenga wrote: > Makes sense, thanks! > > Gj > > On Tue, Jul 2, 2019 at 11:01 PM Neil C Smith > wrote: > >> On Tue, 2 Jul 2019 at 20:06, Geertjan Wielenga >> wrote: >> > I reckon we can save him time and merge them ourselves, if we or anyone >> > hasn't yet at the time he gets to it, he'll do the remaining ones that >> are >> > marked for nb11.1. >> >> I've just had a quick look over and seems we have quite a few new ones >> where I haven't been added as a reviewer (as requested), so would >> rather work through myself so I know what's merging in, particularly >> if anything has impacts on subsequent merge to release branch. >> >> For NB 11.2+ I think we need to ensure whoever is release managing is >> added as a reviewer on all PRs, even if they don't necessarily handle >> merging. >> >> Best wishes, >> >> Neil >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org >> For additional commands, e-mail: dev-h...@netbeans.apache.org >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >>
Re: 11.1 beta-3 status
Makes sense, thanks! Gj On Tue, Jul 2, 2019 at 11:01 PM Neil C Smith wrote: > On Tue, 2 Jul 2019 at 20:06, Geertjan Wielenga > wrote: > > I reckon we can save him time and merge them ourselves, if we or anyone > > hasn't yet at the time he gets to it, he'll do the remaining ones that > are > > marked for nb11.1. > > I've just had a quick look over and seems we have quite a few new ones > where I haven't been added as a reviewer (as requested), so would > rather work through myself so I know what's merging in, particularly > if anything has impacts on subsequent merge to release branch. > > For NB 11.2+ I think we need to ensure whoever is release managing is > added as a reviewer on all PRs, even if they don't necessarily handle > merging. > > Best wishes, > > Neil > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
Re: 11.1 beta-3 status
On Tue, 2 Jul 2019 at 20:06, Geertjan Wielenga wrote: > I reckon we can save him time and merge them ourselves, if we or anyone > hasn't yet at the time he gets to it, he'll do the remaining ones that are > marked for nb11.1. I've just had a quick look over and seems we have quite a few new ones where I haven't been added as a reviewer (as requested), so would rather work through myself so I know what's merging in, particularly if anything has impacts on subsequent merge to release branch. For NB 11.2+ I think we need to ensure whoever is release managing is added as a reviewer on all PRs, even if they don't necessarily handle merging. Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
I reckon we can save him time and merge them ourselves, if we or anyone hasn't yet at the time he gets to it, he'll do the remaining ones that are marked for nb11.1. Gj On Tue, Jul 2, 2019 at 9:04 PM Laszlo Kishalmi wrote: > BTW. Shall we merge the approved PR-s or let Neil have the final decision? > > On 7/2/19 10:55 AM, Geertjan Wielenga wrote: > > Very awesome. :-) > > > > Gj > > > > On Tue, Jul 2, 2019 at 7:47 PM Neil C Smith > wrote: > > > >> Hi, > >> > >> On Tue, 2 Jul 2019, 18:27 Geertjan Wielenga, > wrote: > >> > >>> With Neil doing beta-3 tomorrow, there are a few important PRs marked > >> with > >>> nb11.1 in the queue: > >>> > >> Thanks. Literally just back home. Will look through and merge things as > >> required tomorrow morning, and aim to get beta done by close of play. > >> > >> Best wishes, > >> > >> Neil > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
Re: 11.1 beta-3 status
BTW. Shall we merge the approved PR-s or let Neil have the final decision? On 7/2/19 10:55 AM, Geertjan Wielenga wrote: Very awesome. :-) Gj On Tue, Jul 2, 2019 at 7:47 PM Neil C Smith wrote: Hi, On Tue, 2 Jul 2019, 18:27 Geertjan Wielenga, wrote: With Neil doing beta-3 tomorrow, there are a few important PRs marked with nb11.1 in the queue: Thanks. Literally just back home. Will look through and merge things as required tomorrow morning, and aim to get beta done by close of play. Best wishes, Neil - To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: 11.1 beta-3 status
Very awesome. :-) Gj On Tue, Jul 2, 2019 at 7:47 PM Neil C Smith wrote: > Hi, > > On Tue, 2 Jul 2019, 18:27 Geertjan Wielenga, wrote: > > > With Neil doing beta-3 tomorrow, there are a few important PRs marked > with > > nb11.1 in the queue: > > > > Thanks. Literally just back home. Will look through and merge things as > required tomorrow morning, and aim to get beta done by close of play. > > Best wishes, > > Neil >
Re: 11.1 beta-3 status
Hi, On Tue, 2 Jul 2019, 18:27 Geertjan Wielenga, wrote: > With Neil doing beta-3 tomorrow, there are a few important PRs marked with > nb11.1 in the queue: > Thanks. Literally just back home. Will look through and merge things as required tomorrow morning, and aim to get beta done by close of play. Best wishes, Neil
