Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-17 Thread Jean-Marc Borer
Tanks for the info. I fixed it the NBM maven plugin the same way. Now it
works there as well.

On Sat, Jan 15, 2022 at 5:19 AM Jaroslav Tulach 
wrote:

> FYI: https://github.com/apache/netbeans/commit/1b96b56 & co.
>
> It gets interpreted by the NetBeans runtime system.
> -jt
>
>
> čt 13. 1. 2022 v 21:30 odesílatel Jean-Marc Borer 
> napsal:
>
> >
> >
> https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath
> >
> > But still, it is a very special case here since I have never seen URL
> such
> > as "%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar". ${xxx} is a dynamic value
> > that shall be replaced at runtime. I really wonder if the manifest gets
> > properly interpreted with such a construction.
> >
> > On Thu, Jan 13, 2022 at 8:25 PM Jean-Marc Borer 
> wrote:
> >
> > > True. Then the issue lies in the maven nbm plugin that doesn't
> understand
> > > the URL escaping.
> > >
> > > I tested by manually modifying the manifest to restore the old values.
> > The
> > > warning message is gone.
> > >
> > > On Thu, Jan 13, 2022 at 7:04 PM Matthias Bläsing <
> > > mblaes...@doppel-helix.eu> wrote:
> > >
> > >> Hi,
> > >>
> > >> Am Donnerstag, dem 13.01.2022 um 17:54 + schrieb Jean-Marc Borer:
> > >> > When building my NB RCP application with Maven, I get:
> > >> >
> > >> > Could not resolve Class-Path item in
> > >> > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> > >> > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
> > >> >
> > >> > I checked the manifest of module org-netbeans-libs-javafx.jar
> > >> > And actually I found:
> > >> > 
> > >> > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> > >> > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
> > >> >
> > >> > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
> > >> >
> > >> > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> > >> > where jfxrt.jar exists... and JFX works in the application later.
> Just
> > >> > wondering why such warning is generated.
> > >> >
> > >> > I suspect that the Maven checker is somehow not understanding
> properly
> > >> this
> > >> > classpath entry in the manifest.
> > >> >
> > >> > Any idea?
> > >>
> > >> The commit that changes this is here:
> > >>
> > >>
> > >>
> >
> https://github.com/apache/netbeans/commit/1b96b56ac3bfda8bd9b97f36c25901e84289cb23
> > >>
> > >> And is part of this:
> > >>
> > >> https://github.com/apache/netbeans/pull/2761
> > >>
> > >> The TL;DR version is (if I remember correctly): the JAR File
> > >> Specification says, that the Class-Path attribute is a list of URLs
> and
> > >> since javac 11 this is actually enforced.
> > >>
> > >> Try this:
> > >>
> > >> new URI("%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar");
> > >> new URI("${java.home}/lib/ext/jfxrt.jar");
> > >>
> > >> It blows for the second line.
> > >>
> > >> Hope that clears it up.
> > >>
> > >> Greetings
> > >>
> > >> Matthias
> > >>
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> > >> For additional commands, e-mail: dev-h...@netbeans.apache.org
> > >>
> > >> For further information about the NetBeans mailing lists, visit:
> > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > >>
> > >>
> > >>
> > >>
> >
>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-14 Thread Jaroslav Tulach
FYI: https://github.com/apache/netbeans/commit/1b96b56 & co.

It gets interpreted by the NetBeans runtime system.
-jt


čt 13. 1. 2022 v 21:30 odesílatel Jean-Marc Borer 
napsal:

>
> https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath
>
> But still, it is a very special case here since I have never seen URL such
> as "%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar". ${xxx} is a dynamic value
> that shall be replaced at runtime. I really wonder if the manifest gets
> properly interpreted with such a construction.
>
> On Thu, Jan 13, 2022 at 8:25 PM Jean-Marc Borer  wrote:
>
> > True. Then the issue lies in the maven nbm plugin that doesn't understand
> > the URL escaping.
> >
> > I tested by manually modifying the manifest to restore the old values.
> The
> > warning message is gone.
> >
> > On Thu, Jan 13, 2022 at 7:04 PM Matthias Bläsing <
> > mblaes...@doppel-helix.eu> wrote:
> >
> >> Hi,
> >>
> >> Am Donnerstag, dem 13.01.2022 um 17:54 + schrieb Jean-Marc Borer:
> >> > When building my NB RCP application with Maven, I get:
> >> >
> >> > Could not resolve Class-Path item in
> >> > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> >> > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
> >> >
> >> > I checked the manifest of module org-netbeans-libs-javafx.jar
> >> > And actually I found:
> >> > 
> >> > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> >> > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
> >> >
> >> > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
> >> >
> >> > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> >> > where jfxrt.jar exists... and JFX works in the application later. Just
> >> > wondering why such warning is generated.
> >> >
> >> > I suspect that the Maven checker is somehow not understanding properly
> >> this
> >> > classpath entry in the manifest.
> >> >
> >> > Any idea?
> >>
> >> The commit that changes this is here:
> >>
> >>
> >>
> https://github.com/apache/netbeans/commit/1b96b56ac3bfda8bd9b97f36c25901e84289cb23
> >>
> >> And is part of this:
> >>
> >> https://github.com/apache/netbeans/pull/2761
> >>
> >> The TL;DR version is (if I remember correctly): the JAR File
> >> Specification says, that the Class-Path attribute is a list of URLs and
> >> since javac 11 this is actually enforced.
> >>
> >> Try this:
> >>
> >> new URI("%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar");
> >> new URI("${java.home}/lib/ext/jfxrt.jar");
> >>
> >> It blows for the second line.
> >>
> >> Hope that clears it up.
> >>
> >> Greetings
> >>
> >> Matthias
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> >> For additional commands, e-mail: dev-h...@netbeans.apache.org
> >>
> >> For further information about the NetBeans mailing lists, visit:
> >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>
> >>
> >>
> >>
>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Jean-Marc Borer
Reported in https://issues.apache.org/jira/browse/NETBEANSINFRA-262
And already fixed in master of
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin

On Thu, Jan 13, 2022 at 8:29 PM Jean-Marc Borer  wrote:

>
> https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath
>
> But still, it is a very special case here since I have never seen URL such
> as "%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar". ${xxx} is a dynamic value
> that shall be replaced at runtime. I really wonder if the manifest gets
> properly interpreted with such a construction.
>
> On Thu, Jan 13, 2022 at 8:25 PM Jean-Marc Borer  wrote:
>
>> True. Then the issue lies in the maven nbm plugin that doesn't understand
>> the URL escaping.
>>
>> I tested by manually modifying the manifest to restore the old values.
>> The warning message is gone.
>>
>> On Thu, Jan 13, 2022 at 7:04 PM Matthias Bläsing <
>> mblaes...@doppel-helix.eu> wrote:
>>
>>> Hi,
>>>
>>> Am Donnerstag, dem 13.01.2022 um 17:54 + schrieb Jean-Marc Borer:
>>> > When building my NB RCP application with Maven, I get:
>>> >
>>> > Could not resolve Class-Path item in
>>> > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
>>> > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
>>> >
>>> > I checked the manifest of module org-netbeans-libs-javafx.jar
>>> > And actually I found:
>>> > 
>>> > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
>>> > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
>>> >
>>> > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
>>> >
>>> > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
>>> > where jfxrt.jar exists... and JFX works in the application later. Just
>>> > wondering why such warning is generated.
>>> >
>>> > I suspect that the Maven checker is somehow not understanding properly
>>> this
>>> > classpath entry in the manifest.
>>> >
>>> > Any idea?
>>>
>>> The commit that changes this is here:
>>>
>>>
>>> https://github.com/apache/netbeans/commit/1b96b56ac3bfda8bd9b97f36c25901e84289cb23
>>>
>>> And is part of this:
>>>
>>> https://github.com/apache/netbeans/pull/2761
>>>
>>> The TL;DR version is (if I remember correctly): the JAR File
>>> Specification says, that the Class-Path attribute is a list of URLs and
>>> since javac 11 this is actually enforced.
>>>
>>> Try this:
>>>
>>> new URI("%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar");
>>> new URI("${java.home}/lib/ext/jfxrt.jar");
>>>
>>> It blows for the second line.
>>>
>>> Hope that clears it up.
>>>
>>> Greetings
>>>
>>> Matthias
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
>>> For additional commands, e-mail: dev-h...@netbeans.apache.org
>>>
>>> For further information about the NetBeans mailing lists, visit:
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>
>>>
>>>
>>>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Jean-Marc Borer
https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath

But still, it is a very special case here since I have never seen URL such
as "%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar". ${xxx} is a dynamic value
that shall be replaced at runtime. I really wonder if the manifest gets
properly interpreted with such a construction.

On Thu, Jan 13, 2022 at 8:25 PM Jean-Marc Borer  wrote:

> True. Then the issue lies in the maven nbm plugin that doesn't understand
> the URL escaping.
>
> I tested by manually modifying the manifest to restore the old values. The
> warning message is gone.
>
> On Thu, Jan 13, 2022 at 7:04 PM Matthias Bläsing <
> mblaes...@doppel-helix.eu> wrote:
>
>> Hi,
>>
>> Am Donnerstag, dem 13.01.2022 um 17:54 + schrieb Jean-Marc Borer:
>> > When building my NB RCP application with Maven, I get:
>> >
>> > Could not resolve Class-Path item in
>> > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
>> > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
>> >
>> > I checked the manifest of module org-netbeans-libs-javafx.jar
>> > And actually I found:
>> > 
>> > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
>> > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
>> >
>> > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
>> >
>> > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
>> > where jfxrt.jar exists... and JFX works in the application later. Just
>> > wondering why such warning is generated.
>> >
>> > I suspect that the Maven checker is somehow not understanding properly
>> this
>> > classpath entry in the manifest.
>> >
>> > Any idea?
>>
>> The commit that changes this is here:
>>
>>
>> https://github.com/apache/netbeans/commit/1b96b56ac3bfda8bd9b97f36c25901e84289cb23
>>
>> And is part of this:
>>
>> https://github.com/apache/netbeans/pull/2761
>>
>> The TL;DR version is (if I remember correctly): the JAR File
>> Specification says, that the Class-Path attribute is a list of URLs and
>> since javac 11 this is actually enforced.
>>
>> Try this:
>>
>> new URI("%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar");
>> new URI("${java.home}/lib/ext/jfxrt.jar");
>>
>> It blows for the second line.
>>
>> Hope that clears it up.
>>
>> Greetings
>>
>> Matthias
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
>> For additional commands, e-mail: dev-h...@netbeans.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Jean-Marc Borer
True. Then the issue lies in the maven nbm plugin that doesn't understand
the URL escaping.

I tested by manually modifying the manifest to restore the old values. The
warning message is gone.

On Thu, Jan 13, 2022 at 7:04 PM Matthias Bläsing 
wrote:

> Hi,
>
> Am Donnerstag, dem 13.01.2022 um 17:54 + schrieb Jean-Marc Borer:
> > When building my NB RCP application with Maven, I get:
> >
> > Could not resolve Class-Path item in
> > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
> >
> > I checked the manifest of module org-netbeans-libs-javafx.jar
> > And actually I found:
> > 
> > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
> >
> > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
> >
> > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> > where jfxrt.jar exists... and JFX works in the application later. Just
> > wondering why such warning is generated.
> >
> > I suspect that the Maven checker is somehow not understanding properly
> this
> > classpath entry in the manifest.
> >
> > Any idea?
>
> The commit that changes this is here:
>
>
> https://github.com/apache/netbeans/commit/1b96b56ac3bfda8bd9b97f36c25901e84289cb23
>
> And is part of this:
>
> https://github.com/apache/netbeans/pull/2761
>
> The TL;DR version is (if I remember correctly): the JAR File
> Specification says, that the Class-Path attribute is a list of URLs and
> since javac 11 this is actually enforced.
>
> Try this:
>
> new URI("%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar");
> new URI("${java.home}/lib/ext/jfxrt.jar");
>
> It blows for the second line.
>
> Hope that clears it up.
>
> Greetings
>
> Matthias
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Matthias Bläsing
Hi,

Am Donnerstag, dem 13.01.2022 um 17:54 + schrieb Jean-Marc Borer:
> When building my NB RCP application with Maven, I get:
> 
> Could not resolve Class-Path item in
> org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
> 
> I checked the manifest of module org-netbeans-libs-javafx.jar
> And actually I found:
> 
> OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
> 
> Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
> 
> I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> where jfxrt.jar exists... and JFX works in the application later. Just
> wondering why such warning is generated.
> 
> I suspect that the Maven checker is somehow not understanding properly this
> classpath entry in the manifest.
> 
> Any idea?

The commit that changes this is here:

https://github.com/apache/netbeans/commit/1b96b56ac3bfda8bd9b97f36c25901e84289cb23

And is part of this:

https://github.com/apache/netbeans/pull/2761

The TL;DR version is (if I remember correctly): the JAR File
Specification says, that the Class-Path attribute is a list of URLs and
since javac 11 this is actually enforced.

Try this:

new URI("%24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar");
new URI("${java.home}/lib/ext/jfxrt.jar");

It blows for the second line.

Hope that clears it up.

Greetings

Matthias


-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Jean-Marc Borer
OK so I have the 12.1 sources and when building with JDK 8 the NBM gets
generated and the manifest is:

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.10.7
Created-By: 1.8.0_302-b08 (Azul Systems, Inc.)
OpenIDE-Module-Public-Packages: javafx.animation.*, javafx.application
 .*, javafx.beans.*, javafx.beans.binding.*, javafx.beans.property.*,
 javafx.beans.property.adapter.*, javafx.beans.value.*, javafx.collect
 ions.*, javafx.concurrent.*, javafx.css.*, javafx.embed.swing.*, java
 fx.event.*, javafx.fxml.*, javafx.geometry.*, javafx.scene.*, javafx.
 scene.canvas.*, javafx.scene.chart.*, javafx.scene.control.*, javafx.
 scene.control.cell.*, javafx.scene.effect.*, javafx.scene.image.*, ja
 vafx.scene.input.*, javafx.scene.layout.*, javafx.scene.media.*, java
 fx.scene.paint.*, javafx.scene.shape.*, javafx.scene.text.*, javafx.s
 cene.transform.*, javafx.scene.web.*, javafx.stage.*, javafx.util.*,
 javafx.util.converter.*, netscape.javascript.*, com.sun.javafx.scene.
 web.*
OpenIDE-Module-Module-Dependencies: org.openide.modules > 7.40, org.op
 enide.util.lookup > 8.23
OpenIDE-Module-Java-Dependencies: Java > 1.7
OpenIDE-Module-Implementation-Version: 12.1-dev-4527aef9ade73eaafe6af6
 809a684e1f7f8f1468
AutoUpdate-Show-In-Client: false
OpenIDE-Module: org.netbeans.libs.javafx
OpenIDE-Module-Package-Dependencies: javafx.application[Application]
OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/javafx/Bundle.prop
 erties
OpenIDE-Module-Specification-Version: 2.16
OpenIDE-Module-Needs: org.openide.modules.jre.JavaFX
OpenIDE-Module-Provides: javafx.animation,   javafx.application,   jav
 afx.beans,   javafx.beans.binding,   javafx.beans.property,   javafx.
 beans.property.adapter,   javafx.beans.value,   javafx.collections,
  javafx.collections.transformation,   javafx.concurrent,   javafx.css
 ,   javafx.embed.swing,   javafx.event,   javafx.fxml,   javafx.geome
 try,   javafx.scene,   javafx.scene.canvas,   javafx.scene.chart,   j
 avafx.scene.control,   javafx.scene.control.cell,   javafx.scene.effe
 ct,   javafx.scene.image,   javafx.scene.input,   javafx.scene.layout
 ,   javafx.scene.media,   javafx.scene.paint,   javafx.scene.shape,
  javafx.scene.text,   javafx.scene.transform,   javafx.scene.web,   j
 avafx.stage,   javafx.util,   javafx.util.converter,   netscape.javas
 cript
OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
*Class-Path: ${java.home}/lib/ext/jfxrt.jar*

This time no escaping!

On Thu, Jan 13, 2022 at 6:23 PM Jean-Marc Borer  wrote:

> I suppose it should resolve to the JRE lib, but as such, Maven classpath
> checker doesn't understand the encoded version. I am currently trying to
> reproduce by building NB from the sources and generating the NMBs.
>
> On Thu, Jan 13, 2022 at 6:10 PM Geertjan Wielenga
>  wrote:
>
>> So what does {java.home} resolve to?
>>
>> Gj
>>
>> On Thu, Jan 13, 2022 at 7:08 PM Jean-Marc Borer 
>> wrote:
>>
>> > Sure. You can send me a private message.
>> >
>> > Back to the topic: I checked the sources and indeed the source Manifest
>> of
>> > this JavaFX lib wrapper module reads:
>> >
>> > Manifest-Version: 1.0
>> > OpenIDE-Module: org.netbeans.libs.javafx
>> > OpenIDE-Module-Package-Dependencies: javafx.application[Application]
>> > OpenIDE-Module-Localizing-Bundle:
>> > org/netbeans/libs/javafx/Bundle.properties
>> > OpenIDE-Module-Specification-Version: 2.16
>> > OpenIDE-Module-Needs: org.openide.modules.jre.JavaFX
>> > OpenIDE-Module-Provides: javafx.animation,
>> > javafx.application,
>> > javafx.beans,
>> > javafx.beans.binding,
>> > javafx.beans.property,
>> > javafx.beans.property.adapter,
>> > javafx.beans.value,
>> > javafx.collections,
>> > javafx.collections.transformation,
>> > javafx.concurrent,
>> > javafx.css,
>> > javafx.embed.swing,
>> > javafx.event,
>> > javafx.fxml,
>> > javafx.geometry,
>> > javafx.scene,
>> > javafx.scene.canvas,
>> > javafx.scene.chart,
>> > javafx.scene.control,
>> > javafx.scene.control.cell,
>> > javafx.scene.effect,
>> > javafx.scene.image,
>> > javafx.scene.input,
>> > javafx.scene.layout,
>> > javafx.scene.media,
>> > javafx.scene.paint,
>> > javafx.scene.shape,
>> > javafx.scene.text,
>> > javafx.scene.transform,
>> > javafx.scene.web,
>> > javafx.stage,
>> > javafx.util,
>> > javafx.util.converter,
>> > netscape.javascript
>> > Class-Path: ${java.home}/lib/ext/jfxrt.jar
>> >
>> > The URL encoding seems to happen somewhere in between...
>> >
>> >
>> > On Thu, Jan 13, 2022 at 5:56 PM Geertjan Wielenga
>> >  wrote:
>> >
>> > > Hmmm. That's strange.
>> > >
>> > > (And as an Azul employee, I'd like to share with you that we'd love to
>> > > promote your usage of Zulu. :-) )
>> > >
>> > > Gj
>> > >
>> > > On Thu, Jan 13, 2022 at 6:54 PM Jean-Marc Borer 
>> > wrote:
>> > >
>> > > > Hello,
>> > > >
>> > > > When building my NB RCP application with Maven, I get:
>> > > >
>> > > > Cou

Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Jean-Marc Borer
I suppose it should resolve to the JRE lib, but as such, Maven classpath
checker doesn't understand the encoded version. I am currently trying to
reproduce by building NB from the sources and generating the NMBs.

On Thu, Jan 13, 2022 at 6:10 PM Geertjan Wielenga
 wrote:

> So what does {java.home} resolve to?
>
> Gj
>
> On Thu, Jan 13, 2022 at 7:08 PM Jean-Marc Borer  wrote:
>
> > Sure. You can send me a private message.
> >
> > Back to the topic: I checked the sources and indeed the source Manifest
> of
> > this JavaFX lib wrapper module reads:
> >
> > Manifest-Version: 1.0
> > OpenIDE-Module: org.netbeans.libs.javafx
> > OpenIDE-Module-Package-Dependencies: javafx.application[Application]
> > OpenIDE-Module-Localizing-Bundle:
> > org/netbeans/libs/javafx/Bundle.properties
> > OpenIDE-Module-Specification-Version: 2.16
> > OpenIDE-Module-Needs: org.openide.modules.jre.JavaFX
> > OpenIDE-Module-Provides: javafx.animation,
> > javafx.application,
> > javafx.beans,
> > javafx.beans.binding,
> > javafx.beans.property,
> > javafx.beans.property.adapter,
> > javafx.beans.value,
> > javafx.collections,
> > javafx.collections.transformation,
> > javafx.concurrent,
> > javafx.css,
> > javafx.embed.swing,
> > javafx.event,
> > javafx.fxml,
> > javafx.geometry,
> > javafx.scene,
> > javafx.scene.canvas,
> > javafx.scene.chart,
> > javafx.scene.control,
> > javafx.scene.control.cell,
> > javafx.scene.effect,
> > javafx.scene.image,
> > javafx.scene.input,
> > javafx.scene.layout,
> > javafx.scene.media,
> > javafx.scene.paint,
> > javafx.scene.shape,
> > javafx.scene.text,
> > javafx.scene.transform,
> > javafx.scene.web,
> > javafx.stage,
> > javafx.util,
> > javafx.util.converter,
> > netscape.javascript
> > Class-Path: ${java.home}/lib/ext/jfxrt.jar
> >
> > The URL encoding seems to happen somewhere in between...
> >
> >
> > On Thu, Jan 13, 2022 at 5:56 PM Geertjan Wielenga
> >  wrote:
> >
> > > Hmmm. That's strange.
> > >
> > > (And as an Azul employee, I'd like to share with you that we'd love to
> > > promote your usage of Zulu. :-) )
> > >
> > > Gj
> > >
> > > On Thu, Jan 13, 2022 at 6:54 PM Jean-Marc Borer 
> > wrote:
> > >
> > > > Hello,
> > > >
> > > > When building my NB RCP application with Maven, I get:
> > > >
> > > > Could not resolve Class-Path item in
> > > > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> > > > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
> > > >
> > > > I checked the manifest of module org-netbeans-libs-javafx.jar
> > > > And actually I found:
> > > > 
> > > > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> > > > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
> > > >
> > > > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
> > > >
> > > > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> > > > where jfxrt.jar exists... and JFX works in the application later.
> Just
> > > > wondering why such warning is generated.
> > > >
> > > > I suspect that the Maven checker is somehow not understanding
> properly
> > > this
> > > > classpath entry in the manifest.
> > > >
> > > > Any idea?
> > > >
> > > > Cheers,
> > > >
> > > > JMB
> > > >
> > >
> >
>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Geertjan Wielenga
So what does {java.home} resolve to?

Gj

On Thu, Jan 13, 2022 at 7:08 PM Jean-Marc Borer  wrote:

> Sure. You can send me a private message.
>
> Back to the topic: I checked the sources and indeed the source Manifest of
> this JavaFX lib wrapper module reads:
>
> Manifest-Version: 1.0
> OpenIDE-Module: org.netbeans.libs.javafx
> OpenIDE-Module-Package-Dependencies: javafx.application[Application]
> OpenIDE-Module-Localizing-Bundle:
> org/netbeans/libs/javafx/Bundle.properties
> OpenIDE-Module-Specification-Version: 2.16
> OpenIDE-Module-Needs: org.openide.modules.jre.JavaFX
> OpenIDE-Module-Provides: javafx.animation,
> javafx.application,
> javafx.beans,
> javafx.beans.binding,
> javafx.beans.property,
> javafx.beans.property.adapter,
> javafx.beans.value,
> javafx.collections,
> javafx.collections.transformation,
> javafx.concurrent,
> javafx.css,
> javafx.embed.swing,
> javafx.event,
> javafx.fxml,
> javafx.geometry,
> javafx.scene,
> javafx.scene.canvas,
> javafx.scene.chart,
> javafx.scene.control,
> javafx.scene.control.cell,
> javafx.scene.effect,
> javafx.scene.image,
> javafx.scene.input,
> javafx.scene.layout,
> javafx.scene.media,
> javafx.scene.paint,
> javafx.scene.shape,
> javafx.scene.text,
> javafx.scene.transform,
> javafx.scene.web,
> javafx.stage,
> javafx.util,
> javafx.util.converter,
> netscape.javascript
> Class-Path: ${java.home}/lib/ext/jfxrt.jar
>
> The URL encoding seems to happen somewhere in between...
>
>
> On Thu, Jan 13, 2022 at 5:56 PM Geertjan Wielenga
>  wrote:
>
> > Hmmm. That's strange.
> >
> > (And as an Azul employee, I'd like to share with you that we'd love to
> > promote your usage of Zulu. :-) )
> >
> > Gj
> >
> > On Thu, Jan 13, 2022 at 6:54 PM Jean-Marc Borer 
> wrote:
> >
> > > Hello,
> > >
> > > When building my NB RCP application with Maven, I get:
> > >
> > > Could not resolve Class-Path item in
> > > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> > > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
> > >
> > > I checked the manifest of module org-netbeans-libs-javafx.jar
> > > And actually I found:
> > > 
> > > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> > > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
> > >
> > > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
> > >
> > > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> > > where jfxrt.jar exists... and JFX works in the application later. Just
> > > wondering why such warning is generated.
> > >
> > > I suspect that the Maven checker is somehow not understanding properly
> > this
> > > classpath entry in the manifest.
> > >
> > > Any idea?
> > >
> > > Cheers,
> > >
> > > JMB
> > >
> >
>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Jean-Marc Borer
Sure. You can send me a private message.

Back to the topic: I checked the sources and indeed the source Manifest of
this JavaFX lib wrapper module reads:

Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.libs.javafx
OpenIDE-Module-Package-Dependencies: javafx.application[Application]
OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/javafx/Bundle.properties
OpenIDE-Module-Specification-Version: 2.16
OpenIDE-Module-Needs: org.openide.modules.jre.JavaFX
OpenIDE-Module-Provides: javafx.animation,
javafx.application,
javafx.beans,
javafx.beans.binding,
javafx.beans.property,
javafx.beans.property.adapter,
javafx.beans.value,
javafx.collections,
javafx.collections.transformation,
javafx.concurrent,
javafx.css,
javafx.embed.swing,
javafx.event,
javafx.fxml,
javafx.geometry,
javafx.scene,
javafx.scene.canvas,
javafx.scene.chart,
javafx.scene.control,
javafx.scene.control.cell,
javafx.scene.effect,
javafx.scene.image,
javafx.scene.input,
javafx.scene.layout,
javafx.scene.media,
javafx.scene.paint,
javafx.scene.shape,
javafx.scene.text,
javafx.scene.transform,
javafx.scene.web,
javafx.stage,
javafx.util,
javafx.util.converter,
netscape.javascript
Class-Path: ${java.home}/lib/ext/jfxrt.jar

The URL encoding seems to happen somewhere in between...


On Thu, Jan 13, 2022 at 5:56 PM Geertjan Wielenga
 wrote:

> Hmmm. That's strange.
>
> (And as an Azul employee, I'd like to share with you that we'd love to
> promote your usage of Zulu. :-) )
>
> Gj
>
> On Thu, Jan 13, 2022 at 6:54 PM Jean-Marc Borer  wrote:
>
> > Hello,
> >
> > When building my NB RCP application with Maven, I get:
> >
> > Could not resolve Class-Path item in
> > org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> > is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
> >
> > I checked the manifest of module org-netbeans-libs-javafx.jar
> > And actually I found:
> > 
> > OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> > Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
> >
> > Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
> >
> > I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> > where jfxrt.jar exists... and JFX works in the application later. Just
> > wondering why such warning is generated.
> >
> > I suspect that the Maven checker is somehow not understanding properly
> this
> > classpath entry in the manifest.
> >
> > Any idea?
> >
> > Cheers,
> >
> > JMB
> >
>


Re: JavaFX classpath warning when building NB RCP with Maven

2022-01-13 Thread Geertjan Wielenga
Hmmm. That's strange.

(And as an Azul employee, I'd like to share with you that we'd love to
promote your usage of Zulu. :-) )

Gj

On Thu, Jan 13, 2022 at 6:54 PM Jean-Marc Borer  wrote:

> Hello,
>
> When building my NB RCP application with Maven, I get:
>
> Could not resolve Class-Path item in
> org.netbeans.api:org-netbeans-libs-javafx:nbm-file:RELEASE124, path
> is:%24%7Bjava.home%7D/lib/ext/jfxrt.jar, skipping
>
> I checked the manifest of module org-netbeans-libs-javafx.jar
> And actually I found:
> 
> OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1
> Class-Path: %24%7Bjava.home%7D/lib/ext/jfxrt.jar
>
> Which is an url encoded string of ${java.hom}/lib/ext/jfxrt.jar
>
> I build on zulu8.58.0.13-ca-fx-jdk8.0.312-win_x64\jre\lib\ext
> where jfxrt.jar exists... and JFX works in the application later. Just
> wondering why such warning is generated.
>
> I suspect that the Maven checker is somehow not understanding properly this
> classpath entry in the manifest.
>
> Any idea?
>
> Cheers,
>
> JMB
>