[GitHub] incubator-netbeans pull request #63: [NETBEANS-54] Module Review csl.api

2017-10-04 Thread junichi11
GitHub user junichi11 opened a pull request:

https://github.com/apache/incubator-netbeans/pull/63

[NETBEANS-54] Module Review csl.api

- no external library
- checked Rat report: update the license header in 
csl.api/src/org/netbeans/modules/csl/editor/semantic/Bundle.properties. ignore 
manifest.mf and *.txt
- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/junichi11/incubator-netbeans 
module-review-csl.api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit 7797f43412cb8463736ac495ed7a80193814a770
Author: Junichi Yamamoto 
Date:   2017-10-03T16:01:40Z

[NETBEANS-54] Module Review csl.api

- no external library
- checked Rat report: update the license header in 
csl.api/src/org/netbeans/modules/csl/editor/semantic/Bundle.properties. ignore 
manifest.mf and *.txt
- skimmed through the module, did not notice additional problems




---


[GitHub] incubator-netbeans pull request #61: Repair build failure due to binary hash...

2017-10-04 Thread ikysil
Github user ikysil closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/61


---


Re: New pattern for license converter tool

2017-10-04 Thread Jan Lahoda
FWIW, I've changed the tool to accept license headers in the second comment
in the file, and changed the limit where the comment must start to 300.
This seems to cover about 63 additional files.

For the examples-readme.txt, the comment/header detection in such files is
tricky. I think the reason is that the second line in the file does not
start with the comment character ('#'), so the detection fails.

Jan

On Wed, Oct 4, 2017 at 2:49 PM, Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:

> Great!
>
> Another similar one is in api.visual/examples-readme.txt.
>
> Gj
>
> On Wed, Oct 4, 2017 at 5:36 AM, Jan Lahoda  wrote:
>
> > I think there are two problem with these files:
> > -the tool only looks for the first comment, and the headers in these
> files
> > are in the second comment, so the tool won't find it.
> > -the tool only looks for comments that begin in the first 100 characters
> > from the beginning (a safety feature, as a few files contain texts of the
> > license headers as patterns)
> >
> > I'll look at those.
> >
> > Jan
> >
> >
> > On Wed, Oct 4, 2017 at 2:31 PM, Geertjan Wielenga <
> > geertjan.wiele...@googlemail.com> wrote:
> >
> > > Hi all,
> > >
> > > Yesterday at JavaOne, some of us got together to work on the Modules
> > Review
> > > and found a new pattern that needs to be handled in the converter tool.
> > >
> > > The pattern can be found in several hundred files, so we can clean
> these
> > > all up at the same time by twesking the tool for this.
> > >
> > > Here are three places where this pattern is found:
> > >
> > >
> > >- api.progress.nb/apichanges.xml
> > >- api.progress/apichanges.xml
> > >- api.progress.nb/apichanges.xml
> > >
> > >
> > > Except, we haven't been able to figure out yet how the pattern (it is a
> > > variation on the standard Oracle license) is different and why it
> hasn't
> > > been handled by the tool yet.
> > >
> > > Could Jan or someone interested in this question else take a look?
> > >
> > > Geertjan
> > >
> >
>


[GitHub] incubator-netbeans pull request #62: [NETBEANS-54] Module Review hibernate

2017-10-04 Thread ikysil
GitHub user ikysil opened a pull request:

https://github.com/apache/incubator-netbeans/pull/62

[NETBEANS-54] Module Review hibernate

- external binary contains DTDs for Hibernate 3.0 configuration files
- changed license headers for files reported by Rat
- replacing the bundled binary is tracked by 
https://issues.apache.org/jira/browse/NETBEANS-79

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ikysil/incubator-netbeans 
netbeans-54-review-hibernate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit 5f5ba9225902f8c38a09f14001af5d412f5c0f64
Author: Illya Kysil 
Date:   2017-10-04T19:48:37Z

[NETBEANS-54] Module Review hibernate

- changed license headers for files reported by Rat




---


[GitHub] incubator-netbeans pull request #49: [NETBEANS-54] Add license header to bin...

2017-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/49


---


Re: Permissions to edit List of Modules to Review

2017-10-04 Thread Geertjan Wielenga
Done.

Gj

On Wed, Oct 4, 2017 at 11:19 AM, Illya Kysil  wrote:

> Hi,
>
> Could you please add permissions to edit List of Modules to Review for user
> ikysil.
> https://cwiki.apache.org/confluence/display/NETBEANS/
> List+of+Modules+to+Review
>
> Thank you in advance
> --
> Illya Kysil
> --
> For a successful technology, reality must take precedence
> over public relations, for Nature cannot be fooled.
> Richard P. Feynman
>


[GitHub] incubator-netbeans pull request #16: [NETBEANS-54] Module Review db.dataview

2017-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/16


---


Permissions to edit List of Modules to Review

2017-10-04 Thread Illya Kysil
Hi,

Could you please add permissions to edit List of Modules to Review for user
ikysil.
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review

Thank you in advance
-- 
Illya Kysil
--
For a successful technology, reality must take precedence
over public relations, for Nature cannot be fooled.
Richard P. Feynman


[GitHub] incubator-netbeans pull request #24: [NETBEANS-54] Module Review db.sql.visu...

2017-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/24


---


[GitHub] incubator-netbeans pull request #50: [NETBEANS-54] Module review diff

2017-10-04 Thread matthiasblaesing
Github user matthiasblaesing closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/50


---


[GitHub] incubator-netbeans issue #56: [NETBEANS-54] Module Review editor.errorstripe

2017-10-04 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/56
  
Looks good.


---


[GitHub] incubator-netbeans issue #57: [NETBEANS-54] Module Review parsing.api

2017-10-04 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/57
  
Looks good.


---


[GitHub] incubator-netbeans issue #58: [NETBEANS-54] Module Review parsing.nb

2017-10-04 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/58
  
Looks good.


---


[GitHub] incubator-netbeans issue #60: [NETBEANS-54] Module Review spellchecker

2017-10-04 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/60
  
Looks good.


---


[GitHub] incubator-netbeans issue #61: Repair build failure due to binary hash not ma...

2017-10-04 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/61
  
This was already fixed by @jlahoda in 
743564d016ca29ee65bc96a631b0ef72d762ad34


---


[GitHub] incubator-netbeans pull request #61: Repair build failure due to binary hash...

2017-10-04 Thread ikysil
GitHub user ikysil opened a pull request:

https://github.com/apache/incubator-netbeans/pull/61

Repair build failure due to binary hash not matching the updated coor…

…dinates.

[downloadbinaries] Downloading: 
http://central.maven.org/maven2/com/jcraft/jsch/0.1.54/jsch-0.1.54.jar

BUILD FAILED
incubator-netbeans/nbbuild/build.xml:1094: Download of 
http://central.maven.org/maven2/com/jcraft/jsch/0.1.54/jsch-0.1.54.jar
produced content with hash DA3584329A263616E277E15462B387ADDD1B208D when 
0D7D8ABA0D11E8CD2F775F47CD3A6CFBF2837DA4 was expected

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ikysil/incubator-netbeans 
build-fails-due-to-incorrect-binary-hash

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #61


commit 852b33738287ade73557b90dd7b32cc35c1c99b0
Author: Illya Kysil 
Date:   2017-10-04T18:02:42Z

Repair build failure due to binary hash not matching the updated 
coordinates.

[downloadbinaries] Downloading: 
http://central.maven.org/maven2/com/jcraft/jsch/0.1.54/jsch-0.1.54.jar

BUILD FAILED
incubator-netbeans/nbbuild/build.xml:1094: Download of 
http://central.maven.org/maven2/com/jcraft/jsch/0.1.54/jsch-0.1.54.jar
produced content with hash DA3584329A263616E277E15462B387ADDD1B208D when 
0D7D8ABA0D11E8CD2F775F47CD3A6CFBF2837DA4 was expected




---


[GitHub] incubator-netbeans pull request #60: [NETBEANS-54] Module Review spellchecke...

2017-10-04 Thread emilianbold
GitHub user emilianbold opened a pull request:

https://github.com/apache/incubator-netbeans/pull/60

[NETBEANS-54] Module Review spellchecker



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/emilianbold/incubator-netbeans 
emi-review-spellchecker

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60






---


[GitHub] incubator-netbeans pull request #58: [NETBEANS-54] Module Review parsing.nb

2017-10-04 Thread emilianbold
GitHub user emilianbold opened a pull request:

https://github.com/apache/incubator-netbeans/pull/58

[NETBEANS-54] Module Review parsing.nb



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/emilianbold/incubator-netbeans 
emi-review-parsing.nb

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit c02b9bf06c09175101ea8385eb2dfdd2c30a4dcc
Author: Emilian Bold 
Date:   2017-10-04T14:36:52Z

[NETBEANS-54] Module Review parsing.nb




---


[GitHub] incubator-netbeans pull request #57: [NETBEANS-54] Module Review parsing.api

2017-10-04 Thread emilianbold
GitHub user emilianbold opened a pull request:

https://github.com/apache/incubator-netbeans/pull/57

[NETBEANS-54] Module Review parsing.api

  - No external binaries.
  - Updated licenses in arch.xml
  - No additional problems found.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/emilianbold/incubator-netbeans 
emi-review-parsing.api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit e2c63ff9476dd977647dc87dd3a84777816503b9
Author: Emilian Bold 
Date:   2017-10-04T14:29:46Z

[NETBEANS-54] Module Review parsing.api
  - No external binaries.
  - Updated licenses in arch.xml
  - No additional problems found.




---


Re: New pattern for license converter tool

2017-10-04 Thread Geertjan Wielenga
Great!

Another similar one is in api.visual/examples-readme.txt.

Gj

On Wed, Oct 4, 2017 at 5:36 AM, Jan Lahoda  wrote:

> I think there are two problem with these files:
> -the tool only looks for the first comment, and the headers in these files
> are in the second comment, so the tool won't find it.
> -the tool only looks for comments that begin in the first 100 characters
> from the beginning (a safety feature, as a few files contain texts of the
> license headers as patterns)
>
> I'll look at those.
>
> Jan
>
>
> On Wed, Oct 4, 2017 at 2:31 PM, Geertjan Wielenga <
> geertjan.wiele...@googlemail.com> wrote:
>
> > Hi all,
> >
> > Yesterday at JavaOne, some of us got together to work on the Modules
> Review
> > and found a new pattern that needs to be handled in the converter tool.
> >
> > The pattern can be found in several hundred files, so we can clean these
> > all up at the same time by twesking the tool for this.
> >
> > Here are three places where this pattern is found:
> >
> >
> >- api.progress.nb/apichanges.xml
> >- api.progress/apichanges.xml
> >- api.progress.nb/apichanges.xml
> >
> >
> > Except, we haven't been able to figure out yet how the pattern (it is a
> > variation on the standard Oracle license) is different and why it hasn't
> > been handled by the tool yet.
> >
> > Could Jan or someone interested in this question else take a look?
> >
> > Geertjan
> >
>


Re: New pattern for license converter tool

2017-10-04 Thread Jan Lahoda
I think there are two problem with these files:
-the tool only looks for the first comment, and the headers in these files
are in the second comment, so the tool won't find it.
-the tool only looks for comments that begin in the first 100 characters
from the beginning (a safety feature, as a few files contain texts of the
license headers as patterns)

I'll look at those.

Jan


On Wed, Oct 4, 2017 at 2:31 PM, Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:

> Hi all,
>
> Yesterday at JavaOne, some of us got together to work on the Modules Review
> and found a new pattern that needs to be handled in the converter tool.
>
> The pattern can be found in several hundred files, so we can clean these
> all up at the same time by twesking the tool for this.
>
> Here are three places where this pattern is found:
>
>
>- api.progress.nb/apichanges.xml
>- api.progress/apichanges.xml
>- api.progress.nb/apichanges.xml
>
>
> Except, we haven't been able to figure out yet how the pattern (it is a
> variation on the standard Oracle license) is different and why it hasn't
> been handled by the tool yet.
>
> Could Jan or someone interested in this question else take a look?
>
> Geertjan
>


New pattern for license converter tool

2017-10-04 Thread Geertjan Wielenga
Hi all,

Yesterday at JavaOne, some of us got together to work on the Modules Review
and found a new pattern that needs to be handled in the converter tool.

The pattern can be found in several hundred files, so we can clean these
all up at the same time by twesking the tool for this.

Here are three places where this pattern is found:


   - api.progress.nb/apichanges.xml
   - api.progress/apichanges.xml
   - api.progress.nb/apichanges.xml


Except, we haven't been able to figure out yet how the pattern (it is a
variation on the standard Oracle license) is different and why it hasn't
been handled by the tool yet.

Could Jan or someone interested in this question else take a look?

Geertjan


[GitHub] incubator-netbeans pull request #44: Testcases related fixes

2017-10-04 Thread rtaneja1
Github user rtaneja1 commented on a diff in the pull request:

https://github.com/apache/incubator-netbeans/pull/44#discussion_r142642889
  
--- Diff: 
autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java
 ---
@@ -50,7 +49,7 @@ protected void tearDown () throws  Exception {
 public void testCreate () throws Exception {
 String name = "new-one";
 String displayName = "Newone";
-URL url = UpdateUnitFactoryTest.class.getResource 
("data/catalog.xml");
+URL url = getClass().getResource 
("/org/netbeans/modules/autoupdate/updateprovider/data/catalog.xml");
--- End diff --

Using the one from 
https://github.com/apache/incubator-netbeans/tree/master/autoupdate.services/test/unit/src/org/netbeans/modules/autoupdate/updateprovider/data


---


Podling Report Reminder - October 2017

2017-10-04 Thread johndament
Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 18 October 2017, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, October 04).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.
*   How does the podling rate their own maturity.

This should be appended to the Incubator Wiki page at:

https://wiki.apache.org/incubator/October2017

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC


[GitHub] incubator-netbeans pull request #44: Testcases related fixes

2017-10-04 Thread rtaneja1
Github user rtaneja1 commented on a diff in the pull request:

https://github.com/apache/incubator-netbeans/pull/44#discussion_r142635629
  
--- Diff: 
autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java
 ---
@@ -50,7 +49,7 @@ protected void tearDown () throws  Exception {
 public void testCreate () throws Exception {
 String name = "new-one";
 String displayName = "Newone";
-URL url = UpdateUnitFactoryTest.class.getResource 
("data/catalog.xml");
+URL url = getClass().getResource 
("/org/netbeans/modules/autoupdate/updateprovider/data/catalog.xml");
--- End diff --

no data/catalog.xml in above location


---


[GitHub] incubator-netbeans pull request #44: Testcases related fixes

2017-10-04 Thread rtaneja1
Github user rtaneja1 commented on a diff in the pull request:

https://github.com/apache/incubator-netbeans/pull/44#discussion_r142635505
  
--- Diff: 
autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java
 ---
@@ -50,7 +49,7 @@ protected void tearDown () throws  Exception {
 public void testCreate () throws Exception {
 String name = "new-one";
 String displayName = "Newone";
-URL url = UpdateUnitFactoryTest.class.getResource 
("data/catalog.xml");
+URL url = getClass().getResource 
("/org/netbeans/modules/autoupdate/updateprovider/data/catalog.xml");
--- End diff --

There's no catalog.xml here : 
https://github.com/apache/incubator-netbeans/tree/master/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate


---


[GitHub] incubator-netbeans pull request #44: Testcases related fixes

2017-10-04 Thread emilianbold
Github user emilianbold commented on a diff in the pull request:

https://github.com/apache/incubator-netbeans/pull/44#discussion_r142631994
  
--- Diff: 
autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java
 ---
@@ -50,7 +49,7 @@ protected void tearDown () throws  Exception {
 public void testCreate () throws Exception {
 String name = "new-one";
 String displayName = "Newone";
-URL url = UpdateUnitFactoryTest.class.getResource 
("data/catalog.xml");
+URL url = getClass().getResource 
("/org/netbeans/modules/autoupdate/updateprovider/data/catalog.xml");
--- End diff --

Doesn't the relative path data/catalog.xml work anymore?


---


[GitHub] incubator-netbeans pull request #44: Testcases related fixes

2017-10-04 Thread rtaneja1
Github user rtaneja1 commented on a diff in the pull request:

https://github.com/apache/incubator-netbeans/pull/44#discussion_r142630474
  
--- Diff: 
autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java
 ---
@@ -50,7 +50,7 @@ protected void tearDown () throws  Exception {
 public void testCreate () throws Exception {
 String name = "new-one";
 String displayName = "Newone";
-URL url = UpdateUnitFactoryTest.class.getResource 
("data/catalog.xml");
+URL url = CatalogCacheTest.class.getResource ("data/catalog.xml");
--- End diff --

Fixed


---


[GitHub] incubator-netbeans pull request #56: [NETBEANS-54] Module Review editor.erro...

2017-10-04 Thread vieiro
GitHub user vieiro opened a pull request:

https://github.com/apache/incubator-netbeans/pull/56

[NETBEANS-54] Module Review editor.errorstripe

  - No external binaries.
  - Updated licenses in two layer.xml files.
  - Two unit tests failed: 
org.netbeans.modules.editor.errorstripe.AnnotationViewDataImplTest 
org.netbeans.modules.editor.errorstripe.AnnotationViewTest
  - No additional problems found.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-editor.errorstripe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #56


commit 9a76df3c614a3542d504e02a38fb7cef344f7f45
Author: Antonio Vieiro 
Date:   2017-10-04T09:18:59Z

[NETBEANS-54] Module Review editor.errorstripe

  - No external binaries.
  - Updated licenses in two layer.xml files.
  - Two unit tests failed: 
org.netbeans.modules.editor.errorstripe.AnnotationViewDataImplTest 
org.netbeans.modules.editor.errorstripe.AnnotationViewTest
  - No additional problems found.




---


[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

2017-10-04 Thread jlahoda
Github user jlahoda commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
I agree the hash is useful (among other things) to verify that the jar from 
the central is the same.

But it is unfortunately not the same in this case. Seems the jar on 
hg/binaries is the same as a download from the JSch web page, and the jar on 
maven central is different. My wild guess is that these have been produced by 
different build processes and different JDKs.


---


[GitHub] incubator-netbeans pull request #55: [NETBEANS-54] Module Review editor.comp...

2017-10-04 Thread vieiro
GitHub user vieiro opened a pull request:

https://github.com/apache/incubator-netbeans/pull/55

[NETBEANS-54] Module Review editor.completion

  - No external libraries.
  - Updated licenses in apichanges.xml and a Bundle.properties file as per 
rat report.
  - Tests passing. No additional problems found.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-editor.completion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit f300576ecf8f5f2ab99b44c56ca3f088bab8dee1
Author: Antonio Vieiro 
Date:   2017-10-04T07:52:49Z

[NETBEANS-54] Module Review editor.completion

  - No external libraries.
  - Updated licenses in apichanges.xml and a Bundle.properties file as per 
rat report.
  - Tests passing. No additional problems found.




---


[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

2017-10-04 Thread emilianbold
Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
You know, I was just thinking how super useful it is to have the hash when 
switching to Maven Central since at least you know it's the same JAR.

How could they differ for the same library?


---


[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

2017-10-04 Thread junichi11
Github user junichi11 commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
@jlahoda I'm sorry... Would you please do that?


---


[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

2017-10-04 Thread jlahoda
Github user jlahoda commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
Please note that this changes fail the build, because the jar from maven 
central has a different hash. The hash on the central is:
DA3584329A263616E277E15462B387ADDD1B208D

I skimmed through the differences, and so far it seems to me it is OK to 
use the jar from central (we presumably would eventually learn if there would 
be issues anyway).  I can do that tonight, unless someone will do that before.


---