[GitHub] incubator-netbeans pull request #24: [NETBEANS-54] Module Review db.sql.visu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/24


---

[GitHub] incubator-netbeans pull request #24: [NETBEANS-54] Module Review db.sql.visu...

[matthiasblaesing]

GitHub user matthiasblaesing opened a pull request:

https://github.com/apache/incubator-netbeans/pull/24

[NETBEANS-54] Module Review db.sql.visualeditor

- external library javacc is only used at build time and is not
  distributed with netbeans

- modified binaries-list to point to maven coordinates

- checked Rat report; missing headers added, ignored *.form 
  (see central problems)

- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matthiasblaesing/incubator-netbeans 
db.sql.visualeditor-review

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 6e470a8ef57af875989dac5a02e125536c203f34
Author: Matthias Bläsing 
Date:   2017-09-29T20:57:42Z

[NETBEANS-54] Module Review db.sql.visualeditor

- external library javacc is only used at build time and is not
  distributed with netbeans

- modified binaries-list to point to maven coordinates

- checked Rat report; missing headers added, ignored *.form 
  (see central problems)

- skimmed through the module, did not notice additional problems




---