Re: add "-notice.txt" if needed with any required notices?

[Jan Lahoda]

On Tue, Oct 17, 2017 at 10:06 PM, Antonio Vieiro  wrote:

>
> > El 17 oct 2017, a las 21:42, Jan Lahoda  escribió:
> >
> > Hi Antonio,
> >
> > On Sun, Oct 8, 2017 at 12:36 PM, Antonio Vieiro 
> wrote:
> >
> >> I understand, thanks for the info.
> >>
> >> I think that once we have maven group/artifact/version coordinates for
> >> each of the files in binaries_list we could try to automatically
> generate
> >> notice files (as in [1]).
> >>
> >> I’ll take a look at how this can be automated.
> >>
> >
> > Did you have a chance to look at this? I think it would be good to start
> > looking at producing the appropriate LICENSE/NOTICE(/DEPENDENCIES) files
> > for distributions we do, should I look at that, or is that part of what
> you
> > want to look at?
> >
>
> Hi Jan,
>
> This is a bad week for me (helping out a customer with a big mess) so I
> won’t be able to look at this at all. Your lead here would be most
> appreciated.
>

Ok. I am peeking at this. Unless there are objections or better ideas, I'll
create a new branch for this over the next few days, and a (platform) build
to produce the zips, so that the content of all the files can be checked.

Jan


> As time permits I’d like to tackle the generation of binaries for those
> modules that have patches to third party source code, and that cannot be
> then downloaded from Maven.
>
> Un abrazo,
> Antonio
>
>
>
>

Re: add "-notice.txt" if needed with any required notices?

[Antonio Vieiro]

> El 17 oct 2017, a las 21:42, Jan Lahoda  escribió:
> 
> Hi Antonio,
> 
> On Sun, Oct 8, 2017 at 12:36 PM, Antonio Vieiro  wrote:
> 
>> I understand, thanks for the info.
>> 
>> I think that once we have maven group/artifact/version coordinates for
>> each of the files in binaries_list we could try to automatically generate
>> notice files (as in [1]).
>> 
>> I’ll take a look at how this can be automated.
>> 
> 
> Did you have a chance to look at this? I think it would be good to start
> looking at producing the appropriate LICENSE/NOTICE(/DEPENDENCIES) files
> for distributions we do, should I look at that, or is that part of what you
> want to look at?
> 

Hi Jan,

This is a bad week for me (helping out a customer with a big mess) so I won’t 
be able to look at this at all. Your lead here would be most appreciated.

As time permits I’d like to tackle the generation of binaries for those modules 
that have patches to third party source code, and that cannot be then 
downloaded from Maven.

Un abrazo,
Antonio

Re: add "-notice.txt" if needed with any required notices?

[Jan Lahoda]

Hi Antonio,

(my) intent here was to include the -notice.txt file if the given library
would need an entry in the NOTICE file. The build then would (although it
does not right now) merge the -notice.txt files into the NOTICE file for
the given distribution. Source distributions would not have them merged, as
they don't directly contain the dependencies, but binary distributions that
contain the library would have the -notice.txt added into the NOTICE file.

The description when the NOTICE for a library is required is here:
http://www.apache.org/dev/licensing-howto.html

On Sun, Oct 8, 2017 at 7:36 AM, Antonio <anto...@vieiro.net> wrote:

> Hi all,
>
> From the list of modules to review I see:
>
> add "-notice.txt" if needed with any required notices
>
> a) What does "if needed" exactly mean? When is a notice file required?
> b) From [1],
> ==  DO NOT EDIT THIS FILE DIRECTLY. IT IS GENERATED
> == BY THE buildnotice TARGET IN THE TOP LEVEL build.xml FILE.
>But "buildnotice" is not in NetBeans build.xml.
>

I believe this notice is copied from the derby library (where they
apparently are generating automatically similarly to the above plan).


>
> So, do we have to add a "-notice.txt" file? When? Or is is automatically
> generated somehow?
>

If the (external) library requires an entry in NOTICE per the policy above,
then it should have a -notice.txt, and the build will (hopefully at some
point) merge it into a master NOTICE as needed.

Jan


>
> Thanks,
> Antonio
>
>
> [1] https://github.com/apache/incubator-netbeans/blob/master/db/
> external/derby-10.2.2.0-notice.txt
>

add "-notice.txt" if needed with any required notices?

[Antonio]

Hi all,

From the list of modules to review I see:

add "-notice.txt" if needed with any required notices

a) What does "if needed" exactly mean? When is a notice file required?
b) From [1],
==  DO NOT EDIT THIS FILE DIRECTLY. IT IS GENERATED
== BY THE buildnotice TARGET IN THE TOP LEVEL build.xml FILE.
   But "buildnotice" is not in NetBeans build.xml.

So, do we have to add a "-notice.txt" file? When? Or is is automatically 
generated somehow?


Thanks,
Antonio


[1] 
https://github.com/apache/incubator-netbeans/blob/master/db/external/derby-10.2.2.0-notice.txt