[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-14 Thread olegz
Github user olegz commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-171660747
  
@markap14 @joewitt Guys, please review. As agreed I've put read lock back 
in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-14 Thread joewitt
Github user joewitt commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-171664124
  
thanks oleg.  i won't be able to help today most likely . Hopefully 
payne-monster or someone else can.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-14 Thread trkurc
Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-171665816
  
@olegz  - I'll dig my old notes out and try to verify that a read-lock 
won't continue to cause a deadlock. I will likely have some time later this 
evening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NiFi-1356

2016-01-14 Thread jdye64
Github user jdye64 commented on the pull request:

https://github.com/apache/nifi/pull/158#issuecomment-171674914
  
Taking Joe's feedback I merged the two processors InferAvroSchemaFromCSV 
and InferAvroSchemaFromJSON into a single processor InferAvroSchema. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1376 Provide access to logged messages fro...

2016-01-14 Thread rpmiskin
Github user rpmiskin commented on the pull request:

https://github.com/apache/nifi/pull/165#issuecomment-171761193
  
@markap14 I chose to provide a Logger implementation to avoid having to 
make many changes to MockProcessorLog, especially as there are a number of 
methods that make two logger calls (e.g. line 162 and line 213).

Additionally it ensure that all messages would be made available to via 
TestRunner even if someone comes along and updates MockProcessorLog with 
additional methods.

@olegz Using the underlying output stream would work, but being able to  
assert on the objects being passed to the logger may be more helpful for the 
tests. There was also a post on the dev list this week about 
testShouldValidatePGPPublicKeyringExists failing due to a platform dependent 
toString(), that suggests that avoiding asserts based on toString() would be 
good. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: NiFi 0.4.1 InvokeHttp processor POST error issue

2016-01-14 Thread Joe Percivall
Hello Evan,

Glad to hear you're enjoying NiFi!

I was able to replicate your results so I dug in a bit and noticed in Wireshark 
that the "Transfer-Encoding" header for InvokeHttp was set to "chunked". When I 
tried using the same flag for curl it failed so I'm relatively confident that 
is the problem. Currently InvokeHttp requires using the chunk encoding for POST 
(primarily because you don't need to know the content-length and can stream the 
contents instead of loading into memory).

PostHttp does have a "Use Chunked Encoding" option which would solve your 
problem except that it doesn't work properly. PostHttp is using the 
"EntityTemplate" which streams the content so the content length will never be 
implemented and thus it will alway use the chunked encoding. I created a ticket 
for it [1].

 
Also as a note, when creating a template you have to either explicitly select 
the connections or not select anything and create a template for the whole 
canvas (your template didn't have any connections).

[1] https://issues.apache.org/jira/browse/NIFI-1396

Cheers,
Joe
- - - - - - 
Joseph Percivall
linkedin.com/in/Percivall
e: joeperciv...@yahoo.com



On Thursday, January 14, 2016 8:07 PM, "yuchen@thomsonreuters.com" 
 wrote:




Hi Guys,
 
Not sure if it is the correct way to raise issue by sending this email, if not, 
let me know where the post the issue, thanks.
 
We are using NiFi InvokeHttp processor to do POST to an webpage.
URL: 
http://www.hkexnews.hk/listedco/listconews/advancedsearch/search_active_main.aspx
Request header: Content-Type: application/x-www-form-urlencoded
POST Data: 
txt_stock_code=24984&sel_DateOfReleaseFrom_y=2016&sel_DateOfReleaseFrom_m=01&sel_DateOfReleaseFrom_d=04&sel_DateOfReleaseTo_y=2016&sel_DateOfReleaseTo_m=01&sel_DateOfReleaseTo_d=11&IsFromNewList=False&sel_tier_1=-2&sel_tier_2_group=-2&sel_tier_2=-2
 
To make sure the request header and request body are correct, we use Fiddler to 
compose the post request.
And the response show the request header and post data are correct.
 
 
Attached file is the template we are using, it is working fine on version 0.3.0
 
But not on the latest version 0.4.1
 
So we suppose it is potential defect of the InvokeHttp processor in this 
version. 
We checked the source code and try to locate the issue, and found it is using 
com.squareup.okhttp.Request; to do the request, so we are not go any further to 
dig the issue…
Currently we are using Curl to do the POST as a workaround.
 
Let me know your comments, thanks.
 
Finally, NiFi is a great tool!!! You guys are awesome!!!
 
Best Regards, 
Evan from Thomson Reuters