Re: [discuss] nifi 2.0 and Java 17...

[Dirk Arends]

Since initially raising concerns about the move to Java 17 losing Nashorn,
 I have been investigating the suggestion to use Nashorn as a standalone
package as potential easier alternative to GraalVM. [1]

While making some progress, a number of issues have been encountered which
I haven't been able to resolve as yet. More details are included in
relevant JIRA tickets, but summarising:

- Building NiFi with a recent Nashorn dependency leads to errors
"Unsupported class file major version 61" [2]
- Building NiFi using Java 17 highlights issues with the current Jetty
version, which I believe would require an upgrade from 9.4.51 to 11.0.15 [3]
- Jetty 11 then requires an upgrade of the Spring Framework version 5 to 6.
[4]

The current steps to remove references to "Javascript" as a preinstalled
scripting language [5] are understandable, but it does seem there is still
quite a bit to do before Nashorn or another external scripting engine could
be used.

[1] https://issues.apache.org/jira/browse/NIFI-11700: Java 17 Nashorn
standalone support
[2] https://issues.apache.org/jira/browse/NIFI-11701: Support building with
version 61 class files
[3] https://issues.apache.org/jira/browse/NIFI-11702: Upgrade Jetty to
version 11
[4] https://issues.apache.org/jira/browse/NIFI-11703: Upgrade Spring
Framework to version 6
[5] https://issues.apache.org/jira/browse/NIFI-11713: Remove Deprecated
ECMAScript Support

Regards,
Dirk Arends

Re: Jira contributor access

[Marton Szasz]

Added you as a contributor to NiFi on Jira. Looking forward to your
contribution!

Marton

On Tue, 20 Jun 2023 at 21:59, Julia DiAngelo  wrote:
>
> I'm a developer and wish to contribute to Apache NiFi. My username is
> jsand918

Jira contributor access

[Julia DiAngelo]

I'm a developer and wish to contribute to Apache NiFi. My username is
jsand918

Re: [discuss] nifi 2.0 and Java 17...

[Dan S]

With those changes, the Contributor Guide
, will
need to be updated specifically the 'Supported Versions' and the 'Minimum
Required Versions' sections.
In addition in the  Apache NiFi Development Quickstart
 in step 4 of the 'Build Steps'
the suggested settings will have to change as 'MaxPermSize' has been
deprecated in Java 17 and if it is included it will not let the build go
further. The error received is: "Unrecognized VM option
'MaxPermSize=>whatever you have this set at>'"

On Mon, Jun 19, 2023 at 11:56 AM David Handermann <
exceptionfact...@apache.org> wrote:

> Team,
>
> With the merge of PR 7397 [1] for NIFI-11717 [2], Java 17.0.6 is the
> minimum required version for building the main branch.
>
> There are still several remaining deprecated features that need to be
> removed for NiFi 2.0, and there are still areas of the system that need to
> be reviewed for additional cleanup. The Deprecated Components and Features
> page [3] lists the progress thus far.
>
> There is still opportunity to introduce new features and improvements in
> parallel with the technical debt reduction focus, and this could include
> evaluating a better strategy for supporting additional scripting engines.
>
> We should review the status of things after addressing some of the larger
> outstanding deprecation removals.
>
> Regards,
> David Handermann
>
> [1] https://github.com/apache/nifi/pull/7397
> [2] https://issues.apache.org/jira/browse/NIFI-11717
> [3]
>
> https://cwiki.apache.org/confluence/display/NIFI/Deprecated+Components+and+Features
>
> On Wed, Jun 7, 2023 at 10:34 PM Ryan Hendrickson <
> ryan.andrew.hendrick...@gmail.com> wrote:
>
> > The major issue for our deployments would be the removal of Nashorn as
> > well.
> >
> > Would GraalVM or an alternative be considered as a part of an initial
> NiFi
> > 2.0 release?
> >
> > Thanks,
> > Ryan
> >
> > On Mon, Jun 5, 2023 at 12:38 PM Joe Witt  wrote:
> >
> > > Team,
> > >
> > > Looking like we will update the NiFi 2.0 goals to be based on Java 17
> > > instead of 11.
> > >
> > > The noted concern around Java removing Nashorn in 11/17 we will need to
> > > identify an alternative plan for regardless and seems like David's
> > proposal
> > > would do the trick.
> > >
> > > Let's give this thread a few more days and if still seems consensus is
> > > present lets just assume lazy consensus and update the NiFi 2.0 goals
> and
> > > make it happen.
> > >
> > > Thanks
> > >
> > > On Fri, Jun 2, 2023 at 8:46 AM David Handermann <
> > > exceptionfact...@apache.org>
> > > wrote:
> > >
> > > > I agree that moving forward with Java 17 as the minimum for NiFi 2.0
> is
> > > the
> > > > best approach given the extended lifecycle of support for Java 17.
> > > >
> > > > With the removal of a number of legacy components, the current main
> > > branch
> > > > is in a much better position to make Java 17 the minimum.
> > > >
> > > > The deprecation and removal of Nashorn from the JDK is worth
> > > highlighting,
> > > > but it should not be a blocker for moving to Java 17. In this case,
> > NiFi
> > > is
> > > > reflecting the deprecation of Nashorn that already exists in Java
> 11. I
> > > > have submitted a PR for NIFI-11630 to mark ECMAScript as deprecated
> for
> > > the
> > > > support branch in subsequent version 1 releases.
> > > >
> > > > With that background, there is ongoing maintenance of the Nashorn
> > engine
> > > as
> > > > an external library, in addition to the GraalVM solution. However,
> this
> > > is
> > > > a good opportunity to take a different approach to scripting engine
> > > > integration. For maintenance and security purposes, it would be much
> > > better
> > > > to reduce the number of bundled scripting engines and make it easier
> to
> > > > bring your own. The current scripting bundle is around 100 MB, which
> > is a
> > > > lot of weight for languages and solutions that do not apply across
> the
> > > > board. Providing an alternative that makes it easier to bring in a
> > script
> > > > engine library should provide a better solution for the future. This
> > also
> > > > should not be a blocker for an initial NiFi 2.0, but it is worth
> > > > highlighting given the general interest in scripted components.
> > > >
> > > > Regards,
> > > > David Handermann
> > > >
> > > > On Thu, Jun 1, 2023, 11:38 PM Dirk Arends  >
> > > > wrote:
> > > >
> > > > > Hi Joe,
> > > > >
> > > > > > Who will be seriously impacted by the removal of Java 11 and what
> > was
> > > > > your plan for upgrading to Java 17?
> > > > >
> > > > > >
> > > > >
> > > > > > thoughts?
> > > > >
> > > > > I would support moving the minimum Java version to 17 if it wasn’t
> > for
> > > > the
> > > > > fact that Nashorn will be removed. Nashorn is already deprecated in
> > > Java
> > > > > 11, and was then fully removed in Java 15. I understand GraalVM is
> > > > intended
> > > > > to be i