Re: Pull request for ValidateJSON revisit
The author submitted a new pull request for ValidateJSON:https://github.com/apache/nifi/pull/5326 Should be ready for a re-review. From: Mark Payne Sent: Friday, August 20, 2021 9:34:17 AM To: dev@nifi.apache.org Subject: Re: Pull request for ValidateJSON revisit Tim, It looks like I’d done a review but then there were updates and I missed the fact that the PR had been updated. My main concern was with the licensing. It looks like I thought it was MIT but in fact it was ASL v2 (either I looked at the wrong dependency or the license was changed). Looking through its LICENSE and NOTICE file, it doesn’t appear that there is anything needed in the license. At this point, it looks like the PR has been closed, and I cannot re-open it (Says “The repository that submitted this pull request has been deleted.”). Based on a quick re-review, I think the PR is okay otherwise. If you want to open another PR I should be able to quickly review & merge. Thanks -Mark [1] > On Aug 20, 2021, at 7:23 AM, Smith, Tim wrote: > > The pull request for a ValidateJSON processor, NIFI-7392: > > https://github.com/apache/nifi/pull/4232 for > > has been marked as stale. From the review comments, this request was near > approval. There was an outstanding question on licensing that still may > exist. I have a similar need for this capability. Could this pull request be > revisited? I would rather not duplicate effort. > > > Tim
Re: Pull request for ValidateJSON revisit
Thanks Mike, Tim From: Michael Hogue Sent: Monday, August 23, 2021 8:31 AM To: dev Subject: Re: Pull request for ValidateJSON revisit Tim, The original author resubmitted the PR here: https://github.com/apache/nifi/pull/5326 Thanks for the bump, Mike On Fri, Aug 20, 2021 at 3:19 PM Smith, Tim wrote: > Mark, > > >Will do. Since repository is gone, I'll pull in the code and resubmit a > PR. > > > Thanks, > > > Tim > > > > From: Mark Payne > Sent: Friday, August 20, 2021 9:34 AM > To: dev@nifi.apache.org > Subject: Re: Pull request for ValidateJSON revisit > > Tim, > > It looks like I’d done a review but then there were updates and I missed > the fact that the PR had been updated. > > My main concern was with the licensing. It looks like I thought it was MIT > but in fact it was ASL v2 (either I looked at the wrong dependency or the > license was changed). > Looking through its LICENSE and NOTICE file, it doesn’t appear that there > is anything needed in the license. > > At this point, it looks like the PR has been closed, and I cannot re-open > it (Says “The repository that submitted this pull request has been > deleted.”). Based on a quick re-review, I think the PR is okay otherwise. > If you want to open another PR I should be able to quickly review & merge. > > Thanks > -Mark > > > [1] > > > On Aug 20, 2021, at 7:23 AM, Smith, Tim wrote: > > > > The pull request for a ValidateJSON processor, NIFI-7392: > > > > https://github.com/apache/nifi/pull/4232 for > > > > has been marked as stale. From the review comments, this request was > near approval. There was an outstanding question on licensing that still > may exist. I have a similar need for this capability. Could this pull > request be revisited? I would rather not duplicate effort. > > > > > > Tim > >
Re: Pull request for ValidateJSON revisit
Mark, Will do. Since repository is gone, I'll pull in the code and resubmit a PR. Thanks, Tim From: Mark Payne Sent: Friday, August 20, 2021 9:34 AM To: dev@nifi.apache.org Subject: Re: Pull request for ValidateJSON revisit Tim, It looks like I’d done a review but then there were updates and I missed the fact that the PR had been updated. My main concern was with the licensing. It looks like I thought it was MIT but in fact it was ASL v2 (either I looked at the wrong dependency or the license was changed). Looking through its LICENSE and NOTICE file, it doesn’t appear that there is anything needed in the license. At this point, it looks like the PR has been closed, and I cannot re-open it (Says “The repository that submitted this pull request has been deleted.”). Based on a quick re-review, I think the PR is okay otherwise. If you want to open another PR I should be able to quickly review & merge. Thanks -Mark [1] > On Aug 20, 2021, at 7:23 AM, Smith, Tim wrote: > > The pull request for a ValidateJSON processor, NIFI-7392: > > https://github.com/apache/nifi/pull/4232 for > > has been marked as stale. From the review comments, this request was near > approval. There was an outstanding question on licensing that still may > exist. I have a similar need for this capability. Could this pull request be > revisited? I would rather not duplicate effort. > > > Tim
Pull request for ValidateJSON revisit
The pull request for a ValidateJSON processor, NIFI-7392: https://github.com/apache/nifi/pull/4232 for has been marked as stale. From the review comments, this request was near approval. There was an outstanding question on licensing that still may exist. I have a similar need for this capability. Could this pull request be revisited? I would rather not duplicate effort. Tim
Issue uploading Nifi templates via UI and curl, NiFi 1.13.2 and up
Started receiving HTTP 500 internal server errors when attempting to upload template through UI after upgarding to version 1,13,2. Related, unable to utilize the nifi-api REST interface to upload templates as well. In both cases, template is uploaded but return failed responses. This did not occur in NiFi 1.12 Last testing performed 1.14 snapshot in my fork. Errors in nifi log after curl : Caused by: org.glassfish.jersey.message.internal.MessageBodyProviderNotFoundException: MessageBodyWriter not found for media type=application/xml, type=class org.apache.nifi.web.api.entity.TemplateEntity, genericType=class org.apache.nifi.web.api.entity.TemplateEntity. Has this already been reported? Tim Smith
Requesting Jira Contributer Access
I thought I had done this awhile back but could you please add me to Apache NiFi Jira. I need to assign tickets to myself. My user name is: tlsmith Thanks Tim Smith
Status of NIFI-5629 GetFile vast listing pergormance, pull request #3033
The last update on this request was in Oct 2018. Is there any movement on this effort?
