[GitHub] nifi pull request: NIFI-1925: Fixed typo in error message
GitHub user simonellistonball opened a pull request: https://github.com/apache/nifi/pull/468 NIFI-1925: Fixed typo in error message You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/nifi NIFI-1925 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #468 commit 41b71e5322fa579f7a115956ac2e9fdd2255bf0c Author: Simon Elliston Ball <si...@simonellistonball.com> Date: 2016-05-26T10:07:11Z Fixed typo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request: MINIFI-6: Basic C++ implementation f...
Github user simonellistonball commented on the pull request: https://github.com/apache/nifi-minifi-cpp/pull/4#issuecomment-221049133 Tried building this with the default settings (-O0), which yields 1.3MB binary. Is the intention to provide a different build script for more constrained environments, (-Os yields 459K binary). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: First cut at NIFI-1833 - Adding Azure Storage p...
Github user simonellistonball commented on the pull request: https://github.com/apache/nifi/pull/399#issuecomment-217411669 This needs a little bit more work. The goal here is to use a common pattern from standard processors, however, while tests work fine, loading into NiFi causes a duplicate of the standard processor nar and therefore unpredicatable ordering. One solution to this would be to factor the base AbstractListProcessor classes out of standard processors into processor-utils. However, they have a legacy dependency on the distributed cache service which would cause a circular dependency for this refactoring. Short term solution would be to reimplement the trigger and state logic direct in the Azure processors, which violates DRY. Longer term it would be great to have clean Abstracts for some of these common custom patterns in processor-utils, but that's for another issue and another PR. In the meantime I'll re-implement and update the PR, so please don't worry about reviews right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
