[GitHub] nifi pull request: [NIFI-774] Create a DeleteS3Object Processor
Github user yu-iskw commented on the pull request: https://github.com/apache/nifi/pull/80#issuecomment-137064643 @danbress thank you for reviewing it. Sorry, one more thing, I fixed a typo and modified an error message. I look forward to merging it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: [NIFI-774] Create a DeleteS3Object Processor
Github user yu-iskw commented on the pull request: https://github.com/apache/nifi/pull/80#issuecomment-136936916 @danbress could you review it? - Transfer `REL_NOT_FOUND` if not found target object on Amazon S3 - Add `REL_NOT_FOUND` to `DeleteS3Object` - Redefine `relationships` on `DeleteS3Object` to append `REL_NOT_FOUND` - Instead, get rid of `final` from `AbstractS3Processor`.`relationships` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: [NIFI-774] Create a DeleteS3Object Processor
GitHub user yu-iskw opened a pull request: https://github.com/apache/nifi/pull/80 [NIFI-774] Create a DeleteS3Object Processor I'm sorry for the delay of my sending a new PR again. @danbress could you review it? ## JIRA [[NIFI-774] Create a DeleteS3Object Processor - ASF JIRA](https://issues.apache.org/jira/browse/NIFI-774) ## Old PR #72 You can merge this pull request into a Git repository by running: $ git pull https://github.com/yu-iskw/nifi NIFI-774 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit d1dbd37629baeb9a1570f47f7583d07f54b38b5c Author: Yu ISHIKAWA <yuu.ishik...@gmail.com> Date: 2015-07-23T04:13:15Z [NIFI-774] Create a DeleteS3Object Processor commit 7e6834937b01f035666b113a6c2735e4156ea4f3 Author: Yuu ISHIKAWA <yuu.ishik...@gmail.com> Date: 2015-09-01T13:36:50Z Ignore the test suite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: [NIFI-774] Create a DeleteS3Object Processor
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/72#discussion_r36270059
--- Diff:
nifi/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/DeleteS3Object.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.s3;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.TimeUnit;
+
+import com.amazonaws.AmazonClientException;
+import com.amazonaws.services.s3.AmazonS3;
+import com.amazonaws.services.s3.model.*;
+import org.apache.nifi.annotation.behavior.*;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.util.StandardValidators;
+
+@SupportsBatching
+@SeeAlso({PutS3Object.class})
+@Tags({Amazon, S3, AWS, Archive, Delete})
+@CapabilityDescription(Deletes FlowFiles on an Amazon S3 Bucket)
+@DynamicProperty(name = The name of a User-Defined Metadata field to add
to the S3 Object,
+value = The value of a User-Defined Metadata field to add to the
S3 Object,
+description = Allows user-defined metadata to be added to the S3
object as key/value pairs,
+supportsExpressionLanguage = true)
+@ReadsAttribute(attribute = filename, description = Uses the FlowFile's
filename as the filename for the S3 object)
+@WritesAttributes({
+@WritesAttribute(attribute = s3.bucket, description = The name
of the S3 bucket),
+@WritesAttribute(attribute = s3.version, description = The
version of the S3 Object),
+@WritesAttribute(attribute = path, description = The path of
the file),
+})
+public class DeleteS3Object extends AbstractS3Processor {
+
+public static final PropertyDescriptor VERSION_ID = new
PropertyDescriptor.Builder()
+.name(Version)
+.description(The Version of the Object to delete)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.expressionLanguageSupported(true)
+.required(false)
+.build();
+
+public static final ListPropertyDescriptor properties =
Collections.unmodifiableList(
+Arrays.asList(KEY, BUCKET, ACCESS_KEY, SECRET_KEY,
CREDENTAILS_FILE, REGION, TIMEOUT,
+FULL_CONTROL_USER_LIST, READ_USER_LIST,
WRITE_USER_LIST, READ_ACL_LIST, WRITE_ACL_LIST, OWNER));
+
+@Override
+protected ListPropertyDescriptor getSupportedPropertyDescriptors() {
+return properties;
+}
+
+@Override
+protected PropertyDescriptor
getSupportedDynamicPropertyDescriptor(final String propertyDescriptorName) {
+return new PropertyDescriptor.Builder()
+.name(propertyDescriptorName)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.expressionLanguageSupported(true)
+.dynamic(true)
+.build();
+}
+
+public void onTrigger(final ProcessContext context, final
ProcessSession session) {
+FlowFile flowFile = session.get();
+if (flowFile == null) {
+return;
+}
+
+final long startNanos = System.nanoTime();
+
+final String bucket =
context.getProperty(BUCKET).evaluateAttributeExpressions(flowFile).getValue();
+final String key =
context.getProperty(KEY).evaluateAttributeExpressions(flowFile).getValue();
+final String versionId =
context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue
[GitHub] nifi pull request: [NIFI-774] Create a DeleteS3Object Processor
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/72#discussion_r36267498
--- Diff:
nifi/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/DeleteS3Object.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.s3;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.TimeUnit;
+
+import com.amazonaws.AmazonClientException;
+import com.amazonaws.services.s3.AmazonS3;
+import com.amazonaws.services.s3.model.*;
+import org.apache.nifi.annotation.behavior.*;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.util.StandardValidators;
+
+@SupportsBatching
+@SeeAlso({PutS3Object.class})
+@Tags({Amazon, S3, AWS, Archive, Delete})
+@CapabilityDescription(Deletes FlowFiles on an Amazon S3 Bucket)
+@DynamicProperty(name = The name of a User-Defined Metadata field to add
to the S3 Object,
--- End diff --
Alright.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: [NIFI-774] Create a DeleteS3Object Processor
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/72#discussion_r36267548
--- Diff:
nifi/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/DeleteS3Object.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.s3;
+
+import java.io.IOException;
+import java.util.*;
+import java.util.concurrent.TimeUnit;
+
+import com.amazonaws.AmazonClientException;
+import com.amazonaws.services.s3.AmazonS3;
+import com.amazonaws.services.s3.model.*;
+import org.apache.nifi.annotation.behavior.*;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.util.StandardValidators;
+
+@SupportsBatching
+@SeeAlso({PutS3Object.class})
+@Tags({Amazon, S3, AWS, Archive, Delete})
+@CapabilityDescription(Deletes FlowFiles on an Amazon S3 Bucket)
+@DynamicProperty(name = The name of a User-Defined Metadata field to add
to the S3 Object,
+value = The value of a User-Defined Metadata field to add to the
S3 Object,
+description = Allows user-defined metadata to be added to the S3
object as key/value pairs,
+supportsExpressionLanguage = true)
+@ReadsAttribute(attribute = filename, description = Uses the FlowFile's
filename as the filename for the S3 object)
+@WritesAttributes({
--- End diff --
I got it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
