[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/272 Thanks for the assist @apiri --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/272 @taftster @JPercivall I'll aid in the assist and wrap this up as I have been scanning through PRs and can merge in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/272 @taftster thanks for taking another look, yup I can merge this when I get a chance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user taftster commented on the issue: https://github.com/apache/nifi/pull/272 I'm happy with this PR. Thanks @pvillard31 for all the effort and seeing this through many changes and discussions. @JPercivall can you still merge this? I'm in between environments right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/272 It should be OK, let me know if not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
I added a comment to the JIRA ticket associated with this pull request. I think there should be discussion / buy-in from others on the aestetics of introducing a new processor property for this edge case. Instead, I think the goals of this request could be fulfilled without strictly introducing a new property, which I think would be a likely improved approach. https://issues.apache.org/jira/browse/NIFI-1620 Maybe we should postpone this ticket resolution and not merge in 0.7.x until more discussion has occurred? I wouldn't want to merge this change without at least a few nods agreeing to the proposed property. On Wed, Jun 15, 2016 at 5:05 PM, JPercivallwrote: > Github user JPercivall commented on the issue: > > https://github.com/apache/nifi/pull/272 > > @taftster I'll let you finish it up tonight if you have time since > you've already had eyes on it. If you're not able to, I'll take a look > tomorrow. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/272 @taftster I'll let you finish it up tonight if you have time since you've already had eyes on it. If you're not able to, I'll take a look tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user taftster commented on the issue: https://github.com/apache/nifi/pull/272 I can try to look at it tonight. But no problems if you want to step in. > On Jun 15, 2016, at 10:51 AM, Joe Percivallwrote: > > @taftster will you have time to finish up this review for 0.7.0 or do you want me to finish it? > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #272: NIFI-1620 Allow empty Content-Type in InvokeHTTP processor
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/272 @taftster will you have time to finish up this review for 0.7.0 or do you want me to finish it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---