[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/328 Merged and closed. Will do the same for [PR 533](https://github.com/apache/nifi/pull/533). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/328 @alopresto just fixed it. Took me a while to figure out what's going on but you can read some details here: https://issues.apache.org/jira/browse/NIFI-1730 (last comment). Also, I am now going to have to make a separate PR for 0.x. Arghhh --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/328 I've tried to build this locally twice (clean checkouts and everything). It is failing with a compilation error in `MonitorMemoryTest` saying that `UserService` cannot be found. I had to clean up a couple checkstyle violations in `nifi-web-api` to get to that point. Those fixes are available [here](https://github.com/alopresto/nifi/commit/f042735d094bb2a14bb7e05bc9ebc1090bfd175f). The compilation error is below: ``` [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ nifi-standard-reporting-tasks --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 3 source files to /Users/alopresto/Workspace/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/target/test-classes [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /Users/alopresto/Workspace/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/test/java/org/apache/nifi/controller/MonitorMemoryTest.java:[28,36] error: cannot find symbol [ERROR] symbol: class UserService location: package org.apache.nifi.admin.service /Users/alopresto/Workspace/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/test/java/org/apache/nifi/controller/MonitorMemoryTest.java:[136,21] error: cannot find symbol [INFO] 2 errors ``` Any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/328 @alopresto all done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/328 Thanks @olegz . If you rebase and squash, I'll verify and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #328: NIFI-1690 Changed MonitorMemory to use allowable values for...
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/328 @alopresto all is addressed. Let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
