[GitHub] nifi issue #397: NIFI-1815
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/397 back to reviewing this. It has some merge conflicts but i'll fox them as I go along --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/397 I stepped away from it as I am trying to finish something else that is very involved. Will get back to it once I am finished, but I am committed to getting it in to both 0.7.0 and 1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/397 Olegz any luck getting your local install of Tesseract to work? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/397
True, and I did the same ('brew install tesseract') and got this
```
Trying a mirror...
==> Downloading
ftp://ftp.simplesystems.org/pub/libpng/png/src/libpng16/libpng-1.6.17.tar.xz
curl: (78) RETR response: 550
Error: Failed to download resource "libpng"
Download failed:
ftp://ftp.simplesystems.org/pub/libpng/png/src/libpng16/libpng-1.6.17.tar.xz
```
So, I'll keep on trying
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #397: NIFI-1815
Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/397 Olegz - I'll certainly add the extra checking. As for installation on nom Windows I did the development on OS X and simply ran "brew install tesseract" rather than building from source Sent from my iPhone > On Jun 6, 2016, at 7:47 AM, Oleg Zhurakousky wrote: > > Ok, while all is good on Windows I can't seem to have any success building those .so files on OSx. Normally I would not worry about it that much but given that Tesseract distribution includes DLLs inside the JAR means that for "all other" OS such native libraries will come from outside and need to be known to the processor, so we probably would need another property and definitely test with at least one non-Win system. > So, I'll keep on trying (when I get a chance) to get/build those native libraries, but could use some help here as well > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/397 Ok, while all is good on Windows I can't seem to have any success building those _.so_ files on OSx. Normally I would not worry about it that much but given that Tesseract distribution includes DLLs inside the JAR means that for "all other" OS such native libraries will come from outside and need to be known to the processor, so we probably would need another property and definitely test with at least one non-Win system. So, I'll keep on trying (when I get a chance) to get/build those native libraries, but could use some help here as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/397 @olegz my initial intention was that the "TESS_DATA_PATH" and the "TessdataDirectoryValidator" being a required PropertyDescriptor would catch those instances where users tried to use this processor without the native system dependencies installed. You bring up a good point however since really all this would do is check that the Tesseract dictionary files are present which certainly doesn't mean that the native libraries will be there as well. This doesn't cover the unit test cases however. I like your point about creating a throw away Tesseract instance to check if the dependencies are present. I will add something like that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/397 @olegz definitely was thinking a customValidate check which determined whether tesseract was ready to roll. If the check you mention does that then that sounds good. We should be careful about ever call to customValidate resulting in an exception so probably best to periodically check if tesseract can work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/397 The DLLs are distributed with the Tesseract JAR, but not _.so_ or other OS specific libs. Basically the current JAR only supports Windows out-of-the-box. @joewitt If I understand correctly we need to create a custom validator with something like this inside it ``` new Tesseract(); ``` . . . basically a throw-away instance of Tesseract just to see if it loads successfully as that is where JNA mapping happens --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/397 as long as the processor is invalid and won't start until the environmentally required bits are present we're good. And yes it is correct we cannot distribute the dlls in our source release but they would be fine for the convenience binary artifacts we put out presuming the licensing allows this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/397 @jdye64 I want to switch the discussion to a different topic now as I am starting to have second thoughts, specifically around JNA bindings and how to properly go about it in the context of NiFi and this processor. Basically out of the box the proc won't work until native libs are installed and I am not sure we can really 'make' and distribute them either. Any thoughts on this? Even tests depend on native libs and the only libs distributed with Tesseract are windows DLLs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #397: NIFI-1815
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/397 @jdye64 I left one last comment. Once addressed I'll begin the merge procedure. I will also take care of LICENSE and NOTICE --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
