[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[mosermw]

Github user mosermw commented on the issue:

https://github.com/apache/nifi/pull/458
  
Completed review, latest changes look good, unit testing and integration 
testing worked as expected, code passes -Pcontrib-check.

+1 I will squash commits and merge to 0.x and master shortly.  Thanks 
@jskora.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[jskora]

Github user jskora commented on the issue:

https://github.com/apache/nifi/pull/458
  
Ok, I think that last commit covers the review feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[trkurc]

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/458
  
I don't mind even a little! Thanks @mosermw


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[mosermw]

Github user mosermw commented on the issue:

https://github.com/apache/nifi/pull/458
  
I will review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[JPercivall]

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/458
  
@trkurc ok, in order to get 0.7.0 as soon as possible, would you mind if 
another committer took over reviewing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[trkurc]

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/458
  
Not until this weekend
On Jun 15, 2016 4:30 PM, "Joe Percivall"  wrote:

> @jskora  rebased and addressed comments,
> @trkurc  are you able to finish reviewing this
> for 0.7.0?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[JPercivall]

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/458
  
@jskora rebased and addressed comments, @trkurc are you able to finish 
reviewing this for 0.7.0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[joewitt]

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/458
  
The name isn't great but not sure what would be better.  It is indeed a 
debugger for the framework and less so for a flow.  It is perhaps good to call 
it 'CreateChaos'.  That said i personally think this is a great idea to have in 
the build and part of the standard processors.  It would only be used by power 
users or curious types.  And for everyone else it is a noop.  But it could make 
it easier for us to demonstrate the evil effects of constant exceptions in a 
flow and do interesting regression checks on various infrastructures.  There is 
admittedly probably a better place for this but with the upcoming nar registry 
work we can tackle that then.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

[markap14]

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/458
  
I'm having trouble understanding the naming convention here. "DebugFlow" 
would indicate that it is debugging the flow that you are putting together, but 
the comment states "Create DebugFlow processor for use in testing and 
troubleshooting the processor framework." So it appears that the desire is to 
debug the framework?

I also wonder if this is something that should be in the nifi codebase, as 
it really seems like a niche processor that is intended to test very specific 
things and not something that we would expect typical users to use. I may be 
wrong, but would GitHub be a more appropriate place for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---