[GitHub] nifi issue #516: NIFI-1993 upgraded CGLIB to 3.2.2

2016-06-10 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/516
  
+1 LGTM, tested #515 with and without this commit, verified the test fails 
without this commit. Merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #516: NIFI-1993 upgraded CGLIB to 3.2.2

2016-06-09 Thread olegz
Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/516
  
@mattyb149 I got one better ;) Try PR 
https://github.com/apache/nifi/pull/515 as it stands now and then with this 
change. That is how it was discovered. I've attached some notes in JIRA. Let me 
know if you need more details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #516: NIFI-1993 upgraded CGLIB to 3.2.2

2016-06-09 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/516
  
What's a good test? Successful build? Or something more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---