[GitHub] nifi issue #525: NIFI-1976 - Windows Event Log native processor

2016-06-29 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/525
  
+1

Did a contrib check build, reviewed the code and any comments were 
addressed. To test I ran three ConsumeWindowsEventLog processors following 
multiple Windows channels and did a query to limit one of them. I verified the 
results by looking at the built in Event Viewer program. Thanks @brosander for 
the contribution! I will rebase and merge it into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #525: NIFI-1976 - Windows Event Log native processor

2016-06-24 Thread brosander
Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/525
  
@JPercivall just pushed change to update duplicate logging in the same way 
as 
https://github.com/apache/nifi/pull/548/files#diff-a88d41c9ef1b881c177706d4cc4b0bf1R294


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #525: NIFI-1976 - Windows Event Log native processor

2016-06-20 Thread brosander
Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/525
  
@JPercivall I believe I have incorporated all of the suggested changes 
(except for the XPath validator because it didn't like some of the provided 
examples in the api doc).  Mind taking another look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---