[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/148


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[mcgilman]

Github user mcgilman commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-176187058
  
With the github outage last night, ended up merging today. Thanks @trkurc 
and @olegz !!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[mcgilman]

Github user mcgilman commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-175755889
  
Would just like to confirm with @trkurc before merging in. Sounds like he 
may have been still working through some of the details. If he's content I'm 
happy to merge this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-175758188
  
Still working it - I'll be done tonight. I can take care of the merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[mcgilman]

Github user mcgilman commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-175758510
  
Sounds good. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-174110924
  
That 'deadlock' above should be readlock


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-174110900
  
@olegz - I am still working through the locking on paper. I gave up on 
getting stack traces. We have a week or so before 0.5.0, if I don't make 
progress I think we go with deadlock. I am beginning to think you're right 
about it not being necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[olegz]

Github user olegz commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-172583777
  
I am not surprised, that's why I was against having a lock in a shutdown in 
the first place. It doesn't bring any value since If you follow the logic of 
shutting down executors we are shutting them down cold anyway if they have not 
shut down in timely fashion. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-172582763
  
I think it may still deadlock. I scripted a startup and shutdown over and 
over again for a few days, and it still was hanging on occasion. I should have 
added a jstack.. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[olegz]

Github user olegz commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-171660747
  
@markap14 @joewitt Guys, please review. As agreed I've put read lock back 
in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[joewitt]

Github user joewitt commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-171664124
  
thanks oleg.  i won't be able to help today most likely . Hopefully 
payne-monster or someone else can.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-171665816
  
@olegz  - I'll dig my old notes out and try to verify that a read-lock 
won't continue to cause a deadlock. I will likely have some time later this 
evening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[joewitt]

Github user joewitt commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-168541741
  
Mark Payne commented on NIFI-1333 ticket.  In short the write lock does 
appear no longer necessary but a readLock still is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/148#issuecomment-167262894
  
Adding some comments on the ticket


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

[olegz]

GitHub user olegz opened a pull request:

https://github.com/apache/nifi/pull/148

NIFI-1333 fixed FlowController shutdown deadlock

The relevant test is available here: 
https://github.com/olegz/nifi/blob/int-test/nifi-integration-tests/src/test/java/org/apache/nifi/test/flowcontroll/FlowControllerTests.java#L50
 

Unfortunately this is one of those multi-module situations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/olegz/nifi NIFI-1333

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #148


commit 302dafbf59e1eab48bece7be8a3e98682c7fc14b
Author: Oleg Zhurakousky 
Date:   2015-12-23T20:41:54Z

NIFI-1333 fixed FlowController shutdown deadlock




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---