[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

2016-03-20 Thread mattyb149
Github user mattyb149 commented on the pull request:

https://github.com/apache/nifi/pull/273#issuecomment-198199315
  
LGTM, successfully built PR, ran unit tests, and tested with running NiFi 
with both a CSV file and an Atom file (both types recognized by extension: 
https://github.com/apache/tika/blob/master/tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml)
 +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

2016-03-19 Thread jfrazee
Github user jfrazee closed the pull request at:

https://github.com/apache/nifi/pull/273


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on the pull request:

https://github.com/apache/nifi/pull/273#issuecomment-198185301
  
reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on the pull request:

https://github.com/apache/nifi/pull/273#issuecomment-198202258
  
I merged this but forgot to close the PR, @jfrazee can you do the honors?

Thanks for the contrib!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---