[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[apiri]

Github user apiri commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199945870
  
Great, thanks everyone for scoping this out.  I'll merge those exclusions 
in with my commit and get them off to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[mcgilman]

Github user mcgilman commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199945136
  
+1

The build looks good in both OSX and Windows 10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[JPercivall]

Github user JPercivall commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199939742
  
+1

Reviewed the code and did a contrib check build on Windows 8, looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[JPercivall]

Github user JPercivall commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199936658
  
With the added pom exclusions the build passes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[apiri]

Github user apiri commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199897484
  
Not sure why this came up, but have included it in 
a2e679bbbc4f612a9fc61a51d47aba693789a44b.  If that checks out, I can squash 
this with the actual changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[mcgilman]

Github user mcgilman commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199894397
  
I am seeing the same contrib check failure that @JPercivall mentioned above 
running Windows 10.

> Unapproved licenses:
> 
>   
C:/Users/gilman/Documents/sandbox/mcgilman/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestEncryptContent/unsalted_128_raw.enc

My environment: 

> mvn -version
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 
2015-11-10T11:41:47-05:00)
> Maven home: C:\Program Files\apache-maven-3.3.9\bin\..
> Java version: 1.8.0_73, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_73\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[apiri]

Github user apiri commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199890235
  
I can add this as part of the commit.  Did everything else check out okay 
though?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[JPercivall]

Github user JPercivall commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199888509
  
A very weird error with contrib check I am only getting windows 8, an 
unapproved license for:

nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestEncryptContent/unsalted_128_raw.enc

It seems this should be excluded in the pom for standard processors but it 
isn't. What is more confusing is that neither Mac nor Travis fails to find this 
contrib check. Even more so, it looks like salted_128_raw.enc should fail as 
well but it doesn't on any tested machine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199871907
  
Testing on Windows 7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199874747
  
I'm a +1, all tests previously in failure are now OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[JPercivall]

Github user JPercivall commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199870316
  
I am testing on Windows 8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[mcgilman]

Github user mcgilman commented on the pull request:

https://github.com/apache/nifi/pull/297#issuecomment-199867101
  
I can verify the tests on Windows 10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1664 Preferring System.nanoTime to System....

[apiri]

GitHub user apiri opened a pull request:

https://github.com/apache/nifi/pull/297

NIFI-1664 Preferring System.nanoTime to System.currentTimeMillis and …

…providing explicit handling of timestamps for files in those tests that 
are testing other attributes of the ListFile process besides timestamp which 
could lead to erroneous transmissions depending on exactly when files were 
created.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apiri/incubator-nifi NIFI-1664

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #297


commit e5fb07ca82ed3a192cf4810ea331ccfc21a5d36f
Author: Aldrin Piri 
Date:   2016-03-22T15:10:08Z

NIFI-1664 Preferring System.nanoTime to System.currentTimeMillis and 
providing explicit handling of timestamps for files in those tests that are 
testing other attributes of the ListFile process besides timestamp which could 
lead to erroneous transmissions depending on exactly when files were created.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---