[GitHub] nifi pull request: NIFI-1748 removed un-used test data

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/344


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

[jskora]

Github user jskora commented on the pull request:

https://github.com/apache/nifi/pull/344#issuecomment-208593602
  
Reviewing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

[olegz]

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/344#discussion_r59292437
  
--- Diff: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/KafkaPublisherTest.java
 ---
@@ -124,33 +112,9 @@ public void validateSuccessfulSendAsDelimited() throws 
Exception {
 }
 
 @Test
-public void validateSuccessfulSendAsDelimited2() throws Exception {
--- End diff --

No, that was actually an addition when we tried to use Scanner from java 
that would parse using regex, so need to test for special character, but since 
that approach never seen the light of day that test was obsolete from the get 
go.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

[jskora]

Github user jskora commented on a diff in the pull request:

https://github.com/apache/nifi/pull/344#discussion_r59292187
  
--- Diff: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/KafkaPublisherTest.java
 ---
@@ -124,33 +112,9 @@ public void validateSuccessfulSendAsDelimited() throws 
Exception {
 }
 
 @Test
-public void validateSuccessfulSendAsDelimited2() throws Exception {
--- End diff --

I see this test is just like the previous test, but is anything lost by not 
testing with a different delimiter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

[olegz]

GitHub user olegz opened a pull request:

https://github.com/apache/nifi/pull/341

NIFI-1748 removed un-used test data



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/olegz/nifi NIFI-1748

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #341


commit 2581f7162f01c09ffd55d219f2af7f3b781dd6eb
Author: Oleg Zhurakousky 
Date:   2016-04-09T21:24:37Z

NIFI-1748 removed un-used test data




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---