[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/457 NIFI-1907 Moving lazy init of SSLContext... to StandardSiteToSiteClientConfig rather than the builder. Tested secure SiteToSite still working between two NiFi nodes, and now example Storm topology can also connect to a secured NiFi instance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-1907 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/457.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #457 commit 25bae0fd890b53f2f201d1e5475d5d0e1708580e Author: Bryan Bende Date: 2016-05-20T15:15:36Z NIFI-1907 Moving lazy init of SSLContext to StandardSiteToSiteClientConfig rather than the builder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...
Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/457#issuecomment-220988156 @bbende i think the move makes sense to improve the lifecycle of when such issues are detected. However, it does seem like throwing RuntimeExceptions for those could be improved. Could they instead be considered IllegalStateExceptions and be a documented part of that interface? Also for the last runtime exception should we include the underlying exception when we create a new exception or do we intentionally bury it here? That said these questions/concerns are not 'because of this change' and i do agree the context should be constructed during the building phase of the client so I'm a +1 anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/457#issuecomment-221068355 @joewitt good idea regarding the error handling, i made the suggested changes and and rebased so the commit should now reflect those changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/457#issuecomment-221268368 Going to merge this in since Joe was a +1... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---