[GitHub] nifi pull request: NIFI-1913 Properly removing flowfile in HandleH...

2016-05-23 Thread JPercivall
GitHub user JPercivall opened a pull request:

https://github.com/apache/nifi/pull/462

NIFI-1913 Properly removing flowfile in HandleHttpRequest when the Co…

…ntext Map fails to register the request

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JPercivall/nifi NIFI-1913

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #462


commit 44013976749d377706999fc49a1a4d3014909a69
Author: jpercivall 
Date:   2016-05-23T16:24:43Z

NIFI-1913 Properly removing flowfile in HandleHttpRequest when the Context 
Map fails to register the request




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1913 Properly removing flowfile in HandleH...

2016-05-23 Thread pvillard31
Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/462#issuecomment-221058590
  
There is a double space on line 160 in test class. Travis seems not to be 
run on 0.x branch so I don't know if contrib check would fail because of that 
(cannot personally check right now).
Otherwise, +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1913 Properly removing flowfile in HandleH...

2016-05-24 Thread JPercivall
Github user JPercivall commented on the pull request:

https://github.com/apache/nifi/pull/462#issuecomment-221296594
  
Thanks @pvillard31, github was being weird when I pushed this originally so 
it didn't get built. I re-pushed, addressing the double space, and it passes. I 
will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request: NIFI-1913 Properly removing flowfile in HandleH...

2016-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---