[GitHub] nifi pull request #520: NIFI-1997: Use the 'autoResumeState' property define...

2016-06-10 Thread markap14
GitHub user markap14 opened a pull request:

https://github.com/apache/nifi/pull/520

NIFI-1997: Use the 'autoResumeState' property defined in nifi.properties on 
each node instead of inheriting the property from the Cluster Coordinator

Use the 'autoResumeState' property defined in nifi.properties on each node 
instead of inheriting the property from the Cluster Coordinator

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markap14/nifi NIFI-1997

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #520


commit 8cebe78d8e93694bce847c3e3c38802aa4f701eb
Author: Mark Payne 
Date:   2016-06-10T18:35:47Z

NIFI-1996: Fixed bug in the generation of UUID's for components when 
dealing with Snippets

commit 4f997585c3ff4c3997f76f0183ee234032d23251
Author: Mark Payne 
Date:   2016-06-10T19:16:18Z

NIFI-1997: Use the 'autoResumeState' property defined in nifi.properties on 
each node instead of inheriting the property from the Cluster Coordinator




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #520: NIFI-1997: Use the 'autoResumeState' property define...

2016-06-15 Thread olegz
Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/520#discussion_r67159721
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message/AdaptedDataFlow.java
 ---
@@ -23,8 +23,6 @@
 private byte[] flow;
 private byte[] snippets;
 
-private boolean autoStartProcessors;
-
 public AdaptedDataFlow() {
 }
--- End diff --

Why do we have it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #520: NIFI-1997: Use the 'autoResumeState' property define...

2016-06-15 Thread markap14
Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/520#discussion_r67190057
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message/AdaptedDataFlow.java
 ---
@@ -23,8 +23,6 @@
 private byte[] flow;
 private byte[] snippets;
 
-private boolean autoStartProcessors;
-
 public AdaptedDataFlow() {
 }
--- End diff --

This was something that remains from the 0.x codebase but it doesn't really 
make sense anymore in the Zero-Master Clustering paradigm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #520: NIFI-1997: Use the 'autoResumeState' property define...

2016-06-15 Thread olegz
Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/520#discussion_r67190218
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message/AdaptedDataFlow.java
 ---
@@ -23,8 +23,6 @@
 private byte[] flow;
 private byte[] snippets;
 
-private boolean autoStartProcessors;
-
 public AdaptedDataFlow() {
 }
--- End diff --

So do you want to leave it or . . . ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #520: NIFI-1997: Use the 'autoResumeState' property define...

2016-06-15 Thread markap14
Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/520#discussion_r67190819
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message/AdaptedDataFlow.java
 ---
@@ -23,8 +23,6 @@
 private byte[] flow;
 private byte[] snippets;
 
-private boolean autoStartProcessors;
-
 public AdaptedDataFlow() {
 }
--- End diff --

Ohhh... I am sorry - I thought you were commented on the removal of the 
'autoStartProcessors' field, and asking why it was there to begin with. I can 
remove it if you prefer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #520: NIFI-1997: Use the 'autoResumeState' property define...

2016-06-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/520


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---