Re: Release candidate verification question
Ok, Thank you Joe and Bryan for the clarification and options. On Tue, Feb 18, 2020 at 11:27 AM Bryan Bende wrote: > If you want to compare the actual content of the source, you could do > something like: > > git clone https://git-wip-us.apache.org/repos/asf/nifi.git > git -C nifi checkout > diff --brief -r nifi-rc-source nifi > > On Tue, Feb 18, 2020 at 11:18 AM Joe Witt wrote: > > > > Chad, > > > > You basically want to ensure that a given release tag matches what we'd > > expect. In this case we're doing a 1.11.2 release so you'd want it to be > > 1.11.1 plus updates. > > > > > https://gitbox.apache.org/repos/asf?p=nifi.git;a=log;h=6d2ec87c8a46d5d39f3b4683e4ea9dec91138d52 > > > > That link and the resulting history shows that it is based off a certain > > commit from master that resulted in 1.11.0 and then a support branch for > > 1.11.x which resulted in 1.11.1 plus some new commits which is now > 1.11.2. > > You can also verify that the content of the previous commit before the > > actual release tag is present in the release as well by comparing the > diff > > to the source itself. > > > > Thanks > > > > > > On Tue, Feb 18, 2020 at 11:13 AM Chad Zobrisky > wrote: > > > > > I was going through the guide over the weekend and hit the step about > > > verifying the RC was branched off the correct git commit. Is this done > just > > > via looking in git at the commit for the tag and that the release vote > > > email has the same commit hash in it , or is the commit hash put > somewhere > > > in the source/build to verify there? > > > > > > Hope that makes sense. > > > > > > Thanks, > > > Chad > > > >
Re: Release candidate verification question
If you want to compare the actual content of the source, you could do something like: git clone https://git-wip-us.apache.org/repos/asf/nifi.git git -C nifi checkout diff --brief -r nifi-rc-source nifi On Tue, Feb 18, 2020 at 11:18 AM Joe Witt wrote: > > Chad, > > You basically want to ensure that a given release tag matches what we'd > expect. In this case we're doing a 1.11.2 release so you'd want it to be > 1.11.1 plus updates. > > https://gitbox.apache.org/repos/asf?p=nifi.git;a=log;h=6d2ec87c8a46d5d39f3b4683e4ea9dec91138d52 > > That link and the resulting history shows that it is based off a certain > commit from master that resulted in 1.11.0 and then a support branch for > 1.11.x which resulted in 1.11.1 plus some new commits which is now 1.11.2. > You can also verify that the content of the previous commit before the > actual release tag is present in the release as well by comparing the diff > to the source itself. > > Thanks > > > On Tue, Feb 18, 2020 at 11:13 AM Chad Zobrisky wrote: > > > I was going through the guide over the weekend and hit the step about > > verifying the RC was branched off the correct git commit. Is this done just > > via looking in git at the commit for the tag and that the release vote > > email has the same commit hash in it , or is the commit hash put somewhere > > in the source/build to verify there? > > > > Hope that makes sense. > > > > Thanks, > > Chad > >
Re: Release candidate verification question
Chad, You basically want to ensure that a given release tag matches what we'd expect. In this case we're doing a 1.11.2 release so you'd want it to be 1.11.1 plus updates. https://gitbox.apache.org/repos/asf?p=nifi.git;a=log;h=6d2ec87c8a46d5d39f3b4683e4ea9dec91138d52 That link and the resulting history shows that it is based off a certain commit from master that resulted in 1.11.0 and then a support branch for 1.11.x which resulted in 1.11.1 plus some new commits which is now 1.11.2. You can also verify that the content of the previous commit before the actual release tag is present in the release as well by comparing the diff to the source itself. Thanks On Tue, Feb 18, 2020 at 11:13 AM Chad Zobrisky wrote: > I was going through the guide over the weekend and hit the step about > verifying the RC was branched off the correct git commit. Is this done just > via looking in git at the commit for the tag and that the release vote > email has the same commit hash in it , or is the commit hash put somewhere > in the source/build to verify there? > > Hope that makes sense. > > Thanks, > Chad >
Release candidate verification question
I was going through the guide over the weekend and hit the step about verifying the RC was branched off the correct git commit. Is this done just via looking in git at the commit for the tag and that the release vote email has the same commit hash in it , or is the commit hash put somewhere in the source/build to verify there? Hope that makes sense. Thanks, Chad
