[GitHub] nutch pull request: Fix for NUTCH-2092 by Sujen Shah

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nutch/pull/54


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Fix for NUTCH-2092 by Sujen Shah

[sujen1412]

GitHub user sujen1412 opened a pull request:

https://github.com/apache/nutch/pull/54

Fix for NUTCH-2092 by Sujen Shah



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sujen1412/nutch NUTCH-2092

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nutch/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit e472d5da9c8b6f29e0370255c05b847e250b2770
Author: Sujen Shah 
Date:   2015-09-09T04:07:51Z

Unit test for NutchServer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Fix for NUTCH-2092 by Sujen Shah

[lewismc]

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/nutch/pull/54#discussion_r39007818
  
--- Diff: src/java/org/apache/nutch/service/NutchServer.java ---
@@ -211,6 +211,10 @@ public boolean canStop(boolean force){
 return jobs.isEmpty();
   }
 
+  protected static void setPort(int port) {
+ NutchServer.port = port;
--- End diff --

Formatting. 2 space indents.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Fix for NUTCH-2092 by Sujen Shah

[lewismc]

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/nutch/pull/54#discussion_r39007826
  
--- Diff: ivy/ivy.xml ---
@@ -76,6 +76,7 @@
 
 
 
+
--- End diff --

Please set scope to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Fix for NUTCH-2092 by Sujen Shah

[lewismc]

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/nutch/pull/54#discussion_r39007881
  
--- Diff: src/test/org/apache/nutch/service/TestNutchServer.java ---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nutch.service;
+
+import javax.ws.rs.core.Response;
+
+import org.apache.cxf.jaxrs.client.WebClient;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class TestNutchServer {
+
--- End diff --

Please adhere to formatting for Nutch code. The formatting is 2 space 
indents. This can be seen within the remainder of the code and there is also an 
existing eclipse code formatter if you would like to import and use that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Fix for NUTCH-2092 by Sujen Shah

[lewismc]

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/nutch/pull/54#discussion_r39008773
  
--- Diff: src/java/org/apache/nutch/service/NutchServer.java ---
@@ -211,6 +211,10 @@ public boolean canStop(boolean force){
 return jobs.isEmpty();
   }
 
+  protected static void setPort(int port) {
+ NutchServer.port = port;
--- End diff --

Formatting


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---