[GitHub] nutch pull request: NUTCH-2213 : do not store the headers verbatim...
Github user asfgit closed the pull request at: https://github.com/apache/nutch/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nutch pull request: NUTCH-2213 : do not store the headers verbatim...
GitHub user jnioche reopened a pull request: https://github.com/apache/nutch/pull/88 NUTCH-2213 : do not store the headers verbatim if the response was compressed See discussion on [https://issues.apache.org/jira/browse/NUTCH-2213]. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jnioche/nutch NUTCH-2213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nutch/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit ba86ddfcc2431ae41accd8f56cc4ffcba16d1cc3 Author: Julien Nioche Date: 2016-02-10T15:38:26Z NUTCH-2213 : do not store the headers verbatim if the response was compressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nutch pull request: NUTCH-2213 : do not store the headers verbatim...
Github user asfgit closed the pull request at: https://github.com/apache/nutch/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nutch pull request: NUTCH-2213 : do not store the headers verbatim...
Github user MJJoyce commented on a diff in the pull request:
https://github.com/apache/nutch/pull/88#discussion_r53254383
--- Diff:
src/plugin/protocol-http/src/java/org/apache/nutch/protocol/http/HttpResponse.java
---
@@ -256,6 +252,11 @@ public HttpResponse(HttpBase http, URL url, CrawlDatum
datum)
} else if ("deflate".equals(contentEncoding)) {
content = http.processDeflateEncoded(content, url);
} else {
+// store the headers verbatim only if the response was not
compressed
+// as the content length reported with not match otherwise
--- End diff --
"with" should be "will" here I think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nutch pull request: NUTCH-2213 : do not store the headers verbatim...
GitHub user jnioche opened a pull request: https://github.com/apache/nutch/pull/88 NUTCH-2213 : do not store the headers verbatim if the response was compressed See discussion on [https://issues.apache.org/jira/browse/NUTCH-2213]. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jnioche/nutch NUTCH-2213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nutch/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit ba86ddfcc2431ae41accd8f56cc4ffcba16d1cc3 Author: Julien Nioche Date: 2016-02-10T15:38:26Z NUTCH-2213 : do not store the headers verbatim if the response was compressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
