[GitHub] nutch pull request: Nutch 2059 - Unit test failures for protocol-h...
Github user asfgit closed the pull request at: https://github.com/apache/nutch/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nutch pull request: Nutch 2059 - Unit test failures for protocol-h...
GitHub user PeterCiuffetti opened a pull request: https://github.com/apache/nutch/pull/49 Nutch 2059 - Unit test failures for protocol-http and protocol-httclient This includes some defensive checks in the setup and tear down of these tests to ensure that the ports being used to start test jetty servers are available when starting and are stopped when finished. I have also applied this technique to TestFetcher's teardown given this recent unit test failure. https://builds.apache.org/job/Nutch-trunk/3238/testReport/junit/org.apache.nutch.fetcher/TestFetcher/testFetch/ You can merge this pull request into a Git repository by running: $ git pull https://github.com/PeterCiuffetti/nutch NUTCH-2059 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nutch/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit 2ac9a4bf251d0b7b5b9d14bb7596b790d67bd785 Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-07-04T20:46:00Z Eliminating java.lang.IllegalStateException: STREAM in unit tests for protocol-httpclient. Removing unneessary white space sent to jsp output commit 38ef6308268a1895a434c8bc6c311a964cf71bfc Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-07-04T21:33:12Z Change max thread computations as suggested by NUTCH-1836; code formatting commit 6f470d75e6fa5836cf7883d3d87da33f526228cc Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-07-15T20:48:00Z Merge branch 'trunk' of github.com:apache/nutch into NUTCH-2059 commit 6ee99ad773e5357b6e76b96853a5bc4db7da Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-07-16T02:48:03Z Adjusting HttpClient unit test to seek available jetty port; and to wait for close of active server commit 9ae4697606db51ace5e80bddc57e73ac119764b8 Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-07-16T02:48:33Z Merge branch 'trunk' of github.com:apache/nutch into NUTCH-2059 commit 052584fcb58662533203cbcd8c6c9d76837431a9 Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-08-04T21:12:31Z Merge branch 'trunk' of github.com:apache/nutch into NUTCH-2059 commit 7c285478b10b3d22dcb27ba389e27dbbe255a8eb Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-08-04T21:32:15Z Small defensive change to TestFestcher tear down to ensure server stopped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nutch pull request: Nutch 2059 - Unit test failures for protocol-h...
GitHub user PeterCiuffetti opened a pull request: https://github.com/apache/nutch/pull/45 Nutch 2059 - Unit test failures for protocol-http and protocol-httclient This also incorporates the suggestion in NUTCH-1836, except that the parameters used to do the suggested computation changed to use the current parameter name. Note that while this eliminates some exceptions that were logged during protocol-httpclient testing, its not certain if this will make any material difference regarding the Jenkins unit test failures. The test are passing on my sandbox with or without these changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PeterCiuffetti/nutch NUTCH-2059 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nutch/pull/45.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #45 commit 2ac9a4bf251d0b7b5b9d14bb7596b790d67bd785 Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-07-04T20:46:00Z Eliminating java.lang.IllegalStateException: STREAM in unit tests for protocol-httpclient. Removing unneessary white space sent to jsp output commit 38ef6308268a1895a434c8bc6c311a964cf71bfc Author: PeterCiuffetti pciuffe...@astreetpress.com Date: 2015-07-04T21:33:12Z Change max thread computations as suggested by NUTCH-1836; code formatting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nutch pull request: Nutch 2059 - Unit test failures for protocol-h...
Github user asfgit closed the pull request at: https://github.com/apache/nutch/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---