[GitHub] nutch pull request: fix for NUTCH-2241 contributed by karanjeets
Github user karanjeets commented on a diff in the pull request:
https://github.com/apache/nutch/pull/98#discussion_r57698140
--- Diff:
src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
---
@@ -112,11 +126,16 @@ public static WebDriver getDriverForPage(String url,
Configuration conf) {
}
LOG.debug("Selenium {} WebDriver selected.", driverType);
+driver.manage().timeouts().pageLoadTimeout(pageLoadWait,
TimeUnit.SECONDS);
driver.get(url);
-new WebDriverWait(driver, pageLoadWait);
} catch (Exception e) {
-throw new RuntimeException(e);
- }
+ if(e instanceof TimeoutException) {
--- End diff --
ACK. I have fixed this in PR #100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nutch pull request: fix for NUTCH-2241 contributed by karanjeets
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/nutch/pull/98#discussion_r57676029
--- Diff:
src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
---
@@ -112,11 +126,16 @@ public static WebDriver getDriverForPage(String url,
Configuration conf) {
}
LOG.debug("Selenium {} WebDriver selected.", driverType);
+driver.manage().timeouts().pageLoadTimeout(pageLoadWait,
TimeUnit.SECONDS);
driver.get(url);
-new WebDriverWait(driver, pageLoadWait);
} catch (Exception e) {
-throw new RuntimeException(e);
- }
+ if(e instanceof TimeoutException) {
--- End diff --
@karanjeets please always use the Eclipse code format
https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nutch pull request: fix for NUTCH-2241 contributed by karanjeets
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/nutch/pull/98#discussion_r57676028
--- Diff:
src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
---
@@ -112,11 +126,16 @@ public static WebDriver getDriverForPage(String url,
Configuration conf) {
}
LOG.debug("Selenium {} WebDriver selected.", driverType);
+driver.manage().timeouts().pageLoadTimeout(pageLoadWait,
TimeUnit.SECONDS);
driver.get(url);
-new WebDriverWait(driver, pageLoadWait);
} catch (Exception e) {
-throw new RuntimeException(e);
- }
+ if(e instanceof TimeoutException) {
--- End diff --
@karanjeets please always use the Eclipse code format
https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nutch pull request: fix for NUTCH-2241 contributed by karanjeets
Github user asfgit closed the pull request at: https://github.com/apache/nutch/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nutch pull request: fix for NUTCH-2241 contributed by karanjeets
GitHub user karanjeets opened a pull request: https://github.com/apache/nutch/pull/98 fix for NUTCH-2241 contributed by karanjeets You can merge this pull request into a Git repository by running: $ git pull https://github.com/karanjeets/nutch NUTCH-2241 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nutch/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit 230693d6dc648f587e88e59817eea934166c9247 Author: Karanjeet Singh Date: 2016-03-19T23:55:40Z fix for NUTCH-2241 contributed by karanjeets --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
