[GitHub] nutch pull request #143: NUTCH-2302 RAMConfManager Could Be Constructed With...

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nutch/pull/143


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nutch pull request #143: NUTCH-2302 RAMConfManager Could Be Constructed With...

2016-08-20 Thread lewismc
Github user lewismc commented on a diff in the pull request:

https://github.com/apache/nutch/pull/143#discussion_r75582137
  
--- Diff: src/java/org/apache/nutch/api/impl/RAMConfManager.java ---
@@ -42,6 +42,10 @@ public RAMConfManager() {
 configurations.put(ConfigResource.DEFAULT, 
NutchConfiguration.create());
   }
 
+  public RAMConfManager(String confId, Configuration configuration) {
--- End diff --

Javadoc on all public methods please. Can you update all of the code you've 
proposed so far with Javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---