[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117240#comment-13117240
]
Markus Jelsma commented on NUTCH-1078:
--
This patch makes me happy, i can see the exception in the fetcher again. Bring
it in!
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Blocker
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch, NUTCH-1078-trunk-20110929.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117863#comment-13117863
]
Hudson commented on NUTCH-1078:
---
Integrated in Nutch-trunk #1619 (See
[https://builds.apache.org/job/Nutch-trunk/1619/])
commit to address NUTCH-1078 and update to changes.txt
lewismc :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1177290
Files :
* /nutch/trunk/CHANGES.txt
* /nutch/trunk/src/java/org/apache/nutch/util/LogUtil.java
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Blocker
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch, NUTCH-1078-trunk-20110929.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116308#comment-13116308
]
Julien Nioche commented on NUTCH-1078:
--
I had modified LogUtil in 2.0 (see
http://svn.apache.org/viewvc/nutch/branches/nutchgora/src/java/org/apache/nutch/util/LogUtil.java?view=markup).
A simple option would be to copy the version from 2.0 to trunk but getting rid
of it altogether is fine too. Let's go for whatever is quickest, we can't have
the trunk broken like this
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Blocker
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116357#comment-13116357
]
Lewis John McGibbney commented on NUTCH-1078:
-
OK I will be working on this later today and will hopefully have a patch sorted
for tonight. Thanks
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Blocker
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114816#comment-13114816
]
Lewis John McGibbney commented on NUTCH-1078:
-
is there any preference to how we are to address the recent issues as
highlighted above? If we can get some ideas out then I can get cracking with a
patch. Thanks
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113298#comment-13113298
]
Lewis John McGibbney commented on NUTCH-1078:
-
yes Markus I'll address this ASAP, thanks.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113328#comment-13113328
]
Lewis John McGibbney commented on NUTCH-1078:
-
This is a pretty tricky case of the following
{code}
only messages of type String are supported
If one of your log statements contains a non-string object as its sole
parameter, you will have to manually add a toString() method call on the object.
For example,
logger.debug(new Object());
has to be manually re-written as
logger.debug(new Object().toString());
{code}
There are quite a few examples of this in fetcher.java I'll start working my
way through them and get a patch submitted later today Markus.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113338#comment-13113338
]
Markus Jelsma commented on NUTCH-1078:
--
Mmm, when i look at the stack trace it seems it's a problem with lib-http's
getProtocolOutput call's to LogUtil.getErrorStream()
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113567#comment-13113567
]
Lewis John McGibbney commented on NUTCH-1078:
-
OK so this kinda opened up a couple of avenues. I am interested to see how we
review and act on this one. Having discussed our problem with some slf4j users,
the following seems to sum up the options.
--
The problem has to do with how LogUtil is implemented.
Here are two possible solutions.
1) Get rid of the LogUtil class. For example, in HttpBase, instead of
{code}
} catch (Throwable e) {
e.printStackTrace(LogUtil.getErrorStream(logger));
return new ProtocolOutput(null, new ProtocolStatus(e));
}
{code}
write instead
{code}
} catch (Throwable e) {
logger.error(Failed to get protocol output, e);
return new ProtocolOutput(null, new ProtocolStatus(e));
}
{code}
This latter form is the standard way of logging exceptions and this is the
format some other Nutch code uses. I noticed this when I was creating the
various patches.
We would need to repeat the above operation in all places where LogUtil is
used. There are about 60 such places located in about a dozen classes.
2) In LogUtil, replace
{code}
static {
try {
TRACE=Logger.class.getMethod(trace, new Class[] { Object.class });
DEBUG=Logger.class.getMethod(debug, new Class[] { Object.class });
INFO=Logger.class.getMethod(info, new Class[] { Object.class });
} catch ...
}
}
{code}
with
{code}
static {
try {
TRACE=Logger.class.getMethod(trace, new Class[] {String.class});
DEBUG=Logger.class.getMethod(debug, new Class[] {String.class});
INFO=Logger.class.getMethod(info, new Class[] {String.class});
} catch ...
}
}
{code}
On line 104 change
{code}
method.invoke(logger, new Object[] {toString().trim() });
{code}
to
{code}
method.invoke(logger, new String[] {toString().trim() });
{code}
Further to this, a suggestion was raised that unless there is a good reason not
to, it might be an idea to get rid of LogUtil in from the Nutch code base
altogether as it seems like a very convoluted way for logging exceptions. I
(and the kind folks from slf4j who I spoke with) by no means understand every
aspect of why we currently use LogUtil, therefore I really need some opinions
from you guys to sort this one out. Thanks
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112600#comment-13112600
]
Markus Jelsma commented on NUTCH-1078:
--
Push it in Lewis! I'll fix whatever breaks here :)
cheers
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112664#comment-13112664
]
Markus Jelsma commented on NUTCH-1078:
--
Cheers! Only had to recommit the CHANGELOG entry for NUTCH-1115 which was
committed a few houts ago.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112857#comment-13112857
]
Markus Jelsma commented on NUTCH-1078:
--
This one also pops up in the fetcher:
{code}
2011-09-22 19:44:26,929 ERROR org.apache.nutch.util.LogUtil: Cannot init log
methods
java.lang.NoSuchMethodException: org.slf4j.Logger.trace(java.lang.Object)
at java.lang.Class.getMethod(Class.java:1605)
at org.apache.nutch.util.LogUtil.clinit(LogUtil.java:48)
at
org.apache.nutch.protocol.http.api.HttpBase.getProtocolOutput(HttpBase.java:197)
at org.apache.nutch.fetcher.Fetcher$FetcherThread.run(Fetcher.java:665)
{code}
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108751#comment-13108751
]
Lewis John McGibbney commented on NUTCH-1078:
-
Hi Sami, please see NUTCH-1091, which I opened. I think this is the next move
to drop it completely, however I think there might be couple of issue here and
there.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108975#comment-13108975
]
Sami Siren commented on NUTCH-1078:
---
Oh, ok. I didn't realize there was another issue open about removing those.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107906#comment-13107906
]
Lewis John McGibbney commented on NUTCH-1078:
-
Any further comments on this one please.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch,
NUTCH-1078-branch-1.4-20110916-v4.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106060#comment-13106060
]
Markus Jelsma commented on NUTCH-1078:
--
Ah, the org.apache.nutch.tools.Benchmark fails. All others patches seem to
work, even with my local changes.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106068#comment-13106068
]
Lewis John McGibbney commented on NUTCH-1078:
-
thank you Markus. I noticed that some classes failed between my eclipse and
when testing locally. I'll get another patch submitted and sort this out.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4
Attachments: NUTCH-1078-branch-1.4-20110816.patch,
NUTCH-1078-branch-1.4-20110824-v2.patch,
NUTCH-1078-branch-1.4-20110911-v3.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13085766#comment-13085766
]
Lewis John McGibbney commented on NUTCH-1078:
-
This issue is inherently large to deal with and it would need to be phased in
my opinion. Almost every class we maintain contains commons logging imports and
usage. Ultimately it would mean that we could drop a couple project
dependencies from runtime if implemented fully across the whole Nutch code base.
I know that this is pretty vague but does anyone have ideas for progressing...
it was not my intention to unearth quite this large a task. Thanks
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4, 2.0
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4, 2.0
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4
and trunk 2.0 respectively.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13085769#comment-13085769
]
Markus Jelsma commented on NUTCH-1078:
--
hmm, you could try to find/replace the imports in the whole project tree. I
don't really expect problems (ahum).
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4, 2.0
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4, 2.0
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4
and trunk 2.0 respectively.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13085771#comment-13085771
]
Julien Nioche commented on NUTCH-1078:
--
slf4j has a library that can do the conversion automatically. That's what I
used for the trunk
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4, 2.0
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4, 2.0
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4
and trunk 2.0 respectively.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13085789#comment-13085789
]
Markus Jelsma commented on NUTCH-1078:
--
Strange:
{code}
[javac]
/home/markus/projects/apache/nutch/branches/branch-1.4/src/java/org/apache/nutch/fetcher/Fetcher.java:531:
cannot find symbol
[javac] symbol : method fatal(java.lang.String,java.io.IOException)
[javac] location: interface org.slf4j.Logger
[javac] LOG.fatal(QueueFeeder error reading input, record
+ cnt, e);
[javac] ^
[javac]
/home/markus/projects/apache/nutch/branches/branch-1.4/src/java/org/apache/nutch/fetcher/Fetcher.java:788:
cannot find symbol
[javac] symbol : method isFatalEnabled()
[javac] location: interface org.slf4j.Logger
[javac] if (LOG.isFatalEnabled()) {
{code}
A lot of errors about these two fatal methods.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4, 2.0
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4, 2.0
Attachments: NUTCH-1078-branch-1.4-20110816.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)
[
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13085792#comment-13085792
]
Lewis John McGibbney commented on NUTCH-1078:
-
Thanks Markus. I will get this sorted out and submit a new patch in due course.
In addition I'll ensure that the two points mentioned above are also addressed.
Upgrade all instances of commons logging to slf4j (with log4j backend)
--
Key: NUTCH-1078
URL: https://issues.apache.org/jira/browse/NUTCH-1078
Project: Nutch
Issue Type: Improvement
Affects Versions: 1.4, 2.0
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Priority: Minor
Fix For: 1.4, 2.0
Attachments: NUTCH-1078-branch-1.4-20110816.patch
Whilst working on another issue, I noticed that some classes still import and
use commons logging for example HttpBase.java
{code}
import java.util.*;
// Commons Logging imports
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
// Nutch imports
import org.apache.nutch.crawl.CrawlDatum;
{code}
At this stage I am unsure how many (if any others) still import and reply
upon commons logging, however they should be upgraded to slf4j for branch-1.4.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
