[jira] [Commented] (NUTCH-2146) hashCode on the Outlink class
[
https://issues.apache.org/jira/browse/NUTCH-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983558#comment-14983558
]
Hudson commented on NUTCH-2146:
---
SUCCESS: Integrated in Nutch-trunk #3299 (See
[https://builds.apache.org/job/Nutch-trunk/3299/])
Fix for NUTCH-2146 hashCode on the Outlink class contributed by Jorge Luis
Betancourt this closes #79. (mattmann:
[http://svn.apache.org/viewvc/nutch/trunk/?view=rev&rev=1711561])
* trunk/CHANGES.txt
* trunk/src/java/org/apache/nutch/parse/Outlink.java
* trunk/src/plugin/index-links/src/test/org/apache/nutch/parse
* trunk/src/plugin/index-links/src/test/org/apache/nutch/parse/TestOutlinks.java
> hashCode on the Outlink class
> -
>
> Key: NUTCH-2146
> URL: https://issues.apache.org/jira/browse/NUTCH-2146
> Project: Nutch
> Issue Type: Bug
> Components: parser
>Affects Versions: 1.10, 1.11
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Chris A. Mattmann
>Priority: Minor
> Fix For: 1.11
>
>
> The {{Outlink}} class doesn't have a {{hashCode}} method. This doesn't cause
> any trouble with the already implemented plugins but if a developer tries to
> use a {{HashSet}} of outlinks in a custom plugin the {{Outlink}} instances
> with same data (toUrl, anchor) gets added several times. In contrast the
> {{Inlink}} class does have a {{hashCode}} method:
> https://github.com/apache/nutch/blob/trunk/src/java/org/apache/nutch/crawl/Inlink.java#L75-L77.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (NUTCH-2146) hashCode on the Outlink class
[
https://issues.apache.org/jira/browse/NUTCH-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983415#comment-14983415
]
ASF GitHub Bot commented on NUTCH-2146:
---
Github user asfgit closed the pull request at:
https://github.com/apache/nutch/pull/79
> hashCode on the Outlink class
> -
>
> Key: NUTCH-2146
> URL: https://issues.apache.org/jira/browse/NUTCH-2146
> Project: Nutch
> Issue Type: Bug
> Components: parser
>Affects Versions: 1.10, 1.11
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Chris A. Mattmann
>Priority: Minor
> Fix For: 1.11
>
>
> The {{Outlink}} class doesn't have a {{hashCode}} method. This doesn't cause
> any trouble with the already implemented plugins but if a developer tries to
> use a {{HashSet}} of outlinks in a custom plugin the {{Outlink}} instances
> with same data (toUrl, anchor) gets added several times. In contrast the
> {{Inlink}} class does have a {{hashCode}} method:
> https://github.com/apache/nutch/blob/trunk/src/java/org/apache/nutch/crawl/Inlink.java#L75-L77.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (NUTCH-2146) hashCode on the Outlink class
[
https://issues.apache.org/jira/browse/NUTCH-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983402#comment-14983402
]
Chris A. Mattmann commented on NUTCH-2146:
--
Going to commit this shortly.
> hashCode on the Outlink class
> -
>
> Key: NUTCH-2146
> URL: https://issues.apache.org/jira/browse/NUTCH-2146
> Project: Nutch
> Issue Type: Bug
> Components: parser
>Affects Versions: 1.10, 1.11
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Chris A. Mattmann
>Priority: Minor
> Fix For: 1.11
>
>
> The {{Outlink}} class doesn't have a {{hashCode}} method. This doesn't cause
> any trouble with the already implemented plugins but if a developer tries to
> use a {{HashSet}} of outlinks in a custom plugin the {{Outlink}} instances
> with same data (toUrl, anchor) gets added several times. In contrast the
> {{Inlink}} class does have a {{hashCode}} method:
> https://github.com/apache/nutch/blob/trunk/src/java/org/apache/nutch/crawl/Inlink.java#L75-L77.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (NUTCH-2146) hashCode on the Outlink class
[
https://issues.apache.org/jira/browse/NUTCH-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965934#comment-14965934
]
Jorge Luis Betancourt Gonzalez commented on NUTCH-2146:
---
For instance a simple JUnit test
https://github.com/jorgelbg/nutch/blob/NUTCH-2146/src/plugin/index-links/src/test/org/apache/nutch/parse/TestOutlinks.java#L40-L53
that fails with the current implementation of the {{Outlink}} class
> hashCode on the Outlink class
> -
>
> Key: NUTCH-2146
> URL: https://issues.apache.org/jira/browse/NUTCH-2146
> Project: Nutch
> Issue Type: Bug
> Components: parser
>Affects Versions: 1.10, 1.11
>Reporter: Jorge Luis Betancourt Gonzalez
>Priority: Minor
>
> The {{Outlink}} class doesn't have a {{hashCode}} method. This doesn't cause
> any trouble with the already implemented plugins but if a developer tries to
> use a {{HashSet}} of outlinks in a custom plugin the {{Outlink}} instances
> with same data (toUrl, anchor) gets added several times. In contrast the
> {{Inlink}} class does have a {{hashCode}} method:
> https://github.com/apache/nutch/blob/trunk/src/java/org/apache/nutch/crawl/Inlink.java#L75-L77.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
