[jira] [Commented] (NUTCH-2284) Basic Authentication Support for REST API
[ https://issues.apache.org/jira/browse/NUTCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364960#comment-15364960 ] Hudson commented on NUTCH-2284: --- SUCCESS: Integrated in Nutch-nutchgora #1563 (See [https://builds.apache.org/job/Nutch-nutchgora/1563/]) NUTCH-2284 Basic Authentication support for Nutch 2.X REST API. (furkankamaci: rev 52ffc5a983f261570fd25f10f2f8fcf70d543c88) * conf/nutch-default.xml * src/java/org/apache/nutch/api/NutchServer.java NUTCH-2284 Javadoc is updated to explain how to use Basic (furkankamaci: rev fc2b80f595c684cdabe07e115001ebd24c185981) * src/java/org/apache/nutch/api/NutchServer.java NUTCH-2284 Typo is fixed at restapi.auth property's description. (furkankamaci: rev 6a82525dba62bf1d67582dc272727675e6fb113a) * conf/nutch-default.xml NUTCH-2284 HTML escape characters are used at javadoc. (furkankamaci: rev 4d1e9e31395091f1677388feaed6f6f3fd6d6cd3) * src/java/org/apache/nutch/api/NutchServer.java NUTCH-2284 nutch-default.xml descriptions for restapi.auth.username and (furkankamaci: rev 8e2552e88999d19a599844559a9c646b62fb) * conf/nutch-default.xml > Basic Authentication Support for REST API > - > > Key: NUTCH-2284 > URL: https://issues.apache.org/jira/browse/NUTCH-2284 > Project: Nutch > Issue Type: Sub-task > Components: REST_api, web gui >Reporter: Furkan KAMACI >Assignee: Furkan KAMACI > Fix For: 2.4 > > > Add Basic Authentication for Nutch REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NUTCH-2284) Basic Authentication Support for REST API
[ https://issues.apache.org/jira/browse/NUTCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364945#comment-15364945 ] ASF GitHub Bot commented on NUTCH-2284: --- Github user asfgit closed the pull request at: https://github.com/apache/nutch/pull/124 > Basic Authentication Support for REST API > - > > Key: NUTCH-2284 > URL: https://issues.apache.org/jira/browse/NUTCH-2284 > Project: Nutch > Issue Type: Sub-task > Components: REST_api, web gui >Reporter: Furkan KAMACI >Assignee: Furkan KAMACI > Fix For: 2.4 > > > Add Basic Authentication for Nutch REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NUTCH-2284) Basic Authentication Support for REST API
[
https://issues.apache.org/jira/browse/NUTCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360539#comment-15360539
]
ASF GitHub Bot commented on NUTCH-2284:
---
Github user kamaci commented on a diff in the pull request:
https://github.com/apache/nutch/pull/124#discussion_r69391391
--- Diff: src/java/org/apache/nutch/api/NutchServer.java ---
@@ -85,7 +88,12 @@
* well as the logging granularity. If the latter option is not provided
via
* {@link org.apache.nutch.api.NutchServer#main(String[])} then it
defaults to
* 'INFO' however best attempts should always be made to specify a
logging
- * level.
+ * level.
+ * {@link org.apache.nutch.api.NutchServer} can be run as secure.
restapi.auth property
+ * should be set to true at nutch-site.xml to enable HTTP
basic authentication
--- End diff --
@lewismc does using > and < is enough? I couldn't see any
documentation related to it?
> Basic Authentication Support for REST API
> -
>
> Key: NUTCH-2284
> URL: https://issues.apache.org/jira/browse/NUTCH-2284
> Project: Nutch
> Issue Type: Sub-task
> Components: REST_api, web gui
>Reporter: Furkan KAMACI
>Assignee: Furkan KAMACI
> Fix For: 2.5
>
>
> Add Basic Authentication for Nutch REST API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (NUTCH-2284) Basic Authentication Support for REST API
[ https://issues.apache.org/jira/browse/NUTCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360507#comment-15360507 ] ASF GitHub Bot commented on NUTCH-2284: --- Github user kamaci commented on a diff in the pull request: https://github.com/apache/nutch/pull/124#discussion_r69390563 --- Diff: conf/nutch-default.xml --- @@ -1435,4 +1435,30 @@ + + restapi.auth + false + +Whether to enable HTTP basic authentication for communicating with RESTAPI. +Use the restapi.auth.username and restapi.auth.auth.password properties to configure --- End diff -- @lewismc I've fixed typo. > Basic Authentication Support for REST API > - > > Key: NUTCH-2284 > URL: https://issues.apache.org/jira/browse/NUTCH-2284 > Project: Nutch > Issue Type: Sub-task > Components: REST_api, web gui >Reporter: Furkan KAMACI >Assignee: Furkan KAMACI > Fix For: 2.5 > > > Add Basic Authentication for Nutch REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NUTCH-2284) Basic Authentication Support for REST API
[
https://issues.apache.org/jira/browse/NUTCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351530#comment-15351530
]
ASF GitHub Bot commented on NUTCH-2284:
---
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/nutch/pull/124#discussion_r68629674
--- Diff: src/java/org/apache/nutch/api/NutchServer.java ---
@@ -85,7 +88,12 @@
* well as the logging granularity. If the latter option is not provided
via
* {@link org.apache.nutch.api.NutchServer#main(String[])} then it
defaults to
* 'INFO' however best attempts should always be made to specify a
logging
- * level.
+ * level.
+ * {@link org.apache.nutch.api.NutchServer} can be run as secure.
restapi.auth property
+ * should be set to true at nutch-site.xml to enable HTTP
basic authentication
--- End diff --
In JDK 1.8 I think the relevnt HTML encoding should be used e.g.
nutch-site.xml
> Basic Authentication Support for REST API
> -
>
> Key: NUTCH-2284
> URL: https://issues.apache.org/jira/browse/NUTCH-2284
> Project: Nutch
> Issue Type: Sub-task
> Components: REST_api, web gui
>Reporter: Furkan KAMACI
>Assignee: Furkan KAMACI
> Fix For: 2.5
>
>
> Add Basic Authentication for Nutch REST API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (NUTCH-2284) Basic Authentication Support for REST API
[ https://issues.apache.org/jira/browse/NUTCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351528#comment-15351528 ] ASF GitHub Bot commented on NUTCH-2284: --- Github user lewismc commented on a diff in the pull request: https://github.com/apache/nutch/pull/124#discussion_r68629394 --- Diff: conf/nutch-default.xml --- @@ -1435,4 +1435,30 @@ + + restapi.auth + false + +Whether to enable HTTP basic authentication for communicating with RESTAPI. +Use the restapi.auth.username and restapi.auth.auth.password properties to configure --- End diff -- Typo in restapi.auth.auth.password it should be restapi.auth.password > Basic Authentication Support for REST API > - > > Key: NUTCH-2284 > URL: https://issues.apache.org/jira/browse/NUTCH-2284 > Project: Nutch > Issue Type: Sub-task > Components: REST_api, web gui >Reporter: Furkan KAMACI >Assignee: Furkan KAMACI > Fix For: 2.5 > > > Add Basic Authentication for Nutch REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NUTCH-2284) Basic Authentication Support for REST API
[ https://issues.apache.org/jira/browse/NUTCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342693#comment-15342693 ] ASF GitHub Bot commented on NUTCH-2284: --- GitHub user kamaci opened a pull request: https://github.com/apache/nutch/pull/124 NUTCH-2284 Basic Authentication support for Nutch 2.X REST API. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kamaci/nutch NUTCH-2284 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nutch/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 commit 52ffc5a983f261570fd25f10f2f8fcf70d543c88 Author: Furkan KAMACI Date: 2016-06-19T20:27:15Z NUTCH-2284 Basic Authentication support for Nutch 2.X REST API. > Basic Authentication Support for REST API > - > > Key: NUTCH-2284 > URL: https://issues.apache.org/jira/browse/NUTCH-2284 > Project: Nutch > Issue Type: Sub-task > Components: REST_api, web gui >Reporter: Furkan KAMACI >Assignee: Furkan KAMACI > Fix For: 2.5 > > > Add Basic Authentication for Nutch REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
