[jira] [Commented] (NUTCH-2661) Move TestOutlinks to the proper path

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/NUTCH-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653781#comment-16653781
 ] 

ASF GitHub Bot commented on NUTCH-2661:
---

jorgelbg opened a new pull request #399: NUTCH-2661 Move the TestOutlinks class 
into the o.a.n.parse path
URL: https://github.com/apache/nutch/pull/399
 
 
   This test covers the specific case of the comparison betwen 2 identical 
`Outlink` instances. Because this is not `index-links` specific I'm moving the 
test class into the core parse tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move TestOutlinks to the proper path
> 
>
> Key: NUTCH-2661
> URL: https://issues.apache.org/jira/browse/NUTCH-2661
> Project: Nutch
>  Issue Type: Improvement
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Jorge Luis Betancourt Gonzalez
>Priority: Trivial
> Fix For: 1.16
>
>
> Initially, I placed the {{TestOutlinks}} class in the index-links plugin, 
> although this was when I found the bug with the {{hashCode}}. Now I realised 
> that this test is best to have in the {{test/org/apache/nutch/nutch/parse}} 
> directory. 
> Even more because since this test is not covering any plugin-specific code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2661) Move TestOutlinks to the proper path

2018-10-17 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/NUTCH-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653876#comment-16653876
 ] 

ASF GitHub Bot commented on NUTCH-2661:
---

sebastian-nagel commented on issue #399: NUTCH-2661 Move the TestOutlinks class 
into the o.a.n.parse path
URL: https://github.com/apache/nutch/pull/399#issuecomment-430710838
 
 
   +1 that's the right location


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move TestOutlinks to the proper path
> 
>
> Key: NUTCH-2661
> URL: https://issues.apache.org/jira/browse/NUTCH-2661
> Project: Nutch
>  Issue Type: Improvement
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Jorge Luis Betancourt Gonzalez
>Priority: Trivial
> Fix For: 1.16
>
>
> Initially, I placed the {{TestOutlinks}} class in the index-links plugin, 
> although this was when I found the bug with the {{hashCode}}. Now I realised 
> that this test is best to have in the {{test/org/apache/nutch/nutch/parse}} 
> directory. 
> Even more because since this test is not covering any plugin-specific code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2661) Move TestOutlinks to the proper path

2018-10-23 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/NUTCH-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661199#comment-16661199
 ] 

ASF GitHub Bot commented on NUTCH-2661:
---

jorgelbg closed pull request #399: NUTCH-2661 Move the TestOutlinks class into 
the o.a.n.parse path
URL: https://github.com/apache/nutch/pull/399
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/plugin/index-links/src/test/org/apache/nutch/parse/TestOutlinks.java 
b/src/test/org/apache/nutch/parse/TestOutlinks.java
similarity index 100%
rename from 
src/plugin/index-links/src/test/org/apache/nutch/parse/TestOutlinks.java
rename to src/test/org/apache/nutch/parse/TestOutlinks.java


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move TestOutlinks to the proper path
> 
>
> Key: NUTCH-2661
> URL: https://issues.apache.org/jira/browse/NUTCH-2661
> Project: Nutch
>  Issue Type: Improvement
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Jorge Luis Betancourt Gonzalez
>Priority: Trivial
> Fix For: 1.16
>
>
> Initially, I placed the {{TestOutlinks}} class in the index-links plugin, 
> although this was when I found the bug with the {{hashCode}}. Now I realised 
> that this test is best to have in the {{test/org/apache/nutch/nutch/parse}} 
> directory. 
> Even more because since this test is not covering any plugin-specific code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2661) Move TestOutlinks to the proper path

2018-10-23 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/NUTCH-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661261#comment-16661261
 ] 

Hudson commented on NUTCH-2661:
---

FAILURE: Integrated in Jenkins build Nutch-trunk #3576 (See 
[https://builds.apache.org/job/Nutch-trunk/3576/])
NUTCH-2661 Move the TestOutlinks class into the o.a.n.parse path 
(jorge-luis.betancourt: 
[https://github.com/apache/nutch/commit/c8fcb78890df4e917a1d36ae945a1e01e02c0c78])
* (delete) 
src/plugin/index-links/src/test/org/apache/nutch/parse/TestOutlinks.java
* (add) src/test/org/apache/nutch/parse/TestOutlinks.java


> Move TestOutlinks to the proper path
> 
>
> Key: NUTCH-2661
> URL: https://issues.apache.org/jira/browse/NUTCH-2661
> Project: Nutch
>  Issue Type: Improvement
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Jorge Luis Betancourt Gonzalez
>Priority: Trivial
> Fix For: 1.16
>
>
> Initially, I placed the {{TestOutlinks}} class in the index-links plugin, 
> although this was when I found the bug with the {{hashCode}}. Now I realised 
> that this test is best to have in the {{test/org/apache/nutch/nutch/parse}} 
> directory. 
> Even more because since this test is not covering any plugin-specific code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2661) Move TestOutlinks to the proper path

2018-11-15 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/NUTCH-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687800#comment-16687800
 ] 

Hudson commented on NUTCH-2661:
---

FAILURE: Integrated in Jenkins build Nutch-trunk #3589 (See 
[https://builds.apache.org/job/Nutch-trunk/3589/])
NUTCH-2661 Move the TestOutlinks class into the o.a.n.parse path (snagel: 
[https://github.com/apache/nutch/commit/2d48152db0d032a58ea2324e8b40b6c5c48d7cd6])
* (add) src/test/org/apache/nutch/parse/TestOutlinks.java
* (delete) 
src/plugin/index-links/src/test/org/apache/nutch/parse/TestOutlinks.java


> Move TestOutlinks to the proper path
> 
>
> Key: NUTCH-2661
> URL: https://issues.apache.org/jira/browse/NUTCH-2661
> Project: Nutch
>  Issue Type: Improvement
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Jorge Luis Betancourt Gonzalez
>Priority: Trivial
> Fix For: 1.16
>
>
> Initially, I placed the {{TestOutlinks}} class in the index-links plugin, 
> although this was when I found the bug with the {{hashCode}}. Now I realised 
> that this test is best to have in the {{test/org/apache/nutch/nutch/parse}} 
> directory. 
> Even more because since this test is not covering any plugin-specific code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)