Re: Usrsocktest app example fails
The semaphore assertion look like the memory corrruption(maybe the stack too small) which platform you are running. On Sat, Feb 22, 2020 at 6:52 PM Oleg Evseev wrote: > > Hi Xiang, > > I can check it only on Monday, thanks! > > But, by the way, in commits you mentioned several errors in usrsocktest > that looks different than on my first screenshot (especially debug > assertion failed somewhere inside semaphore). Maybe there will still be > problems due to my wrong settings. Will see after checking this PR. > In any case, thanks for your time and support! > > сб, 22 февр. 2020 г. в 13:38, Xiang Xiao : > > > Oleg, try this PR: > > https://github.com/apache/incubator-nuttx/pull/354 > > with Masayuki and my patch, all test in usrsocktest should pass now. > > Actually, all fail is very minor: > > 1.Set the different errno > > 2.Foget to check NULL pointer > > 3.Don't zero the sockaddr padding bytes > > ,usrsock work well very even without these patch. > > > > On Fri, Feb 21, 2020 at 4:17 PM Oleg Evseev wrote: > > > > > > Hi Masayuki, > > > > > > Thanks for the work! Looking forward to new PRs. > > > > > > пт, 21 февр. 2020 г. в 08:42, Ishikawa, Masayuki (SHES) < > > > masayuki.ishik...@sony.com>: > > > > > > > Hi, Oleg, > > > > > > > > > > > > > > > > Though I am not an author of the code, > > > > > > > > I found a couple of bugs both usrsocktest and nuttx. > > > > > > > > I will send PRs later. > > > > > > > > > > > > > > > > Regards, > > > > > > > > Masayuki > > > > > > > > > > > > > > > > > >
Re: Build is broken
On Sat, Feb 22, 2020 at 9:59 PM David Sidrane wrote: > Hmm - what value is a 24 hr cycle time? The build was broken and we did > not know it. > > > Yes, the nightly build run every 24hr, because apache server is shared by many project and each jenkins job may wait in the queue for several hours. > How about getting actions wired against a set of container that can build > nuttx target without pulling tools? > > several > > Then run 9-10 separate build on EVERY PR > > 3 arm linux > > 3 non arm linux > > 1 windows arm > > 1 windows mac > > 1 sim linux > > > > Then get the badge on the PRs > > > Yes, this is what precheck build will do. To leverage both apache and github resource, we will have two type of build: 1.The nightly build run every 24hr on apache server which build all Linux buildable config and will include daily test in the furture. 2.The precheck build run for each PR automatically which do: a.Run checkpatch.sh against all modified files b.Run selected config on Ubuntu And should include the following in the furtue: a.Check the copyright b.Spell check c.Run selected config on Windows(Cygwin, Msys2, Native) b.Run selected config on macOS Since github allow us start maximum 20 VMs at the same time so the precheck build most likely could finsih within 30m if we carefully distribute all config/host on VMs. > It will look like this: > > > Yes, this will come in the next couple day, the maintainter can merge PR only when the green mark show up, and shouldn't do any modification in pr branch to avoid bypass the precheck system and then break the build potentially. Any change the maintainer want need talk in PR and let the contributor update the PR to trigger the precheck again. > And add the [![Build Status] to the README.md > > > > > > > > > > -Original Message- > From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] > Sent: Friday, February 21, 2020 9:55 PM > To: dev@nuttx.apache.org > Subject: Re: Build is broken > > > > On Sat, Feb 22, 2020 at 12:58 AM Nathan Hartman > > wrote: > > > > > > On Fri, Feb 21, 2020 at 11:21 AM David Sidrane > > > wrote: > > > > > > > This is what I did: > > > > > > > > For apps and nuttx git fetch nuttx > > > > For apps and nuttx git checkout master > > > > For apps and nuttx git reset -hard nuttx/master > > > > > > > > make distclean > > > > ./tools/configure.sh imxrt1060-evk:nsh > > > > make oldconfig > > > > make > > > > > > > > The results are as shown. > > > > > > > > Why are we changed the build system without testing on braches? > > > > > > > > > We should be testing build system changes a bit more carefully. In > addition > > > I think the CI system is supposed to do this as well (nightly?) Has that > > > gone "live" yet? > > > > > > > Haitao has scheduled apache Jenkins nightly build several weeks ago, > > here is the recent output: > > https://builds.apache.org/job/NuttX-Nightly-Build/38/display/redirect > > In these weeks, Haitao and I already made many change to improve the > > build system and integrate our build system with apache/github > > infrastructure. > > The parellel build is the last issue which block we enable the nightly > > and preheck build, so please either fix yamt's patch or take our > > method ASAP: > > https://github.com/apache/incubator-nuttx-apps/pull/87 > > https://github.com/apache/incubator-nuttx-apps/pull/83 > > > > Here has more backgournd info: > > https://github.com/apache/incubator-nuttx/pull/102 > > > > > Thanks for catching this quickly. > > > > > > Nathan >
RE: Build is broken
Hmm - what value is a 24 hr cycle time? The build was broken and we did not know it. How about getting actions wired against a set of container that can build nuttx target without pulling tools? Then run 9-10 separate build on EVERY PR 3 arm linux 3 non arm linux 1 windows arm 1 windows mac 1 sim linux Then get the badge on the PRs It will look like this: And add the [![Build Status] to the README.md -Original Message- From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] Sent: Friday, February 21, 2020 9:55 PM To: dev@nuttx.apache.org Subject: Re: Build is broken On Sat, Feb 22, 2020 at 12:58 AM Nathan Hartman wrote: > > On Fri, Feb 21, 2020 at 11:21 AM David Sidrane > wrote: > > > This is what I did: > > > > For apps and nuttx git fetch nuttx > > For apps and nuttx git checkout master > > For apps and nuttx git reset -hard nuttx/master > > > > make distclean > > ./tools/configure.sh imxrt1060-evk:nsh > > make oldconfig > > make > > > > The results are as shown. > > > > Why are we changed the build system without testing on braches? > > > We should be testing build system changes a bit more carefully. In addition > I think the CI system is supposed to do this as well (nightly?) Has that > gone "live" yet? > Haitao has scheduled apache Jenkins nightly build several weeks ago, here is the recent output: https://builds.apache.org/job/NuttX-Nightly-Build/38/display/redirect In these weeks, Haitao and I already made many change to improve the build system and integrate our build system with apache/github infrastructure. The parellel build is the last issue which block we enable the nightly and preheck build, so please either fix yamt's patch or take our method ASAP: https://github.com/apache/incubator-nuttx-apps/pull/87 https://github.com/apache/incubator-nuttx-apps/pull/83 Here has more backgournd info: https://github.com/apache/incubator-nuttx/pull/102 > Thanks for catching this quickly. > > Nathan
Re: Usrsocktest app example fails
Hi Xiang, I can check it only on Monday, thanks! But, by the way, in commits you mentioned several errors in usrsocktest that looks different than on my first screenshot (especially debug assertion failed somewhere inside semaphore). Maybe there will still be problems due to my wrong settings. Will see after checking this PR. In any case, thanks for your time and support! сб, 22 февр. 2020 г. в 13:38, Xiang Xiao : > Oleg, try this PR: > https://github.com/apache/incubator-nuttx/pull/354 > with Masayuki and my patch, all test in usrsocktest should pass now. > Actually, all fail is very minor: > 1.Set the different errno > 2.Foget to check NULL pointer > 3.Don't zero the sockaddr padding bytes > ,usrsock work well very even without these patch. > > On Fri, Feb 21, 2020 at 4:17 PM Oleg Evseev wrote: > > > > Hi Masayuki, > > > > Thanks for the work! Looking forward to new PRs. > > > > пт, 21 февр. 2020 г. в 08:42, Ishikawa, Masayuki (SHES) < > > masayuki.ishik...@sony.com>: > > > > > Hi, Oleg, > > > > > > > > > > > > Though I am not an author of the code, > > > > > > I found a couple of bugs both usrsocktest and nuttx. > > > > > > I will send PRs later. > > > > > > > > > > > > Regards, > > > > > > Masayuki > > > > > > > > > > > > >
Re: Usrsocktest app example fails
Oleg, try this PR: https://github.com/apache/incubator-nuttx/pull/354 with Masayuki and my patch, all test in usrsocktest should pass now. Actually, all fail is very minor: 1.Set the different errno 2.Foget to check NULL pointer 3.Don't zero the sockaddr padding bytes ,usrsock work well very even without these patch. On Fri, Feb 21, 2020 at 4:17 PM Oleg Evseev wrote: > > Hi Masayuki, > > Thanks for the work! Looking forward to new PRs. > > пт, 21 февр. 2020 г. в 08:42, Ishikawa, Masayuki (SHES) < > masayuki.ishik...@sony.com>: > > > Hi, Oleg, > > > > > > > > Though I am not an author of the code, > > > > I found a couple of bugs both usrsocktest and nuttx. > > > > I will send PRs later. > > > > > > > > Regards, > > > > Masayuki > > > > > > > >
