[jira] Closed: (OFBIZ-225) Discussion about the interaction between order total promotions and sales taxes
[ https://issues.apache.org/jira/browse/OFBIZ-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-225. - Resolution: Fixed Fix Version/s: SVN trunk Thanks Amit good work, Your patch is in trunk revision 606777. In my 1st attempt I forgot that I had set Y to include promos in taxes in 2 tax autorithies and not only one. Discussion about the interaction between order total promotions and sales taxes --- Key: OFBIZ-225 URL: https://issues.apache.org/jira/browse/OFBIZ-225 Project: OFBiz Issue Type: Wish Components: order Reporter: Jacopo Cappellato Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-225.patch, OFBIZ-225.patch Bug is sales tax adj when there is a promotion applied to the order total. I've set up a promotion, 10% applied to the order total, and a sales tax, 20%. When I create the order, a sales tax adjustment is attached to every order item without considering the promotion (20%) that is applied to the order total. For an example, see the attached picture: the order item subtotal is $500, the sales tax adj (20%) is $100 (!), even if there is a promotion for the order total (50$). All CommentsWork LogChange History Sort Order: [navigator.ascending.order] Comment by David E. Jones [09/Aug/05 10:34 AM] [ Permlink ] This is an interesting issue, and has been around for a while. The main problem is that sales tax is calculated per-item and not per-order, so the adjustments go on each item. For order discounts the only way I can think of to handle them is to pro-rate the discount over each order item based on that item's value relative to the total value of the order. I guess that's not being done now... Anyone have any other ideas? -David Comment by Jacopo Cappellato [09/Aug/05 01:02 PM] [ Permlink ] My proposal: we could leave everything as is now and at the end we could add a new negative sales tax adjustment to compensate the total sales tax amount. Does it make sense? Comment by Si Chen [09/Aug/05 01:16 PM] [ Permlink ] This is not necessarily a bug. Some stores don't give you a promotion on the pre-tax amount. One solution is to change the promotion's description to say it is a discount on the after-tax amount. If we want to add a discount on the pre-tax amount, I think David's suggestion is right. Maybe we should calculate the order item adjustments, all the promotions, order totals. Then calculate the total tax on the order. Then use the order item's value / order total to pro-rate the tax against each item. The reason we don't want to add a separate item is if someone returns one of the items, it'll be very hard to track down the effect of returning an item if the adjustments and taxes aren't kept together. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1256) Send mail through gmail with the javamail api in ofbiz
[
https://issues.apache.org/jira/browse/OFBIZ-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-1256.
--
Resolution: Fixed
Thanks Fabien and Chris,
I commited a refactored patch from Fabien and Chris's patch in trunk revision
606789 . Some other code reformating changes in this commit also.
Send mail through gmail with the javamail api in ofbiz
--
Key: OFBIZ-1256
URL: https://issues.apache.org/jira/browse/OFBIZ-1256
Project: OFBiz
Issue Type: New Feature
Components: content
Affects Versions: SVN trunk
Environment: All
Reporter: Fabien Carrion
Assignee: Jacques Le Roux
Priority: Minor
Fix For: SVN trunk
Attachments: emailssl_diff.patch, gmail.patch
This a small patch to accept ssl connections to smtp servers.
Index: content/src/org/ofbiz/content/email/EmailServices.java
===
--- content/src/org/ofbiz/content/email/EmailServices.java (revision
576503)
+++ content/src/org/ofbiz/content/email/EmailServices.java (working copy)
@@ -129,6 +129,8 @@
String sendFrom = (String) context.get(sendFrom);
String sendType = (String) context.get(sendType);
+String port = (String) context.get(port);
+String ssl = (String) context.get(ssl);
String sendVia = (String) context.get(sendVia);
String authUser = (String) context.get(authUser);
String authPass = (String) context.get(authPass);
@@ -151,6 +153,12 @@
if (authUser != null authUser.length() 0) {
useSmtpAuth = true;
}
+if (port == null || port.length() == 0) {
+port = UtilProperties.getPropertyValue(general.properties,
mail.smtp.port, 25);
+}
+if (ssl == null || ssl.length() == 0) {
+ssl = UtilProperties.getPropertyValue(general.properties,
mail.smtp.ssl, javax.net.ssl.SSLSocketFactory);
+}
} else if (sendVia == null) {
return ServiceUtil.returnError(Parameter sendVia is required
when sendType is not mail.smtp.host);
}
@@ -168,6 +176,14 @@
try {
Properties props = System.getProperties();
props.put(sendType, sendVia);
+ if (port != null port.length() 0) {
+ props.put(mail.smtp.port, port);
+ props.put(mail.smtp.socketFactory.port, port);
+ }
+ if (ssl != null ssl.length() 0) {
+ props.put(mail.smtp.socketFactory.class, ssl);
+ props.put(mail.smtp.socketFactory.fallback, false);
+ }
if (useSmtpAuth) {
props.put(mail.smtp.auth, true);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Proposal of guidelines for the creation of Jira issues
+1 Bilgin -- View this message in context: http://www.nabble.com/Proposal-of-guidelines-for-the-creation-of-Jira-issues-tp14476701p14495316.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] Commented: (OFBIZ-1154) Black list is not working
[ https://issues.apache.org/jira/browse/OFBIZ-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554340 ] Bilgin Ibryam commented on OFBIZ-1154: -- Hi Jacques, Thanks for the reminder. I will take care of it, very soon! Black list is not working - Key: OFBIZ-1154 URL: https://issues.apache.org/jira/browse/OFBIZ-1154 Project: OFBiz Issue Type: Bug Components: ecommerce, order Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk, Release Branch 4.0 Attachments: blacklist.patch Hi guys, I want to ask what is the purpose of Black list in ofbiz and how should it really work? I tried to use it and found that it is not working at all. 1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem. 2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message. In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think? 3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types. 4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1499) When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
[ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-1499. Resolution: Fixed Thank Sumit. Your patch is in trunk revision 606792. Please, next time add references for commiters to the jira issue, and create the patch as ready for commit when possible :) When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total. Key: OFBIZ-1499 URL: https://issues.apache.org/jira/browse/OFBIZ-1499 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Sumit Pandit Assignee: Bilgin Ibryam Priority: Trivial Fix For: SVN trunk Attachments: surveyProduct.patch, surveyProduct.patch, surveyProduct.patch 1) Set surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml) 2) Pass surveyResponseId with inMap in calculateProductPrice method (PriceServices.java) Thanks to Anil Patel Sumit Porwal for helping me in implementing this changes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1424) ShoppingCart.addToCart event for different kind of products
[ https://issues.apache.org/jira/browse/OFBIZ-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554345 ] Bilgin Ibryam commented on OFBIZ-1424: -- Any opinions? May I commit this? ShoppingCart.addToCart event for different kind of products --- Key: OFBIZ-1424 URL: https://issues.apache.org/jira/browse/OFBIZ-1424 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: addToCart.patch Trying to add products only by productId cause errors for configurable, rental and virtual products. You can see this in Order Manager (if you choose this type of product from lookup and try to add to cart) . In eccomerce this error appears, if you use add 1 to cart links from Last Products menu for example. Actually addToCart event only dispatch products with CART_ADD surveys to survey screen, and returns error for configurable, rental or virtual products, w/o giving a possibility to the user to entering the needed information in the next step. So i added some checks to addToCart event , and if the product is not ready for adding to cart, return the product page, where the user can configure product (if product is configurable), enter booking info (for ASSET_USAGE products) or choose a variant product (if product is virtual). Any ideas for better handling these kind of situations? Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r606794 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java
Thanks Bilgin, Just before commiting I used the automatic refactoring option in Eclipse but it ended in a mess (adding a loot of import java.util classes in place of import java.util.* for instance). So I reverted this part, forgeting the Security call I added previously on Chris's advice. Don't worry it's well tested, I sent myself a message using Gmail and received it. Jacques From: [EMAIL PROTECTED] URL: http://svn.apache.org/viewvc?rev=606794view=rev Log: Added the missing import for r606789. Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794r1=606793r2=606794view=diff == --- ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java (original) +++ ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Tue Dec 25 07:30:14 2007 @@ -59,6 +59,7 @@ import java.net.URL; import java.sql.Timestamp; import java.util.*; +import java.security.Security; /** * Email Services
[jira] Assigned: (OFBIZ-1495) Aggregate items base price is displayed yet unattainable
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-1495: Assignee: Bilgin Ibryam Aggregate items base price is displayed yet unattainable Key: OFBIZ-1495 URL: https://issues.apache.org/jira/browse/OFBIZ-1495 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Chris Lombardi Assignee: Bilgin Ibryam Priority: Minor I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there. Configurable PC PC001 Your Price: $50.00 Hey, 50$ for a PC, I want one! So I click on the item. Configurable PC PC001 Product Aggregated Price: $385.00 What? So, whatever is being called for the price of a PC001 should probably report the price of the default configuration, not the price of the unconfigured product that you can't buy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1495) Aggregate items base price is displayed yet unattainable
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1495: - Attachment: totalPrice.patch Is this patch ok for the issue? Aggregate items base price is displayed yet unattainable Key: OFBIZ-1495 URL: https://issues.apache.org/jira/browse/OFBIZ-1495 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Chris Lombardi Assignee: Bilgin Ibryam Priority: Minor Attachments: totalPrice.patch I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there. Configurable PC PC001 Your Price: $50.00 Hey, 50$ for a PC, I want one! So I click on the item. Configurable PC PC001 Product Aggregated Price: $385.00 What? So, whatever is being called for the price of a PC001 should probably report the price of the default configuration, not the price of the unconfigured product that you can't buy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-82) Support for product catalogs in ordermgr order entry
[ https://issues.apache.org/jira/browse/OFBIZ-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-82. -- Resolution: Fixed Fix Version/s: SVN trunk Committed in trunk rev. 606797 Si, if the initial purpose of the issue is not fulfilled by this commit, i will reopen this issue. Support for product catalogs in ordermgr order entry Key: OFBIZ-82 URL: https://issues.apache.org/jira/browse/OFBIZ-82 Project: OFBiz Issue Type: New Feature Components: order Reporter: Si Chen Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: catalog.patch Currently the ordermgr's order entry is basically getting the first available prodCatalogId by using the CatalogWorker.getCurrentCatalogId(request) method. We should change the initial order entry screen to show a list of available catalogs for this product and also change the add items to order to get a list of available catalogs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Import libraries was svn commit: r606794 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java
side note, if you have a large library that does not get implemented like java.util.* using the individual calls saves memory. it is a trade off between load speed and memory usage. Jacques Le Roux sent the following on 12/25/2007 8:54 AM: Thanks Bilgin, Just before commiting I used the automatic refactoring option in Eclipse but it ended in a mess (adding a loot of import java.util classes in place of import java.util.* for instance). So I reverted this part, forgeting the Security call I added previously on Chris's advice. Don't worry it's well tested, I sent myself a message using Gmail and received it. Jacques From: [EMAIL PROTECTED] URL: http://svn.apache.org/viewvc?rev=606794view=rev Log: Added the missing import for r606789. Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794r1=606793r2=606794view=diff == --- ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java (original) +++ ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Tue Dec 25 07:30:14 2007 @@ -59,6 +59,7 @@ import java.net.URL; import java.sql.Timestamp; import java.util.*; +import java.security.Security; /** * Email Services
[jira] Commented: (OFBIZ-1495) Aggregate items base price is displayed yet unattainable
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554355 ] Jacques Le Roux commented on OFBIZ-1495: It's ok for me : +1 Aggregate items base price is displayed yet unattainable Key: OFBIZ-1495 URL: https://issues.apache.org/jira/browse/OFBIZ-1495 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Chris Lombardi Assignee: Bilgin Ibryam Priority: Minor Attachments: totalPrice.patch I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there. Configurable PC PC001 Your Price: $50.00 Hey, 50$ for a PC, I want one! So I click on the item. Configurable PC PC001 Product Aggregated Price: $385.00 What? So, whatever is being called for the price of a PC001 should probably report the price of the default configuration, not the price of the unconfigured product that you can't buy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
re: svn commit 574709
track-stats (renamed later track-serverhit) isn't an initiated
parameter by default so therefore only works when the individual
webapps web.xml contains the variable track-serverhit. Shouldn't there
be a config setting somewhere to set this globally and then overridden
by individual webapp preferences? ServerHit db logging should be the
show all tools of a default checkout.
---
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ControlServlet.java
2007/09/11 22:00:36 574708
+++
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ControlServlet.java
2007/09/11 22:09:40 574709
@@ -281,7 +281,11 @@
try {
UtilHttp.setInitialRequestInfo(request);
VisitHandler.getVisitor(request, response);
-ServerHitBin.countRequest(webappName + . + rname,
request, requestStartTime, System.currentTimeMillis() -
requestStartTime, userLogin, delegator);
+if (requestHandler.trackStats(request)) {
+ServerHitBin.countRequest(webappName + . +
rname, request, requestStartTime, System.currentTimeMillis() -
requestStartTime, userLogin, delegator);
+} else {
+Debug.log(Track status is disabled for this
request);
+}
} catch (Throwable t) {
Debug.logError(t, Error in ControlServlet saving
ServerHit/Bin information; the output was successful, but can't save
this tracking information. The error was: + t.toString(), module);
}
[jira] Commented: (OFBIZ-1424) ShoppingCart.addToCart event for different kind of products
[ https://issues.apache.org/jira/browse/OFBIZ-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554354 ] Jacques Le Roux commented on OFBIZ-1424: I like it : +1 ShoppingCart.addToCart event for different kind of products --- Key: OFBIZ-1424 URL: https://issues.apache.org/jira/browse/OFBIZ-1424 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: addToCart.patch Trying to add products only by productId cause errors for configurable, rental and virtual products. You can see this in Order Manager (if you choose this type of product from lookup and try to add to cart) . In eccomerce this error appears, if you use add 1 to cart links from Last Products menu for example. Actually addToCart event only dispatch products with CART_ADD surveys to survey screen, and returns error for configurable, rental or virtual products, w/o giving a possibility to the user to entering the needed information in the next step. So i added some checks to addToCart event , and if the product is not ready for adding to cart, return the product page, where the user can configure product (if product is configurable), enter booking info (for ASSET_USAGE products) or choose a variant product (if product is virtual). Any ideas for better handling these kind of situations? Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r606807 - in /ofbiz/trunk/applications/ecommerce: build.xml src/org/ofbiz/ecommerce/misc/ThirdPartyEvents.java
I wrote From Java complier message [javac] Note: Recompile with -Xlint:unchecked for details. I tried to use it in eCommerce and corrected ThirdPartyEvents.java I wonder now if we should not use it everywhere. Personnally I think we should, what do you think, are we ready ? I believe it should not be to hard to deal with it, but I did not try yet... After having a look at the POS component, I'm finally not sure that it's a good idea. OK, we will have clean java 1.5+ code but this also adds a lot of syntaxic sugar w/o a lot of valuable returns (our code is already safe). Jacques
Re: Import libraries was svn commit: r606794 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java
Thanks for the explanation. Jacques Le Roux sent the following on 12/25/2007 12:17 PM: My main motivation was to change as less as possible code, to make reviews easier... Jacques - Original Message - From: BJ Freeman [EMAIL PROTECTED] To: dev@ofbiz.apache.org Sent: Tuesday, December 25, 2007 8:27 PM Subject: Re: Import libraries was svn commit: r606794 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java side note, if you have a large library that does not get implemented like java.util.* using the individual calls saves memory. it is a trade off between load speed and memory usage. Jacques Le Roux sent the following on 12/25/2007 8:54 AM: Thanks Bilgin, Just before commiting I used the automatic refactoring option in Eclipse but it ended in a mess (adding a loot of import java.util classes in place of import java.util.* for instance). So I reverted this part, forgeting the Security call I added previously on Chris's advice. Don't worry it's well tested, I sent myself a message using Gmail and received it. Jacques From: [EMAIL PROTECTED] URL: http://svn.apache.org/viewvc?rev=606794view=rev Log: Added the missing import for r606789. Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794r1=606793r2=606794view=diff == --- ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java (original) +++ ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Tue Dec 25 07:30:14 2007 @@ -59,6 +59,7 @@ import java.net.URL; import java.sql.Timestamp; import java.util.*; +import java.security.Security; /** * Email Services
Re: Import libraries was svn commit: r606794 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java
My main motivation was to change as less as possible code, to make reviews easier... Jacques - Original Message - From: BJ Freeman [EMAIL PROTECTED] To: dev@ofbiz.apache.org Sent: Tuesday, December 25, 2007 8:27 PM Subject: Re: Import libraries was svn commit: r606794 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java side note, if you have a large library that does not get implemented like java.util.* using the individual calls saves memory. it is a trade off between load speed and memory usage. Jacques Le Roux sent the following on 12/25/2007 8:54 AM: Thanks Bilgin, Just before commiting I used the automatic refactoring option in Eclipse but it ended in a mess (adding a loot of import java.util classes in place of import java.util.* for instance). So I reverted this part, forgeting the Security call I added previously on Chris's advice. Don't worry it's well tested, I sent myself a message using Gmail and received it. Jacques From: [EMAIL PROTECTED] URL: http://svn.apache.org/viewvc?rev=606794view=rev Log: Added the missing import for r606789. Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Modified: ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java?rev=606794r1=606793r2=606794view=diff == --- ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java (original) +++ ofbiz/trunk/applications/content/src/org/ofbiz/content/email/EmailServices.java Tue Dec 25 07:30:14 2007 @@ -59,6 +59,7 @@ import java.net.URL; import java.sql.Timestamp; import java.util.*; +import java.security.Security; /** * Email Services
[jira] Updated: (OFBIZ-1382) Setup Folder to make Configuration easier.
[ https://issues.apache.org/jira/browse/OFBIZ-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-1382: -- Attachment: Setup.zip This version has one menu completed to show how it works. click on Setup Tab then Do setups for the Applications then SetupProduct then SetupWebsite you will see the website setup page /content/control/EditWebSite you notice that is ask for product Store in the page. so this SetupWebsite menu would be grayed out till the Product Store setup was done. any other setup code wold not be in the Setup folder. the setup code would be in the app folder it was meant for. if others wish to put some time on this or just list the setup page you are aware of I will put them in. Setup Folder to make Configuration easier. -- Key: OFBIZ-1382 URL: https://issues.apache.org/jira/browse/OFBIZ-1382 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: svn 591598 Reporter: BJ Freeman Priority: Minor Fix For: SVN trunk Attachments: Setup.zip New application to pull all setup functions into one area. The menus and screens only organize the configuration and setup that already exist. might add some service to validate all configurations that are changed are valid in the future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1382) Setup Folder to make Configuration easier.
[ https://issues.apache.org/jira/browse/OFBIZ-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-1382: -- Attachment: (was: Setup.zip) Setup Folder to make Configuration easier. -- Key: OFBIZ-1382 URL: https://issues.apache.org/jira/browse/OFBIZ-1382 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: svn 591598 Reporter: BJ Freeman Priority: Minor Fix For: SVN trunk Attachments: Setup.zip New application to pull all setup functions into one area. The menus and screens only organize the configuration and setup that already exist. might add some service to validate all configurations that are changed are valid in the future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is displayed yet unattainable
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554358 ] Chris Lombardi commented on OFBIZ-1495: --- This was taking me a while because I was thinking about how to implement it. The patch addresses the display issue in the web application, but doesn't address my issue of how to handle the default price in the POS application. I had done some digging and found PriceServices.java in production\applications\product\src\org\ofbiz\product\price and thought that might be a place to handle it once instead of implementing it everywhere the price is displayed. Comments anyone? Aggregate items base price is displayed yet unattainable Key: OFBIZ-1495 URL: https://issues.apache.org/jira/browse/OFBIZ-1495 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Chris Lombardi Assignee: Bilgin Ibryam Priority: Minor Attachments: totalPrice.patch I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there. Configurable PC PC001 Your Price: $50.00 Hey, 50$ for a PC, I want one! So I click on the item. Configurable PC PC001 Product Aggregated Price: $385.00 What? So, whatever is being called for the price of a PC001 should probably report the price of the default configuration, not the price of the unconfigured product that you can't buy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554361 ] Jacques Le Roux commented on OFBIZ-880: --- I had a quick look at these 2 methods. Why are they deprecated ? Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. --- Key: OFBIZ-880 URL: https://issues.apache.org/jira/browse/OFBIZ-880 Project: OFBiz Issue Type: Improvement Components: order Reporter: Jacopo Cappellato Priority: Minor Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. It would be great to have this fixed before the upcoming release (volunteers?). Here is the list of the warnings: 13 warnings applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double updatedTotal = orh.getOrderGrandTotal(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double orderSubTotal = orh.getOrderItemsSubTotal(); applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated double shippingAmount =
[jira] Closed: (OFBIZ-1509) Allow for more status values for a task in the project.
[ https://issues.apache.org/jira/browse/OFBIZ-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-1509. -- Resolution: Fixed Fix Version/s: SVN trunk Allow for more status values for a task in the project. --- Key: OFBIZ-1509 URL: https://issues.apache.org/jira/browse/OFBIZ-1509 Project: OFBiz Issue Type: Improvement Components: projectmgr Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Currently the status values of a task in the workeffort manager only allow for : 'accepted' and 'completed' For a project Task this is not enough, we need to have an indication not only that the task is completed but for example is tested with another person. I would like to add another status called 'confirmed' to indicate that another authority has confirmed the task is really completed. The question is do we add this status to the workeffort manager or we create a new workEffortType only used in the project manager application? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1511) Create a project scheduler
[ https://issues.apache.org/jira/browse/OFBIZ-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-1511. -- Resolution: Fixed a first version has been implemented. Create a project scheduler -- Key: OFBIZ-1511 URL: https://issues.apache.org/jira/browse/OFBIZ-1511 Project: OFBiz Issue Type: New Feature Components: projectmgr Affects Versions: SVN trunk Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk A project scheduler is needed to create and revise planned dates of tasks in a project taking into account the available resources, required sequence of tasks and priorities and actual dates of already started tasks. This could also be used for the scheduling of a manufacturing run. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1544: -- Attachment: new_style_catalogs_products.patch This is a new patch for new style css to the catalogs and products forms. Feedback are welcome before commit this big patch, deprecated class has still to be removed from catalogs and products forms. Thanks Marco New Styles For Catalog application -- Key: OFBIZ-1544 URL: https://issues.apache.org/jira/browse/OFBIZ-1544 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Attachments: new_style_catalogs_products.patch, new_style_product.patch, new_style_product2.patch Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-266) Agreement terms shown and changeable on the order entry page
[ https://issues.apache.org/jira/browse/OFBIZ-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-266: --- Assignee: Jacopo Cappellato Agreement terms shown and changeable on the order entry page Key: OFBIZ-266 URL: https://issues.apache.org/jira/browse/OFBIZ-266 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Jacopo Cappellato Priority: Minor Make order (and agreement terms) selection available for sales as well as purchase orders. Put them on the order entry to the left in a box and make them changeable after initial selection. The prices set in the agreements (AgreementProductAppl) are already used in the sales order (if the agreement is selected during order init) but agreement terms are not considered. Maybe we could simply use the same AgreementTerm checkout screen that is available for the purchase orders. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1538) Recover shopping cart and email customer for feedback or support.
[ https://issues.apache.org/jira/browse/OFBIZ-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554380 ] Bilgin Ibryam commented on OFBIZ-1538: -- CartAbandonedLine entity could help you. Recover shopping cart and email customer for feedback or support. - Key: OFBIZ-1538 URL: https://issues.apache.org/jira/browse/OFBIZ-1538 Project: OFBiz Issue Type: New Feature Components: order Reporter: Rohit Sureka Hi, I would like to propose a new feature in the order manager and the ecommerce application. The feature should allow the sales manager or marketing officer of the company to recover the items in the shopping cart of a online shopper who did added the products to the cart and signed for an account on the website but for some reason did not complele the transaction. The officer shoufd be able to retrieve the carts in a list and must be able to see the items in each cart. He must then be able to send courtesy emails (from a template) to the selected customers, asking for feedback on the shopping experience and/or offering any help/support the customer might need to complete the transaction. I believe this to be a very useful feature and help to business improve its customer-care and at the same time increase the conversions. Any ideas and suggestions of this is welcome. Thanks, Rohit -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
