[jira] Created: (OFBIZ-1750) Online user help link icon
Online user help link icon
--
Key: OFBIZ-1750
URL: https://issues.apache.org/jira/browse/OFBIZ-1750
Project: OFBiz
Issue Type: New Feature
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Bruno Busco
I have implemented an on-line help linking system the you can find in the
attached patch (help_links.patch) and preview in help_links.jpg.
This is a short description of how it works.
I have added a link-url property to the container tag. Now it is possible to
write something like:
property-map resource=ProjectMgrUiHelpUrls map-name=uiHelpUrlsMap
global=true/
...
container style=screenlet
help-url=${uiHelpUrlsMap.ProjectManagerApplicationRoles}
When such a property is specified the container is rendered with a textual ?
that contains an href to an help page url.
I have included in the patch also a modified maincss.css file that shows a more
beatifull yellow icon like you can see in the preview.
I have done some thinking about how to build the help urls with the following
requirements:
1) Should be possible to change the whole help site used with a single
modification in one file
2) Different help urls should be used depending on th locale
To implement this I added the HelpUrls.xml resource file that in in the
framework and defines the following keys:
- helpurls.prefix = the first part of every help url
- helpurls.suffix = the last part of every help url
- helpurls.hint = a string that is displayed when the mouse is moved on the
help icon
All these keys are translated in urls and strings that are (or can be) specific
to the selected locale. I this way it is possible for example to have the
different languages help pages located on different sites (changing the
helpurl.prefix) or it is possible to have an help system that provides
different language help based on parameter attached to the url (something like
?language=it or similar)
The final url attached to the icon is made of the prefix, the container
specific help-url and the suffix
Even the container specific help-url could conveniently be taken from a
resource file so that a change in the help system pages should require only the
resource file modification and not all the screens.
I have included in the patch a single modified screen that uses the help links.
This is one of the Project Manager Application that is available at this link:
https://localhost:8443/projectmgr/control/MyTasks
Could you please review the system?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1750) Online user help link icon
[
https://issues.apache.org/jira/browse/OFBIZ-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Busco updated OFBIZ-1750:
---
Attachment: help_links.jpg
help_links.patch
Online user help link icon
--
Key: OFBIZ-1750
URL: https://issues.apache.org/jira/browse/OFBIZ-1750
Project: OFBiz
Issue Type: New Feature
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Bruno Busco
Attachments: help_links.jpg, help_links.patch
I have implemented an on-line help linking system the you can find in the
attached patch (help_links.patch) and preview in help_links.jpg.
This is a short description of how it works.
I have added a link-url property to the container tag. Now it is possible
to write something like:
property-map resource=ProjectMgrUiHelpUrls map-name=uiHelpUrlsMap
global=true/
...
container style=screenlet
help-url=${uiHelpUrlsMap.ProjectManagerApplicationRoles}
When such a property is specified the container is rendered with a textual
? that contains an href to an help page url.
I have included in the patch also a modified maincss.css file that shows a
more beatifull yellow icon like you can see in the preview.
I have done some thinking about how to build the help urls with the following
requirements:
1) Should be possible to change the whole help site used with a single
modification in one file
2) Different help urls should be used depending on th locale
To implement this I added the HelpUrls.xml resource file that in in the
framework and defines the following keys:
- helpurls.prefix = the first part of every help url
- helpurls.suffix = the last part of every help url
- helpurls.hint = a string that is displayed when the mouse is moved on the
help icon
All these keys are translated in urls and strings that are (or can be)
specific to the selected locale. I this way it is possible for example to
have the different languages help pages located on different sites (changing
the helpurl.prefix) or it is possible to have an help system that provides
different language help based on parameter attached to the url (something
like ?language=it or similar)
The final url attached to the icon is made of the prefix, the container
specific help-url and the suffix
Even the container specific help-url could conveniently be taken from a
resource file so that a change in the help system pages should require only
the resource file modification and not all the screens.
I have included in the patch a single modified screen that uses the help
links. This is one of the Project Manager Application that is available at
this link:
https://localhost:8443/projectmgr/control/MyTasks
Could you please review the system?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Linking OFBIZ to the on-line help system
OK, I have worked a little bit on this and came to a solution that I have submitted here: https://issues.apache.org/jira/browse/OFBIZ-1750 Please review and eventually integrate! -Bruno 2008/4/12, Bruno Busco [EMAIL PROTECTED]: Ooops, I have resolved. I was modifying the renderScreenletBegin function instead of the renderContainerBegin function. Now I can continue on my road-map... -Bruno 2008/4/12, Bruno Busco [EMAIL PROTECTED]: After the discussion we had in http://www.nabble.com/Loading-Raw-HTML-td16595109.html I am trying to modify ofbiz to optionally include a little help icon in the screenlet title bar. What I want to obtais is the possibility to specify for every container an help page link. I am not expert of Ofbiz and of Java too but I want use this as an exercize to grow my experience up. My roadmap is: 1 - add a little help icon image (help_yellow.gif) to ofbiz 2 - add a helpHomeUrl property in general.properies 3 - add a new helplink property to the container tag to let the programmer to link an help page to every single UI element. When the container is rendered the following HTML should be added in the container. a class=helpLink target=_ofbizhelp href=HELPURL img width=16 height=16 align=absmiddle title=Get online help about Using Ofbiz src=/images/help_yellow.gif/ /a Where HELPURL is a string obtained from the helpHomeUrl, the helplink property and perhaps the actual locale 4- add something in the main.css to make the little help icon displayed inline on the right of the container area So, after the trivial step 1, skipped step 2 for the moment, I started navigating the code to do step 3. I have seen that the screenlet container is someting that is built in two (at least) different ways in .ftl files and in screens.xml files. I have done it for a single .ftl file inserting the HTML code by hand but now I want to make it for the screens.xml files. I have tried to modify the HtmlScreenRenderer.java but I get no effect at all changing this file ant-building and the startofbizing. Could someone help me? -Bruno
[jira] Closed: (OFBIZ-1663) POS: All payment types allow change to be made
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1663. -- Resolution: Fixed Chris, So thanks to Scott I think it's clear now and I close it definitively. Please open a *new* issue if you think it's needed POS: All payment types allow change to be made Key: OFBIZ-1663 URL: https://issues.apache.org/jira/browse/OFBIZ-1663 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos Affects Versions: Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 4.0 Attachments: ofbiz-1663.patch I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction. I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales. Does anyone have any international scenarios that would not follow this rule? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r646132 - /ofbiz/trunk/applications/order/servicedef/services_cart.xml
Yes, 4 days after this seems pretty reasonnable... Jacques From: Scott Gray [EMAIL PROTECTED] +1 Scott On 13/04/2008, Jacopo Cappellato [EMAIL PROTECTED] wrote: No feedback on this? However, a committer should always be around to explain and provide further details if there are concerns or questions on his commits. Should we revert this commit? Jacopo On Apr 9, 2008, at 4:29 AM, David E Jones wrote: Actually, transactions ARE important for reading as well as writing, and should pretty much always be used. What was the problem you had that this change is supposed to solve? -David On Apr 8, 2008, at 5:21 PM, [EMAIL PROTECTED] wrote: Author: sichen Date: Tue Apr 8 16:21:14 2008 New Revision: 646132 URL: http://svn.apache.org/viewvc?rev=646132view=rev Log: turning off transactions for loading of cart from quote, since there does not seem to be any data being stored, and having a transaction consumes resources unnecessarily and could cause it to fail if there are many items on a quote Modified: ofbiz/trunk/applications/order/servicedef/services_cart.xml Modified: ofbiz/trunk/applications/order/servicedef/services_cart.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services_cart.xml?rev=646132r1=646131r2=646132view=diff == --- ofbiz/trunk/applications/order/servicedef/services_cart.xml (original) +++ ofbiz/trunk/applications/order/servicedef/services_cart.xml Tue Apr 8 16:21:14 2008 @@ -103,7 +103,7 @@ /service service name=loadCartFromQuote engine=java auth=true - location=org.ofbiz.order.shoppingcart.ShoppingCartServices invoke=loadCartFromQuote + location=org.ofbiz.order.shoppingcart.ShoppingCartServices invoke=loadCartFromQuote use-transaction=false descriptionCreate a ShoppingCart Object based on an existing quote. If applyQuoteAdjustments is set to false then standard cart adjustments are generated./description attribute name=quoteId type=String mode=IN optional=false/ attribute name=applyQuoteAdjustments type=String mode=IN optional=true/
[jira] Updated: (OFBIZ-1738) Add support for running one instance of OfBiz under Tomcat
[ https://issues.apache.org/jira/browse/OFBIZ-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ludovic Maître updated OFBIZ-1738: -- Attachment: ofbiz-tomcat-setup.zip Final version of the OfBiz Tomcat setup templates. Add support for running one instance of OfBiz under Tomcat -- Key: OFBIZ-1738 URL: https://issues.apache.org/jira/browse/OFBIZ-1738 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: Mac OS X 10.5.2, JDK 1.5.0_13 Reporter: Ludovic Maître Assignee: Jacques Le Roux Priority: Minor Attachments: ofbiz-tomcat-setup.zip, tomcat.zip Original Estimate: 8h Remaining Estimate: 8h This issue provide templates and patchs to run one instance of OfBiz under Tomcat. The templates are used to: - setup the classpath of Tomcat, (catalina.properties) - declare the ofbiz webapps in the server configuration The files generated from the templates, with the command 'java -jar ofbiz.jar -setup tomcat', should be copied in the $CATALINA_HOME/conf folder of Tomcat. IIRC there is also some setup to perform in the first loaded webapp, and a few other modifications in the code, i will digg into it this evening (French riviera time) and create a patch which will be added to this issue. (the full code is also published on my subversion server: http://forge.ubik-products.com/repositories/apache-ofbiz/trunk/ , but good luck to find the relveant parts :-)) Best regards, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1738) Add support for running one instance of OfBiz under Tomcat
[ https://issues.apache.org/jira/browse/OFBIZ-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588380#action_12588380 ] Ludovic Maître commented on OFBIZ-1738: --- Hi all, I've finished working on the Tomcat setup files. There is now 2 folders, one for Tomcat 5.5 (named tomcat55, validated with Tomcat 5.5.26) and another for Tomcat 6 (named tomcat6, validated wit Tomcat 6.0.16). Now the Tomcat server(s) use the Ofbiz SSL keystore. I've wrote a succinct documentation, should i or someone add it to the wiki ? How to run OfBiz under Tomcat Get OfBiz and Tomcat mkdir ofbiz-tomcat cd ofbiz-tomcat svn co http://svn.apache.org/repos/asf/ofbiz/trunk ofbiz wget http://apache.crihan.fr/dist/tomcat/tomcat-6/v6.0.16/bin/apache-tomcat-6.0.16.tar.gz tar -zxvf apache-tomcat-6.0.16.tar.gz Compile OfBiz cd ofbiz ant clean ant Generate Tomcat templates Tomcat 5.5: java -jar ofbiz.jar -setup tomcat55 Tomcat 6: java -jar ofbiz.jar -setup tomcat6 Install Tomcat templates in server configuration folder Tomcat 5: cd ../apache-tomcat-5.5.26 cp ../ofbiz/setup/tomcat55/catalina.sh ../ofbiz/setup/tomcat55/catalina.bat bin/ cp ../ofbiz/setup/tomcat55/catalina.properties ../ofbiz/setup/tomcat55/server.xml conf/ cd ../apache-tomcat-6.0.16 cp ../ofbiz/setup/tomcat6/catalina.sh ../ofbiz/setup/tomcat6/catalina.bat bin/ cp ../ofbiz/setup/tomcat6/catalina.properties ../ofbiz/setup/tomcat6/server.xml conf/ Run Tomcat ./bin/catalina.sh run Run a cluster of Tomcats As usual for a Tomcat (and OfBiz) cluster. Add support for running one instance of OfBiz under Tomcat -- Key: OFBIZ-1738 URL: https://issues.apache.org/jira/browse/OFBIZ-1738 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: Mac OS X 10.5.2, JDK 1.5.0_13 Reporter: Ludovic Maître Assignee: Jacques Le Roux Priority: Minor Attachments: ofbiz-tomcat-setup.zip, tomcat.zip Original Estimate: 8h Remaining Estimate: 8h This issue provide templates and patchs to run one instance of OfBiz under Tomcat. The templates are used to: - setup the classpath of Tomcat, (catalina.properties) - declare the ofbiz webapps in the server configuration The files generated from the templates, with the command 'java -jar ofbiz.jar -setup tomcat', should be copied in the $CATALINA_HOME/conf folder of Tomcat. IIRC there is also some setup to perform in the first loaded webapp, and a few other modifications in the code, i will digg into it this evening (French riviera time) and create a patch which will be added to this issue. (the full code is also published on my subversion server: http://forge.ubik-products.com/repositories/apache-ofbiz/trunk/ , but good luck to find the relveant parts :-)) Best regards, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Linking OFBIZ to the on-line help system
Bruno, I'll definitely look at your patch, thanks. An idea we could also consider is to use the screen name (or form name) to compose the name of the help page: in this way we could have a link tht points to an help page even if we don't specify the url in the screen's container (if the page is not available we could return a default page). There are pros and cons with this approach but it is definitely something we could consider. Jacopo On Apr 13, 2008, at 10:46 AM, Bruno Busco wrote: OK, I have worked a little bit on this and came to a solution that I have submitted here: https://issues.apache.org/jira/browse/OFBIZ-1750 Please review and eventually integrate! -Bruno 2008/4/12, Bruno Busco [EMAIL PROTECTED]: Ooops, I have resolved. I was modifying the renderScreenletBegin function instead of the renderContainerBegin function. Now I can continue on my road-map... -Bruno 2008/4/12, Bruno Busco [EMAIL PROTECTED]: After the discussion we had in http://www.nabble.com/Loading-Raw-HTML-td16595109.html I am trying to modify ofbiz to optionally include a little help icon in the screenlet title bar. What I want to obtais is the possibility to specify for every container an help page link. I am not expert of Ofbiz and of Java too but I want use this as an exercize to grow my experience up. My roadmap is: 1 - add a little help icon image (help_yellow.gif) to ofbiz 2 - add a helpHomeUrl property in general.properies 3 - add a new helplink property to the container tag to let the programmer to link an help page to every single UI element. When the container is rendered the following HTML should be added in the container. a class=helpLink target=_ofbizhelp href=HELPURL img width=16 height=16 align=absmiddle title=Get online help about Using Ofbiz src=/images/help_yellow.gif/ /a Where HELPURL is a string obtained from the helpHomeUrl, the helplink property and perhaps the actual locale 4- add something in the main.css to make the little help icon displayed inline on the right of the container area So, after the trivial step 1, skipped step 2 for the moment, I started navigating the code to do step 3. I have seen that the screenlet container is someting that is built in two (at least) different ways in .ftl files and in screens.xml files. I have done it for a single .ftl file inserting the HTML code by hand but now I want to make it for the screens.xml files. I have tried to modify the HtmlScreenRenderer.java but I get no effect at all changing this file ant-building and the startofbizing. Could someone help me? -Bruno
[jira] Commented: (OFBIZ-1750) Online user help link icon
[
https://issues.apache.org/jira/browse/OFBIZ-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588386#action_12588386
]
Jacopo Cappellato commented on OFBIZ-1750:
--
Bruno,
in the patch there are a lot of lines that have been modified just to remove
the spaces... even if I agree that we could commit this without harm, it makes
the review process harder... would it be possible for you to provide a new
patch?
Thanks
Online user help link icon
--
Key: OFBIZ-1750
URL: https://issues.apache.org/jira/browse/OFBIZ-1750
Project: OFBiz
Issue Type: New Feature
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Bruno Busco
Attachments: help_links.jpg, help_links.patch
I have implemented an on-line help linking system the you can find in the
attached patch (help_links.patch) and preview in help_links.jpg.
This is a short description of how it works.
I have added a link-url property to the container tag. Now it is possible
to write something like:
property-map resource=ProjectMgrUiHelpUrls map-name=uiHelpUrlsMap
global=true/
...
container style=screenlet
help-url=${uiHelpUrlsMap.ProjectManagerApplicationRoles}
When such a property is specified the container is rendered with a textual
? that contains an href to an help page url.
I have included in the patch also a modified maincss.css file that shows a
more beatifull yellow icon like you can see in the preview.
I have done some thinking about how to build the help urls with the following
requirements:
1) Should be possible to change the whole help site used with a single
modification in one file
2) Different help urls should be used depending on th locale
To implement this I added the HelpUrls.xml resource file that in in the
framework and defines the following keys:
- helpurls.prefix = the first part of every help url
- helpurls.suffix = the last part of every help url
- helpurls.hint = a string that is displayed when the mouse is moved on the
help icon
All these keys are translated in urls and strings that are (or can be)
specific to the selected locale. I this way it is possible for example to
have the different languages help pages located on different sites (changing
the helpurl.prefix) or it is possible to have an help system that provides
different language help based on parameter attached to the url (something
like ?language=it or similar)
The final url attached to the icon is made of the prefix, the container
specific help-url and the suffix
Even the container specific help-url could conveniently be taken from a
resource file so that a change in the help system pages should require only
the resource file modification and not all the screens.
I have included in the patch a single modified screen that uses the help
links. This is one of the Project Manager Application that is available at
this link:
https://localhost:8443/projectmgr/control/MyTasks
Could you please review the system?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1748) Menus styled with the menu-container-style button-bar tab-bar are not visible in IE 7.
[ https://issues.apache.org/jira/browse/OFBIZ-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Podejma updated OFBIZ-1748: - Attachment: maincss.css.patch With my patch menu-container-style button-bar tab-bar should be visible on IE7 Menus styled with the menu-container-style button-bar tab-bar are not visible in IE 7. - Key: OFBIZ-1748 URL: https://issues.apache.org/jira/browse/OFBIZ-1748 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Environment: IE 7 Reporter: Jacques Le Roux Attachments: maincss.css.patch See any sub-menu in Party for instance like at the page https://localhost:8443/partymgr/control/viewprofile?partyId=admin I found it at the page https://localhost:8443/projectmgr/control/login?projectId=9000 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588401#action_12588401 ] Enrique Ruibal commented on OFBIZ-1189: --- I think currently there is an issue with this default setting as the order is only approved (and completed) for a digital good if and only if it has been previously paid for, wich seems a bit odd compared to real business situations where a service order is just issued and paid for after a period of time has elapsed, there is a broad discussion here http://www.nabble.com/Can%27t-Approve-Orders-with-service-products-to16242722.html#a16659894 Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: David E. Jones Fix For: SVN trunk Attachments: order.patch, order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1751) IE browser scripting error when selecting variation
IE browser scripting error when selecting variation Key: OFBIZ-1751 URL: https://issues.apache.org/jira/browse/OFBIZ-1751 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Release Branch 4.0 Environment: IE 7.0.5730.11 Update version:0 Win XP home edition: v 5.1.2600 service pack 2 build 2600 Reporter: chris select giant widget product (WG-9943). then select a color in color combo box. Error is as follows: Line: 475 char: 13 Error: Invalid argument code: 0 URL: http://demo40.hotwaxmedia.com/ecommerce/control/product/~category_id=202/~product_id=WG-9943 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1716) POS: CVV2 code is not always deleted from the DB
[ https://issues.apache.org/jira/browse/OFBIZ-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588403#action_12588403 ] David E. Jones commented on OFBIZ-1716: --- The NSF retry stuff can be used for any order, but is mostly intended for automatic orders done through ShoppingLists. Either way, it totally depends on business policy and desired process. For CVV codes it doesn't matter anyway. You cannot store or in any way remember them beyond the time scope of the transaction they were entered for (and if it is split into auth and capture then that would be ONLY the auth part you can keep the code for). That means for ALL automatic retries you will not have the CVV code, and will not get the benefit of the discounted transaction fee for having the CVV code. That's the only real difference. Again, it's all a business decision to be made with an understanding of these sorts of constraints. Whatever is done OOTB in OFBiz needs to be changeable to different situations. Well, it is always changeable, but the goal is to make more common variations easier to configure. POS: CVV2 code is not always deleted from the DB Key: OFBIZ-1716 URL: https://issues.apache.org/jira/browse/OFBIZ-1716 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Critical I ran a transaction that was declined by the processor. I later noticed that the cvv2 code was still present in the database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1716) POS: CVV2 code is not always deleted from the DB
[ https://issues.apache.org/jira/browse/OFBIZ-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588410#action_12588410 ] Chris Lombardi commented on OFBIZ-1716: --- I'll fix it to delete the cvv and track2 information per DJ's comment. JLR, do you have any objections? POS: CVV2 code is not always deleted from the DB Key: OFBIZ-1716 URL: https://issues.apache.org/jira/browse/OFBIZ-1716 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Critical I ran a transaction that was declined by the processor. I later noticed that the cvv2 code was still present in the database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1746) Firefox view gantt chart bug
[ https://issues.apache.org/jira/browse/OFBIZ-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Podejma updated OFBIZ-1746: - Attachment: gantChart.ftl.patch Please review my second patch. I think it is fixed. I have tested with patch from OFBIZ-1748. Firefox view gantt chart bug Key: OFBIZ-1746 URL: https://issues.apache.org/jira/browse/OFBIZ-1746 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk Environment: Firefox 2.0.0.13 Reporter: Krzysztof Podejma Priority: Minor Fix For: SVN trunk Attachments: gantChart.ftl.patch, projMgrGanttFix.patch Original Estimate: 0.17h Remaining Estimate: 0.17h Chart is not created well under Firefox. Dates in gantChart.ftl have invalid format, proper format is /MM/dd HH:mm . See my patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1716) POS: CVV2 code is not always deleted from the DB
[ https://issues.apache.org/jira/browse/OFBIZ-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588417#action_12588417 ] Jacques Le Roux commented on OFBIZ-1716: Any objections this is fine with me POS: CVV2 code is not always deleted from the DB Key: OFBIZ-1716 URL: https://issues.apache.org/jira/browse/OFBIZ-1716 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Critical I ran a transaction that was declined by the processor. I later noticed that the cvv2 code was still present in the database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1750) Online user help link icon
[
https://issues.apache.org/jira/browse/OFBIZ-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Busco updated OFBIZ-1750:
---
Attachment: help_yellow.gif
help_links1.patch
Jacopo,
thank you for reviewing my patch.
I have attached a new patch (help_links1.patch) with the white spaces issue
fixed. This was due to my editor that is set to remove during file save all the
trailing spaces and my compare program was programmed to ignore difference in
white spaces. This is why I did not realize the wrong patch.
Now I have changed the setting in my tools and will not do the error again.
BTW reviewing the patch I discovered another stange behaviour...the little gif
file I added to my working directory has not been included in the patch (even
if I svn added it). I don't know how to fix this and so I attached this file in
the issue itself (help_yellow.gif).
Online user help link icon
--
Key: OFBIZ-1750
URL: https://issues.apache.org/jira/browse/OFBIZ-1750
Project: OFBiz
Issue Type: New Feature
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Bruno Busco
Attachments: help_links.jpg, help_links.patch, help_links1.patch,
help_yellow.gif
I have implemented an on-line help linking system the you can find in the
attached patch (help_links.patch) and preview in help_links.jpg.
This is a short description of how it works.
I have added a link-url property to the container tag. Now it is possible
to write something like:
property-map resource=ProjectMgrUiHelpUrls map-name=uiHelpUrlsMap
global=true/
...
container style=screenlet
help-url=${uiHelpUrlsMap.ProjectManagerApplicationRoles}
When such a property is specified the container is rendered with a textual
? that contains an href to an help page url.
I have included in the patch also a modified maincss.css file that shows a
more beatifull yellow icon like you can see in the preview.
I have done some thinking about how to build the help urls with the following
requirements:
1) Should be possible to change the whole help site used with a single
modification in one file
2) Different help urls should be used depending on th locale
To implement this I added the HelpUrls.xml resource file that in in the
framework and defines the following keys:
- helpurls.prefix = the first part of every help url
- helpurls.suffix = the last part of every help url
- helpurls.hint = a string that is displayed when the mouse is moved on the
help icon
All these keys are translated in urls and strings that are (or can be)
specific to the selected locale. I this way it is possible for example to
have the different languages help pages located on different sites (changing
the helpurl.prefix) or it is possible to have an help system that provides
different language help based on parameter attached to the url (something
like ?language=it or similar)
The final url attached to the icon is made of the prefix, the container
specific help-url and the suffix
Even the container specific help-url could conveniently be taken from a
resource file so that a change in the help system pages should require only
the resource file modification and not all the screens.
I have included in the patch a single modified screen that uses the help
links. This is one of the Project Manager Application that is available at
this link:
https://localhost:8443/projectmgr/control/MyTasks
Could you please review the system?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Linking OFBIZ to the on-line help system
Jacopo, yes the system could be improved. I think anyway that the one that I propose should be a good starting point. There is the possibility to attach an help page, if needed, to every single screenlet or even smaller container. -Bruno 2008/4/13, Jacopo Cappellato [EMAIL PROTECTED]: Bruno, I'll definitely look at your patch, thanks. An idea we could also consider is to use the screen name (or form name) to compose the name of the help page: in this way we could have a link tht points to an help page even if we don't specify the url in the screen's container (if the page is not available we could return a default page). There are pros and cons with this approach but it is definitely something we could consider. Jacopo On Apr 13, 2008, at 10:46 AM, Bruno Busco wrote: OK, I have worked a little bit on this and came to a solution that I have submitted here: https://issues.apache.org/jira/browse/OFBIZ-1750 Please review and eventually integrate! -Bruno 2008/4/12, Bruno Busco [EMAIL PROTECTED]: Ooops, I have resolved. I was modifying the renderScreenletBegin function instead of the renderContainerBegin function. Now I can continue on my road-map... -Bruno 2008/4/12, Bruno Busco [EMAIL PROTECTED]: After the discussion we had in http://www.nabble.com/Loading-Raw-HTML-td16595109.html I am trying to modify ofbiz to optionally include a little help icon in the screenlet title bar. What I want to obtais is the possibility to specify for every container an help page link. I am not expert of Ofbiz and of Java too but I want use this as an exercize to grow my experience up. My roadmap is: 1 - add a little help icon image (help_yellow.gif) to ofbiz 2 - add a helpHomeUrl property in general.properies 3 - add a new helplink property to the container tag to let the programmer to link an help page to every single UI element. When the container is rendered the following HTML should be added in the container. a class=helpLink target=_ofbizhelp href=HELPURL img width=16 height=16 align=absmiddle title=Get online help about Using Ofbiz src=/images/help_yellow.gif/ /a Where HELPURL is a string obtained from the helpHomeUrl, the helplink property and perhaps the actual locale 4- add something in the main.css to make the little help icon displayed inline on the right of the container area So, after the trivial step 1, skipped step 2 for the moment, I started navigating the code to do step 3. I have seen that the screenlet container is someting that is built in two (at least) different ways in .ftl files and in screens.xml files. I have done it for a single .ftl file inserting the HTML code by hand but now I want to make it for the screens.xml files. I have tried to modify the HtmlScreenRenderer.java but I get no effect at all changing this file ant-building and the startofbizing. Could someone help me? -Bruno
[jira] Closed: (OFBIZ-1748) Menus styled with the menu-container-style button-bar tab-bar are not visible in IE 7.
[ https://issues.apache.org/jira/browse/OFBIZ-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1748. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Krzysztof, This is indeed better, your patch is in trunk rev. 647632 . I did not see any bad effects in Firefox. Some things I noticed though in IE 7 (for instance at the page https://localhost:8443/partymgr/control/viewprofile?partyId=admin) . The buttons of the menu below the menu styled with the menu-container-style button-bar tab-bar have no lines at bottom . The Party Content screenlet shows some erratic behaviour (see Attach Content for instance) But anyway it's usable so I commited. If a CSS guru see how this could be solved, it would be welcome of course. Menus styled with the menu-container-style button-bar tab-bar are not visible in IE 7. - Key: OFBIZ-1748 URL: https://issues.apache.org/jira/browse/OFBIZ-1748 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Environment: IE 7 Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: maincss.css.patch See any sub-menu in Party for instance like at the page https://localhost:8443/partymgr/control/viewprofile?partyId=admin I found it at the page https://localhost:8443/projectmgr/control/login?projectId=9000 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1746) Firefox view gantt chart bug
[ https://issues.apache.org/jira/browse/OFBIZ-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588441#action_12588441 ] Jacques Le Roux commented on OFBIZ-1746: Thanks Krzysztof, I agree that it's a good improvement in IE 7 (chart in screenlet and not outside) and Firefox (tasks visible). But the chart is always imbricated (in Firefox and IE 7: ). To be commited yet. I would prefer that the persons who worked on the Project component review you work and amend it before. Firefox view gantt chart bug Key: OFBIZ-1746 URL: https://issues.apache.org/jira/browse/OFBIZ-1746 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk Environment: Firefox 2.0.0.13 Reporter: Krzysztof Podejma Priority: Minor Fix For: SVN trunk Attachments: gantChart.ftl.patch, projMgrGanttFix.patch Original Estimate: 0.17h Remaining Estimate: 0.17h Chart is not created well under Firefox. Dates in gantChart.ftl have invalid format, proper format is /MM/dd HH:mm . See my patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1209) Canceling rental product reservations (room booking)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1209: -- Assignee: Bilgin Ibryam (was: Jacques Le Roux) Sorry Bilgin, I did not realise that this issue was already assigned to you. I prefer to let you make the decision :o) Canceling rental product reservations (room booking) Key: OFBIZ-1209 URL: https://issues.apache.org/jira/browse/OFBIZ-1209 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: cancelRental.patch Hi all, This is an initial service for canceling rental product reservations, visible through fixed asset calendar. It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1716) POS: CVV2 code is not always deleted from the DB
[ https://issues.apache.org/jira/browse/OFBIZ-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lombardi updated OFBIZ-1716: -- Attachment: ofbiz-1716.patch I have to test this patch. POS: CVV2 code is not always deleted from the DB Key: OFBIZ-1716 URL: https://issues.apache.org/jira/browse/OFBIZ-1716 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Critical Attachments: ofbiz-1716.patch I ran a transaction that was declined by the processor. I later noticed that the cvv2 code was still present in the database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588474#action_12588474 ] David E. Jones commented on OFBIZ-1189: --- What you're describing is a difference between service products and digital products. A new indicator should be added to the ProductType entity to represent service products and the relevant code should be added or changed to look at this indicator and behave accordingly, just like we do for digital and physical goods (neither of which are service products). Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: David E. Jones Fix For: SVN trunk Attachments: order.patch, order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r646132 - /ofbiz/trunk/applications/order/servicedef/services_cart.xml
+1 from me on the revert as well (making it clear as it is only implied in my initial reply). -David On Apr 12, 2008, at 11:04 PM, Jacopo Cappellato wrote: No feedback on this? However, a committer should always be around to explain and provide further details if there are concerns or questions on his commits. Should we revert this commit? Jacopo On Apr 9, 2008, at 4:29 AM, David E Jones wrote: Actually, transactions ARE important for reading as well as writing, and should pretty much always be used. What was the problem you had that this change is supposed to solve? -David On Apr 8, 2008, at 5:21 PM, [EMAIL PROTECTED] wrote: Author: sichen Date: Tue Apr 8 16:21:14 2008 New Revision: 646132 URL: http://svn.apache.org/viewvc?rev=646132view=rev Log: turning off transactions for loading of cart from quote, since there does not seem to be any data being stored, and having a transaction consumes resources unnecessarily and could cause it to fail if there are many items on a quote Modified: ofbiz/trunk/applications/order/servicedef/services_cart.xml Modified: ofbiz/trunk/applications/order/servicedef/ services_cart.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services_cart.xml?rev=646132r1=646131r2=646132view=diff = = = = = = = = = = --- ofbiz/trunk/applications/order/servicedef/services_cart.xml (original) +++ ofbiz/trunk/applications/order/servicedef/services_cart.xml Tue Apr 8 16:21:14 2008 @@ -103,7 +103,7 @@ /service service name=loadCartFromQuote engine=java auth=true - location=org.ofbiz.order.shoppingcart.ShoppingCartServices invoke=loadCartFromQuote + location=org.ofbiz.order.shoppingcart.ShoppingCartServices invoke=loadCartFromQuote use-transaction=false descriptionCreate a ShoppingCart Object based on an existing quote. If applyQuoteAdjustments is set to false then standard cart adjustments are generated./description attribute name=quoteId type=String mode=IN optional=false/ attribute name=applyQuoteAdjustments type=String mode=IN optional=true/
