[jira] Commented: (OFBIZ-3390) The add address feature in order manager/order creation is broken

2010-01-16 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801164#action_12801164
 ] 

Jacques Le Roux commented on OFBIZ-3390:


Hi Scott,

When you create a sale order from the order manager with admin as customer 
(actually any customer without a postal address) and use Quick Finalise. Then 
you must create an address. In trunk you get an error. The problem is it's 
calling a CommonPartyDecorator that does not exist in ordermgr. I quickly/dirty 
tried to add it but then when you want to get back it does not work (missing an 
home for backHome request). In 9.04 you get to change the address but can't get 
back as well. Sorry I have no time to investigate further

Thanks



 The add address feature in order manager/order creation is broken
 -

 Key: OFBIZ-3390
 URL: https://issues.apache.org/jira/browse/OFBIZ-3390
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Fix For: SVN trunk


 When you create an order with the order manager and need to add an address 
 you get an error message. I did test only with trunk

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3374) UI upgrade, new lookups

2010-01-16 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801173#action_12801173
 ] 

Jacques Le Roux commented on OFBIZ-3374:


Hi Sascha,

I just tried but get an error after an ant clean build run? I don't see any 
data to load, did you test your last patch? May I miss something?

Thanks



 UI upgrade, new lookups
 ---

 Key: OFBIZ-3374
 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
Priority: Minor
 Fix For: SVN trunk

 Attachments: header_bg.gif, header_close_button.png, lookup.jpg, 
 lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, 
 lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, 
 lookups.patch, lookups.patch, lookups.patch, lookups.patch


 Hi,
 regarding to this articel: 
 [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29]
  I decided to improve the lookup fields.
 They shouldn't open in a page layer instead of a seperate windows. 
 My Patch contains a prototype (not a final patch), so what do you think about 
 the new lookup windows?
 Should i follow this idea, any suggestions?
 So long 
 Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-3412) WebTools Labels - DE Translation of latest trunk version

2010-01-16 Thread Erwan de FERRIERES (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erwan de FERRIERES closed OFBIZ-3412.
-

Resolution: Fixed

Done at rev. 80
Thanks Carsten !

 WebTools Labels - DE Translation of latest trunk version
 

 Key: OFBIZ-3412
 URL: https://issues.apache.org/jira/browse/OFBIZ-3412
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
 Environment: any
Reporter: Carsten Schinzer
Assignee: Erwan de FERRIERES
Priority: Trivial
 Fix For: SVN trunk

 Attachments: OFBIZ-3412_WebTools Labels - DE Translation of latest 
 trunk version.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Tanslated the latest verison of framework/webtools/config/WebtoolsUiLabels.xml

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-3413) Add Temporal Expressions To Async Services

2010-01-16 Thread Adrian Crum (JIRA)
Add Temporal Expressions To Async Services
--

 Key: OFBIZ-3413
 URL: https://issues.apache.org/jira/browse/OFBIZ-3413
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Adrian Crum
Priority: Minor


The current asynchronous service implementation uses iCalendar-style data to 
schedule the service. The implementation needs to be improved to support 
temporal expressions.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3413) Add Temporal Expressions To Async Services

2010-01-16 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801284#action_12801284
 ] 

Adrian Crum commented on OFBIZ-3413:


The service engine, CoreEvents.java, and UI artifacts all need to be changed.


 Add Temporal Expressions To Async Services
 --

 Key: OFBIZ-3413
 URL: https://issues.apache.org/jira/browse/OFBIZ-3413
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Adrian Crum
Priority: Minor

 The current asynchronous service implementation uses iCalendar-style data to 
 schedule the service. The implementation needs to be improved to support 
 temporal expressions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk

2010-01-16 Thread Adrian Crum (JIRA)
Work Effort Appliaction Is Broken In Trunk
--

 Key: OFBIZ-3414
 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Affects Versions: SVN trunk
Reporter: Adrian Crum


The work effort application has become useless. There has been a major 
regression since R 9.04. See comments for details.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk

2010-01-16 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801305#action_12801305
 ] 

Adrian Crum commented on OFBIZ-3414:


Issue #1: The Find Work Efforts screen doesn't work.

Click on the Find button in the 9.04 demo 
(https://demo904.ofbiz.org/workeffort/control/FindWorkEffort). All work efforts 
are displayed.

Click on the Find button in the trunk demo 
(https://demo.ofbiz.org/workeffort/control/FindWorkEffort). Only some work 
efforts are displayed.



 Work Effort Appliaction Is Broken In Trunk
 --

 Key: OFBIZ-3414
 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Affects Versions: SVN trunk
Reporter: Adrian Crum

 The work effort application has become useless. There has been a major 
 regression since R 9.04. See comments for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk

2010-01-16 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801308#action_12801308
 ] 

Adrian Crum commented on OFBIZ-3414:


Issue #2: Create/Edit Work Effort in Calendar screen doesn't work properly.

Go to the Calendar screen in the 9.04 demo 
(https://demo904.ofbiz.org/workeffort/control/day). Click on one of the Add New 
links. An Edit Work Effort screen appears that allows you to enter any type of 
work effort.

Go to the Calendar screen in the trunk demo 
(https://demo.ofbiz.org/workeffort/control/calendar). Click on one of the Add 
New links. A screen appears that only lets you enter very limited information, 
and only for an event. There is no way to enter another type of work effort.




 Work Effort Appliaction Is Broken In Trunk
 --

 Key: OFBIZ-3414
 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Affects Versions: SVN trunk
Reporter: Adrian Crum

 The work effort application has become useless. There has been a major 
 regression since R 9.04. See comments for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3414) Work Effort Appliaction Is Broken In Trunk

2010-01-16 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum updated OFBIZ-3414:
---

Description: 
The work effort application has become unusable. There has been a major 
regression since R 9.04. See comments for details.


  was:
The work effort application has become useless. There has been a major 
regression since R 9.04. See comments for details.



 Work Effort Appliaction Is Broken In Trunk
 --

 Key: OFBIZ-3414
 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Affects Versions: SVN trunk
Reporter: Adrian Crum

 The work effort application has become unusable. There has been a major 
 regression since R 9.04. See comments for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: svn commit: r900050 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java

2010-01-16 Thread Adam Heath
adri...@apache.org wrote:
 Author: adrianc
 Date: Sun Jan 17 03:13:19 2010
 New Revision: 900050
 
 URL: http://svn.apache.org/viewvc?rev=900050view=rev
 Log:
 Reorganized code in TemporalExpressions.java. No functional change.
 
 Modified:
 
 ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
 
 Modified: 
 ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java?rev=900050r1=900049r2=900050view=diff
 ==
 --- 
 ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
  (original)
 +++ 
 ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
  Sun Jan 17 03:13:19 2010
 @@ -37,224 +37,323 @@
  public class TemporalExpressions implements Serializable {
  public static final String module = TemporalExpressions.class.getName();
  public static final TemporalExpression NullExpression = new Null();
 +// Expressions are evaluated from largest unit of time to smallest.
 +// When unit of time is the same, then they are evaluated from
 +// least ambiguous to most. Frequency should always be first -
 +// since it is the most specific. Date range should always be last.
 +// The idea is to evaluate all other expressions, then check to see
 +// if the result falls within the date range.
 +public static final int SEQUENCE_DATE_RANGE = 1;
 +public static final int SEQUENCE_DAY_IN_MONTH = 400;
 +public static final int SEQUENCE_DOM_RANGE = 300;
 +public static final int SEQUENCE_DOW_RANGE = 500;
 +public static final int SEQUENCE_FREQ = 100;
 +public static final int SEQUENCE_HOUR_RANGE = 700;
 +public static final int SEQUENCE_MINUTE_RANGE = 800;
 +public static final int SEQUENCE_MONTH_RANGE = 200;
 +public static final int SEQUENCE_TOD_RANGE = 600;

I'd prefer to see this as an enum instead, it offers better type safety.

public enum SEQUENCE {
DATE_RANGE { public int value() { return 1; },
DAY_IN_MONTH { public int value() { return 400; },
...
public abstract int value();
}

If you don't want to have each enum contain a value method, then an
enum map could be used(which is not a real map), but then you'd have
Integer objects, instead of int values.


Re: svn commit: r900050 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java

2010-01-16 Thread Adrian Crum
--- On Sat, 1/16/10, Adam Heath doo...@brainfood.com wrote:

 From: Adam Heath doo...@brainfood.com
 Subject: Re: svn commit: r900050 - 
 /ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
 To: dev@ofbiz.apache.org
 Date: Saturday, January 16, 2010, 8:20 PM
 adri...@apache.org
 wrote:
  Author: adrianc
  Date: Sun Jan 17 03:13:19 2010
  New Revision: 900050
  
  URL: http://svn.apache.org/viewvc?rev=900050view=rev
  Log:
  Reorganized code in TemporalExpressions.java. No
 functional change.
  
  Modified:
  
    ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
  
  Modified:
 ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java?rev=900050r1=900049r2=900050view=diff
 
 ==
  ---
 ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
 (original)
  +++
 ofbiz/trunk/framework/service/src/org/ofbiz/service/calendar/TemporalExpressions.java
 Sun Jan 17 03:13:19 2010
  @@ -37,224 +37,323 @@
   public class TemporalExpressions implements
 Serializable {
       public static final String module
 = TemporalExpressions.class.getName();
       public static final
 TemporalExpression NullExpression = new Null();
  +    // Expressions are evaluated from
 largest unit of time to smallest.
  +    // When unit of time is the same, then
 they are evaluated from
  +    // least ambiguous to most. Frequency
 should always be first -
  +    // since it is the most specific. Date
 range should always be last.
  +    // The idea is to evaluate all other
 expressions, then check to see
  +    // if the result falls within the date
 range.
  +    public static final int
 SEQUENCE_DATE_RANGE = 1;
  +    public static final int
 SEQUENCE_DAY_IN_MONTH = 400;
  +    public static final int
 SEQUENCE_DOM_RANGE = 300;
  +    public static final int
 SEQUENCE_DOW_RANGE = 500;
  +    public static final int SEQUENCE_FREQ =
 100;
  +    public static final int
 SEQUENCE_HOUR_RANGE = 700;
  +    public static final int
 SEQUENCE_MINUTE_RANGE = 800;
  +    public static final int
 SEQUENCE_MONTH_RANGE = 200;
  +    public static final int
 SEQUENCE_TOD_RANGE = 600;
 
 I'd prefer to see this as an enum instead, it offers better
 type safety.
 
 public enum SEQUENCE {
     DATE_RANGE { public int value() { return
 1; },
     DAY_IN_MONTH { public int value() { return
 400; },
     ...
     public abstract int value();
 }
 
 If you don't want to have each enum contain a value method,
 then an
 enum map could be used(which is not a real map), but then
 you'd have
 Integer objects, instead of int values.

That's a good suggestion. I will file it and save it for later. Right now I'm 
working on Martin Fowler's substitution conundrum.






[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk

2010-01-16 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801332#action_12801332
 ] 

Adrian Crum commented on OFBIZ-3414:


Issue #3: The temporal expression demo doesn't work in either version.

Log into Work Efforts application as admin. Go to Calendar and select Month 
View. A staff meeting should appear on the first Monday of the month.


 Work Effort Application Is Broken In Trunk
 --

 Key: OFBIZ-3414
 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Affects Versions: SVN trunk
Reporter: Adrian Crum

 The work effort application has become unusable. There has been a major 
 regression since R 9.04. See comments for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3414) Work Effort Application Is Broken In Trunk

2010-01-16 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801334#action_12801334
 ] 

Adrian Crum commented on OFBIZ-3414:


Issue # 4: The iCalendar demo doesn't work (probably related to #3).

Using an iCalendar client, view this R 9.04 calendar:

https://demo904.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics

The staff meeting appears.

Using an iCalendar client, view this trunk calendar:

https://demo.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics

The calendar requires authentication. After logging in, no calendar appears.


 Work Effort Application Is Broken In Trunk
 --

 Key: OFBIZ-3414
 URL: https://issues.apache.org/jira/browse/OFBIZ-3414
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Affects Versions: SVN trunk
Reporter: Adrian Crum

 The work effort application has become unusable. There has been a major 
 regression since R 9.04. See comments for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Webslinger demo screen in example application

2010-01-16 Thread Bruno Busco
Hi,
I would like to see webslinger in action to better understand what it
can be used for. I think this would be useful to all developers.

Could a webslinger expert add a demo screen or something in the
Example application that shows it?

Thank you,
Bruno