[jira] Commented: (OFBIZ-3847) Entity ECAs not triggered correctly when using Delegator.storeAll() method
[
https://issues.apache.org/jira/browse/OFBIZ-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888956#action_12888956
]
Scott Gray commented on OFBIZ-3847:
---
I think this points to a larger problem whereby there is no guarantee that any
entity ECA will receive a complete GenericValue representing the entire record.
For example GenericDelegator.removeByPrimaryKey() only passes the primary key
fields to the ECA rule runner and any ECAs that depend on other non-pk fields
won't be able to evaluate their condition properly.
I'm not sure what the full solution would look like, it would be good to get
some thoughts of others on this.
We could consider having EntityEcaCondition.eval() perform a db lookup if any
of the fields it needs to evaluate are missing. If they are missing it could
fully populate the entity with the missing fields so that a lookup is only
required at most once per delegator operation. If no ECA conditions require
any missing fields then the lookup wouldn't be performed, so the performance
penalty would only be incurred when necessary.
> Entity ECAs not triggered correctly when using Delegator.storeAll() method
> --
>
> Key: OFBIZ-3847
> URL: https://issues.apache.org/jira/browse/OFBIZ-3847
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 10.04
>Reporter: Martin Kreidenweis
> Attachments: GenericDelegator.java.diff
>
>
> The conditions don't work when updating (not creating) entities using the
> Delegator.storeAll() method. E.g. the following condition does not work:
> {code}
>
> value="N"/>
> value-attr="productInstance"/>
>
> {code}
> The indexProductKeywords service is called anyway when the product is updated
> and the autoCreateKeywords was "N" and stays "N". It works correctly for
> newly created products.
> The problem is in the method GenericDelegator.storeAll(), where unchanged
> field values are not passed down to the store() method. The store method
> calls the ECA engine, which does not receive the unchanged values at all and
> thus cannot evaluate the EECA conditions correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3850) Exception on Add Credit Card page from Quick Checkout option
[ https://issues.apache.org/jira/browse/OFBIZ-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888938#action_12888938 ] Scott Gray commented on OFBIZ-3850: --- Hi Mukesh Please provide some steps to reproduce the issue Thanks Scott > Exception on Add Credit Card page from Quick Checkout option > - > > Key: OFBIZ-3850 > URL: https://issues.apache.org/jira/browse/OFBIZ-3850 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: SVN trunk >Reporter: Mukesh Marathe > Attachments: OFBIZ-3850.patch > > > While creating the credit card for party by selecting Quick Finalize Order > option, it throwing an exception need to add some null checks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3859) Convert parameters before using entity-engine
[ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888932#action_12888932 ] Scott Gray commented on OFBIZ-3859: --- After looking at createCalendarExceptionDay, I see two problems: 1. The service definition types exceptionCapacity as a BigDecimal but the entity definition types it as a double, hence the mismatch 2. set-nonpk-fields ultimately just calls GenericEntity.set(String, Object), once upon a time this method would print (not throw) an exception if a mismatch occurred but would then convert it to the correct type but this doesn't appear to happen anymore. I would check the svn history and reinstate whatever logic was in place before the conversion framework took over. > Convert parameters before using entity-engine > - > > Key: OFBIZ-3859 > URL: https://issues.apache.org/jira/browse/OFBIZ-3859 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: SVN trunk >Reporter: matthieu bollot > Attachments: ofbiz-3859.patch > > > Now, values need to be converted before using entity-engine. I'll provide a > patch corresponding to this selenium test : > http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3857) Fix bad field reference "projectIdId" should be "projectId"
[ https://issues.apache.org/jira/browse/OFBIZ-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888904#action_12888904 ] Erwan de FERRIERES commented on OFBIZ-3857: --- Done at r964558 964567 and 964560. Thanks Bob ! > Fix bad field reference "projectIdId" should be "projectId" > --- > > Key: OFBIZ-3857 > URL: https://issues.apache.org/jira/browse/OFBIZ-3857 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/projectmgr >Affects Versions: SVN trunk >Reporter: Bob Morley >Assignee: Erwan de FERRIERES > Fix For: Release 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-3857_FixBadFieldReference.patch > > > Was working in hot-deploy and caused the same error so I did a quick scan and > found this one as well. As you can see parameters.projectId is references a > little higher in a set element. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3857) Fix bad field reference "projectIdId" should be "projectId"
[ https://issues.apache.org/jira/browse/OFBIZ-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-3857. - Fix Version/s: SVN trunk Release Branch 10.04 Release 09.04 Resolution: Fixed > Fix bad field reference "projectIdId" should be "projectId" > --- > > Key: OFBIZ-3857 > URL: https://issues.apache.org/jira/browse/OFBIZ-3857 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/projectmgr >Affects Versions: SVN trunk >Reporter: Bob Morley >Assignee: Erwan de FERRIERES > Fix For: SVN trunk, Release Branch 10.04, Release 09.04 > > Attachments: OFBIZ-3857_FixBadFieldReference.patch > > > Was working in hot-deploy and caused the same error so I did a quick scan and > found this one as well. As you can see parameters.projectId is references a > little higher in a set element. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3830) jQuery Calendar Implementation
[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888900#action_12888900 ] Erwan de FERRIERES commented on OFBIZ-3830: --- Done at 964556 ! Thanks > jQuery Calendar Implementation > -- > > Key: OFBIZ-3830 > URL: https://issues.apache.org/jira/browse/OFBIZ-3830 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: jQuery >Reporter: Sascha Rodekamp >Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: cal.gif, images.zip, jquery.zip, > OFBIZ-3814_calendar_fix.patch, OFBIZ-3830_calendar_update.patch, > OFBIZ-3830_CalendarLanguageFix.patch, OFBIZ-3830_CalSetCurrentTimeOnOpen.patch > > > Hey, good morning, > here a few changes from the WE. I try to implement a new jQuery calendar. > It's not totally done, yet. I didn't touch the FTLs were the calenar is > called. But all calendar calls over the Macro renderer work. > I used the jQuery User Interface [http://jqueryui.com/] Calendar (so no > licence problems) furthermore i added a plugin for the data pickin (GLP/MIT > Licence too :-) [http://trentrichardson.com/examples/timepicker/]). The > jQuery UI have some interessting widgets!! > For commit please copy the folder from the jquery.zip in the images/jquery > folder. You should have images/jquery/ui and images/jquery/plugins. > Furthermore there are themes for the jQuery UI widgets. Which i have copied > in the Theme CSS of ofbiz. The images.zip contains images which are needed by > the jQuery widegts, i placed them in the image folder of each ofbiz Theme. > I think we have to decide if this is the right way to deal with th jQuery UI. > Cheers, hava good day > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Edit Product store survey
Hello Rishi, I want to edit the product store survey not the survey, screen title says edit product store surveys but there is no option for editing. Thanks and Regards Santosh Malviya On Thu, Jul 15, 2010 at 7:08 PM, Rishi Solanki wrote: > Hi Santosh, > On clicking on the surveyId you will navigate to - > https://localhost:8443/content/control/EditSurvey?surveyId=1000 > Here you can edit it. > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Media Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxmedia.com > > > On Thu, Jul 15, 2010 at 5:12 PM, Santosh Malviya >wrote: > > > Hello dev, > > > > Is there any specific reason for not providing updation of product store > > survey. To see this follow steps: - > > > > (1) Go to Catalog click on Store menu, then click on Ofbiz ecommerce > store. > > (2) Click on Surveys tab, you'll see there, adding and deleting survey to > > product store but there is no option for edit. > > > > Thanks and Regards > > Santosh Malviya > > >
[jira] Commented: (OFBIZ-3407) update library iText 2.0.1 to iText 2.1.7
[ https://issues.apache.org/jira/browse/OFBIZ-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1210#action_1210 ] Hans Bakker commented on OFBIZ-3407: finally solved by chattree in rev 964371 and 964431 by upgrading birt > update library iText 2.0.1 to iText 2.1.7 > - > > Key: OFBIZ-3407 > URL: https://issues.apache.org/jira/browse/OFBIZ-3407 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Gil Portenseigne >Assignee: Erwan de FERRIERES >Priority: Minor > Fix For: SVN trunk > > Attachments: iText-2.1.7.jar, iText-LICENSE_OFBIZ-3407.patch > > > Trying to use JasperReport 3.6.0, this project needs at least iText 2.1.0 > library. So I propose to update iText lib to the latest compatible with ofbiz > ie : iText 2.1.7 > (iText 5.0.0 is under AGPL) > Change log of iText lib : http://itextpdf.com/history.php > The lib is downloadable here : http://sourceforge.net/projects/itext/files/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Edit Product store survey
Hi Santosh, On clicking on the surveyId you will navigate to - https://localhost:8443/content/control/EditSurvey?surveyId=1000 Here you can edit it. Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Thu, Jul 15, 2010 at 5:12 PM, Santosh Malviya wrote: > Hello dev, > > Is there any specific reason for not providing updation of product store > survey. To see this follow steps: - > > (1) Go to Catalog click on Store menu, then click on Ofbiz ecommerce store. > (2) Click on Surveys tab, you'll see there, adding and deleting survey to > product store but there is no option for edit. > > Thanks and Regards > Santosh Malviya >
Error in E-commerce while updating store
Hi,
There seems to be a problem when update e-commerce store. Also, if I
click on the Inventory Tab of a product.
SVN Info:
Path: .
URL: http://svn.apache.org/repos/asf/ofbiz/trunk
Repository Root: http://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 964384
Node Kind: directory
Schedule: normal
Last Changed Author: hansbak
Last Changed Rev: 964371
Last Changed Date: 2010-07-15 16:03:57 +0530 (Thu, 15 Jul 2010)
=E-commerce product update
error=
Below is the Error and stacktrace:
The Following Errors Occurred:
Type check failed for field [updateProductStore.daysToCancelNonPay];
expected type is [Long]; actual type is [java.lang.String]
Type check failed for field [updateProductStore.storeCreditValidDays];
expected type is [Long]; actual type is [java.lang.String]
E-Commerce
stacktrace==
[java] 2010-07-15 18:50:39,520 (http-0.0.0.0-8443-1) [
ModelService.java:564:ERROR] [ModelService.validate] :
{updateProductStore} : (IN) Required test error:
org.ofbiz.service.ServiceValidationException: Type check failed for
field [updateProductStore.daysToCancelNonPay]; expected type is [Long];
actual type is [java.lang.String]Type check failed for field
[updateProductStore.storeCreditValidDays]; expected type is [Long];
actual type is [java.lang.String]
[java] 2010-07-15 18:50:39,541 (http-0.0.0.0-8443-1) [
ServiceDispatcher.java:381:ERROR]
[java] exception report
--
[java] Incoming context (in runSync : updateProductStore) does not
match expected requirements
[java] Exception: org.ofbiz.service.ServiceValidationException
[java] Message: Type check failed for field
[updateProductStore.daysToCancelNonPay]; expected type is [Long]; actual
type is [java.lang.String]Type check failed for field
[updateProductStore.storeCreditValidDays]; expected type is [Long];
actual type is [java.lang.String]
[java] stack trace
---
[java] org.ofbiz.service.ServiceValidationException: Type check
failed for field [updateProductStore.daysToCancelNonPay]; expected type
is [Long]; actual type is [java.lang.String]Type check failed for field
[updateProductStore.storeCreditValidDays]; expected type is [Long];
actual type is [java.lang.String]
[java] org.ofbiz.service.ModelService.validate(ModelService.java:698)
[java] org.ofbiz.service.ModelService.validate(ModelService.java:562)
[java]
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
[java]
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:226)
[java]
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:165)
[java]
org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:336)
[java]
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:637)
[java]
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:383)
[java]
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:227)
[java]
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:90)
[java] javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
[java] javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
[java]
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
[java]
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
[java]
org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:271)
[java]
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
[java]
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
[java]
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
[java]
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
[java]
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
[java]
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
[java]
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
[java]
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
[java]
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
[java]
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:852)
[java]
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588)
[java]
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
[java] java.lang.Thread.run(Thread.java:619)
[java]
[jira] Updated: (OFBIZ-3830) jQuery Calendar Implementation
[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3830: --- Attachment: OFBIZ-3830_CalSetCurrentTimeOnOpen.patch Hey, here is a patch which added the current time to the DateTime Picker :-) Cheers > jQuery Calendar Implementation > -- > > Key: OFBIZ-3830 > URL: https://issues.apache.org/jira/browse/OFBIZ-3830 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: jQuery >Reporter: Sascha Rodekamp >Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: cal.gif, images.zip, jquery.zip, > OFBIZ-3814_calendar_fix.patch, OFBIZ-3830_calendar_update.patch, > OFBIZ-3830_CalendarLanguageFix.patch, OFBIZ-3830_CalSetCurrentTimeOnOpen.patch > > > Hey, good morning, > here a few changes from the WE. I try to implement a new jQuery calendar. > It's not totally done, yet. I didn't touch the FTLs were the calenar is > called. But all calendar calls over the Macro renderer work. > I used the jQuery User Interface [http://jqueryui.com/] Calendar (so no > licence problems) furthermore i added a plugin for the data pickin (GLP/MIT > Licence too :-) [http://trentrichardson.com/examples/timepicker/]). The > jQuery UI have some interessting widgets!! > For commit please copy the folder from the jquery.zip in the images/jquery > folder. You should have images/jquery/ui and images/jquery/plugins. > Furthermore there are themes for the jQuery UI widgets. Which i have copied > in the Theme CSS of ofbiz. The images.zip contains images which are needed by > the jQuery widegts, i placed them in the image folder of each ofbiz Theme. > I think we have to decide if this is the right way to deal with th jQuery UI. > Cheers, hava good day > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Edit Product store survey
Hello dev, Is there any specific reason for not providing updation of product store survey. To see this follow steps: - (1) Go to Catalog click on Store menu, then click on Ofbiz ecommerce store. (2) Click on Surveys tab, you'll see there, adding and deleting survey to product store but there is no option for edit. Thanks and Regards Santosh Malviya
Re: svn commit: r964371 [1/3] - in /ofbiz/trunk: ./ framework/birt/ framework/birt/lib/platform/plugins/ framework/birt/lib/platform/plugins/com.lowagie.itext/ framework/birt/lib/platform/plugins/com.
Le 15/07/2010 13:30, Hans Bakker a écrit : This was a contribution of our collegue Chattree, not perfect yet...but he will fix it Regards, Hans On Thu, 2010-07-15 at 13:27 +0200, Erwan de FERRIERES wrote: Le 15/07/2010 12:34, hans...@apache.org a écrit : Author: hansbak Date: Thu Jul 15 10:33:57 2010 New Revision: 964371 URL: http://svn.apache.org/viewvc?rev=964371&view=rev Log: upgrade birt to 2.6 and at the same time upgrade the itext library (OFBIZ-3407) which does work with this birt version Thanks Hans ! I haven't tested, but upgrading was a good idea. So wait&see ! -- Erwan de FERRIERES www.nereide.biz
Re: svn commit: r964371 [1/3] - in /ofbiz/trunk: ./ framework/birt/ framework/birt/lib/platform/plugins/ framework/birt/lib/platform/plugins/com.lowagie.itext/ framework/birt/lib/platform/plugins/com.
This was a contribution of our collegue Chattree, not perfect yet...but he will fix it Regards, Hans On Thu, 2010-07-15 at 13:27 +0200, Erwan de FERRIERES wrote: > Le 15/07/2010 12:34, hans...@apache.org a écrit : > > Author: hansbak > > Date: Thu Jul 15 10:33:57 2010 > > New Revision: 964371 > > > > URL: http://svn.apache.org/viewvc?rev=964371&view=rev > > Log: > > upgrade birt to 2.6 and at the same time upgrade the itext library > > (OFBIZ-3407) which does work with this birt version > > > > Thanks Hans ! > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates.
Re: svn commit: r964371 [1/3] - in /ofbiz/trunk: ./ framework/birt/ framework/birt/lib/platform/plugins/ framework/birt/lib/platform/plugins/com.lowagie.itext/ framework/birt/lib/platform/plugins/com.
Le 15/07/2010 12:34, hans...@apache.org a écrit : Author: hansbak Date: Thu Jul 15 10:33:57 2010 New Revision: 964371 URL: http://svn.apache.org/viewvc?rev=964371&view=rev Log: upgrade birt to 2.6 and at the same time upgrade the itext library (OFBIZ-3407) which does work with this birt version Thanks Hans ! -- Erwan de FERRIERES www.nereide.biz
[jira] Commented: (OFBIZ-3859) Convert parameters before using entity-engine
[ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888762#action_12888762 ] matthieu bollot commented on OFBIZ-3859: will you or anyone have some times to take a look ? Are you sure it is about set-nonpk-fields and not make-value ? May be we could close this issue and create a new one in framework. > Convert parameters before using entity-engine > - > > Key: OFBIZ-3859 > URL: https://issues.apache.org/jira/browse/OFBIZ-3859 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: SVN trunk >Reporter: matthieu bollot > Attachments: ofbiz-3859.patch > > > Now, values need to be converted before using entity-engine. I'll provide a > patch corresponding to this selenium test : > http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
