[jira] Commented: (OFBIZ-4078) Provide the option on orderview screen so that CSR could change customer phone and email address.

2010-12-28 Thread Amit Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975450#action_12975450
 ] 

Amit Sharma commented on OFBIZ-4078:


Thanks Ashish.

Regards
Amit Sharma


 Provide the option on orderview screen so that CSR could change customer 
 phone and email address.
 -

 Key: OFBIZ-4078
 URL: https://issues.apache.org/jira/browse/OFBIZ-4078
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: SVN trunk
Reporter: Amit Sharma
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4078.patch


 Provide the option on orderview screen so that CSR could change customer 
 phone and email address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



End of month : Main New features

2010-12-28 Thread Jacques Le Roux


Please devs, don't forget to add your changes in Main New features with shorts 
explanations

https://cwiki.apache.org/confluence/display/OFBIZ/Main+New+Features

Thanks

Jacques




Re: svn commit: r1053198 - /ofbiz/trunk/framework/images/webapp/images/getDependentDropdownValues.js

2010-12-28 Thread Jacques Le Roux

Hi,

Following this, I'd like to suggest to use, if possible, Eclipse/Aptana for editing Javascript files and notably to format them 
correctly. I suggest also to not use tabs in *our* javascript files but 4 spaces (like in Java)

I have put the Aptana formatting template as an attachment of OFBiz 
Contributors Best Practices

Thanks to share your opinion

Jacques

From: jler...@apache.org

URL: http://svn.apache.org/viewvc?rev=1053198view=rev
Log:
Use the power of Aptana to format correctly this file. I have adapted the default format setting to be more near our best 
practices. If you are interested I can share the formatting template.


Anyway I think I will discuss that on dev ML latter. We could have it posted in the wiki, when agreed upon its content, and use it 
as part of our best practices...







[jira] Commented: (OFBIZ-4076) When audit log is enabled it creates log transacations even when there's no change

2010-12-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975479#action_12975479
 ] 

Jacques Le Roux commented on OFBIZ-4076:


Hi Jeroen,

Sorry, your patch looks good but is outdated (Adrian moved things this weekend, 
maybe the reason)

 When audit log is enabled it creates log transacations even when there's no 
 change
 --

 Key: OFBIZ-4076
 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jeroen van der Wal
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4076.patch


 The createEntittyAuditLogSingle function creates a record in the AuditLog 
 entity even when there's no change. This patch only logs new, changed and 
 deleted values. Also, all changes in the same transaction will get the same 
 change date.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2777) exception in Shipment Information panel of view order page

2010-12-28 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-2777.
--

   Resolution: Invalid
Fix Version/s: SVN trunk
 Assignee: Jacques Le Roux

The code has been changed since and I can't find any 
*shipmentId:shipment.shipmentId* in 
applications/order/webapp/ordermgr/order/ordershippinginfo.ftl

I think the problem has been addressed (though I did not find any clear 
evidences and no exact revision to associate)

 exception in Shipment Information panel of view order page
 --

 Key: OFBIZ-2777
 URL: https://issues.apache.org/jira/browse/OFBIZ-2777
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Wai Tam
Assignee: Jacques Le Roux
 Fix For: SVN trunk


 Error on line 556, column 25 in 
 component://order/webapp/ordermgr/order/ordershippinginfo.ftl 
 Static[org.ofbiz.entity.util.EntityUtil].getFirst(delegator.findByAnd(ShipmentRouteSegment,
  {shipmentId:shipment.shipmentId})) is undefined. It cannot be assigned to 
 shipmentRoutSegment The problematic instruction: -- == assignment: 
 shipmentRoutSegment=Static[org.ofbiz.entity.util.EntityUtil].getFirst(delegator.findByAnd(ShipmentRouteSegment,
  {shipmentId:shipment.shipmentId})) [on line 556, column 25 in 
 component://order/webapp/ordermgr/order/ordershippinginfo.ftl] -- 
 Java backtrace for programmers: -- 
 freemarker.core.InvalidReferenceException: Error on line 556, column 25 in 
 component://order/webapp/ordermgr/order/ordershippinginfo.ftl 
 Static[org.ofbiz.entity.util.EntityUtil].getFirst(delegator.findByAnd(ShipmentRouteSegment,
  {shipmentId:shipment.shipmentId})) is undefined. It cannot be assigned to 
 shipmentRoutSegment at freemarker.core.Assignment.accept(Assignment.java:111) 
 at freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.MixedContent.accept(MixedContent.java:92) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:167) at 
 freemarker.core.Environment.visit(Environment.java:416) at 
 freemarker.core.IteratorBlock.accept(IteratorBlock.java:102) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.MixedContent.accept(MixedContent.java:92) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.MixedContent.accept(MixedContent.java:92) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:167) at 
 freemarker.core.Environment.visit(Environment.java:416) at 
 freemarker.core.IteratorBlock.accept(IteratorBlock.java:102) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.MixedContent.accept(MixedContent.java:92) at 
 freemarker.core.Environment.visit(Environment.java:209) at 
 freemarker.core.Environment.process(Environment.java:189) at 
 org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:205)
  at 
 org.ofbiz.widget.screen.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:205) at 
 org.ofbiz.widget.screen.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:250)
  at 
 org.ofbiz.widget.screen.HtmlWidget.renderWidgetString(HtmlWidget.java:110) at 
 org.ofbiz.widget.screen.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1001)
  at 
 org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:138)
  at 
 org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:229)
  at 
 org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:393) 
 at 
 org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:563)
  at 
 org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:138)
  at 
 org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:297)
  at 
 org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:138)
  at 
 org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:229)
  at 
 org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:393) 
 at 
 org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:563)
  at 
 

[jira] Commented: (OFBIZ-4076) When audit log is enabled it creates log transacations even when there's no change

2010-12-28 Thread Jeroen van der Wal (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12975488#action_12975488
 ] 

Jeroen van der Wal commented on OFBIZ-4076:
---

Thanks Jacques,

I will provide a better patch later today.

 When audit log is enabled it creates log transacations even when there's no 
 change
 --

 Key: OFBIZ-4076
 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jeroen van der Wal
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4076.patch


 The createEntittyAuditLogSingle function creates a record in the AuditLog 
 entity even when there's no change. This patch only logs new, changed and 
 deleted values. Also, all changes in the same transaction will get the same 
 change date.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2010-12-28 Thread Willem Janssen (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Janssen updated OFBIZ-4079:
--

Attachment: 2010-12-28_2329.png

 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
 Attachments: 2010-12-28_2329.png


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Discussion: Flat Grey Visual Theme

2010-12-28 Thread Adrian Crum
The Flat Grey visual theme is getting old.

The current version of the theme is based on the original look and feel of 
OFBiz when I first joined the community - back in 2004. Around the Spring of 
2007 I added some gradient gifs to make the original style a little more 
interesting. 

After that, the visual theme was converted to a floating flexible layout (to 
fit any size screen), it was made sight-impaired accessible (font size can be 
changed), and it added support for bi-directional layout (for rtl languages). 
Those design decisions were made by the OFBiz community and, in my opinion, 
continue to make the Flat Grey theme the fallback theme when all else fails. It 
just works.

Despite its advantages, it looks dated. I would like to update it to make it 
more modern, but maintain its advantages over the other themes. I'm thinking it 
only needs css and gif file updates. The current templates and javascripts 
would be maintained.

If anyone is interested, they are welcome to help out. I would also appreciate 
any suggestions or comments.

Let me know what you think.

-Adrian