[jira] Commented: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Willem Janssen (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980617#action_12980617
 ] 

Willem Janssen commented on OFBIZ-4079:
---

Hi Jacques, thank you for your effort on this issue. If I had knowlegde about 
JS I'd have helped, but unfortunately that's not the case. Nice to see progress 
:)

 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Attachments: 2010-12-28_2329.png


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Sascha Rodekamp (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980640#action_12980640
 ] 

Sascha Rodekamp commented on OFBIZ-4079:


Hm, the form is defined in WebSiteCMSContent.ftl and uses the content db entry 
to fill the from fields. Maybe we can set a condition here (i'll check later).
Another bug we have to face here is when try to store the new/changed content, 
i got a simple method exception:

Message: Error in simple-method [Update Electronic Text 
[file:/C:/Eclipse/workspace/ofbiz_trunk/applications/content/script/org/ofbiz/content/data/DataServices.xml#updateElectronicText]]:
 In set-nonpk-fields a value was not found with the specified valueAcsr: 
lookedUpValue, not setting fields




 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Attachments: 2010-12-28_2329.png


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Martin Kreidenweis (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Kreidenweis updated OFBIZ-4079:
--

Attachment: OFBIZ-4079_cmsEditorFixes.patch

fixing some bugs in CMS introduced in svn r1036195 when migrating from dojo to 
jQuery:
 * reverted accidental logic change in callDocument() that broke the new ... 
context menu items (OFBiz bug OFBIZ-4079)
 * making elRTE save toolbar button work: same behavior as the regular Save 
button
 * using regular form submit instead of ajax for new content for now
   ** ajaxSubmitForm() can't handle new content, it won't reload the form 
because it doesn't know the new contentId
 *** some controller changes would probably be necessary to make that work 
(return new contentId as JSON)
   ** nav tree is not updated with ajax submit currently
 * now always creating editor if corresponsing html element exists
   ** editor was not initialized when WebSiteCMSContent screen was loaded by 
non-ajax call


 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Attachments: 2010-12-28_2329.png, OFBIZ-4079_cmsEditorFixes.patch


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Martin Kreidenweis (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980647#action_12980647
 ] 

Martin Kreidenweis commented on OFBIZ-4079:
---

I'm not sure my patch fixes all the jQuery related issues with the CMS. Some 
more testing is necessary there. Creating new long and short texts works as 
expected now, though. 

 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Attachments: 2010-12-28_2329.png, OFBIZ-4079_cmsEditorFixes.patch


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Sascha Rodekamp (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980651#action_12980651
 ] 

Sascha Rodekamp commented on OFBIZ-4079:


Hey Martin,
thanks, the patch looks good to me, seem to work.  Are you sure you created it 
against the last trunk rev. I'm not able to apply the patch file.

Cheers
Sascha

 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Attachments: 2010-12-28_2329.png, OFBIZ-4079_cmsEditorFixes.patch


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-4110) Error while viewing list of time periods

2011-01-12 Thread Andrey Mitroshin (JIRA)
Error while viewing list of time periods


 Key: OFBIZ-4110
 URL: https://issues.apache.org/jira/browse/OFBIZ-4110
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Release Branch 09.04
 Environment: SunOS ni5nrpa1 5.9 Generic_122300-49 sun4u sparc 
SUNW,Netra-T12
java version 1.5.0_09
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)

Reporter: Andrey Mitroshin
Priority: Minor


I've created custom time period in organization GL setting as follows
Custom Time Period Id   Parent Period IdPeriod Type Id  Period Num  
Period Name From Date   Thru Date
10001   Fiscal Year 1   20112011-01-01  2011-12-31

when I'm viewing list of time periods I'm getting a message on the last page 
(where my new time period resides)

The Following Errors Occurred:

Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
parameter [periodTypeId] passed to secure (https) request-map with uri 
[createCustomTimePeriod] with an event that calls service 
[createCustomTimePeriod]; this is not allowed for security reasons! The data 
should be encrypted by making it part of the request body (a form field) 
instead of the request URL. Moreover it would be kind if you could create a 
Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before 
if a sub-task for this error does not exist). If you are not sure how to create 
a Jira issue please have a look before at http://docs.ofbiz.org/x/r. Thank you 
in advance for your help.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4110) Error while viewing list of time periods

2011-01-12 Thread Andrey Mitroshin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Mitroshin updated OFBIZ-4110:


Environment: 
OS: SunOS  5.9 
kernel: Generic_122300-49 
Machine: sun4u sparc SUNW,Netra-T12
java version 1.5.0_09
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)


  was:
SunOS ni5nrpa1 5.9 Generic_122300-49 sun4u sparc SUNW,Netra-T12
java version 1.5.0_09
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)



 Error while viewing list of time periods
 

 Key: OFBIZ-4110
 URL: https://issues.apache.org/jira/browse/OFBIZ-4110
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Release Branch 09.04
 Environment: OS: SunOS  5.9 
 kernel: Generic_122300-49 
 Machine: sun4u sparc SUNW,Netra-T12
 java version 1.5.0_09
 Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
 Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
Reporter: Andrey Mitroshin
Priority: Minor

 I've created custom time period in organization GL setting as follows
 Custom Time Period Id Parent Period IdPeriod Type Id  Period 
 Num  Period Name From Date   Thru Date
 10001 Fiscal Year 1   20112011-01-01  
 2011-12-31
 when I'm viewing list of time periods I'm getting a message on the last page 
 (where my new time period resides)
 The Following Errors Occurred:
 Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
 parameter [periodTypeId] passed to secure (https) request-map with uri 
 [createCustomTimePeriod] with an event that calls service 
 [createCustomTimePeriod]; this is not allowed for security reasons! The data 
 should be encrypted by making it part of the request body (a form field) 
 instead of the request URL. Moreover it would be kind if you could create a 
 Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check 
 before if a sub-task for this error does not exist). If you are not sure how 
 to create a Jira issue please have a look before at 
 http://docs.ofbiz.org/x/r. Thank you in advance for your help.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Martin Kreidenweis (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Kreidenweis updated OFBIZ-4079:
--

Attachment: OFBIZ-4079_cmsEditorFixes.svn.patch

Hi Sascha,

I re-created the patch using subversion. Maybe you have more luck applying this 
one.

Martin

 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Attachments: 2010-12-28_2329.png, OFBIZ-4079_cmsEditorFixes.patch, 
 OFBIZ-4079_cmsEditorFixes.svn.patch


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4109) Pagination is not working for the Entity Reference

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980708#action_12980708
 ] 

Adrian Crum commented on OFBIZ-4109:


The Tomahawk theme hides the page title - so that is a problem in every screen. 
A separate issue should be created for that.


  Pagination is not working for the Entity Reference
 ---

 Key: OFBIZ-4109
 URL: https://issues.apache.org/jira/browse/OFBIZ-4109
 Project: OFBiz
  Issue Type: Bug
  Components: framework
 Environment: Ubuntu 10.04
Reporter: Chatree Srichart

 I got an error when I use a pagination at Webtools  Entity Reference. It 
 look like the pagination is not working. I also didn't see an entity name on 
 a title of the entity section when I use the Tomahawk theme.
 Regards,
 Chatree Srichart

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Sascha Rodekamp (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980712#action_12980712
 ] 

Sascha Rodekamp commented on OFBIZ-4079:


Yea, works like a charm.
I think the patch can be committed.
Thanks for solving the issue Martin

Have a good day
Cheers
Sascha

 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Attachments: 2010-12-28_2329.png, OFBIZ-4079_cmsEditorFixes.patch, 
 OFBIZ-4079_cmsEditorFixes.svn.patch


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: svn commit: r1058056 - in /ofbiz/trunk: applications/humanres/webapp/humanres/WEB-INF/ framework/widget/config/ framework/widget/src/org/ofbiz/widget/screen/ specialpurpose/ecommerce/webapp/ecomme

2011-01-12 Thread Adrian Crum
Jacopo,

Technically, you didn't deprecate the HTML compress setting, you disabled it.

-Adrian

--- On Wed, 1/12/11, jaco...@apache.org jaco...@apache.org wrote:

 From: jaco...@apache.org jaco...@apache.org
 Subject: svn commit: r1058056 - in /ofbiz/trunk: 
 applications/humanres/webapp/humanres/WEB-INF/ framework/widget/config/ 
 framework/widget/src/org/ofbiz/widget/screen/ 
 specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/ 
 specialpurpose/oagis/webapp/oagis/WEB-INF/ ...
 To: comm...@ofbiz.apache.org
 Date: Wednesday, January 12, 2011, 2:44 AM
 Author: jacopoc
 Date: Wed Jan 12 10:44:35 2011
 New Revision: 1058056
 
 URL: http://svn.apache.org/viewvc?rev=1058056view=rev
 Log:
 Removed unused handler from controller files; replaced
 handlers that were still using the old
 ScreenWidgetViewHandler with the current
 MacroScreenViewHandler; deprecated compress.HTML property
 with output specific properties like screen.compress; this
 fixes a rather important issue happening when the
 compress.HTML setting is set to true: non html output
 screens like for example tab delimited exports were messed
 up.
 
 Modified:
    
 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
    
 ofbiz/trunk/framework/widget/config/widget.properties
    
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java
    
 ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
    
 ofbiz/trunk/specialpurpose/oagis/webapp/oagis/WEB-INF/controller.xml
    
 ofbiz/trunk/specialpurpose/shark/webapp/shark/WEB-INF/controller.xml
    
 ofbiz/trunk/specialpurpose/webpos/webapp/webpos/WEB-INF/controller.xml
 
 Modified:
 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml?rev=1058056r1=1058055r2=1058056view=diff
 ==
 ---
 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
 (original)
 +++
 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
 Wed Jan 12 10:44:35 2011
 @@ -27,7 +27,6 @@ under the License.
      
      !-- view handlers --
      handler name=service-multi
 type=request
 class=org.ofbiz.webapp.event.ServiceMultiEventHandler/
 -    handler name=screenxml type=view
 class=org.ofbiz.widget.screen.ScreenXmlViewHandler/
  
      !-- Events to run on every
 request before security (chains exempt) --
      !--
 
 Modified:
 ofbiz/trunk/framework/widget/config/widget.properties
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/config/widget.properties?rev=1058056r1=1058055r2=1058056view=diff
 ==
 --- ofbiz/trunk/framework/widget/config/widget.properties
 (original)
 +++ ofbiz/trunk/framework/widget/config/widget.properties
 Wed Jan 12 10:44:35 2011
 @@ -17,7 +17,7 @@
  # under the License.
 
 ###
  
 -# Enable HTML whitespace compression
 +# Enable HTML whitespace compression; deprecated: use
 output specific compress setting instead; see for example
 screen.compress
  #compress.HTML=true
  
  # Enable screen widget boundary comments
 @@ -57,6 +57,7 @@ screen.formrenderer=component://widget/t
 
 screen.menurenderer=component://widget/templates/htmlMenuMacroLibrary.ftl
 
 screen.treerenderer=component://widget/templates/htmlTreeMacroLibrary.ftl
  screen.encoder=html
 +screen.compress=false
  screen.default.contenttype=UTF-8
  screen.default.encoding=none
  # text output
 
 Modified:
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java?rev=1058056r1=1058055r2=1058056view=diff
 ==
 ---
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java
 (original)
 +++
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java
 Wed Jan 12 10:44:35 2011
 @@ -76,7 +76,7 @@ public class MacroScreenViewHandler exte
              }
          
    boolean compressOutput =
 compressed.equals(encoding);
              if
 (!compressOutput) {
 -               
 compressOutput =
 true.equals(UtilProperties.getPropertyValue(widget,
 compress.HTML));
 +               
 compressOutput =
 true.equals(UtilProperties.getPropertyValue(widget,
 getName() + .compress));
              }
              if
 (!compressOutput  this.servletContext != null) {
              
    compressOutput =
 true.equals(this.servletContext.getAttribute(compressHTML));
 
 Modified:
 ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
 URL: 
 

Re: svn commit: r1058056 - in /ofbiz/trunk: applications/humanres/webapp/humanres/WEB-INF/ framework/widget/config/ framework/widget/src/org/ofbiz/widget/screen/ specialpurpose/ecommerce/webapp/ecomme

2011-01-12 Thread Jacopo Cappellato
Adrian,

you are right, this is not a deprecation; I have mentioned the deprecation 
term because the setting still works for applications using the old 
ScreenWidgetViewHandler but yeah, I should have used a different term.

Kind regards,

Jacopo

On Jan 12, 2011, at 2:44 PM, Adrian Crum wrote:

 Jacopo,
 
 Technically, you didn't deprecate the HTML compress setting, you disabled it.
 
 -Adrian
 
 --- On Wed, 1/12/11, jaco...@apache.org jaco...@apache.org wrote:
 
 From: jaco...@apache.org jaco...@apache.org
 Subject: svn commit: r1058056 - in /ofbiz/trunk: 
 applications/humanres/webapp/humanres/WEB-INF/ framework/widget/config/ 
 framework/widget/src/org/ofbiz/widget/screen/ 
 specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/ 
 specialpurpose/oagis/webapp/oagis/WEB-INF/ ...
 To: comm...@ofbiz.apache.org
 Date: Wednesday, January 12, 2011, 2:44 AM
 Author: jacopoc
 Date: Wed Jan 12 10:44:35 2011
 New Revision: 1058056
 
 URL: http://svn.apache.org/viewvc?rev=1058056view=rev
 Log:
 Removed unused handler from controller files; replaced
 handlers that were still using the old
 ScreenWidgetViewHandler with the current
 MacroScreenViewHandler; deprecated compress.HTML property
 with output specific properties like screen.compress; this
 fixes a rather important issue happening when the
 compress.HTML setting is set to true: non html output
 screens like for example tab delimited exports were messed
 up.
 
 Modified:

 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml

 ofbiz/trunk/framework/widget/config/widget.properties

 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java

 ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml

 ofbiz/trunk/specialpurpose/oagis/webapp/oagis/WEB-INF/controller.xml

 ofbiz/trunk/specialpurpose/shark/webapp/shark/WEB-INF/controller.xml

 ofbiz/trunk/specialpurpose/webpos/webapp/webpos/WEB-INF/controller.xml
 
 Modified:
 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml?rev=1058056r1=1058055r2=1058056view=diff
 ==
 ---
 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
 (original)
 +++
 ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
 Wed Jan 12 10:44:35 2011
 @@ -27,7 +27,6 @@ under the License.
  
  !-- view handlers --
  handler name=service-multi
 type=request
 class=org.ofbiz.webapp.event.ServiceMultiEventHandler/
 -handler name=screenxml type=view
 class=org.ofbiz.widget.screen.ScreenXmlViewHandler/
 
  !-- Events to run on every
 request before security (chains exempt) --
  !--
 
 Modified:
 ofbiz/trunk/framework/widget/config/widget.properties
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/config/widget.properties?rev=1058056r1=1058055r2=1058056view=diff
 ==
 --- ofbiz/trunk/framework/widget/config/widget.properties
 (original)
 +++ ofbiz/trunk/framework/widget/config/widget.properties
 Wed Jan 12 10:44:35 2011
 @@ -17,7 +17,7 @@
 # under the License.
 
 ###
 
 -# Enable HTML whitespace compression
 +# Enable HTML whitespace compression; deprecated: use
 output specific compress setting instead; see for example
 screen.compress
 #compress.HTML=true
 
 # Enable screen widget boundary comments
 @@ -57,6 +57,7 @@ screen.formrenderer=component://widget/t
 
 screen.menurenderer=component://widget/templates/htmlMenuMacroLibrary.ftl
 
 screen.treerenderer=component://widget/templates/htmlTreeMacroLibrary.ftl
 screen.encoder=html
 +screen.compress=false
 screen.default.contenttype=UTF-8
 screen.default.encoding=none
 # text output
 
 Modified:
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java?rev=1058056r1=1058055r2=1058056view=diff
 ==
 ---
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java
 (original)
 +++
 ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenViewHandler.java
 Wed Jan 12 10:44:35 2011
 @@ -76,7 +76,7 @@ public class MacroScreenViewHandler exte
  }
  
boolean compressOutput =
 compressed.equals(encoding);
  if
 (!compressOutput) {
 -   
 compressOutput =
 true.equals(UtilProperties.getPropertyValue(widget,
 compress.HTML));
 +   
 compressOutput =
 true.equals(UtilProperties.getPropertyValue(widget,
 getName() + .compress));
  }
  if
 

[jira] Closed: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4079.
--

   Resolution: Fixed
Fix Version/s: SVN trunk

Thanks Martin,

Your patch is in trunk at r1058197+ (Some unrelated changes slipped in at 
r1058197 )

Good catch for the elRTE save toolbar button

I will open a new issue for those:
* using regular form submit instead of ajax for new content for now
** ajaxSubmitForm() can't handle new content, it won't reload the form because 
it doesn't know the new contentId 
+ some controller changes would probably be necessary to make that work (return 
new contentId as JSON)
** nav tree is not updated with ajax submit currently

Thanks Sascha for testing.

 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: 2010-12-28_2329.png, OFBIZ-4079_cmsEditorFixes.patch, 
 OFBIZ-4079_cmsEditorFixes.svn.patch


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (OFBIZ-4079) Adding content in CMS using add long text (right mouse click) doesn't work

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980757#action_12980757
 ] 

Jacques Le Roux edited comment on OFBIZ-4079 at 1/12/11 10:48 AM:
--

EDIT : missed a rev#

Thanks Martin,

Your patch is in trunk at r1058197+1058198 (some unrelated changes slipped in 
at r1058197 )

Good catch for the elRTE save toolbar button

I will open a new issue for those:
* using regular form submit instead of ajax for new content for now
** ajaxSubmitForm() can't handle new content, it won't reload the form because 
it doesn't know the new contentId 
+ some controller changes would probably be necessary to make that work (return 
new contentId as JSON)
** nav tree is not updated with ajax submit currently

Thanks Sascha for testing.

  was (Author: jacques.le.roux):
Thanks Martin,

Your patch is in trunk at r1058197+ (Some unrelated changes slipped in at 
r1058197 )

Good catch for the elRTE save toolbar button

I will open a new issue for those:
* using regular form submit instead of ajax for new content for now
** ajaxSubmitForm() can't handle new content, it won't reload the form because 
it doesn't know the new contentId 
+ some controller changes would probably be necessary to make that work (return 
new contentId as JSON)
** nav tree is not updated with ajax submit currently

Thanks Sascha for testing.
  
 Adding content in CMS using add long text (right mouse click) doesn't work
 --

 Key: OFBIZ-4079
 URL: https://issues.apache.org/jira/browse/OFBIZ-4079
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: Willem Janssen
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: 2010-12-28_2329.png, OFBIZ-4079_cmsEditorFixes.patch, 
 OFBIZ-4079_cmsEditorFixes.svn.patch


 When using the add long text function in the menu that shows when using the 
 right mouse click the existing content is shown, not an empty form. 
 Now it's not possible to add content in the CMS because only existing content 
 is shown in the forms. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-4111) Small issues in Content/CMS

2011-01-12 Thread Jacques Le Roux (JIRA)
Small issues in Content/CMS
---

 Key: OFBIZ-4111
 URL: https://issues.apache.org/jira/browse/OFBIZ-4111
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980770#action_12980770
 ] 

Adrian Crum commented on OFBIZ-4092:


Some thoughts on the text transformations...

The upper case transformation looks good on main navigation and the application 
title.

The lower case transformation on the application navigation looks bad. Most of 
the screen contains ul case text, and having one set of links that are all 
lower case makes that section of the screen look like it doesn't belong there. 
The same is true for the upper case buttons - they don't quite fit in with the 
rest of the screen.

My recommendation would be to keep the upper case transformations on main 
navigation and application title, and drop the rest.


 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, 
 brushed-aluminum.gif, catalog800x600.png, catalogManager.png, 
 content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, 
 partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4111) Small issues in Content/CMS

2011-01-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4111:
---

  Component/s: content
  Description: 
In OFBIZ-4079 Martin Kreidenweis fixed some issues in Content/ CMS (see 
https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=CmsSite)

So now it works, but he simultaneoulsy signaled some points.
* He used regular form submit instead of ajax for new content for now, thus:
** ajaxSubmitForm() can't handle new content, it won't reload the form because 
it doesn't know the new contentId 
+ some controller changes would probably be necessary to make that work (return 
new contentId as JSON)
** nav tree is not updated with ajax submit currently


 Priority: Minor  (was: Major)
  Environment: NA
Affects Version/s: SVN trunk

 Small issues in Content/CMS
 ---

 Key: OFBIZ-4111
 URL: https://issues.apache.org/jira/browse/OFBIZ-4111
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
 Environment: NA
Reporter: Jacques Le Roux
Priority: Minor

 In OFBIZ-4079 Martin Kreidenweis fixed some issues in Content/ CMS (see 
 https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=CmsSite)
 So now it works, but he simultaneoulsy signaled some points.
 * He used regular form submit instead of ajax for new content for now, thus:
 ** ajaxSubmitForm() can't handle new content, it won't reload the form 
 because it doesn't know the new contentId 
 + some controller changes would probably be necessary to make that work 
 (return new contentId as JSON)
 ** nav tree is not updated with ajax submit currently

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4109) Pagination is not working for the Entity Reference

2011-01-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4109:
---

Issue Type: Sub-task  (was: Bug)
Parent: OFBIZ-3517

  Pagination is not working for the Entity Reference
 ---

 Key: OFBIZ-4109
 URL: https://issues.apache.org/jira/browse/OFBIZ-4109
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
 Environment: Ubuntu 10.04
Reporter: Chatree Srichart

 I got an error when I use a pagination at Webtools  Entity Reference. It 
 look like the pagination is not working. I also didn't see an entity name on 
 a title of the entity section when I use the Tomahawk theme.
 Regards,
 Chatree Srichart

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (OFBIZ-3517) Umbrella task for Tomahawk theme

2011-01-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-3517:



 Umbrella task for Tomahawk  theme
 -

 Key: OFBIZ-3517
 URL: https://issues.apache.org/jira/browse/OFBIZ-3517
 Project: OFBiz
  Issue Type: Task
  Components: themes
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
 Fix For: SVN trunk


 The tomahawk theme is really a huge enhancement, thanks Brainfood (Eric 
 mostly I guess) and Bruno, really great!
 Here are some quirks found here and there. I suspect some are most the lack 
 of consistency in OFBiz underneath (for instance do we really need 3 or more 
 type of buttons, text links, etc.). We may though profit of the current 
 effort to clean that all definitvely
 Jacques

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4109) Pagination is not working for the Entity Reference

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980790#action_12980790
 ] 

Adrian Crum commented on OFBIZ-4109:


Jacques,

This issue should not be a sub-task of the Tomahawk theme. There is a bug in 
the entity reference screen - the list pagination does not work. That bug 
exists regardless of the visual theme.

A separate issue needs to be created for the missing page title in the Tomahawk 
theme.


  Pagination is not working for the Entity Reference
 ---

 Key: OFBIZ-4109
 URL: https://issues.apache.org/jira/browse/OFBIZ-4109
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
 Environment: Ubuntu 10.04
Reporter: Chatree Srichart

 I got an error when I use a pagination at Webtools  Entity Reference. It 
 look like the pagination is not working. I also didn't see an entity name on 
 a title of the entity section when I use the Tomahawk theme.
 Regards,
 Chatree Srichart

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4109) Pagination is not working for the Entity Reference

2011-01-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4109:
---

Issue Type: Bug  (was: Sub-task)
Parent: (was: OFBIZ-3517)

  Pagination is not working for the Entity Reference
 ---

 Key: OFBIZ-4109
 URL: https://issues.apache.org/jira/browse/OFBIZ-4109
 Project: OFBiz
  Issue Type: Bug
  Components: framework
 Environment: Ubuntu 10.04
Reporter: Chatree Srichart

 I got an error when I use a pagination at Webtools  Entity Reference. It 
 look like the pagination is not working. I also didn't see an entity name on 
 a title of the entity section when I use the Tomahawk theme.
 Regards,
 Chatree Srichart

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4109) Pagination is not working for the Entity Reference

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980817#action_12980817
 ] 

Jacques Le Roux commented on OFBIZ-4109:


Thanks Adrian,

I created OFBIZ-4112

  Pagination is not working for the Entity Reference
 ---

 Key: OFBIZ-4109
 URL: https://issues.apache.org/jira/browse/OFBIZ-4109
 Project: OFBiz
  Issue Type: Bug
  Components: framework
 Environment: Ubuntu 10.04
Reporter: Chatree Srichart

 I got an error when I use a pagination at Webtools  Entity Reference. It 
 look like the pagination is not working. I also didn't see an entity name on 
 a title of the entity section when I use the Tomahawk theme.
 Regards,
 Chatree Srichart

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-4112) Webtools Entity Reference: missing entity name page on title of the entity section in the Tomahawk theme.

2011-01-12 Thread Jacques Le Roux (JIRA)
Webtools  Entity Reference: missing entity name page on title of the entity 
section in the Tomahawk theme.
---

 Key: OFBIZ-4112
 URL: https://issues.apache.org/jira/browse/OFBIZ-4112
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4109) Pagination is not working for the Entity Reference

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980820#action_12980820
 ] 

Jacques Le Roux commented on OFBIZ-4109:


BTW which version, interactive or static? it seems the problem is only in 
static, but it's not quire clear to what the problem is exactly...

  Pagination is not working for the Entity Reference
 ---

 Key: OFBIZ-4109
 URL: https://issues.apache.org/jira/browse/OFBIZ-4109
 Project: OFBiz
  Issue Type: Bug
  Components: framework
 Environment: Ubuntu 10.04
Reporter: Chatree Srichart

 I got an error when I use a pagination at Webtools  Entity Reference. It 
 look like the pagination is not working. I also didn't see an entity name on 
 a title of the entity section when I use the Tomahawk theme.
 Regards,
 Chatree Srichart

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4112) Webtools Entity Reference: missing entity name page on title of the entity section in the Tomahawk theme.

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980822#action_12980822
 ] 

Jacques Le Roux commented on OFBIZ-4112:


From Adrian's comment at OFBIZ-4109
{quote]
The Tomahawk theme hides the page title - so that is a problem in every screen. 
A separate issue should be created for that.
{quote]
it seems it's no only in this screen...

A picture could here ...

 Webtools  Entity Reference: missing entity name page on title of the entity 
 section in the Tomahawk theme.
 ---

 Key: OFBIZ-4112
 URL: https://issues.apache.org/jira/browse/OFBIZ-4112
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4112) Page title missing in the Tomahawk theme.

2011-01-12 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum updated OFBIZ-4112:
---

Priority: Minor  (was: Major)
 Summary: Page title missing in the Tomahawk theme.  (was: Webtools  
Entity Reference: missing entity name page on title of the entity section in 
the Tomahawk theme.)

 Page title missing in the Tomahawk theme.
 -

 Key: OFBIZ-4112
 URL: https://issues.apache.org/jira/browse/OFBIZ-4112
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux
Priority: Minor



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4112) Page title missing in the Tomahawk theme.

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980827#action_12980827
 ] 

Adrian Crum commented on OFBIZ-4112:


Steps to reproduce:

Got to Example main page. No page title is displayed above the New Example 
button. Switch visual theme to Flat Grey - the page title appears.


 Page title missing in the Tomahawk theme.
 -

 Key: OFBIZ-4112
 URL: https://issues.apache.org/jira/browse/OFBIZ-4112
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux
Priority: Minor



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (OFBIZ-4112) Page title missing in the Tomahawk theme.

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980827#action_12980827
 ] 

Adrian Crum edited comment on OFBIZ-4112 at 1/12/11 12:44 PM:
--

Steps to reproduce:

Go to Example main page using Tomahawk theme. No page title is displayed above 
the New Example button. Switch visual theme to Flat Grey - the page title 
appears.


  was (Author: adri...@hlmksw.com):
Steps to reproduce:

Got to Example main page. No page title is displayed above the New Example 
button. Switch visual theme to Flat Grey - the page title appears.

  
 Page title missing in the Tomahawk theme.
 -

 Key: OFBIZ-4112
 URL: https://issues.apache.org/jira/browse/OFBIZ-4112
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux
Priority: Minor



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4109) Pagination is not working for the Entity Reference

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980832#action_12980832
 ] 

Adrian Crum commented on OFBIZ-4109:


Go here:

https://localhost:8443/webtools/control/FindGeneric?entityName=GlAccountfind=trueVIEW_SIZE=50VIEW_INDEX=0


  Pagination is not working for the Entity Reference
 ---

 Key: OFBIZ-4109
 URL: https://issues.apache.org/jira/browse/OFBIZ-4109
 Project: OFBiz
  Issue Type: Bug
  Components: framework
 Environment: Ubuntu 10.04
Reporter: Chatree Srichart

 I got an error when I use a pagination at Webtools  Entity Reference. It 
 look like the pagination is not working. I also didn't see an entity name on 
 a title of the entity section when I use the Tomahawk theme.
 Regards,
 Chatree Srichart

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (OFBIZ-4112) Page title missing in the Tomahawk theme.

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980822#action_12980822
 ] 

Jacques Le Roux edited comment on OFBIZ-4112 at 1/12/11 12:58 PM:
--

From Adrian's comment at OFBIZ-4109
{quote}
The Tomahawk theme hides the page title - so that is a problem in every screen. 
A separate issue should be created for that.
{quote}
it seems it's no only in this screen...


  was (Author: jacques.le.roux):
From Adrian's comment at OFBIZ-4109
{quote]
The Tomahawk theme hides the page title - so that is a problem in every screen. 
A separate issue should be created for that.
{quote]
it seems it's no only in this screen...

A picture could here ...
  
 Page title missing in the Tomahawk theme.
 -

 Key: OFBIZ-4112
 URL: https://issues.apache.org/jira/browse/OFBIZ-4112
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux
Priority: Minor



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4112) Page title missing in the Tomahawk theme.

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980833#action_12980833
 ] 

Jacques Le Roux commented on OFBIZ-4112:


Thanks Adrian, it's quite clear!

 Page title missing in the Tomahawk theme.
 -

 Key: OFBIZ-4112
 URL: https://issues.apache.org/jira/browse/OFBIZ-4112
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux
Priority: Minor



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4110) Error while viewing list of time periods

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980843#action_12980843
 ] 

Jacques Le Roux commented on OFBIZ-4110:


I had any problems creating a Custom Time Period under Company with the same 
parameters than you as you can see here
https://demo-trunk.ofbiz.apache.org/accounting/control/createCustomTimePeriod 
(id= 1)

You need to give us more details. Most of the time URLs are enough and welcome
Else please follow this scenario (at leat relevant parts)

Why
* What you were looking for
* How did you try to achieve it
* What did you expect as results
* And what you really got
How
# What you did (including detailed steps to reproduce)
# What you expected to happen
# What actually happened (including exact quotes of error messages, etc)
# If possible provide an URL

Thanks

 Error while viewing list of time periods
 

 Key: OFBIZ-4110
 URL: https://issues.apache.org/jira/browse/OFBIZ-4110
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Release Branch 09.04
 Environment: OS: SunOS  5.9 
 kernel: Generic_122300-49 
 Machine: sun4u sparc SUNW,Netra-T12
 java version 1.5.0_09
 Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
 Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
Reporter: Andrey Mitroshin
Priority: Minor

 I've created custom time period in organization GL setting as follows
 Custom Time Period Id Parent Period IdPeriod Type Id  Period 
 Num  Period Name From Date   Thru Date
 10001 Fiscal Year 1   20112011-01-01  
 2011-12-31
 when I'm viewing list of time periods I'm getting a message on the last page 
 (where my new time period resides)
 The Following Errors Occurred:
 Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
 parameter [periodTypeId] passed to secure (https) request-map with uri 
 [createCustomTimePeriod] with an event that calls service 
 [createCustomTimePeriod]; this is not allowed for security reasons! The data 
 should be encrypted by making it part of the request body (a form field) 
 instead of the request URL. Moreover it would be kind if you could create a 
 Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check 
 before if a sub-task for this error does not exist). If you are not sure how 
 to create a Jira issue please have a look before at 
 http://docs.ofbiz.org/x/r. Thank you in advance for your help.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (OFBIZ-4110) Error while viewing list of time periods

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980843#action_12980843
 ] 

Jacques Le Roux edited comment on OFBIZ-4110 at 1/12/11 1:17 PM:
-

I had any problems creating a Custom Time Period under Company with the same 
parameters than you as you can see here
https://demo-trunk.ofbiz.apache.org/accounting/control/TimePeriods?organizationPartyId=Company
 (id= 1)

You need to give us more details. Most of the time an URL is enough and welcome
Else please follow this scenario (at leat relevant parts)

Why
* What you were looking for
* How did you try to achieve it
* What did you expect as results
* And what you really got
How
# What you did (including detailed steps to reproduce)
# What you expected to happen
# What actually happened (including exact quotes of error messages, etc)
# If possible provide an URL

Thanks

  was (Author: jacques.le.roux):
I had any problems creating a Custom Time Period under Company with the 
same parameters than you as you can see here
https://demo-trunk.ofbiz.apache.org/accounting/control/createCustomTimePeriod 
(id= 1)

You need to give us more details. Most of the time URLs are enough and welcome
Else please follow this scenario (at leat relevant parts)

Why
* What you were looking for
* How did you try to achieve it
* What did you expect as results
* And what you really got
How
# What you did (including detailed steps to reproduce)
# What you expected to happen
# What actually happened (including exact quotes of error messages, etc)
# If possible provide an URL

Thanks
  
 Error while viewing list of time periods
 

 Key: OFBIZ-4110
 URL: https://issues.apache.org/jira/browse/OFBIZ-4110
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Release Branch 09.04
 Environment: OS: SunOS  5.9 
 kernel: Generic_122300-49 
 Machine: sun4u sparc SUNW,Netra-T12
 java version 1.5.0_09
 Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
 Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
Reporter: Andrey Mitroshin
Priority: Minor

 I've created custom time period in organization GL setting as follows
 Custom Time Period Id Parent Period IdPeriod Type Id  Period 
 Num  Period Name From Date   Thru Date
 10001 Fiscal Year 1   20112011-01-01  
 2011-12-31
 when I'm viewing list of time periods I'm getting a message on the last page 
 (where my new time period resides)
 The Following Errors Occurred:
 Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
 parameter [periodTypeId] passed to secure (https) request-map with uri 
 [createCustomTimePeriod] with an event that calls service 
 [createCustomTimePeriod]; this is not allowed for security reasons! The data 
 should be encrypted by making it part of the request body (a form field) 
 instead of the request URL. Moreover it would be kind if you could create a 
 Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check 
 before if a sub-task for this error does not exist). If you are not sure how 
 to create a Jira issue please have a look before at 
 http://docs.ofbiz.org/x/r. Thank you in advance for your help.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Ryan Foster (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980862#action_12980862
 ] 

Ryan Foster commented on OFBIZ-4092:


I agree with you on the casing for the navigation and title.  

The casing on the buttons, and in fact the buttons themselves, are a different 
issue entirely.  The reason why I changed the casing with CSS is because there 
is no consistency in casing in the markup and labels.  Some button labels and 
values are all caps, some are lowercase, some are normal case; it's all over 
the map. 

Button styling in OFBiz has been something that has bugged me for years and I 
think it would be very beneficial to look at this as a separate issue in the 
near future.  There are currently 13, yes 13!, different button styles 
currently defined right now.  Just look at lines 2556 through 2573 in 
maincss.css.  We have:

.buttontext,
.buttontextbig,
.smallSubmit,
.mediumSubmit, 
.largeSubmit, 
.loginButton,
.button-style-1,
.button-style-2,
.button,
button,
input[type=reset],
input[type=submit],
input[type=button]

it's kind of ridiculous.  Why can't we simply have 1 button class and call it 
some obvious like .button or .btn?  We have been having a great discussion on 
UI labeling consistency, Edit vs. Update vs. Save, etc. which is awesome, 
but I think all of that is meaningless if the buttons themselves don't look the 
same.  Okay, I'll end my rant there.  Can you tell this is something of a hot 
button issue with me, pun completely intended ;)


 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, 
 brushed-aluminum.gif, catalog800x600.png, catalogManager.png, 
 content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, 
 partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980872#action_12980872
 ] 

Adrian Crum commented on OFBIZ-4092:


I understand your frustration. When the new styles were created the old styles 
were deprecated and we started to remove them - but that effort eventually 
fizzled out. In addition, we just introduced more styles with JQuery.

I agree it's a mess and we should create a new issue for that. Or we could just 
delete the deprecated styles from the style sheet and let the elements that use 
them break - that might motivate others to stop using them.

I started a Wiki page to document current styles and their intended use, but it 
hasn't been kept up-to-date:

https://cwiki.apache.org/OFBIZ/ofbiz-maincsscss-html-element-collection-styles.html


 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, 
 brushed-aluminum.gif, catalog800x600.png, catalogManager.png, 
 content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, 
 partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Ryan Foster (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883
 ] 

Ryan Foster commented on OFBIZ-4092:


I tried deleting deprecated styles and letting things break when I created the 
BizznessTime theme... mostly just pissed people off.  :)

 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, 
 brushed-aluminum.gif, catalog800x600.png, catalogManager.png, 
 content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, 
 partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980884#action_12980884
 ] 

Jacques Le Roux commented on OFBIZ-4092:


Yes, I agree we should really do an effort regarding this aspect an other 
closely related. As Adrian outlined, consistence is a key point!

 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, 
 brushed-aluminum.gif, catalog800x600.png, catalogManager.png, 
 content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, 
 partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Bruno Busco
In addition, when deprecating or selecting styles to be used we should
better use style names that describe what the button IS in the screen and
not HOW it should appear.

So style names like
.buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
.button-style-1, .button-style-2,

should not be used.

Style names like:
.buttontext,
.loginButton,
.button,
input[type=reset],
input[type=submit],
input[type=button]

are OK.
In this way the theme can make a button larger or smaller than another
button according to its function.

My two cents.
-Bruno

2011/1/12 Ryan Foster (JIRA) j...@apache.org


[
 https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883]

 Ryan Foster commented on OFBIZ-4092:
 

 I tried deleting deprecated styles and letting things break when I created
 the BizznessTime theme... mostly just pissed people off.  :)

  Update The Flat Grey Visual Theme
  -
 
  Key: OFBIZ-4092
  URL: https://issues.apache.org/jira/browse/OFBIZ-4092
  Project: OFBiz
   Issue Type: Improvement
   Components: framework
 Affects Versions: SVN trunk
 Reporter: Adrian Crum
 Assignee: Adrian Crum
 Priority: Minor
  Attachments: ac_flatgrey.patch, ac_images.zip,
 accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
 catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
 flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
 ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
 timeSheet.png
 
 
  Update the Flat Grey visual theme. Design objectives:
  1. Floating, flexible layout - screen can be resized.
  2. Sight impaired accessible - users can change font size in their
 browser.
  3. Supports RTL layout.
  4. Does not require JavaScript. JavaScript can be used to add
 embellishments, but the theme can't depend on it.

 --
 This message is automatically generated by JIRA.
 -
 You can reply to this email to add a comment to the issue online.




[jira] Commented: (OFBIZ-736) Apache Internet bookshop

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980899#action_12980899
 ] 

Jacques Le Roux commented on OFBIZ-736:
---

Should we keep this issue open?

 Apache Internet bookshop
 

 Key: OFBIZ-736
 URL: https://issues.apache.org/jira/browse/OFBIZ-736
 Project: OFBiz
  Issue Type: Wish
Reporter: Jacques Le Roux
Priority: Trivial

 Just a reminder since I can't find anything more about it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-348) Increasing font size makes a disaster in eCommerce, seems far better in back end

2011-01-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-348.
-

Resolution: Not A Problem

It's not perfect but it's really better now...

 Increasing font size makes a disaster in eCommerce, seems far better in back 
 end
 

 Key: OFBIZ-348
 URL: https://issues.apache.org/jira/browse/OFBIZ-348
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk


 When Increasing font size in eCommerce (using ctl+knob for instance) things 
 go wrong, seems far better in back end. Surely a CSS issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1119) Use the same backend colourful CSS in eCommerce

2011-01-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980902#action_12980902
 ] 

Jacques Le Roux commented on OFBIZ-1119:


Were there any attempt to continue this effort, else should we close?

 Use the same backend colourful CSS in eCommerce
 ---

 Key: OFBIZ-1119
 URL: https://issues.apache.org/jira/browse/OFBIZ-1119
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Priority: Trivial
 Fix For: SVN trunk

 Attachments: ecommain.patch, Just found this little quirk.jpg


 This cescription comes from Adrian's answer to a question I asked on the user 
 ML
 Jacques Le Roux wrote:
   A quick question (mostly intended to Adrian I guess). Why don't we use the 
 backend colourful CSS theme in eCommerce ?
 Jacques,
 The back office apps were styled based on the general agreement that the new 
 styles can target newer 
 browsers - older (non-compliant) browsers were not a concern.
 The eCommerce component needs to work with the majority of browsers - even 
 the broken ones. A lot of 
 the backend styling doesn't work in certain browsers, so we can't just copy 
 the back office styles 
 over to eCommerce.
 The approach taken in the back office apps could be repeated in eCommerce - 
 taking care to introduce 
 styles that will work in most browsers.
 One difference is you would want to specify sizes in pixels - so there will 
 be greater control over 
 the layout. The back office apps were made scalable (using ems) and 
 accessible - a good feature. As 
 a result, the layout is fluid - things move around when default font sizes 
 are changed or the 
 window size is changed. That behavior might be undesirable in eCommerce.
 Here are the steps taken during the back office UI refactoring:
 1. Eliminate redundant properties settings (fonts and font size for example) 
 in the main style 
 sheet. The Resets and Basic Element sections of maincss.css could be 
 copied over to facilitate 
 that (converting em to px in the process).
 2. Reduce the number of CSS styles by using descendent selectors. In other 
 words, style HTML element 
 compounds - not individual HTML elements.
 3. Convert table-based layout to CSS-based layout. Use the screenlet classes, 
 etc.
 The eCommerce style sheet will probably require browser-specific hacks. That 
 is an area I am not 
 proficient with. Maybe some CSS gurus in the developer community can help 
 with that.
 So, the bottom line is - the process used in the back office apps can be used 
 as a model, but the 
 steps need to be carried out differently to maintain browser compatibility.
 -Adrian

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Ryan Foster
Bruno,

I'll see your 2 cents, and raise you a dollar.  I agree, the naming of an 
element should never dictate how it looks or behaves; that is what properties 
are for.  You are opening up a can of worms with me when you start down that 
path, so careful what you wish for.  Buttons aren't the only offenders when it 
comes to that, the problem starts with the main decorator.  The layout of the 
backend and the front end center around the fact that we have column layouts 
with classNames of .left, .right, and .center.  What if I don't want .left on 
the left anymore?...

Ryan L. Foster
801.671.0769
cont...@ryanlfoster.com
ryanlfoster.com

On Jan 12, 2011, at 1:01 PM, Bruno Busco wrote:

 In addition, when deprecating or selecting styles to be used we should
 better use style names that describe what the button IS in the screen and
 not HOW it should appear.
 
 So style names like
 .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
 .button-style-1, .button-style-2,
 
 should not be used.
 
 Style names like:
 .buttontext,
 .loginButton,
 .button,
 input[type=reset],
 input[type=submit],
 input[type=button]
 
 are OK.
 In this way the theme can make a button larger or smaller than another
 button according to its function.
 
 My two cents.
 -Bruno
 
 2011/1/12 Ryan Foster (JIRA) j...@apache.org
 
 
   [
 https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883]
 
 Ryan Foster commented on OFBIZ-4092:
 
 
 I tried deleting deprecated styles and letting things break when I created
 the BizznessTime theme... mostly just pissed people off.  :)
 
 Update The Flat Grey Visual Theme
 -
 
Key: OFBIZ-4092
URL: https://issues.apache.org/jira/browse/OFBIZ-4092
Project: OFBiz
 Issue Type: Improvement
 Components: framework
   Affects Versions: SVN trunk
   Reporter: Adrian Crum
   Assignee: Adrian Crum
   Priority: Minor
Attachments: ac_flatgrey.patch, ac_images.zip,
 accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
 catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
 flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
 ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
 timeSheet.png
 
 
 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their
 browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add
 embellishments, but the theme can't depend on it.
 
 --
 This message is automatically generated by JIRA.
 -
 You can reply to this email to add a comment to the issue online.
 
 



Discussion: CSS styles (was: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme)

2011-01-12 Thread Adrian Crum
We need the smallSubmit style so we can style links to look like submit 
buttons. Maybe we could change the CSS class to a.smallSubmit to make 
sure it is used only for a elements.


The button-style-1 and button-style-2 style names are pretty generic - 
they don't indicate how the button should appear (aside from the obvious 
- that they should look like buttons). Originally, the rows of buttons 
below the page title had two styles that indicated two types of buttons: 
those that linked to other pages within the application (intra-app) and 
others that linked to pages outside the application (inter-app). That 
distinction has been lost in recent changes.


A similar thing was done with the table header styles - there are two 
styles to choose from, depending on how you use them. The style names 
don't indicate what they look like.


I don't think there is anything wrong with having more than one style to 
choose from. If we were to cut back too much on the selection, then the 
UI would start to look bland or monotonous.


I created a Wiki page that listed some of the deprecated styles and 
another page that describes the new styles and how they should be used. 
Those pages are effective only when people take the time to read them.


-Adrian

On 1/12/2011 12:01 PM, Bruno Busco wrote:

In addition, when deprecating or selecting styles to be used we should
better use style names that describe what the button IS in the screen and
not HOW it should appear.

So style names like
.buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
.button-style-1, .button-style-2,

should not be used.

Style names like:
.buttontext,
.loginButton,
.button,
input[type=reset],
input[type=submit],
input[type=button]

are OK.
In this way the theme can make a button larger or smaller than another
button according to its function.

My two cents.
-Bruno

2011/1/12 Ryan Foster (JIRA)j...@apache.org



[
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883]

Ryan Foster commented on OFBIZ-4092:


I tried deleting deprecated styles and letting things break when I created
the BizznessTime theme... mostly just pissed people off.  :)


Update The Flat Grey Visual Theme
-

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip,

accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
timeSheet.png



Update the Flat Grey visual theme. Design objectives:
1. Floating, flexible layout - screen can be resized.
2. Sight impaired accessible - users can change font size in their

browser.

3. Supports RTL layout.
4. Does not require JavaScript. JavaScript can be used to add

embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.






[jira] Commented: (OFBIZ-4091) Internationalization of ServiceUtil.returnSuccess, ServiceUtil.returnFailure, ServiceUtil.returnError

2011-01-12 Thread Marco Risaliti (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980926#action_12980926
 ] 

Marco Risaliti commented on OFBIZ-4091:
---

content/ordermgr (except one) component is now ok. 

 Internationalization of ServiceUtil.returnSuccess, ServiceUtil.returnFailure, 
 ServiceUtil.returnError
 -

 Key: OFBIZ-4091
 URL: https://issues.apache.org/jira/browse/OFBIZ-4091
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Marco Risaliti
Assignee: Marco Risaliti
Priority: Minor
 Fix For: SVN trunk


 Actually there are more than 800 reference to hard-coded labels into call to 
 ServiceUtil.returnSuccess, ServiceUtil.returnFailure, ServiceUtil.returnError 
 and those messages cannot be translate.
 I will start to remove it and this issue is for track the status of the 
 conversion.
 Thanks
 Marco

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



buildbot failure in ASF Buildbot on ofbiz-trunk

2011-01-12 Thread buildbot
The Buildbot has detected a new failure of ofbiz-trunk on ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/ofbiz-trunk/builds/1072

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason: 
Build Source Stamp: [branch ofbiz/trunk] 1058311
Blamelist: mrisaliti

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot



Re: Discussion: CSS styles (was: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme)

2011-01-12 Thread Ryan Foster
Consistency is not synonymous with monotonous.  Hey, that sounds like a good 
catch phrase... Consistency is not synonymous with monotonous™

But seriously, if different elements perform the same way then they should look 
the same and be called the same thing.  There is no reason why we can't have 
button class=btn, input type=submit class=btn, and a class=btn if 
they all do the same thing.  That doesn't make the UI bland, it makes it 
consistent and familiar.  I'm all for having options, but they should be done 
with a purpose.  For instance, we could a primary button style, a secondary 
button style and a tertiary button style, but these should be combinations, not 
individual style.  For example:

a href=# class=btn primary
a href=# class=btn secondary 
a href=# class=btn tertiary 

That way, we could apply a consistent button style and then make adjustments if 
we need to based on what action the button performs, Save vs. Cancel, etc.  But 
simply having a button-style-1, and a button-style-2 because maybe we want to 
have a blue button and a green button is not a good reason, no is it a good 
idea.  Having 2 buttons that perform the same, but look different just confuses 
the user and makes an already complex application even more difficult to use.

Ryan L. Foster
801.671.0769
cont...@ryanlfoster.com
ryanlfoster.com

On Jan 12, 2011, at 1:30 PM, Adrian Crum wrote:

 We need the smallSubmit style so we can style links to look like submit 
 buttons. Maybe we could change the CSS class to a.smallSubmit to make sure 
 it is used only for a elements.
 
 The button-style-1 and button-style-2 style names are pretty generic - they 
 don't indicate how the button should appear (aside from the obvious - that 
 they should look like buttons). Originally, the rows of buttons below the 
 page title had two styles that indicated two types of buttons: those that 
 linked to other pages within the application (intra-app) and others that 
 linked to pages outside the application (inter-app). That distinction has 
 been lost in recent changes.
 
 A similar thing was done with the table header styles - there are two styles 
 to choose from, depending on how you use them. The style names don't indicate 
 what they look like.
 
 I don't think there is anything wrong with having more than one style to 
 choose from. If we were to cut back too much on the selection, then the UI 
 would start to look bland or monotonous.
 
 I created a Wiki page that listed some of the deprecated styles and another 
 page that describes the new styles and how they should be used. Those pages 
 are effective only when people take the time to read them.
 
 -Adrian
 
 On 1/12/2011 12:01 PM, Bruno Busco wrote:
 In addition, when deprecating or selecting styles to be used we should
 better use style names that describe what the button IS in the screen and
 not HOW it should appear.
 
 So style names like
 .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
 .button-style-1, .button-style-2,
 
 should not be used.
 
 Style names like:
 .buttontext,
 .loginButton,
 .button,
 input[type=reset],
 input[type=submit],
 input[type=button]
 
 are OK.
 In this way the theme can make a button larger or smaller than another
 button according to its function.
 
 My two cents.
 -Bruno
 
 2011/1/12 Ryan Foster (JIRA)j...@apache.org
 
 
[
 https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883]
 
 Ryan Foster commented on OFBIZ-4092:
 
 
 I tried deleting deprecated styles and letting things break when I created
 the BizznessTime theme... mostly just pissed people off.  :)
 
 Update The Flat Grey Visual Theme
 -
 
 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip,
 accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
 catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
 flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
 ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
 timeSheet.png
 
 
 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their
 browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add
 embellishments, but the theme can't depend on it.
 
 --
 This message is automatically generated by JIRA.
 -
 You can reply to this email to add a comment to the issue online.
 
 
 



Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Jacques Le Roux

That's great guys, but it would be better if you could keep your comments in 
the OFBIZ-4092
Really easier later when looking back to have things centralized somewhere (I 
saw Adrian tried to create a new thread...)

Thanks

Jacques

Ryan Foster wrote:

Bruno,

I'll see your 2 cents, and raise you a dollar.  I agree, the naming of an 
element should never dictate how it looks or behaves;
that is what properties are for.  You are opening up a can of worms with me 
when you start down that path, so careful what you
wish for.  Buttons aren't the only offenders when it comes to that, the problem 
starts with the main decorator.  The layout of
the backend and the front end center around the fact that we have column 
layouts with classNames of .left, .right, and .center.
What if I don't want .left on the left anymore?...

Ryan L. Foster
801.671.0769
cont...@ryanlfoster.com
ryanlfoster.com

On Jan 12, 2011, at 1:01 PM, Bruno Busco wrote:


In addition, when deprecating or selecting styles to be used we should
better use style names that describe what the button IS in the screen and
not HOW it should appear.

So style names like
.buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
.button-style-1, .button-style-2,

should not be used.

Style names like:
.buttontext,
.loginButton,
.button,
input[type=reset],
input[type=submit],
input[type=button]

are OK.
In this way the theme can make a button larger or smaller than another
button according to its function.

My two cents.
-Bruno

2011/1/12 Ryan Foster (JIRA) j...@apache.org



  [
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883]

Ryan Foster commented on OFBIZ-4092:


I tried deleting deprecated styles and letting things break when I created
the BizznessTime theme... mostly just pissed people off.  :)


Update The Flat Grey Visual Theme
-

   Key: OFBIZ-4092
   URL: https://issues.apache.org/jira/browse/OFBIZ-4092
   Project: OFBiz
Issue Type: Improvement
Components: framework
  Affects Versions: SVN trunk
  Reporter: Adrian Crum
  Assignee: Adrian Crum
  Priority: Minor
   Attachments: ac_flatgrey.patch, ac_images.zip,

accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
timeSheet.png



Update the Flat Grey visual theme. Design objectives:
1. Floating, flexible layout - screen can be resized.
2. Sight impaired accessible - users can change font size in their

browser.

3. Supports RTL layout.
4. Does not require JavaScript. JavaScript can be used to add

embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online. 





Re: Discussion: CSS styles

2011-01-12 Thread Adrian Crum
Keep in mind that the button-style-* classes are button-bar decorators. 
Having two buttons that perform the same but look different was not an 
issue here - the two styles indicated two different purposes, PLUS they 
were in different button bars. So, you had a row of buttons in one style 
that were intra-app, and another row of buttons in a different style 
that were inter-app. There was no confusion - the styles and the 
separation into two rows were a clear visual indicator of where the link 
was going to take you.


The purpose of the button-bar style was to provide a container for 
graphic artists to design around. The buttons could be arranged in a row 
(the current orientation) or they could be a vertical stack.


-Adrian

On 1/12/2011 1:05 PM, Ryan Foster wrote:

Consistency is not synonymous with monotonous.  Hey, that sounds like a good 
catch phrase... Consistency is not synonymous with monotonous™

But seriously, if different elements perform the same way then they should look the same and be called the same thing.  There is no 
reason why we can't havebutton class=btn,input type=submit class=btn, anda 
class=btn  if they all do the same thing.  That doesn't make the UI bland, it makes it consistent and familiar.  I'm all 
for having options, but they should be done with a purpose.  For instance, we could a primary button style, a secondary button style and 
a tertiary button style, but these should be combinations, not individual style.  For example:

a href=# class=btn primary
a href=# class=btn secondary
a href=# class=btn tertiary

That way, we could apply a consistent button style and then make adjustments if 
we need to based on what action the button performs, Save vs. Cancel, etc.  But 
simply having a button-style-1, and a button-style-2 because maybe we want to 
have a blue button and a green button is not a good reason, no is it a good 
idea.  Having 2 buttons that perform the same, but look different just confuses 
the user and makes an already complex application even more difficult to use.

Ryan L. Foster
801.671.0769
cont...@ryanlfoster.com
ryanlfoster.com

On Jan 12, 2011, at 1:30 PM, Adrian Crum wrote:


We need the smallSubmit style so we can style links to look like submit buttons. Maybe we could 
change the CSS class to a.smallSubmit to make sure it is used only fora  
elements.

The button-style-1 and button-style-2 style names are pretty generic - they 
don't indicate how the button should appear (aside from the obvious - that they 
should look like buttons). Originally, the rows of buttons below the page title 
had two styles that indicated two types of buttons: those that linked to other 
pages within the application (intra-app) and others that linked to pages 
outside the application (inter-app). That distinction has been lost in recent 
changes.

A similar thing was done with the table header styles - there are two styles to 
choose from, depending on how you use them. The style names don't indicate what 
they look like.

I don't think there is anything wrong with having more than one style to choose 
from. If we were to cut back too much on the selection, then the UI would start 
to look bland or monotonous.

I created a Wiki page that listed some of the deprecated styles and another 
page that describes the new styles and how they should be used. Those pages are 
effective only when people take the time to read them.

-Adrian

On 1/12/2011 12:01 PM, Bruno Busco wrote:

In addition, when deprecating or selecting styles to be used we should
better use style names that describe what the button IS in the screen and
not HOW it should appear.

So style names like
.buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
.button-style-1, .button-style-2,

should not be used.

Style names like:
.buttontext,
.loginButton,
.button,
input[type=reset],
input[type=submit],
input[type=button]

are OK.
In this way the theme can make a button larger or smaller than another
button according to its function.

My two cents.
-Bruno

2011/1/12 Ryan Foster (JIRA)j...@apache.org



[
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980883#action_12980883]

Ryan Foster commented on OFBIZ-4092:


I tried deleting deprecated styles and letting things break when I created
the BizznessTime theme... mostly just pissed people off.  :)


Update The Flat Grey Visual Theme
-

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_images.zip,

accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
catalogManager.png, 

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2011-01-12 Thread risali...@gmail.com
Hi dev,

anyone having this failed during compile, I have tried those steps and I have 
not any build failed :

ant clean-all
ant build
ant run-install
ant create-admin-user-login
ant run-tests

any suggestion to solve is appreciated.

Thanks
Marco

Il giorno 12/gen/2011, alle ore 22.03, build...@apache.org ha scritto:

 The Buildbot has detected a new failure of ofbiz-trunk on ASF Buildbot.
 Full details are available at:
 http://ci.apache.org/builders/ofbiz-trunk/builds/1072
 
 Buildbot URL: http://ci.apache.org/
 
 Buildslave for this Build: isis_ubuntu
 
 Build Reason: 
 Build Source Stamp: [branch ofbiz/trunk] 1058311
 Blamelist: mrisaliti
 
 BUILD FAILED: failed compile_1
 
 sincerely,
 -The Buildbot
 



Re: Discussion: CSS styles

2011-01-12 Thread Adrian Crum
Some background and additional thoughts for the community in general, 
not Ryan specifically...


In 2007 the UI was refactored - partially because of the same reason 
mentioned here: too many styles in the style sheet and no consistency in 
their use.


At around the same time we were also adding a lot of new contributors 
and committers to the community. I started to notice that the UI layout 
was losing consistency - and I assumed it was because the new commits 
weren't being checked thoroughly.


In 2008 there was another UI refactor that drastically changed the 
layout - where nearly every screen was wrapped in a screenlet. That 
layout change was never discussed with the community, and I have no idea 
why it was made.


So, I created a Wiki page of UI Layout Best Practices for others to 
refer to:


https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices

That document is intended to describe basic layout - from a typesetter's 
perspective. Specific CSS styles shouldn't be mentioned in it, but they 
are - and I plan to fix that when I have time. The document is based on 
the de-facto UI layout prior to things going bad.


I use those Best Practices myself - even recently when I moved the 
security UI artifacts from the Party component to the Common component. 
Once I understand the basic layout, I go to the HTML markup page:


https://cwiki.apache.org/OFBIZ/ofbiz-maincsscss-html-element-collection-styles.html

to see what styles are available to lay out the page.

It was my hope that those documents would help keep the UI consistent, 
but like I said earlier - they are only effective if people read them.


I said all that to say this: It's common for style sheets to bloat, and 
it's common for UI layout to creep. It takes conversations like this one 
to bring the bloat and creep to the community's attention, but it won't 
change until someone takes action.


-Adrian


On 1/12/2011 1:29 PM, Adrian Crum wrote:

Keep in mind that the button-style-* classes are button-bar decorators.
Having two buttons that perform the same but look different was not an
issue here - the two styles indicated two different purposes, PLUS they
were in different button bars. So, you had a row of buttons in one style
that were intra-app, and another row of buttons in a different style
that were inter-app. There was no confusion - the styles and the
separation into two rows were a clear visual indicator of where the link
was going to take you.

The purpose of the button-bar style was to provide a container for
graphic artists to design around. The buttons could be arranged in a row
(the current orientation) or they could be a vertical stack.

-Adrian

On 1/12/2011 1:05 PM, Ryan Foster wrote:

Consistency is not synonymous with monotonous. Hey, that sounds like a
good catch phrase... Consistency is not synonymous with monotonous™

But seriously, if different elements perform the same way then they
should look the same and be called the same thing. There is no reason
why we can't havebutton class=btn,input type=submit
class=btn, anda class=btn if they all do the same thing. That
doesn't make the UI bland, it makes it consistent and familiar. I'm
all for having options, but they should be done with a purpose. For
instance, we could a primary button style, a secondary button style
and a tertiary button style, but these should be combinations, not
individual style. For example:

a href=# class=btn primary
a href=# class=btn secondary
a href=# class=btn tertiary

That way, we could apply a consistent button style and then make
adjustments if we need to based on what action the button performs,
Save vs. Cancel, etc. But simply having a button-style-1, and a
button-style-2 because maybe we want to have a blue button and a green
button is not a good reason, no is it a good idea. Having 2 buttons
that perform the same, but look different just confuses the user and
makes an already complex application even more difficult to use.

Ryan L. Foster
801.671.0769
cont...@ryanlfoster.com
ryanlfoster.com

On Jan 12, 2011, at 1:30 PM, Adrian Crum wrote:


We need the smallSubmit style so we can style links to look like
submit buttons. Maybe we could change the CSS class to
a.smallSubmit to make sure it is used only fora elements.

The button-style-1 and button-style-2 style names are pretty generic
- they don't indicate how the button should appear (aside from the
obvious - that they should look like buttons). Originally, the rows
of buttons below the page title had two styles that indicated two
types of buttons: those that linked to other pages within the
application (intra-app) and others that linked to pages outside the
application (inter-app). That distinction has been lost in recent
changes.

A similar thing was done with the table header styles - there are two
styles to choose from, depending on how you use them. The style names
don't indicate what they look like.

I don't think there is anything wrong 

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2011-01-12 Thread Adrian Crum

Try running a fresh checkout locally.

-Adrian

On 1/12/2011 2:05 PM, risali...@gmail.com wrote:

Hi dev,

anyone having this failed during compile, I have tried those steps and I have 
not any build failed :

ant clean-all
ant build
ant run-install
ant create-admin-user-login
ant run-tests

any suggestion to solve is appreciated.

Thanks
Marco

Il giorno 12/gen/2011, alle ore 22.03, build...@apache.org ha scritto:


The Buildbot has detected a new failure of ofbiz-trunk on ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/1072

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason:
Build Source Stamp: [branch ofbiz/trunk] 1058311
Blamelist: mrisaliti

BUILD FAILED: failed compile_1

sincerely,
-The Buildbot






Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2011-01-12 Thread risali...@gmail.com
Ok, thanks Adrian.
Probably it was an issue on ASF server because I have done another commit and 
the issue seems no more present.

Marco 

Il giorno 12/gen/2011, alle ore 23.45, Adrian Crum ha scritto:

 Try running a fresh checkout locally.
 
 -Adrian
 
 On 1/12/2011 2:05 PM, risali...@gmail.com wrote:
 Hi dev,
 
 anyone having this failed during compile, I have tried those steps and I 
 have not any build failed :
 
 ant clean-all
 ant build
 ant run-install
 ant create-admin-user-login
 ant run-tests
 
 any suggestion to solve is appreciated.
 
 Thanks
 Marco
 
 Il giorno 12/gen/2011, alle ore 22.03, build...@apache.org ha scritto:
 
 The Buildbot has detected a new failure of ofbiz-trunk on ASF Buildbot.
 Full details are available at:
 http://ci.apache.org/builders/ofbiz-trunk/builds/1072
 
 Buildbot URL: http://ci.apache.org/
 
 Buildslave for this Build: isis_ubuntu
 
 Build Reason:
 Build Source Stamp: [branch ofbiz/trunk] 1058311
 Blamelist: mrisaliti
 
 BUILD FAILED: failed compile_1
 
 sincerely,
 -The Buildbot
 
 
 



Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2011-01-12 Thread Adrian Crum
Sometimes the buildbot fails when the checkout takes too long. It should 
say that though - Build failed: svn checkout or something similar.


-Adrian

On 1/12/2011 3:02 PM, risali...@gmail.com wrote:

Ok, thanks Adrian.
Probably it was an issue on ASF server because I have done another commit and 
the issue seems no more present.

Marco

Il giorno 12/gen/2011, alle ore 23.45, Adrian Crum ha scritto:


Try running a fresh checkout locally.

-Adrian

On 1/12/2011 2:05 PM, risali...@gmail.com wrote:

Hi dev,

anyone having this failed during compile, I have tried those steps and I have 
not any build failed :

ant clean-all
ant build
ant run-install
ant create-admin-user-login
ant run-tests

any suggestion to solve is appreciated.

Thanks
Marco

Il giorno 12/gen/2011, alle ore 22.03, build...@apache.org ha scritto:


The Buildbot has detected a new failure of ofbiz-trunk on ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/1072

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason:
Build Source Stamp: [branch ofbiz/trunk] 1058311
Blamelist: mrisaliti

BUILD FAILED: failed compile_1

sincerely,
-The Buildbot









Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2011-01-12 Thread Adrian Crum

I haven't seen a message indicating a successful build.

-Adrian

On 1/12/2011 3:02 PM, risali...@gmail.com wrote:

Ok, thanks Adrian.
Probably it was an issue on ASF server because I have done another commit and 
the issue seems no more present.

Marco

Il giorno 12/gen/2011, alle ore 23.45, Adrian Crum ha scritto:


Try running a fresh checkout locally.

-Adrian

On 1/12/2011 2:05 PM, risali...@gmail.com wrote:

Hi dev,

anyone having this failed during compile, I have tried those steps and I have 
not any build failed :

ant clean-all
ant build
ant run-install
ant create-admin-user-login
ant run-tests

any suggestion to solve is appreciated.

Thanks
Marco

Il giorno 12/gen/2011, alle ore 22.03, build...@apache.org ha scritto:


The Buildbot has detected a new failure of ofbiz-trunk on ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/1072

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason:
Build Source Stamp: [branch ofbiz/trunk] 1058311
Blamelist: mrisaliti

BUILD FAILED: failed compile_1

sincerely,
-The Buildbot









[jira] Created: (OFBIZ-4113) updateRequirement savedValue variable never used

2011-01-12 Thread Paul Foxworthy (JIRA)
updateRequirement savedValue variable never used


 Key: OFBIZ-4113
 URL: https://issues.apache.org/jira/browse/OFBIZ-4113
 Project: OFBiz
  Issue Type: Bug
  Components: marketing
Affects Versions: SVN trunk
 Environment: rev 1058379
Reporter: Paul Foxworthy
Priority: Minor
 Fix For: SVN trunk


The updateRequirement simple method in 
applications/order/script/org/ofbiz/order/requirement/RequirementServices.xml
creates a variable called savedValue that is never used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4113) updateRequirement savedValue variable never used

2011-01-12 Thread Paul Foxworthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-4113:
--

Attachment: OFBIZ-4113_updateRequirements.patch

 updateRequirement savedValue variable never used
 

 Key: OFBIZ-4113
 URL: https://issues.apache.org/jira/browse/OFBIZ-4113
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
 Environment: rev 1058379
Reporter: Paul Foxworthy
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4113_updateRequirements.patch


 The updateRequirement simple method in 
 applications/order/script/org/ofbiz/order/requirement/RequirementServices.xml
 creates a variable called savedValue that is never used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4113) updateRequirement savedValue variable never used

2011-01-12 Thread Paul Foxworthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-4113:
--

Component/s: (was: marketing)
 order

 updateRequirement savedValue variable never used
 

 Key: OFBIZ-4113
 URL: https://issues.apache.org/jira/browse/OFBIZ-4113
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
 Environment: rev 1058379
Reporter: Paul Foxworthy
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-4113_updateRequirements.patch


 The updateRequirement simple method in 
 applications/order/script/org/ofbiz/order/requirement/RequirementServices.xml
 creates a variable called savedValue that is never used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-4114) ServiceUtil.returnError called but its result not returned

2011-01-12 Thread Paul Foxworthy (JIRA)
ServiceUtil.returnError called but its result not returned
--

 Key: OFBIZ-4114
 URL: https://issues.apache.org/jira/browse/OFBIZ-4114
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: SVN trunk
 Environment: rev 1058379
Reporter: Paul Foxworthy
Priority: Minor
 Fix For: SVN trunk


In 
applications/accounting/src/org/ofbiz/accounting/Invoice/InvoiceServices.java, 
there are numerous calls to ServiceUtil.returnError where nothing is done with 
the result of the call. Surely a

return ServiceUtil.returnError

was intended?

A grep turned up one other place with a similar problem, PosTransaction.java .

Patches attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4114) ServiceUtil.returnError called but its result not returned

2011-01-12 Thread Paul Foxworthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-4114:
--

Attachment: OFBIZ-4114_PosTransaction_returnError_result_not_returned.patch
OFBIZ-4114_InvoiceServices_returnError_result_not_returned.patch

 ServiceUtil.returnError called but its result not returned
 --

 Key: OFBIZ-4114
 URL: https://issues.apache.org/jira/browse/OFBIZ-4114
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: SVN trunk
 Environment: rev 1058379
Reporter: Paul Foxworthy
Priority: Minor
 Fix For: SVN trunk

 Attachments: 
 OFBIZ-4114_InvoiceServices_returnError_result_not_returned.patch, 
 OFBIZ-4114_PosTransaction_returnError_result_not_returned.patch


 In 
 applications/accounting/src/org/ofbiz/accounting/Invoice/InvoiceServices.java,
  there are numerous calls to ServiceUtil.returnError where nothing is done 
 with the result of the call. Surely a
 return ServiceUtil.returnError
 was intended?
 A grep turned up one other place with a similar problem, PosTransaction.java .
 Patches attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1119) Use the same backend colourful CSS in eCommerce

2011-01-12 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981148#action_12981148
 ] 

Adrian Crum commented on OFBIZ-1119:


There are still a lot of places where the deprecated box* CSS styles are used. 
Those need to be changed to use the new screenlet* CSS classes.


 Use the same backend colourful CSS in eCommerce
 ---

 Key: OFBIZ-1119
 URL: https://issues.apache.org/jira/browse/OFBIZ-1119
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Priority: Trivial
 Fix For: SVN trunk

 Attachments: ecommain.patch, Just found this little quirk.jpg


 This cescription comes from Adrian's answer to a question I asked on the user 
 ML
 Jacques Le Roux wrote:
   A quick question (mostly intended to Adrian I guess). Why don't we use the 
 backend colourful CSS theme in eCommerce ?
 Jacques,
 The back office apps were styled based on the general agreement that the new 
 styles can target newer 
 browsers - older (non-compliant) browsers were not a concern.
 The eCommerce component needs to work with the majority of browsers - even 
 the broken ones. A lot of 
 the backend styling doesn't work in certain browsers, so we can't just copy 
 the back office styles 
 over to eCommerce.
 The approach taken in the back office apps could be repeated in eCommerce - 
 taking care to introduce 
 styles that will work in most browsers.
 One difference is you would want to specify sizes in pixels - so there will 
 be greater control over 
 the layout. The back office apps were made scalable (using ems) and 
 accessible - a good feature. As 
 a result, the layout is fluid - things move around when default font sizes 
 are changed or the 
 window size is changed. That behavior might be undesirable in eCommerce.
 Here are the steps taken during the back office UI refactoring:
 1. Eliminate redundant properties settings (fonts and font size for example) 
 in the main style 
 sheet. The Resets and Basic Element sections of maincss.css could be 
 copied over to facilitate 
 that (converting em to px in the process).
 2. Reduce the number of CSS styles by using descendent selectors. In other 
 words, style HTML element 
 compounds - not individual HTML elements.
 3. Convert table-based layout to CSS-based layout. Use the screenlet classes, 
 etc.
 The eCommerce style sheet will probably require browser-specific hacks. That 
 is an area I am not 
 proficient with. Maybe some CSS gurus in the developer community can help 
 with that.
 So, the bottom line is - the process used in the back office apps can be used 
 as a model, but the 
 steps need to be carried out differently to maintain browser compatibility.
 -Adrian

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-12 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum updated OFBIZ-4092:
---

Attachment: ac_flatgrey.patch
ac_images.zip

Updated files. Contains Ryan's appbar.ftl plus bug fixes. I converted the 
masthead and main nav png images to gif - so the transitions are smoother. 
Masthead and main nav can be increased to any size without breaking. Improved 
seed data - OFBiz icon doesn't need to be in framework/images any more. 
Tightened up spacing a little on app navigation.

These changes are suggestions - comments are welcome.


 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, 
 ac_images.zip, accounting800x600.png, brushed-aluminum.gif, 
 catalog800x600.png, catalogManager.png, content800x600.png, 
 contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, 
 partyManager.png, screenshot.gif, timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-736) Apache Internet bookshop

2011-01-12 Thread Sascha Rodekamp (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981163#action_12981163
 ] 

Sascha Rodekamp commented on OFBIZ-736:
---

Do this book store idea still exist? I like the idea having such a demo 
system with a real world focus.

But the post is no four years old and the links are dead. So i think if this 
Apache book store doesn't exist anymore we can close it.
Cheers 


 Apache Internet bookshop
 

 Key: OFBIZ-736
 URL: https://issues.apache.org/jira/browse/OFBIZ-736
 Project: OFBiz
  Issue Type: Wish
Reporter: Jacques Le Roux
Priority: Trivial

 Just a reminder since I can't find anything more about it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.