Re: AccountingErrorUiLabels modified on trunk demo

2011-03-04 Thread David E Jones 

Quick note: unless you know:

1. where the changes came from
2. what the purpose is
3. how they do it and what each change actually does

please don't commit it!

In this case, maybe someone just ran the label tool stuff or something. It's a 
bad place to look for contributions in general.

-David


On Mar 3, 2011, at 3:11 AM, Jacques Le Roux wrote:

 Hi,
 
 Is there any reasons AccountingErrorUiLabels has been modified on trunk demo 
 and not committed rather?
 Should we apply the patch, revert?
 
 Index: applications/accounting/config/AccountingErrorUiLabels.xml
 ===
 --- applications/accounting/config/AccountingErrorUiLabels.xml (revision 
 1076533)
 +++ applications/accounting/config/AccountingErrorUiLabels.xml (working copy)
 @@ -19,11 +19,6 @@
under the License.
 --
 resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
 -property key=AccountingDeleteRateAmount
 -value xml:lang=enCould not find RateAmount record to be 
 deleted/value
 -value xml:lang=itNon è possibile trovare un record di 
 RateAmount che deve essere cancellato/value
 -value xml:lang=ptNão foi possà vel localizar o registro a ser 
 excluà do RateAmount/value
 -/property
property key=AccountingEftAccountCannotBeCreated
value xml:lang=enERROR: Could not create payment method Id (id 
 generation failure)/value
value xml:lang=itERRORE: Non è possibile creare il metodo 
 pagamento (fallimento generazione id)/value
 @@ -384,6 +379,42 @@
value xml:lang=enData error getting tax settings: 
 ${errorString}/value
value xml:lang=itErrore di lettura impostazioni tasse: 
 ${errorString}/value
/property
 +property 
 key=idealEvents.failedToExecuteServiceCreatePaymentFromPreference
 +value xml:lang=enFailed To Execute Service 
 CreatePaymentFromPreference/value
 +value xml:lang=frÉchec sur l'execution du service de création 
 d'un payment suivant les préférence (CreatePaymentFromPreference)/value
 +value xml:lang=hi_INसर्विस 
 CreatePaymentFromPreference पर अमल(execute) करने में 
 असफल/value
 +value xml:lang=itFallita esecuzione servizio 
 CreatePaymentFromPreference/value
 +/property
 +property key=idealEvents.noValidOrderIdReturned
 +value xml:lang=enNo Valid OrderId Returned/value
 +value xml:lang=frRéférence commande retournée n'est pas 
 valide/value
 +value xml:lang=hi_INमान्य OrderId वापस 
 नहीं लौटा/value
 +value xml:lang=itNessun numero ordine restituito/value
 +/property
 +property key=idealEvents.problemsConnectingWithIdeal
 +value xml:lang=enProblems Connecting With iDEAL/value
 +value xml:lang=frProblème rencontré dans la connexion avec 
 iDEAL/value
 +value xml:lang=hi_INiDEAL के साथ जोड़ने 
 में समस्या/value
 +value xml:lang=itProblema nella connessione con iDEAL/value
 +/property
 +property key=idealEvents.problemsGettingAuthenticationUser
 +value xml:lang=enProblems Getting Authentication User/value
 +value xml:lang=frProblème sur l'authentification de 
 l'utilisateur/value
 +value xml:lang=hi_INउपयोगकर्ता(user) के 
 प्रमाणीकरण में समस्याएँ हो 
 रही/value
 +value xml:lang=itProblema durante l'autenticazione utente/value
 +/property
 +property key=idealEvents.problemsGettingMerchantConfiguration
 +value xml:lang=enProblems Getting Merchant Configuration/value
 +value xml:lang=frProblème de récupération de la configuration 
 marchand/value
 +value xml:lang=hi_INव्यापारी 
 विन्यास में समस्याएँ हो 
 रही/value
 +value xml:lang=itProblema nel ricavare la configurazione del 
 negoziante/value
 +/property
 +property key=idealEvents.problemsGettingOrderHeader
 +value xml:lang=enProblems Getting OrderHeader/value
 +value xml:lang=frProblème de récupération de la 
 commande/value
 +value xml:lang=hi_INOrderHeader में 
 समस्याएँ हो रही/value
 +value xml:lang=itProblema nel ricavare la testata ordine/value
 +/property
property 
 key=payPalEvents.failedToExecuteServiceCreatePaymentFromPreference
value xml:lang=enFailed to execute service 
 createPaymentFromPreference/value
value xml:lang=frEchec à l'exécution du service 
 createPaymentFromPreference/value
 @@ -517,40 +548,4 @@
value xml:lang=itProblema nel ricavare la testata ordine/value
value xml:lang=ptProblemas Obtendo OrderHeader/value
/property
 -property 
 key=idealEvents.failedToExecuteServiceCreatePaymentFromPreference
 -value xml:lang=enFailed To

Re: AccountingErrorUiLabels modified on trunk demo

2011-03-04 Thread Jacques Le Roux 

Ha good point, I did not think about the Label Manager.
I  will revert Tueday on trunk demo and will do so later if I come across such 
changes

Thanks David!

Jacques

From: David E Jones d...@me.com

Quick note: unless you know:

1. where the changes came from
2. what the purpose is
3. how they do it and what each change actually does

please don't commit it!

In this case, maybe someone just ran the label tool stuff or something. It's a 
bad place to look for contributions in general.

-David


On Mar 3, 2011, at 3:11 AM, Jacques Le Roux wrote:


Hi,

Is there any reasons AccountingErrorUiLabels has been modified on trunk demo 
and not committed rather?
Should we apply the patch, revert?

Index: applications/accounting/config/AccountingErrorUiLabels.xml
===
--- applications/accounting/config/AccountingErrorUiLabels.xml (revision 
1076533)
+++ applications/accounting/config/AccountingErrorUiLabels.xml (working copy)
@@ -19,11 +19,6 @@
   under the License.
--
resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
-property key=AccountingDeleteRateAmount
-value xml:lang=enCould not find RateAmount record to be 
deleted/value
-value xml:lang=itNon è possibile trovare un record di RateAmount che 
deve essere cancellato/value
-value xml:lang=ptNão foi possà vel localizar o registro a ser excluà do 
RateAmount/value
-/property
   property key=AccountingEftAccountCannotBeCreated
   value xml:lang=enERROR: Could not create payment method Id (id generation 
failure)/value
   value xml:lang=itERRORE: Non è possibile creare il metodo pagamento 
(fallimento generazione id)/value
@@ -384,6 +379,42 @@
   value xml:lang=enData error getting tax settings: 
${errorString}/value
   value xml:lang=itErrore di lettura impostazioni tasse: 
${errorString}/value
   /property
+property 
key=idealEvents.failedToExecuteServiceCreatePaymentFromPreference
+value xml:lang=enFailed To Execute Service 
CreatePaymentFromPreference/value
+value xml:lang=frÉchec sur l'execution du service de création 
d'un payment suivant les préférence
(CreatePaymentFromPreference)/value
+value xml:lang=hi_INसर्विस CreatePaymentFromPreference 
पर अमल(execute) करने में
असफल/value
+value xml:lang=itFallita esecuzione servizio 
CreatePaymentFromPreference/value
+/property
+property key=idealEvents.noValidOrderIdReturned
+value xml:lang=enNo Valid OrderId Returned/value
+value xml:lang=frRéférence commande retournée n'est pas 
valide/value
+value xml:lang=hi_INमान्य OrderId वापस नहीं 
लौटा/value
+value xml:lang=itNessun numero ordine restituito/value
+/property
+property key=idealEvents.problemsConnectingWithIdeal
+value xml:lang=enProblems Connecting With iDEAL/value
+value xml:lang=frProblème rencontré dans la connexion avec 
iDEAL/value
+value xml:lang=hi_INiDEAL के साथ जोड़ने में 
समस्या/value
+value xml:lang=itProblema nella connessione con iDEAL/value
+/property
+property key=idealEvents.problemsGettingAuthenticationUser
+value xml:lang=enProblems Getting Authentication User/value
+value xml:lang=frProblème sur l'authentification de 
l'utilisateur/value
+value xml:lang=hi_INउपयोगकर्ता(user) के 
प्रमाणीकरण में
समस्याएँ हो रही/value
+value xml:lang=itProblema durante l'autenticazione utente/value
+/property
+property key=idealEvents.problemsGettingMerchantConfiguration
+value xml:lang=enProblems Getting Merchant Configuration/value
+value xml:lang=frProblème de récupération de la configuration 
marchand/value
+value xml:lang=hi_INव्यापारी विन्यास 
में समस्याएँ हो
रही/value
+value xml:lang=itProblema nel ricavare la configurazione del 
negoziante/value
+/property
+property key=idealEvents.problemsGettingOrderHeader
+value xml:lang=enProblems Getting OrderHeader/value
+value xml:lang=frProblème de récupération de la commande/value
+value xml:lang=hi_INOrderHeader में समस्याएँ 
हो रही/value
+value xml:lang=itProblema nel ricavare la testata ordine/value
+/property
   property 
key=payPalEvents.failedToExecuteServiceCreatePaymentFromPreference
   value xml:lang=enFailed to execute service 
createPaymentFromPreference/value
   value xml:lang=frEchec à l'exécution du service 
createPaymentFromPreference/value
@@ -517,40 +548,4 @@
   value xml:lang=itProblema nel ricavare la testata ordine/value
   value xml:lang=ptProblemas Obtendo OrderHeader/value
   /property
-property

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

2011-03-04 Thread Adrian Crum 

Just a reminder that you are hiding the problem - not fixing it.

-Adrian

On 3/4/2011 10:26 AM, mrisal...@apache.org wrote:

Author: mrisaliti
Date: Fri Mar  4 18:26:16 2011
New Revision: 1078088

URL: http://svn.apache.org/viewvc?rev=1078088view=rev
Log:
Remove a warning in OfbizContentTransform (OFBIZ-4102)

Modified:
 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

Modified: 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088r1=1078087r2=1078088view=diff
==
--- 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 (original)
+++ 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 Fri Mar  4 18:26:16 2011
@@ -63,6 +63,7 @@ public class OfbizContentTransform imple
  return result;
  }

+@SuppressWarnings(unchecked)
  public Writer getWriter(final Writer out, Map args) {
  final StringBuilder buf = new StringBuilder();
  final String imgSize = OfbizContentTransform.getArg(args, variant);

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

2011-03-04 Thread risali...@gmail.com 
Hi Adrian,

I'm agree with you but in this case the method getWriter of interface 
TemplateTransformModel of Freemarker does not accept to specify which type of 
Map you will use.
So until new version of Freemarker will accept parametrized Map I think it's 
better to use @SuppressWarnings(unchecked).

What did you think of it ?

Thanks
Marco

Il giorno 04/mar/2011, alle ore 19.47, Adrian Crum ha scritto:

 Just a reminder that you are hiding the problem - not fixing it.
 
 -Adrian
 
 On 3/4/2011 10:26 AM, mrisal...@apache.org wrote:
 Author: mrisaliti
 Date: Fri Mar  4 18:26:16 2011
 New Revision: 1078088
 
 URL: http://svn.apache.org/viewvc?rev=1078088view=rev
 Log:
 Remove a warning in OfbizContentTransform (OFBIZ-4102)
 
 Modified:
 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 
 Modified: 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088r1=1078087r2=1078088view=diff
 ==
 --- 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
  (original)
 +++ 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
  Fri Mar  4 18:26:16 2011
 @@ -63,6 +63,7 @@ public class OfbizContentTransform imple
  return result;
  }
 
 +@SuppressWarnings(unchecked)
  public Writer getWriter(final Writer out, Map args) {
  final StringBuilder buf = new StringBuilder();
  final String imgSize = OfbizContentTransform.getArg(args, 
 variant);

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

2011-03-04 Thread Adrian Crum 
Okay, I did not realize that was an external API method. Never mind. 
Sorry to bother you. Carry on. ;-)


-Adrian

On 3/4/2011 10:58 AM, risali...@gmail.com wrote:

Hi Adrian,

I'm agree with you but in this case the method getWriter of interface 
TemplateTransformModel of Freemarker does not accept to specify which type of 
Map you will use.
So until new version of Freemarker will accept parametrized Map I think it's better to 
use @SuppressWarnings(unchecked).

What did you think of it ?

Thanks
Marco

Il giorno 04/mar/2011, alle ore 19.47, Adrian Crum ha scritto:


Just a reminder that you are hiding the problem - not fixing it.

-Adrian

On 3/4/2011 10:26 AM, mrisal...@apache.org wrote:

Author: mrisaliti
Date: Fri Mar  4 18:26:16 2011
New Revision: 1078088

URL: http://svn.apache.org/viewvc?rev=1078088view=rev
Log:
Remove a warning in OfbizContentTransform (OFBIZ-4102)

Modified:
 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

Modified: 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088r1=1078087r2=1078088view=diff
==
--- 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 (original)
+++ 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 Fri Mar  4 18:26:16 2011
@@ -63,6 +63,7 @@ public class OfbizContentTransform imple
  return result;
  }

+@SuppressWarnings(unchecked)
  public Writer getWriter(final Writer out, Map args) {
  final StringBuilder buf = new StringBuilder();
  final String imgSize = OfbizContentTransform.getArg(args, variant);

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

2011-03-04 Thread risali...@gmail.com 
No problem Adrian, it's better 4 eyes than only 2 and particularly for this 
migration.

Thanks to look at it.
Marco

Il giorno 04/mar/2011, alle ore 20.10, Adrian Crum ha scritto:

 Okay, I did not realize that was an external API method. Never mind. Sorry to 
 bother you. Carry on. ;-)
 
 -Adrian
 
 On 3/4/2011 10:58 AM, risali...@gmail.com wrote:
 Hi Adrian,
 
 I'm agree with you but in this case the method getWriter of interface 
 TemplateTransformModel of Freemarker does not accept to specify which type 
 of Map you will use.
 So until new version of Freemarker will accept parametrized Map I think it's 
 better to use @SuppressWarnings(unchecked).
 
 What did you think of it ?
 
 Thanks
 Marco
 
 Il giorno 04/mar/2011, alle ore 19.47, Adrian Crum ha scritto:
 
 Just a reminder that you are hiding the problem - not fixing it.
 
 -Adrian
 
 On 3/4/2011 10:26 AM, mrisal...@apache.org wrote:
 Author: mrisaliti
 Date: Fri Mar  4 18:26:16 2011
 New Revision: 1078088
 
 URL: http://svn.apache.org/viewvc?rev=1078088view=rev
 Log:
 Remove a warning in OfbizContentTransform (OFBIZ-4102)
 
 Modified:
 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 
 Modified: 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088r1=1078087r2=1078088view=diff
 ==
 --- 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
  (original)
 +++ 
 ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
  Fri Mar  4 18:26:16 2011
 @@ -63,6 +63,7 @@ public class OfbizContentTransform imple
  return result;
  }
 
 +@SuppressWarnings(unchecked)
  public Writer getWriter(final Writer out, Map args) {
  final StringBuilder buf = new StringBuilder();
  final String imgSize = OfbizContentTransform.getArg(args, 
 variant);

Re: svn commit: r1078167 - /ofbiz/trunk/applications/product/config/ProductUiLabels.xml

2011-03-04 Thread Bruno Busco 
Hi Marco,
I think that the correct Italian label should be:
value xml:lang=itSe un catalogo NON viene valorizzato con categorie,
questo non verrà mostrato nell'albero Sfoglia cataloghi/categorie/value

-Bruno

2011/3/4 mrisal...@apache.org

 Author: mrisaliti
 Date: Fri Mar  4 22:06:35 2011
 New Revision: 1078167

 URL: http://svn.apache.org/viewvc?rev=1078167view=rev
 Log:
  A missing Italian translation

 Modified:
ofbiz/trunk/applications/product/config/ProductUiLabels.xml

 Modified: ofbiz/trunk/applications/product/config/ProductUiLabels.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/config/ProductUiLabels.xml?rev=1078167r1=1078166r2=1078167view=diff

 ==
 --- ofbiz/trunk/applications/product/config/ProductUiLabels.xml (original)
 +++ ofbiz/trunk/applications/product/config/ProductUiLabels.xml Fri Mar  4
 22:06:35 2011
 @@ -9943,6 +9943,7 @@
 property key=ProductBrowseCatalogeAndCategories
 value xml:lang=enBrowse Catalogs/Categories/value
 value xml:lang=frCatalogues/catégories/value
 +value xml:lang=itSfoglia cataloghi/categorie/value
 /property
 property key=ProductBrowseCategories
 value xml:lang=csVýběr skupiny výrobků/value
 @@ -10140,6 +10141,7 @@
 property key=ProductCatalogEmptyWarning
 value xml:lang=enIf you don't populate a Catalog with
 Categories, it will not shown in the Browse Catalogs/Categories tree/value
 value xml:lang=frSi vous ne créez pas de catégories pour un
 catalogue, il n'apparaitra pas dans l'arbre des
 Catalogues/catégories/value
 +value xml:lang=itSe un catalogo viene valorizzato con
 categorie, questo non verrà mostrato nell'albero Sfoglia
 cataloghi/categorie/value
 /property
 property key=ProductCatalogAdministrationMainPage
 value xml:lang=deKatalogverwaltung Hauptseite/value