Re: Sonar for OFBiz?

2011-03-15 Thread Erwan de FERRIERES

Le 03/03/2011 15:51, Jacques Le Roux a écrit :






OK, the ant target is now created at rev 1081708.

Just run a sonar instance on your machine, then run ant sonar, when 
finished, connect to http://localhost:9000.

I've added the svn revision in it, so the timeline will  be based on this.

Cheers,

--
Erwan de FERRIERES
www.nereide.biz


Re: svn commit: r1081272 - in /ofbiz/trunk/applications/product/src/org/ofbiz/product: image/ScaleImage.java product/ProductServices.java

2011-03-15 Thread Eric de Maulde
Where can I see compilation warnings ?

My OS is Debian and my command ./ant build

Thanks

Eric

On Tue, 2011-03-15 at 10:08 +0700, Hans Bakker wrote:

 Sure marco, you are right, i should watch this more.
 
 Your resulting code however i do not understand, within the if statement
 is a statement which does not do anything, or do i miss something?
 
 rev: 1081531
 statements after the change:
 if(PRODUCT_URL.equals(productContentAndInfo.getString(productContentTypeId)))
electronicText.getString(textData);
 }
 
 Wasn't it better to these 3 lines alltogether?
 
 
 rev: 1081526
 statements after the change:
 if (fileLocation.lastIndexOf(/) != -1) {
fileLocation.substring(0, fileLocation.lastIndexOf(/) + 1);
 }
 
 should these statements be completely removed?
 
 Regards,
 Hans
 
 
 On Mon, 2011-03-14 at 20:33 +0100, risali...@gmail.com wrote:
  Hi Hans,
  
  if it's possible it could be better to do not introduce new compile warning 
  into OFBiz now that we have completed to remove it.
  
  Thanks
  Marco
  
  Il giorno 14/mar/2011, alle ore 08.16, hans...@apache.org ha scritto:
  
   Author: hansbak
   Date: Mon Mar 14 07:16:36 2011
   New Revision: 1081272
   
   URL: http://svn.apache.org/viewvc?rev=1081272view=rev
   Log:
   patch to scale main image product content and additional image product 
   content: a contribution by Eric de Maulde: 
   https://issues.apache.org/jira/browse/OFBIZ-4212
   
   Modified:
  
   ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java
  
   ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductServices.java
   
   Modified: 
   ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java
   URL: 
   http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java?rev=1081272r1=1081271r2=1081272view=diff
   ==
   --- 
   ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java
(original)
   +++ 
   ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java
Mon Mar 14 07:16:36 2011
   @@ -107,35 +107,41 @@ public class ScaleImage {
   String imgName = filenameToUse.substring(0, index - 1);
   String imgExtension = filenameToUse.substring(index + 1);
   // paths
   -String mainFilenameFormat = 
   UtilProperties.getPropertyValue(catalog, image.filename.format);
   String imageServerPath = 
   FlexibleStringExpander.expandString(UtilProperties.getPropertyValue(catalog,
image.server.path), context);
   String imageUrlPrefix = 
   UtilProperties.getPropertyValue(catalog, image.url.prefix);
   -
   -String id = null;
   +
   +FlexibleStringExpander filenameExpander;
   +String fileLocation = null;
   String type = null;
   +String id = null;
   if (viewType.toLowerCase().contains(main)) {
   -type = original;
   +String filenameFormat = 
   UtilProperties.getPropertyValue(catalog, image.filename.format);
   +filenameExpander = 
   FlexibleStringExpander.getInstance(filenameFormat);
   id = (String) context.get(productId);
   +fileLocation = 
   filenameExpander.expandString(UtilMisc.toMap(location, products, 
   id, id, type, original));
   +Debug.logWarning(fileLocation for view type = MAIN :  + 
   fileLocation,module);
   } else if (viewType.toLowerCase().contains(additional)  
   viewNumber != null  !viewNumber.equals(0)) {
   -type = additional;
   -id = imgName + _View_ + viewNumber;
   +String filenameFormat = 
   UtilProperties.getPropertyValue(catalog, 
   image.filename.additionalviewsize.format);
   +filenameExpander = 
   FlexibleStringExpander.getInstance(filenameFormat);
   +id = (String) context.get(productId);
   +if (filenameFormat.endsWith(${id})) {
   +id = id + _View_ + viewNumber;
   +} else {
   +viewType = additional + viewNumber;
   +}
   +fileLocation = 
   filenameExpander.expandString(UtilMisc.toMap(location, products, 
   id, id, viewtype, viewType, sizetype, original));
   } else {
   -return 
   ServiceUtil.returnError(UtilProperties.getMessage(resource, 
   -ProductImageViewType, UtilMisc.toMap(viewType, 
   type), locale));
   +return 
   ServiceUtil.returnError(UtilProperties.getMessage(resource, 
   ProductImageViewType, UtilMisc.toMap(viewType, type), locale));
   }
   -FlexibleStringExpander mainFilenameExpander = 
   FlexibleStringExpander.getInstance(mainFilenameFormat);
   -String fileLocation = 
   mainFilenameExpander.expandString(UtilMisc.toMap(location, products, 
   id, context.get(productId), type, 

[jira] Commented: (OFBIZ-4214) i need tutorial in pos

2011-03-15 Thread Hisham Abaza (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006877#comment-13006877
 ] 

Hisham Abaza commented on OFBIZ-4214:
-

Ok Thanks

 i need tutorial in pos
 --

 Key: OFBIZ-4214
 URL: https://issues.apache.org/jira/browse/OFBIZ-4214
 Project: OFBiz
  Issue Type: Wish
Reporter: Hisham Abaza
Assignee: Jacques Le Roux
Priority: Critical

  Can you help me? i need tutorial(pdf,website links ,) in ofbiz 
 -POS(point of sales)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Commented: (OFBIZ-4214) i need tutorial in pos

2011-03-15 Thread Hisham Abaza (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006881#comment-13006881
 ] 

Hisham Abaza commented on OFBIZ-4214:
-

but i search about pos but i did  not find tutorial or documents on it can 
any one tell me more

 i need tutorial in pos
 --

 Key: OFBIZ-4214
 URL: https://issues.apache.org/jira/browse/OFBIZ-4214
 Project: OFBiz
  Issue Type: Wish
Reporter: Hisham Abaza
Assignee: Jacques Le Roux
Priority: Critical

  Can you help me? i need tutorial(pdf,website links ,) in ofbiz 
 -POS(point of sales)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Issue Comment Edited: (OFBIZ-4214) i need tutorial in pos

2011-03-15 Thread Hisham Abaza (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006881#comment-13006881
 ] 

Hisham Abaza edited comment on OFBIZ-4214 at 3/15/11 11:56 AM:
---

This Link contains little information about pos and i search about pos but i 
did  not find tutorial or documents on it can any one tell me more

  was (Author: hmalovekar):
but i search about pos but i did  not find tutorial or documents on it 
can any one tell me more
  
 i need tutorial in pos
 --

 Key: OFBIZ-4214
 URL: https://issues.apache.org/jira/browse/OFBIZ-4214
 Project: OFBiz
  Issue Type: Wish
Reporter: Hisham Abaza
Assignee: Jacques Le Roux
Priority: Critical

  Can you help me? i need tutorial(pdf,website links ,) in ofbiz 
 -POS(point of sales)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: svn commit: r1081272 - in /ofbiz/trunk/applications/product/src/org/ofbiz/product: image/ScaleImage.java product/ProductServices.java

2011-03-15 Thread Jacques Le Roux

./ant is enough and warning should show in terminal

Jacques

From: Eric de Maulde eric...@free.fr

Where can I see compilation warnings ?

My OS is Debian and my command ./ant build

Thanks

Eric

On Tue, 2011-03-15 at 10:08 +0700, Hans Bakker wrote:


Sure marco, you are right, i should watch this more.

Your resulting code however i do not understand, within the if statement
is a statement which does not do anything, or do i miss something?

rev: 1081531
statements after the change:
if(PRODUCT_URL.equals(productContentAndInfo.getString(productContentTypeId)))
   electronicText.getString(textData);
}

Wasn't it better to these 3 lines alltogether?


rev: 1081526
statements after the change:
if (fileLocation.lastIndexOf(/) != -1) {
   fileLocation.substring(0, fileLocation.lastIndexOf(/) + 1);
}

should these statements be completely removed?

Regards,
Hans


On Mon, 2011-03-14 at 20:33 +0100, risali...@gmail.com wrote:
 Hi Hans,

 if it's possible it could be better to do not introduce new compile warning 
into OFBiz now that we have completed to remove it.

 Thanks
 Marco

 Il giorno 14/mar/2011, alle ore 08.16, hans...@apache.org ha scritto:

  Author: hansbak
  Date: Mon Mar 14 07:16:36 2011
  New Revision: 1081272
 
  URL: http://svn.apache.org/viewvc?rev=1081272view=rev
  Log:
  patch to scale main image product content and additional image product content: a contribution by Eric de Maulde: 
  https://issues.apache.org/jira/browse/OFBIZ-4212

 
  Modified:
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductServices.java
 
  Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java?rev=1081272r1=1081271r2=1081272view=diff

  
==
  --- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java 
(original)
  +++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/image/ScaleImage.java Mon Mar 
14 07:16:36 2011
  @@ -107,35 +107,41 @@ public class ScaleImage {
  String imgName = filenameToUse.substring(0, index - 1);
  String imgExtension = filenameToUse.substring(index + 1);
  // paths
  -String mainFilenameFormat = UtilProperties.getPropertyValue(catalog, 
image.filename.format);
  String imageServerPath = FlexibleStringExpander.expandString(UtilProperties.getPropertyValue(catalog, 
  image.server.path), context);

  String imageUrlPrefix = UtilProperties.getPropertyValue(catalog, 
image.url.prefix);
  -
  -String id = null;
  +
  +FlexibleStringExpander filenameExpander;
  +String fileLocation = null;
  String type = null;
  +String id = null;
  if (viewType.toLowerCase().contains(main)) {
  -type = original;
  +String filenameFormat = UtilProperties.getPropertyValue(catalog, 
image.filename.format);
  +filenameExpander = 
FlexibleStringExpander.getInstance(filenameFormat);
  id = (String) context.get(productId);
  +fileLocation = filenameExpander.expandString(UtilMisc.toMap(location, products, id, id, type, 
  original));

  +Debug.logWarning(fileLocation for view type = MAIN :  + 
fileLocation,module);
  } else if (viewType.toLowerCase().contains(additional)  viewNumber != null 
 !viewNumber.equals(0)) {
  -type = additional;
  -id = imgName + _View_ + viewNumber;
  +String filenameFormat = UtilProperties.getPropertyValue(catalog, 
image.filename.additionalviewsize.format);
  +filenameExpander = 
FlexibleStringExpander.getInstance(filenameFormat);
  +id = (String) context.get(productId);
  +if (filenameFormat.endsWith(${id})) {
  +id = id + _View_ + viewNumber;
  +} else {
  +viewType = additional + viewNumber;
  +}
  +fileLocation = filenameExpander.expandString(UtilMisc.toMap(location, products, id, id, viewtype, 
  viewType, sizetype, original));

  } else {
  -return 
ServiceUtil.returnError(UtilProperties.getMessage(resource,
  -ProductImageViewType, UtilMisc.toMap(viewType, 
type), locale));
  +return ServiceUtil.returnError(UtilProperties.getMessage(resource, ProductImageViewType, 
  UtilMisc.toMap(viewType, type), locale));

  }
  -FlexibleStringExpander mainFilenameExpander = 
FlexibleStringExpander.getInstance(mainFilenameFormat);
  -String fileLocation = mainFilenameExpander.expandString(UtilMisc.toMap(location, products, id, 
  context.get(productId), type, type));

  +
  String filePathPrefix = ;
  if (fileLocation.lastIndexOf(/) != -1) 

Compiler issue with

2011-03-15 Thread Jacques Le Roux

FYI, we crossed an issue with
http://svn.apache.org/viewvc/ofbiz/trunk/framework/sql/src/org/ofbiz/sql/Planner.java?view=diffr1=1076852r2=1076853pathrev=1076853
It does not compile with all Java version. So far at least 1.6.0_14 and 
1.6.0_17 fail. It's ok with 1.6.0_23 and 1.6.0_24

HTH

Jacques




[jira] Created: (OFBIZ-4215) Customize contentRootId for showcontenttree screen

2011-03-15 Thread Eric de Maulde (JIRA)
Customize contentRootId for showcontenttree screen
--

 Key: OFBIZ-4215
 URL: https://issues.apache.org/jira/browse/OFBIZ-4215
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: trunk 1081272
Reporter: Eric de Maulde
Priority: Trivial
 Fix For: SVN trunk


the content_categories.ftl file has a fixed contentRootId value.
If we have to manage several web sites with the same screen and different 
contentRootId is impossible.
So I believe it's better to deport upstream this value, in order to each 
webmaster can configure this value and uses the same screen

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Updated: (OFBIZ-4215) Customize contentRootId for showcontenttree screen

2011-03-15 Thread Eric de Maulde (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric de Maulde updated OFBIZ-4215:
--

Attachment: CustomizeContentRootId.patch

This patch deports upstream the contentRootId value to the main decorator.
So it's easier to change contentRootId value for each web site.

 Customize contentRootId for showcontenttree screen
 --

 Key: OFBIZ-4215
 URL: https://issues.apache.org/jira/browse/OFBIZ-4215
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: trunk 1081272
Reporter: Eric de Maulde
Priority: Trivial
 Fix For: SVN trunk

 Attachments: CustomizeContentRootId.patch


 the content_categories.ftl file has a fixed contentRootId value.
 If we have to manage several web sites with the same screen and different 
 contentRootId is impossible.
 So I believe it's better to deport upstream this value, in order to each 
 webmaster can configure this value and uses the same screen

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: Compiler issue with

2011-03-15 Thread Ashish Vijaywargiya
My recent email on user mailing list:- FYI - trunk code was failing on
1.6.0_11 version - updated to latest version of jdk(jdk1.6.0_24) and now it
is compiling fine :-)

--
Ashish

On Tue, Mar 15, 2011 at 9:09 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

 FYI, we crossed an issue with

 http://svn.apache.org/viewvc/ofbiz/trunk/framework/sql/src/org/ofbiz/sql/Planner.java?view=diffr1=1076852r2=1076853pathrev=1076853
 It does not compile with all Java version. So far at least 1.6.0_14 and
 1.6.0_17 fail. It's ok with 1.6.0_23 and 1.6.0_24

 HTH

 Jacques





Re: Compiler issue with

2011-03-15 Thread Jacques Le Roux

Thanks Ashish,

Unfortunately this is on a 64 bits Debian server without access to Internet.
And last but not least jdk1.6.0_22(b04) was installed. I'm sure you are aware of 
http://bugs.sun.com/view_bug.do;jsessionid=eda2515610ea5b524779629b4d53?bug_id=6916062 :/

So, caught from both side, we simply revert the change below, and downgrade the 
jdk (in this case to _14, was used in dev)

Jacques

From: Ashish Vijaywargiya vijaywargiya.ash...@gmail.com

My recent email on user mailing list:- FYI - trunk code was failing on
1.6.0_11 version - updated to latest version of jdk(jdk1.6.0_24) and now it
is compiling fine :-)

--
Ashish

On Tue, Mar 15, 2011 at 9:09 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:


FYI, we crossed an issue with

http://svn.apache.org/viewvc/ofbiz/trunk/framework/sql/src/org/ofbiz/sql/Planner.java?view=diffr1=1076852r2=1076853pathrev=1076853
It does not compile with all Java version. So far at least 1.6.0_14 and
1.6.0_17 fail. It's ok with 1.6.0_23 and 1.6.0_24

HTH

Jacques










Re: Compiler issue with

2011-03-15 Thread David E Jones

On a side note, is that class even used anywhere by default? Or, is anyone 
using it?

-David


On Mar 15, 2011, at 9:39 AM, Jacques Le Roux wrote:

 FYI, we crossed an issue with
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/sql/src/org/ofbiz/sql/Planner.java?view=diffr1=1076852r2=1076853pathrev=1076853
 It does not compile with all Java version. So far at least 1.6.0_14 and 
 1.6.0_17 fail. It's ok with 1.6.0_23 and 1.6.0_24
 
 HTH
 
 Jacques
 
 



Re: Compiler issue with

2011-03-15 Thread Jacques Le Roux

David,

I think Adam uses it. Marco mades the change recently in his warnings effort. 
But I don't see anything in Eclipse nor while building
So I'm reverting this trivial change

Jacques

From: David E Jones d...@me.com


On a side note, is that class even used anywhere by default? Or, is anyone 
using it?

-David


On Mar 15, 2011, at 9:39 AM, Jacques Le Roux wrote:


FYI, we crossed an issue with
http://svn.apache.org/viewvc/ofbiz/trunk/framework/sql/src/org/ofbiz/sql/Planner.java?view=diffr1=1076852r2=1076853pathrev=1076853
It does not compile with all Java version. So far at least 1.6.0_14 and 
1.6.0_17 fail. It's ok with 1.6.0_23 and 1.6.0_24

HTH

Jacques









Re: Revision 894330

2011-03-15 Thread Bruno Busco
Adrian,
I have no time now.

Please do it yourself.

-Bruno

2011/3/13 Adrian Crum adrian.c...@sandglass-software.com

 Ideally, the multi-column layout would be handled by the applications
 needing it - not by the decorator. But it has been that way for too long to
 change it now.

 A framework-only deployment can have applications too - the Example and Web
 Tools components are examples.

 Would you be willing to move the logic to the GlobalDecorator, or should I
 do that myself?

 -Adrian


 On 3/13/2011 12:05 PM, Bruno Busco wrote:

 Hi Adrian,
 when I did this change I supposed that left-column where only something
 related to applications.
 The global decorator only had visibility of a pre-body and a body section.

 The main purpose of the change was to get rid of the several variables and
 use the decorator feature.
 But I agree with you, at least I cannot remember of a particular reason
 for
 not having the logic in the GlobalDecorator.

 -Bruno

 2011/3/13 Adrian Crumadrian.c...@sandglass-software.com

   From the Rev 894330 commit log:

 [OFBIZ-3274] - Using decorator sections to control the left-bar
 The leftbar content is now defined using the left-column
 ApplicationDecorator section instead of setting the variables
 leftbarScreenName, leftbarScreenLocation and MainColumnStyle. The
 logic that checks if the left-column section has content, and thus if a
 left column must be rendered, has been moved from the GlobalDecorator to
 the
 ApplicationDecorator.

 Why was the logic moved to the ApplicationDecorator? Because of that
 change, applications developed in a framework-only deployment do not
 render
 correctly because the necessary containers are missing. From my
 perspective,
 that change was not necessary - the logic should have stayed in the
 GlobalDecorator.

 -Adrian





[jira] Created: (OFBIZ-4216) image dimensions to scaling, configured by catalog / store / web site

2011-03-15 Thread Eric de Maulde (JIRA)
image dimensions to scaling, configured by catalog / store / web site
-

 Key: OFBIZ-4216
 URL: https://issues.apache.org/jira/browse/OFBIZ-4216
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: trunk 1081272
Reporter: Eric de Maulde
Priority: Minor
 Fix For: SVN trunk


Into the file applications/product/config/ImageProperties.xml, image dimensions 
are configured for all e-commerce web sites (and all related applications).
A webmaster can manage several e-commerce web sites with different constraints 
(web site for personnal conputer, web site for smartphone, internal 
applications with large bandwidth ...)
So I believe it's better to separate image dimensions configuration by :
_ catalog
_ store
_ web site

If this configuration can implement a mix between catalog and/or store and/or 
web site is better as more flexible for each contraint.

What do you think ?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Assigned: (OFBIZ-3501) ServerHitBin.java has a dependency on content component

2011-03-15 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum reassigned OFBIZ-3501:
--

Assignee: Adrian Crum

 ServerHitBin.java has a dependency on content component
 ---

 Key: OFBIZ-3501
 URL: https://issues.apache.org/jira/browse/OFBIZ-3501
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: chris snow
Assignee: Adrian Crum
 Attachments: CommonTypeData.xml.patch


 I have removed the applications and I am runing a standalone ofbiz.  I 
 receive an error message when using webtools:
 {code}
 2010-02-24 10:22:36,827 (http-0.0.0.0-8443-6) [   
 ServerHitBin.java:606:WARN ] The datamodel data has not been loaded; cannot 
 find hitTypeId 'REQUEST not storing ServerHit.
 2010-02-24 10:22:36,832 (http-0.0.0.0-8443-6) [   
 GenericDelegator.java:767:ERROR] 
  exception report 
 --
 Failure in create operation for entity [ServerHitBin]: 
 org.ofbiz.entity.GenericEntityNotFoundException: Result set was empty for 
 entity: [GenericEntity:ServerHitBin][serverHitBinId,10025(java.lang.String)]. 
 Rolling back transaction.
 Exception: org.ofbiz.entity.GenericEntityNotFoundException
 Message: Result set was empty for entity: 
 [GenericEntity:ServerHitBin][serverHitBinId,10025(java.lang.String)]
  stack trace 
 ---
 org.ofbiz.entity.GenericEntityNotFoundException: Result set was empty for 
 entity: [GenericEntity:ServerHitBin][serverHitBinId,10025(java.lang.String)]
 org.ofbiz.entity.datasource.GenericDAO.select(GenericDAO.java:538)
 org.ofbiz.entity.datasource.GenericDAO.select(GenericDAO.java:493)
 {code}
 It appears that 
 /framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java has a 
 dependency on /applications/content/data/ContentTypeData.xml
 ServerHitBin.java:
 {code}
 public static final int REQUEST = 1;
 public static final int EVENT = 2;
 public static final int VIEW = 3;
 public static final int ENTITY = 4;
 public static final int SERVICE = 5;
 public static final String[] typeNames = {, Request, Event, View, 
 Entity, Service};
 public static final String[] typeIds = {, REQUEST, EVENT, VIEW, 
 ENTITY, SERVICE};
 {code}
 ContentTypeData.xml
 {code}
 ServerHitType description=Request hitTypeId=REQUEST/
 ServerHitType description=Event hitTypeId=EVENT/
 ServerHitType description=View hitTypeId=VIEW/
 ServerHitType description=Entity hitTypeId=ENTITY/
 ServerHitType description=Service hitTypeId=SERVICE/
 {code}
 Can we move this seed data to somewhere within the framework folder?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Closed: (OFBIZ-3501) ServerHitBin.java has a dependency on content component

2011-03-15 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum closed OFBIZ-3501.
--

   Resolution: Fixed
Fix Version/s: SVN trunk

This was fixed in rev 1050457.

 ServerHitBin.java has a dependency on content component
 ---

 Key: OFBIZ-3501
 URL: https://issues.apache.org/jira/browse/OFBIZ-3501
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: chris snow
Assignee: Adrian Crum
 Fix For: SVN trunk

 Attachments: CommonTypeData.xml.patch


 I have removed the applications and I am runing a standalone ofbiz.  I 
 receive an error message when using webtools:
 {code}
 2010-02-24 10:22:36,827 (http-0.0.0.0-8443-6) [   
 ServerHitBin.java:606:WARN ] The datamodel data has not been loaded; cannot 
 find hitTypeId 'REQUEST not storing ServerHit.
 2010-02-24 10:22:36,832 (http-0.0.0.0-8443-6) [   
 GenericDelegator.java:767:ERROR] 
  exception report 
 --
 Failure in create operation for entity [ServerHitBin]: 
 org.ofbiz.entity.GenericEntityNotFoundException: Result set was empty for 
 entity: [GenericEntity:ServerHitBin][serverHitBinId,10025(java.lang.String)]. 
 Rolling back transaction.
 Exception: org.ofbiz.entity.GenericEntityNotFoundException
 Message: Result set was empty for entity: 
 [GenericEntity:ServerHitBin][serverHitBinId,10025(java.lang.String)]
  stack trace 
 ---
 org.ofbiz.entity.GenericEntityNotFoundException: Result set was empty for 
 entity: [GenericEntity:ServerHitBin][serverHitBinId,10025(java.lang.String)]
 org.ofbiz.entity.datasource.GenericDAO.select(GenericDAO.java:538)
 org.ofbiz.entity.datasource.GenericDAO.select(GenericDAO.java:493)
 {code}
 It appears that 
 /framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java has a 
 dependency on /applications/content/data/ContentTypeData.xml
 ServerHitBin.java:
 {code}
 public static final int REQUEST = 1;
 public static final int EVENT = 2;
 public static final int VIEW = 3;
 public static final int ENTITY = 4;
 public static final int SERVICE = 5;
 public static final String[] typeNames = {, Request, Event, View, 
 Entity, Service};
 public static final String[] typeIds = {, REQUEST, EVENT, VIEW, 
 ENTITY, SERVICE};
 {code}
 ContentTypeData.xml
 {code}
 ServerHitType description=Request hitTypeId=REQUEST/
 ServerHitType description=Event hitTypeId=EVENT/
 ServerHitType description=View hitTypeId=VIEW/
 ServerHitType description=Entity hitTypeId=ENTITY/
 ServerHitType description=Service hitTypeId=SERVICE/
 {code}
 Can we move this seed data to somewhere within the framework folder?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Created: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

2011-03-15 Thread Eric de Maulde (JIRA)
Scaling image for every size type from ImageProperties.xml
--

 Key: OFBIZ-4217
 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
 Project: OFBiz
  Issue Type: Improvement
  Components: framework, product, specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: trunk 1081272
Reporter: Eric de Maulde
Priority: Trivial
 Fix For: SVN trunk


With the new image management, there are more predefined image size types to 
upload an image.
The webmaster needs flexibility because each web site are different.
So, I believe the webmaster needs to customize image size type to scale 
uploaded images, according to his constraints.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Updated: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

2011-03-15 Thread Eric de Maulde (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric de Maulde updated OFBIZ-4217:
--

Attachment: ScalingImageForEverySizeType.patch

This patch allows to customize (decrease, increase, change name) image size 
type from ImageProperties.xml.
An uploading image is scaled to every configured image size type from 
properties.
It's very flexible.

This patch works only with image product content, not yet with the new image 
management.
I'm waiting for your decision to make more.

Problem : when a user uploads several additional images, there is a transaction 
time out !

 Scaling image for every size type from ImageProperties.xml
 --

 Key: OFBIZ-4217
 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
 Project: OFBiz
  Issue Type: Improvement
  Components: framework, product, specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: trunk 1081272
Reporter: Eric de Maulde
Priority: Trivial
 Fix For: SVN trunk

 Attachments: ScalingImageForEverySizeType.patch


 With the new image management, there are more predefined image size types to 
 upload an image.
 The webmaster needs flexibility because each web site are different.
 So, I believe the webmaster needs to customize image size type to scale 
 uploaded images, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Commented: (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml

2011-03-15 Thread Eric de Maulde (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007306#comment-13007306
 ] 

Eric de Maulde commented on OFBIZ-4217:
---

Furthermore, maybe it's enough to save in database only the original image (url 
... height, width).
Then, through the image.filename.format and 
image.filename.additionalviewsize.format (from catalog.properties) developper 
builds the desired url with the image size type.

 Scaling image for every size type from ImageProperties.xml
 --

 Key: OFBIZ-4217
 URL: https://issues.apache.org/jira/browse/OFBIZ-4217
 Project: OFBiz
  Issue Type: Improvement
  Components: framework, product, specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: trunk 1081272
Reporter: Eric de Maulde
Priority: Trivial
 Fix For: SVN trunk

 Attachments: ScalingImageForEverySizeType.patch


 With the new image management, there are more predefined image size types to 
 upload an image.
 The webmaster needs flexibility because each web site are different.
 So, I believe the webmaster needs to customize image size type to scale 
 uploaded images, according to his constraints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: Differences between old image product content and new image management

2011-03-15 Thread Eric de Maulde
I need your advices to improve old/new image mangement,
to customize configured scaling image dimensions :

# By catalog / store / web site, see
https://issues.apache.org/jira/browse/OFBIZ-4216
# By free size type, see
https://issues.apache.org/jira/browse/OFBIZ-4217

Thanks

Eric

On Mon, 2011-03-14 at 09:46 +0100, Eric de Maulde wrote:

 Hi Hans,
 
 I'm just intransigent with my job, and more my e-commerce web site
 www.fabiance.fr has as assets its image management and ..., from OFBiz
 of course !
 My website works with the OFBiz trunk, maybe it's an error but a choice
 too ! My web site and I suppose other OFBiz web site need a functional
 OFBiz trunk.
 
 I know well the scale image system (I'm an initiator). I will be happy
 to contribute to the new image management.
 
 We must not forget the first contributor rule ...
 
 Eric
 
 
 On Mon, 2011-03-14 at 14:25 +0700, Hans Bakker wrote:
 
  Hi Eric,
  
  Thank you for your comments, if we get more time, we sure will have a
  look at it. If you like to work with us getting this image management
  better feel free to send improvements for it, remember we do not own the
  code anymore after we contributed it.
  
  Regards,
  Hans
  
  On Sun, 2011-03-13 at 19:01 +0100, Eric de Maulde wrote:
   Hi,
   
   I've notice several missed features from the new image magenement.
   I haven't seen :
   _ original image saving (where a functionality able to automatically
   resize all images if the webmaster decide by eg. to modify the large
   size)
   _ non-automatic resizing into configured small/medium/large/detail
   dimensions from an upload (it's an easy system to display efficient
   image for an e-commerce web site, to optimize image weight)
   I think small/medium/large/detail are more flexible than 100 X 75 /
   150 X 112 / ... because if a webmaster want to modify a dimension, he
   has to modify too the dimension name with the new system ???
   _ where can I go to the image content (by eg. to write an attribute ...)
   _ the link between product and image (I have to write each time the
   product id)
   _ the session between tabs doesn't work ???
   _ ...
   
   So until the image magement works well, I advice to implement the
   following patch :
   https://issues.apache.org/jira/browse/OFBIZ-4212
   
   Thanks
   
   Eric de Maulde