Re: svn commit: r1495294 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/invoice/InvoiceServices.xml script/org/ofbiz/accounting/payment/PaymentServices.xml servicedef/services_
I checked the DMRB, and it shows the bill to party ID and bill from party ID specified in the INVOICE entity, so the current implementation is correct. It wasn't clear to me what those roles were in the OFBiz model because the field names are ambiguous. -Adrian On 6/23/2013 5:05 AM, Hans Bakker wrote: Hi Adrian, Thank you for your interest in the changes i am currently implementing in the accounting system. Your name change is a fine suggestion and is already implementedin revision 1495791. Your suggestion of the invoiceroles I not really understand. I may be wrong but currently invoiceroles are not used in the accounting process, that is why i did not check them. partyId and partIdFrom are the only fields involved here as far as I can see. If I am wrong, can you explain the invpoiceRoles in the accounting process and where they are used? Regards, Hans On 06/21/2013 02:09 PM, Adrian Crum wrote: If the service is meant to check if a invoice is in a foreign currency related to the accounting company, then it might be best to rename it to isInvoiceForeignCurrency. Also, wouldn't it be better to check the InvoiceRole entity? Those party ID fields are ambiguous. -Adrian On 6/21/2013 6:44 AM, hans...@apache.org wrote: Author: hansbak Date: Fri Jun 21 05:44:15 2013 New Revision: 1495294 URL: http://svn.apache.org/r1495294 Log: make automatic application also working with foreign invoices and payments Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml?rev=1495294r1=1495293r2=1495294view=diff == --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml (original) +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/invoice/InvoiceServices.xml Fri Jun 21 05:44:15 2013 @@ -997,4 +997,30 @@ under the License. call-service service-name=updateSimpleTextContent in-map-name=updateSimpleText/ /simple-method +simple-method method-name=isInvoiceForeign short-description=check if a invoice is in a foreign currency related to the accounting company. +entity-one value-field=invoice entity-name=InvoiceAndType +field-map field-name=invoiceId from-field=parameters.invoiceId/ +/entity-one +if-empty field=invoice +log level=error message=Invoice not found/ +return/ +/if-empty +if-compare field=invoice.parentTypeId operator=equals value=PURCHASE_INVOICE +set field=pref.organizationPartyId from-field=invoice.partyIdFrom/ +/if-compare +if-compare field=invoice.parentTypeId operator=equals value=SALES_INVOICE +set field=pref.organizationPartyId from-field=invoice.partyId/ +/if-compare +call-service service-name=getPartyAccountingPreferences in-map-name=pref +result-to-field result-name=prefResult/ +/call-service +if-compare-field to-field=prefResult.partyAccountingPreference.baseCurrencyUomId operator=equals field=invoice.currencyUomId +set field=isForeign value=false type=Boolean/ +else +set field=isForeign value=true type=Boolean/ +/else +/if-compare-field +field-to-result field=isForeign/ +/simple-method + /simple-methods Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=1495294r1=1495293r2=1495294view=diff == --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml (original) +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml Fri Jun 21 05:44:15 2013 @@ -1016,15 +1016,36 @@ under the License. call-class-method method-name=getInvoiceTotal class-name=org.ofbiz.accounting.invoice.InvoiceWorker ret-field=invoiceTotal field field=invoice type=GenericValue/ /call-class-method -entity-condition list=payments entity-name=Payment -condition-list combine=and -condition-expr field-name=statusId value=PMNT_CONFIRMED operator=not-equals/ -condition-expr field-name=partyIdFrom
[jira] [Commented] (OFBIZ-5243) Make OFBiz really multi company and multi currency
[ https://issues.apache.org/jira/browse/OFBIZ-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691790#comment-13691790 ] Adrian Crum commented on OFBIZ-5243: I agree that detailed requirements are needed. The issue description does not provide enough information. Most likely, the multi-tenancy feature will not accommodate what Hans has in mind. I believe what is being proposed here will provide a means to limit a user to a subset of data based upon their relationship to an internal organization and that organization's relationship to various artifacts. This data subset would be a part of the entire user experience, not just reporting. Make OFBiz really multi company and multi currency -- Key: OFBIZ-5243 URL: https://issues.apache.org/jira/browse/OFBIZ-5243 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Hans Bakker Currently all information related to any company is shown in the system in all components. I would like to suggest to show only information related to the current organization and only allow the entry related to the current organization company. This concerns but is not limited to quotes, orders, shipments, payments, invoices and ledger. This means these documents should have at least the current organization company in either the from- or to-party and should be in the currency of that company. We could also make this a configuration option in general properties. Regards, Hans -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5241) Have PIN payment transactions
[ https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691799#comment-13691799 ] Adrian Crum commented on OFBIZ-5241: I don't understand why we are changing the labels. The attached patches seem to be doing much more than just adding a payment type. Have PIN payment transactions - Key: OFBIZ-5241 URL: https://issues.apache.org/jira/browse/OFBIZ-5241 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch In the Dutch market space it is customary to pay with pin. This should be incorporated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5241) Have PIN payment transactions
[ https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691805#comment-13691805 ] Hans Bakker commented on OFBIZ-5241: i do not understand why adding 'sales' and 'purchase' to the description. These description are either shown on a purchase invoice or sales invoice and defined on that level, not on the item level. Have PIN payment transactions - Key: OFBIZ-5241 URL: https://issues.apache.org/jira/browse/OFBIZ-5241 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch In the Dutch market space it is customary to pay with pin. This should be incorporated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5243) Make OFBiz really multi company and multi currency
[ https://issues.apache.org/jira/browse/OFBIZ-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691806#comment-13691806 ] Pierre Smits commented on OFBIZ-5243: - Adrian, I agree that the organisational context you spoke about in a thread elsewhere would be a truly neat feature to have. It's a pity that you are prohibited to share your insights. Regards, Pierre Make OFBiz really multi company and multi currency -- Key: OFBIZ-5243 URL: https://issues.apache.org/jira/browse/OFBIZ-5243 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Hans Bakker Currently all information related to any company is shown in the system in all components. I would like to suggest to show only information related to the current organization and only allow the entry related to the current organization company. This concerns but is not limited to quotes, orders, shipments, payments, invoices and ledger. This means these documents should have at least the current organization company in either the from- or to-party and should be in the currency of that company. We could also make this a configuration option in general properties. Regards, Hans -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5241) Have PIN payment transactions
[ https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691805#comment-13691805 ] Hans Bakker edited comment on OFBIZ-5241 at 6/24/13 9:05 AM: - i do not understand why adding 'sales' and 'purchase' to the description. These description are either shown on a purchase invoice or sales invoice and defined on that level, not on the item level. further more, this PIN payment is already implemented and is called Ideal in the Netherlands. so adding labels and payment method, is not required, already done. was (Author: hansbak): i do not understand why adding 'sales' and 'purchase' to the description. These description are either shown on a purchase invoice or sales invoice and defined on that level, not on the item level. Have PIN payment transactions - Key: OFBIZ-5241 URL: https://issues.apache.org/jira/browse/OFBIZ-5241 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch In the Dutch market space it is customary to pay with pin. This should be incorporated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5241) Have PIN payment transactions
[ https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691805#comment-13691805 ] Hans Bakker edited comment on OFBIZ-5241 at 6/24/13 9:07 AM: - i do not understand why adding 'sales' and 'purchase' to the description. These description are either shown on a purchase invoice or sales invoice and defined on that level, not on the item level. further more, this PIN payment is already implemented and is called Ideal in the Netherlands. so adding labels and payment method, is not required, already done. The only thing which is valuable is the dutch update to the label file. (OFBIZ-5241-ACCTG-Labels.patch) was (Author: hansbak): i do not understand why adding 'sales' and 'purchase' to the description. These description are either shown on a purchase invoice or sales invoice and defined on that level, not on the item level. further more, this PIN payment is already implemented and is called Ideal in the Netherlands. so adding labels and payment method, is not required, already done. Have PIN payment transactions - Key: OFBIZ-5241 URL: https://issues.apache.org/jira/browse/OFBIZ-5241 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch In the Dutch market space it is customary to pay with pin. This should be incorporated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5241) Have PIN payment transactions
[ https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691807#comment-13691807 ] Pierre Smits commented on OFBIZ-5241: - @Hans, When talking about iDeal you are talking about a different set of functionalities. iDeal is not integrated in the webpos component. Have PIN payment transactions - Key: OFBIZ-5241 URL: https://issues.apache.org/jira/browse/OFBIZ-5241 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch In the Dutch market space it is customary to pay with pin. This should be incorporated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5241) Have PIN payment transactions
[ https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691824#comment-13691824 ] Jacques Le Roux commented on OFBIZ-5241: @Adrian: if ever those are used in the same dropdown, as it happened in OFBIZ-5225, then it's confusing because you have the same labels for both. So better to prevent this and have different labels as well. Have PIN payment transactions - Key: OFBIZ-5241 URL: https://issues.apache.org/jira/browse/OFBIZ-5241 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch In the Dutch market space it is customary to pay with pin. This should be incorporated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5241) Have PIN payment transactions
[ https://issues.apache.org/jira/browse/OFBIZ-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691829#comment-13691829 ] Jacques Le Roux commented on OFBIZ-5241: Since we have already labels in different langages, those concerned should change them accordingly, I did it for French. Have PIN payment transactions - Key: OFBIZ-5241 URL: https://issues.apache.org/jira/browse/OFBIZ-5241 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Pierre Smits Fix For: SVN trunk Attachments: OFBIZ-5241-ACCTG-Labels.patch, OFBIZ-5241-ACCTG-PaymentType.patch, OFBIZ-5241-WEBPOS-PIN-Payment.patch In the Dutch market space it is customary to pay with pin. This should be incorporated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5225) The Invoice Item type dropdown have same description for different invoiceItemTypeId.
[ https://issues.apache.org/jira/browse/OFBIZ-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691855#comment-13691855 ] Hans Bakker commented on OFBIZ-5225: i am only wondering here if the drop down of the agreement is usefull? shouldn't we separate it for sales/purchase/payrol and other types of invoices anyway... The Invoice Item type dropdown have same description for different invoiceItemTypeId. - Key: OFBIZ-5225 URL: https://issues.apache.org/jira/browse/OFBIZ-5225 Project: OFBiz Issue Type: Wish Components: accounting Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5225.patch, Updated-OFBIZ-5225.patch The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting. https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1 The description should be different that the invoiceItemType is for sales or purchase. Eg: Invoice Fee(Sales) Invoice Fee(Purchase) Something to differentiate between the same description. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5225) The Invoice Item type dropdown have same description for different invoiceItemTypeId.
[ https://issues.apache.org/jira/browse/OFBIZ-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691860#comment-13691860 ] Jacques Le Roux commented on OFBIZ-5225: Maybe, I did not question it, another task... The Invoice Item type dropdown have same description for different invoiceItemTypeId. - Key: OFBIZ-5225 URL: https://issues.apache.org/jira/browse/OFBIZ-5225 Project: OFBiz Issue Type: Wish Components: accounting Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5225.patch, Updated-OFBIZ-5225.patch The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting. https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1 The description should be different that the invoiceItemType is for sales or purchase. Eg: Invoice Fee(Sales) Invoice Fee(Purchase) Something to differentiate between the same description. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4794) set different ports for testing in a CI environment (e.g. Jenkins)
[ https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4794: --- Attachment: OFBIZ-4794 - test port.patch set different ports for testing in a CI environment (e.g. Jenkins) -- Key: OFBIZ-4794 URL: https://issues.apache.org/jira/browse/OFBIZ-4794 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch Original Estimate: 1h Remaining Estimate: 1h In order to run test targets in Jenkins we need to change ports for at least ajp, http and https in test-containers.xml as these ports are most likely to be already in use by the CI server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4794) set different ports for testing in a CI environment (e.g. Jenkins)
[
https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691876#comment-13691876
]
Jacques Le Roux commented on OFBIZ-4794:
Attached is a patch, if nobody sees a better way to do this I will commit it. I
still have to test 2 tests intance running locally though (will take more than
1 hour I guess...)
The idea is to use something like
{code}
ant run-tests -Doffsetport=1
{code}
or
{code}
C:\Program Files\Java\jdk1.6.0_22\bin\java -Xms128M -Xmx512M
-XX:MaxPermSize=512m -jar ofbiz.jar -test -portoffset=1
{code}
This will allow to run the Builbots tests simultaneously on the same VM using
ant. The same idea could be used to run the demos, but would need more work (to
pass the ofbiz.admin.port value for instance, not a big deal). I will certainly
do it as a 1st step of OFBIZ-4763...
set different ports for testing in a CI environment (e.g. Jenkins)
--
Key: OFBIZ-4794
URL: https://issues.apache.org/jira/browse/OFBIZ-4794
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits
Assignee: Jacques Le Roux
Fix For: SVN trunk
Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch
Original Estimate: 1h
Remaining Estimate: 1h
In order to run test targets in Jenkins we need to change ports for at least
ajp, http and https in test-containers.xml as these ports are most likely to
be already in use by the CI server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5225) The Invoice Item type dropdown have same description for different invoiceItemTypeId.
[ https://issues.apache.org/jira/browse/OFBIZ-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691880#comment-13691880 ] Pierre Smits commented on OFBIZ-5225: - [~hansbak] To what are you referring? Neither the patches, nor the link provides show dropdown functionality of agreements. When looking at the example provided (https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1) and clicking on the dropdown of Invoice Item Type I see a lot of double entries for returns. The Invoice Item type dropdown have same description for different invoiceItemTypeId. - Key: OFBIZ-5225 URL: https://issues.apache.org/jira/browse/OFBIZ-5225 Project: OFBiz Issue Type: Wish Components: accounting Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5225.patch, Updated-OFBIZ-5225.patch The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting. https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1 The description should be different that the invoiceItemType is for sales or purchase. Eg: Invoice Fee(Sales) Invoice Fee(Purchase) Something to differentiate between the same description. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4794) set different ports for testing in a CI environment (e.g. Jenkins)
[ https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691882#comment-13691882 ] Adrian Crum commented on OFBIZ-4794: It seems to me this is a configuration issue, and usually we solve configuration issues with patches. Why can't the buildbot scripts apply a patch before build/deployment? set different ports for testing in a CI environment (e.g. Jenkins) -- Key: OFBIZ-4794 URL: https://issues.apache.org/jira/browse/OFBIZ-4794 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch Original Estimate: 1h Remaining Estimate: 1h In order to run test targets in Jenkins we need to change ports for at least ajp, http and https in test-containers.xml as these ports are most likely to be already in use by the CI server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4794) set different ports for testing in a CI environment (e.g. Jenkins)
[ https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691909#comment-13691909 ] Jacques Le Roux commented on OFBIZ-4794: It's far easier to use this way, just an ant param. See for instance INFRA-3590 and the [buildot ofbiz.conf file (committers only)|https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf]. Same idea for demos, far less burden when we rotate them, idem for tests BTW. set different ports for testing in a CI environment (e.g. Jenkins) -- Key: OFBIZ-4794 URL: https://issues.apache.org/jira/browse/OFBIZ-4794 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch Original Estimate: 1h Remaining Estimate: 1h In order to run test targets in Jenkins we need to change ports for at least ajp, http and https in test-containers.xml as these ports are most likely to be already in use by the CI server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4794) set different ports for testing in a CI environment (e.g. Jenkins)
[ https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691914#comment-13691914 ] Jacques Le Roux commented on OFBIZ-4794: BTW, I'd like to reopen INFRA-3590, but I have to check the situation before, and if this is really interesting for the project. I guess Erwan is no longer concerned, which is a pity, but well... that's life... :) set different ports for testing in a CI environment (e.g. Jenkins) -- Key: OFBIZ-4794 URL: https://issues.apache.org/jira/browse/OFBIZ-4794 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch Original Estimate: 1h Remaining Estimate: 1h In order to run test targets in Jenkins we need to change ports for at least ajp, http and https in test-containers.xml as these ports are most likely to be already in use by the CI server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Assigning a sales representative to a customer (and then to an order)
Hi, I recently had a closer look at the sales commissions implementation which looks quite good (our customers pays commissions for orders instead of invoices but that's another story..) One thing that seems to be missing is that a sales representative gets automatically assigned to an order (OrderRole SALES_REP) For doing this we need a way to assign a sales rep to a customer. I propose to use the following: PartyRelationship partyIdFrom=DemoCustCompany partyIdTo=DemoRepAll roleTypeIdFrom=CUSTOMER roleTypeIdTo=SALES_REP partyRelationshipTypeId=SALES_REP This would introduce a new partyRelationshipTypeId SALES_REP. When creating an order the sales rep would be added as additional party role to the shopping cart and then could be changed/removed on the Additional Party Entry screen while finalizing the order. If there are no objections to this design I'll create a patch and put it on Jira for review. Christian
[jira] [Commented] (OFBIZ-5218) MRF Landing Page as Portal Page with some Portlet proposals
[ https://issues.apache.org/jira/browse/OFBIZ-5218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13692401#comment-13692401 ] Julien NICOLAS commented on OFBIZ-5218: --- Your question is really interesting ! There is two ways of thinking. First one for production management, the second one for commercial management with delivery scheduling. Production managers, who are working in the factory, want to know this kind of information : - An easy overview of production run. Status by achievement percentage, highlighting late one, etc. - Productivity of workcenter. Difference between forecasted production time and the real production time. Sellers want to know easily : - Production status for an order and the expected date and time of order achievement. - Delivery status for delivery follow up (ready to load, loaded, delivered) Kind regards, Julien NICOLAS MRF Landing Page as Portal Page with some Portlet proposals --- Key: OFBIZ-5218 URL: https://issues.apache.org/jira/browse/OFBIZ-5218 Project: OFBiz Issue Type: Improvement Components: manufacturing Affects Versions: SVN trunk Environment: any Reporter: Carsten Schinzer Priority: Minor Fix For: SVN trunk Original Estimate: 120h Remaining Estimate: 120h I would like to introduce a portal page when landing into the manufacturing component after login. Just as we have already on e.g. ordermgr. Ideas for portlets to be displayed are currently: - stats on configuration data (how many routings/routing tasks/boms/... are configured) - stats on runtime data (how many production runs by status ...) - top ten list of runs by status or duration More ideas are welcome, of course. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4794) set different ports for testing in a CI environment (e.g. Jenkins)
[ https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13692672#comment-13692672 ] Scott Gray commented on OFBIZ-4794: --- +1 for a patch (or patches), command line arguments might work for a while but as configuration differences grow things will be become messy. Easier is not necessarily better. set different ports for testing in a CI environment (e.g. Jenkins) -- Key: OFBIZ-4794 URL: https://issues.apache.org/jira/browse/OFBIZ-4794 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch Original Estimate: 1h Remaining Estimate: 1h In order to run test targets in Jenkins we need to change ports for at least ajp, http and https in test-containers.xml as these ports are most likely to be already in use by the CI server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
A couple of minilang improvement suggestions
A set-map operation that replaces this type of thing: set field=partyRelationshipCtx.partyIdFrom from-field=userLogin.partyId/ set field=partyRelationshipCtx.partyIdTo from-field=partyId/ set field=partyRelationshipCtx.roleTypeIdFrom value=OWNER/ set field=partyRelationshipCtx.roleTypeIdTo value=ACCOUNT/ set field=partyRelationshipCtx.partyRelationshipTypeId value=ACCOUNT/ call-service service-name=createPartyRelationship in-map-name=partyRelationshipCtx/ with this: set-map field=partyRelationshipCtx set field=partyIdFrom from-field=userLogin.partyId/ set field=partyIdTo from-field=partyId/ set field=roleTypeIdFrom value=OWNER/ set field=roleTypeIdTo value=ACCOUNT/ set field=partyRelationshipTypeId value=ACCOUNT/ /set-map call-service service-name=createPartyRelationship in-map-name=partyRelationshipCtx/ Not a huge change but removes the annoyance of having to type partyRelationshipCtx repeatedly. Add support for supplying service in parameters without having to define the map first: call-service service-name=createPartyRelationship parameter field=partyIdFrom from-field=userLogin.partyId/ parameter field=partyIdTo from-field=partyId/ parameter field=roleTypeIdFrom value=OWNER/ parameter field=roleTypeIdTo value=ACCOUNT/ parameter field=partyRelationshipTypeId value=ACCOUNT/ /call-service I think this would help to simplify the code somewhat. You could also replace the existing call-service.in-map attribute with an element and allow a mix of both styles. Regards Scott
