[jira] [Commented] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2015-02-25 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336238#comment-14336238
 ] 

Jacopo Cappellato commented on OFBIZ-6110:
--

For *demo* data it may be easier (to read and maintain) to have all demo data 
in one place.
We have recently discussed the idea to group all the business data model and 
base services into one component that will be the basis for all the 
applications (user interfaces and specialized services): we could move all demo 
data there.

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: OFBiz Community Member Raj Saini

2015-02-25 Thread Anchit Jindal
Rest in peace Sir, You will be missed all the time.



--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/OFBiz-Community-Member-Raj-Saini-tp4664197p4664228.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


[jira] [Commented] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336288#comment-14336288
 ] 

Jacques Le Roux commented on OFBIZ-6110:


Yes I read https://cwiki.apache.org/confluence/display/OFBIZ/Draft+Roadmaps 
some time ago, but I have really to think more about it. I'm a bit reluctant to 
do so, at least for now. First thing which comes to my mind is cloned web-apps. 
AFAIK we can have only 1 web-app by web.xml file (I just read that [Resin has a 
special setting for 
that|http://www.caucho.com/resin-4.0/admin/http-web-apps.xtp#definingwebxmlinresinxml],
 but [it's not 
standard|http://docs.oracle.com/cd/E13222_01/wls/docs100/webapp/web_xml.html]

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336288#comment-14336288
 ] 

Jacques Le Roux edited comment on OFBIZ-6110 at 2/25/15 9:33 AM:
-

Yes I read https://cwiki.apache.org/confluence/display/OFBIZ/Draft+Roadmaps 
some time ago, but I have really to think more about it. I'm a bit reluctant to 
do so, at least for now. First thing which comes to my mind is cloned web-apps. 
AFAIK we can have only 1 web-app by web.xml file. I just read that [Resin has a 
special setting for 
that|http://www.caucho.com/resin-4.0/admin/http-web-apps.xtp#definingwebxmlinresinxml],
 but [it's not 
standard|http://docs.oracle.com/cd/E13222_01/wls/docs100/webapp/web_xml.html]


was (Author: jacques.le.roux):
Yes I read https://cwiki.apache.org/confluence/display/OFBIZ/Draft+Roadmaps 
some time ago, but I have really to think more about it. I'm a bit reluctant to 
do so, at least for now. First thing which comes to my mind is cloned web-apps. 
AFAIK we can have only 1 web-app by web.xml file (I just read that [Resin has a 
special setting for 
that|http://www.caucho.com/resin-4.0/admin/http-web-apps.xtp#definingwebxmlinresinxml],
 but [it's not 
standard|http://docs.oracle.com/cd/E13222_01/wls/docs100/webapp/web_xml.html]

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-4966) Translation to Arabic

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-4966:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Translation to Arabic
> -
>
> Key: OFBIZ-4966
> URL: https://issues.apache.org/jira/browse/OFBIZ-4966
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: language, patch
> Attachments: CommonUiLabels.patch
>
>
> I have translated fully the framework/common/config/CommonUiLabels.xml to 
> arabic. Attached is the patch for the translation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-3036) Translation of the OFBiz help system in French

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-3036:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Translation of the OFBiz help system in French
> --
>
> Key: OFBIZ-3036
> URL: https://issues.apache.org/jira/browse/OFBIZ-3036
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Erwan de FERRIERES
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-3036.diff
>
>
> Here is the beginning of the translation for the OFBiz help system in French. 
> This is only the root page. I suggest to keep this issue open and add the 
> translations as sub-tasks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-4761) Adding some translations for French

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-4761:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Adding some translations for French
> ---
>
> Key: OFBIZ-4761
> URL: https://issues.apache.org/jira/browse/OFBIZ-4761
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Francis ANDRE
> Attachments: ofbiz.patch
>
>
> Hi
> Here a pacth for adding some translations for French. The patch is in U8-DOS 
> encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-2219) Special issue to allow submitting patches for online help update

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-2219:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Special issue to allow submitting patches for online help update
> 
>
> Key: OFBIZ-2219
> URL: https://issues.apache.org/jira/browse/OFBIZ-2219
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Hans Bakker
>Priority: Minor
> Attachments: HelpAccounting.jpg, 
> OFBIZ-2219_DocbookAccountingHelp10.patch, build.xml
>
>
> *This issue should not be closed, at least until the online help is 
> completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from 
> OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan 
> if she could update this links, while she is improving documentation, and she 
> agreed. So this issue is to allow her, and anybody else, to submit patches to 
> improve the online help (not only accounting of course hence the ALL 
> COMPONENTS)
> We commit only the [ones 
> completed|https://issues.apache.org/jira/browse/OFBIZ-4175?focusedCommentId=12993718&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12993718]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-3951) portlets are not transparent in the components Help system

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-3951:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> portlets are not transparent in the components Help system
> --
>
> Key: OFBIZ-3951
> URL: https://issues.apache.org/jira/browse/OFBIZ-3951
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 10.04, Trunk
>Reporter: BJ Freeman
>
> when a portlet has replaced the current component widget the under lying Help 
> that may exist is nullified.
> Also when Help is shown for a portlet is uses Portlet names for the help that 
> has no relationship to the actual UI as the user sees it.
> This counter intuitive and cause confusion to a User.
> from the Dev mailing list
> Hans Bakker sent the following on 9/22/2010 2:46 AM:
> > Have a look in the party profile, which is almost also a portal page.
> I looked and it was confusing and not intuitive on the help
> First question from a users point of view
> What is a Portal, as I search the page for something that says portal.
> So I am interested in help on the User Names
> I look at the list and see nothing that refers to User names.
> Again I look around the page to see anything label as User Login Portal.
> Now because I am familar with ofbiz I guessed the user Login Portal is the 
> one for User Names.
> I have not run one of my apps that call party pages against this version.
> I expect i will have to modify. That does not make me happy camper with 50 
> apps to do that with.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6086) Support list type form widget no-current-selected-key attribute

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6086:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Support list type form widget  no-current-selected-key attribute
> ---
>
> Key: OFBIZ-6086
> URL: https://issues.apache.org/jira/browse/OFBIZ-6086
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Christian Carlow
>
> I tried setting no-current-selected-key attribute of  for form 
> widget type list but it wasn't applied until the form widget type was changed 
> to multi.  It should work for all form types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6072) Improves parties assignments to production run tasks

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6072:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Improves parties assignments to production run tasks
> 
>
> Key: OFBIZ-6072
> URL: https://issues.apache.org/jira/browse/OFBIZ-6072
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> After OFBIZ-5706 parties can be assigned to production run tasks. But we can 
> improve how it's managed:
> * Be able to set the life span of an assignment (start and through date) upon 
> creation of an assignment
> * Being able to expire a party assignment by setting the through date (when 
> none is set)
> * Show the parties in the EditProductionRun and ShowProductionRun screen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Update: Screen Widget Refactor

2015-02-25 Thread Jacques Le Roux

Hi Adrian,

Sorry but I'm against this, or rather I have another suggestion to do. I will 
make it brief.

We decided to create a R14.12 freezed branch. Since then you worked on the screen widget refactor, I committed the SEO webapp in ecommerce: 
https://cwiki.apache.org/confluence/display/OFBIZ/Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also backport it to the R14 branch. I 
guess others would want to backport their own work, etc.


My suggestion is to rename R14.12 to R15.02 and to tag it again and freeze it before the end of Feburary. Nothing forces us to have a release by year, 
R15.02 is fine!


Jacques

Le 24/02/2015 22:32, Adrian Crum a écrit :

My volunteer time will be extremely limited starting next week, so I have put 
the remaining widget refactoring work on the shelf.

I accomplished most of what I set out to do, but I wasn't able to do any work 
on widget XML validation.

My hope is that this effort provides a springboard for others to innovate in 
this area of the project.

I would like to backport the screen widget refactor to the R14 branch. The refactor fixed innumerable bugs and flaws in the previous code. If there 
are no strong objections, I will do the backport in a few days.


Thank you everyone for your patience while I worked on the problems caused by 
the refactor.



[jira] [Updated] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-5048:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
> Attachments: GroovyEventMultipartParametes.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6076) Error on Sending confirm email from newly created quote

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6076:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Error on Sending confirm email from newly created quote
> ---
>
> Key: OFBIZ-6076
> URL: https://issues.apache.org/jira/browse/OFBIZ-6076
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
> Environment: 
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
>Reporter: Eduardo Arellano
>
> Error on Sending confirm email from newly created quote
> http://demo-trunk-ofbiz.apache.org/ordermgr/control/sendQuoteReportMail
> The Following Errors Occurred:
> Error rendering screen for email: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null))) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null)) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null) (Error rendering screen 
> [component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
> java.lang.NullPointerException (null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6057) Quote item view FreeMarker error message due to changes made in OFBIZ-2120

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6057:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Quote item view FreeMarker error message due to changes made in OFBIZ-2120
> --
>
> Key: OFBIZ-6057
> URL: https://issues.apache.org/jira/browse/OFBIZ-6057
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 13.07
> Environment: Linux
>Reporter: Forrest Rae
>
> In order to fix OFBIZ-2120, code was added to the 
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl file at lines 
> 53 through 57, with the offending line being at 5:
> https://github.com/apache/ofbiz/blob/trunk/applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl##L56
> Here is the commit: 
> https://github.com/apache/ofbiz/commit/27253c4667e87721212fa8955d75c74a0d171c73
> This ends up causing the following error:
>  [java] freemarker.core.InvalidReferenceException: The following has 
> evaluated to null or missing:
>  [java] ==> null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 40]
>  [java] 
>  [java] 
>  [java] Tip: If the failing expression is known to be legally refer to 
> something that's null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
>  [java] 
>  [java] 
>  [java] 
>  [java] FTL stack trace ("~" means nesting-related):
>  [java]   - Failed at: #assign product = null  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 56, 
> column 21]
>  [java]   - Reached through: #list quoteItems as quoteItem  [in template 
> "component://order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl" at line 52, 
> column 13]
> The main reason for this is because there is no concept of "null" in 
> FreeMarker 2.3, as the following thread explains: 
> http://ehc.ac/p/freemarker/discussion/2346/thread/85da30a4/  Not sure how to 
> go about fixing this error, the thread suggests setting the variable to the 
> string "null".
> There are other instances of this bug as well:
> $ grep -r "<#assign" * | grep "= null"
> applications/order/webapp/ordermgr/return/returnItems.ftl: 
> <#assign returnItemSubTotal = null >  <#-- otherwise the last item's might 
> carry over -->
> applications/order/webapp/ordermgr/quote/ViewQuoteItemInfo.ftl:   
>  <#assign product = null> <#-- don't drag it along to the next iteration 
> -->
> applications/accounting/webapp/accounting/reports/DepositSlip.fo.ftl: 
><#assign creditCard = null/>
> framework/webtools/webapp/webtools/datafile/viewdatafile.ftl:<#assign 
> lastRecordName = null>
> Reproduction Steps:
> 1) Visit http://demo-stable-ofbiz.apache.org/ordermgr/control/FindRequest
> 2) Click "New Request"
> 3) Set
>   - Cust Request Type Id = Request for Quote
>   - Requesting Party = DemoCustomer
>   - Cust Request Name = Test Request
>   - Description = This is a test request
> 4) Click "Sumbit"
> 5) "Create Quote from request"
> 6) error will appear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6064) Errors 404 in ecomseo when category-url is disabled

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6064:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Errors 404 in ecomseo when category-url is disabled
> ---
>
> Key: OFBIZ-6064
> URL: https://issues.apache.org/jira/browse/OFBIZ-6064
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When you set the  attribute of the  in the SeoConfig.xml 
> file to disable, and try to get to a product or a category you get a "404 Not 
> Found" error for the page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-3877) New Web Service Style

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-3877:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> New Web Service Style
> -
>
> Key: OFBIZ-3877
> URL: https://issues.apache.org/jira/browse/OFBIZ-3877
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
> Environment: Windows, Ubuntu Linux
>Reporter: Chatree Srichart
>Priority: Minor
> Attachments: ASF.LICENSE.NOT.GRANTED--webui empty UI.jpg, 
> webservice.tar.bz2, webui.png, webui.tar.bz2
>
>
> This is a new stub for new web service style that use a normal style (not 
> hash map [key/value]).
> [[ Installation ]]
> - Extract webservice.zip file (attached file) to hot-deploy directory of 
> OFBiz framework
> - run ant task for apply patch in webservice directory with:
>ant reapply-ofbiz-patches 
> [[ Features ]]
> 1.) New classes
> There is new important class
> org.ofbiz.webapp.webservice.event.WebServiceEventHandler
> which corresponds to earlier
> org.ofbiz.webapp.event.SOAPEventHandler
> but tries to support document style web services using
> SOAP with XML-format, or REST with XML and JSON-formats.
> This handler class uses other class:
> org.ofbiz.service.webservice.WebServiceModel
> which wraps inside class
> org.ofbiz.service.ModelService
> and contains support for WSDL-generation, WADL-generation
> and conversion between Java Maps and XML-object models.
> WSDL=Web Service Definition Language for SOAP-interface
> http://www.w3.org/TR/wsdl
> WADL=Web Application Description Language for REST-interface
> http://www.w3.org/Submission/wadl/
> There is another new important class
> org.ofbiz.service.webservice.engine.WebServiceClientEngine
> which corresponds to earlier
> org.ofbiz.service.engine.SOAPClientEngine
> but tries to support document style web services using
> SOAP with XML-format. Web services can be called using
> their WSDL-document or messages can be specified in
> services.xml without using WSDL-document. engine-attribute
> in services description is set to "webservice". Location
> of WSDL-document is given in attribute wsdlLocation or
> it can be left out if messages are described with attribute-
> definitions. Name of service in WSDL is given in
> attribute webServiceName and name of operation to be
> invoked in attribute invoke. One service-definition is
> needed for one web service-operation pair.
> Example of web service definitions are in file:
> framework/common/servicedef/services_test.xml
> This engine class uses other class:
> org.ofbiz.service.webservice.WebServiceClientModel
> which extends org.ofbiz.service.webservice.WebServiceModel
> and contains support for filling attribute definitions
> in org.ofbiz.service.ModelService from WSDL-document.
> 2.) Service definitions
> Web service interface can be used only if service definition
> file services.xml is completed with additional definitions.
> Schema of this file is extended.
> attribute-elements can have nested attribute elements
> which describe structure of Java maps and lists.
> If attribute has type Map, it should have nested attributes
> which describe contents of this map.
> If attribute has type List, it should have nested attributes
> which describe element contents of this list.
> If List has simple elements, there must be only one
> nested attribute, which describes element.
> If List has element which is map or other list, there
> must be one nested attribute stating that the element
> is Map or List, and then this attribute should have
> nested attributes describing structure of Map or
> structure of list element.
> There are also two new modes for attributes
> ERROR which means that attribute is responded as error message
> OUTERROR which means that attribute is responded as error
>  or as success message
> These modes are needed for web services to describe
> which parameters will go to detail-elements of SOAP Fault response
> or REST error messages. Also in WSDL- and WADL-files will be
> generated XML-schema for general response messages.
> File framework\webapp\servicedef\services_test.xml
> can be used as example of attribute definitions.
> This file is used in unit tests of web service interface.
> 3.) Web service requests
> In REST-services HTTP GET-method is used in services whose
> name start with words "find" or "get". These services should
> have input parameters in one level, so that they can be
> given as query parameters in URL. HTTP DELETE-method is used
> with services whose name start with word "remove". Other services
> are used with HTTP POST-method and PUT-method. Service must
> look itself for method name POST or PUT, if it is required
> to operate differently in insert or update cases.
> List of links to all WSDL-documents can be requested with URL:
> /webtool

[jira] [Updated] (OFBIZ-6083) Give numeric values in overview a proper alignment.

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6083:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Give numeric values in overview a proper alignment. 
> 
>
> Key: OFBIZ-6083
> URL: https://issues.apache.org/jira/browse/OFBIZ-6083
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>
> Currently,  most numeric values in overviews are left-aligned. The proper 
> alignment is right-aligned. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6066) Tenant specific components are visible/accessible in any tenant instance

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6066:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Tenant specific components are visible/accessible in any tenant instance
> 
>
> Key: OFBIZ-6066
> URL: https://issues.apache.org/jira/browse/OFBIZ-6066
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Blocker
>  Labels: component, tenant
>
> Tenant specific components should only be visible/accessible by users of the 
> specified tenant. 
> However, because data of the tenant specific component can be loaded into any 
> tenant (including the master rmdbs) through ./ant load-data or via the import 
> function of webtools, the tenant specific component is exposed to all



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6070) Create content for product causes exception

2015-02-25 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-6070:
---
Sprint:   (was: Bug Crush Event - 21/2/2015)

> Create content for product causes exception
> ---
>
> Key: OFBIZ-6070
> URL: https://issues.apache.org/jira/browse/OFBIZ-6070
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
>
> Using demo data.
> https://localhost:8443/catalog/control/EditProductContent?productId=CPU-586
> Console output...
> 2015-02-11 11:08:44,547 |http-bio-8443-exec-3 |ServiceEcaCondition   
> |I| From Field (contentAssocTypeId) is not found in context for 
> createContent, defaulting to null.
> 2015-02-11 11:08:44,557 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createContent] on [commit] got false for condition: 
> [contentAssocTypeId][is-not-empty][true][String]
> 2015-02-11 11:08:44,564 |http-bio-8443-exec-3 |ServiceEcaCondition   
> |I| From Field (contentAssocTypeId) is not found in context for 
> createContent, defaulting to null.
> 2015-02-11 11:08:44,565 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createContent] on [commit] got false for condition: 
> [contentAssocTypeId][is-not-empty][true][String]
> 2015-02-11 11:08:44,566 |http-bio-8443-exec-3 |ServiceEcaCondition   
> |I| From Field (contentPurposeTypeId) is not found in context for 
> createContent, defaulting to null.
> 2015-02-11 11:08:44,567 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createContent] on [commit] got false for condition: 
> [contentPurposeTypeId][is-not-empty][true][String]
> 2015-02-11 11:08:44,568 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| Running Service ECA Service: createContentAlternativeUrl, triggered by 
> rule on Service: createContent
> 2015-02-11 11:08:44,581 |http-bio-8443-exec-3 |ServiceEcaRule
> |I| For Service ECA [createProductContent] on [in-validate] got false for 
> condition: [contentId][is-empty][true][String]
> 2015-02-11 11:08:44,635 |http-bio-8443-exec-3 |GenericDelegator  
> |E| Failure in create operation for entity [ProductContent]: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ProductContent][contentId,10001(java.lang.String)][createdStamp,2015-02-11
>  11:08:44.587(java.sql.Timestamp)][createdTxStamp,2015-02-11 
> 11:08:32.59(java.sql.Timestamp)][fromDate,2015-02-11 
> 11:08:23.0(java.sql.Timestamp)][lastUpdatedStamp,2015-02-11 
> 11:08:44.587(java.sql.Timestamp)][lastUpdatedTxStamp,2015-02-11 
> 11:08:32.59(java.sql.Timestamp)][productContentTypeId,XTRA_IMG_E_SMALL(java.lang.String)][productId,CPU-586(java.lang.String)][thruDate,null()]
>  (SQL Exception while executing the following:INSERT INTO PRODUCT_CONTENT 
> (PRODUCT_ID, CONTENT_ID, PRODUCT_CONTENT_TYPE_ID, FROM_DATE, THRU_DATE, 
> PURCHASE_FROM_DATE, PURCHASE_THRU_DATE, USE_COUNT_LIMIT, USE_TIME, 
> USE_TIME_UOM_ID, USE_ROLE_TYPE_ID, SEQUENCE_NUM, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (Cannot add or update a child row: a 
> foreign key constraint fails (`ofbiz`.`PRODUCT_CONTENT`, CONSTRAINT 
> `PROD_CNT_TYPE` FOREIGN KEY (`PRODUCT_CONTENT_TYPE_ID`) REFERENCES 
> `PRODUCT_CONTENT_TYPE` (`PRODUCT_CONTENT_TYPE_ID`. Rolling back 
> transaction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2015-02-25 Thread Ron Wheeler (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336541#comment-14336541
 ] 

Ron Wheeler commented on OFBIZ-6110:


This would require a commitment to a BaseApplication set which seems to be 
possible. 
Does eCommerce move into the base set? 
How many installations use eCommerce as opposed to other Base Applications such 
as Human  Resources?

In any event, the extra seed data in the Base Applications that would accrue 
because of data moving from special purpose is pretty minimal in the overall 
scheme of things.

The mixing of demo data with core makes the system harder to understand. 

I would like to see the demo data moved to a separate project where technical 
writers and system administrators can work on it in a more productive 
environment than is currently possible.
I don't have the time for this if it involves producing patch files every time 
I find a spelling mistake or need to add seed data to clarify a wiki screenshot.



> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6111) Strange Behaviour of the eCommerice Login Link

2015-02-25 Thread Forrest Rae (JIRA)
Forrest Rae created OFBIZ-6111:
--

 Summary: Strange Behaviour of the eCommerice Login Link
 Key: OFBIZ-6111
 URL: https://issues.apache.org/jira/browse/OFBIZ-6111
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: 13.07.01, Trunk
Reporter: Forrest Rae



I've noticed some strange behaviour with the Login link in the eCommerce
application.  If you're visit the Login link from "main", you're
redirected back to the Login view even after logging in:

1) Visit http://demo-stable-ofbiz.apache.org/ecommerce/control/main
2) Click "Login" in the upper left
3) Login as "DemoCustomer" with a password of "ofbiz"
4) Notice that you're at a new URL, logged in, but the login form is
redrawn.

Compare this with how it's supposed to work:

1) Logout
2) Visit http://demo-stable-ofbiz.apache.org/ecommerce/tiny-gismo-GZ-1000-p
3) Click "Login" in the upper left
4) Login as "DemoCustomer" with a password of "ofbiz"
5) Notice that you're at a new URL, but the product page is redrawn
correctly.

It's just really strange behaviour, quite hard to track down, and I
can't really find a root cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6111) Strange Behaviour of the eCommerice Login Link

2015-02-25 Thread Forrest Rae (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Forrest Rae updated OFBIZ-6111:
---
Description: 
I've noticed some strange behaviour with the Login link in the eCommerce 
application.  If you're visit the Login link from "main", you're redirected 
back to the Login view even after logging in:

1) Visit http://demo-stable-ofbiz.apache.org/ecommerce/control/main
2) Click "Login" in the upper left
3) Login as "DemoCustomer" with a password of "ofbiz"
4) Notice that you're at a new URL, logged in, but the login form is redrawn.

Compare this with how it's supposed to work:

1) Logout
2) Visit http://demo-stable-ofbiz.apache.org/ecommerce/tiny-gismo-GZ-1000-p
3) Click "Login" in the upper left
4) Login as "DemoCustomer" with a password of "ofbiz"
5) Notice that you're at a new URL, but the product page is redrawn correctly.

It's just really strange behaviour, quite hard to track down, and I can't 
really find a root cause.

  was:

I've noticed some strange behaviour with the Login link in the eCommerce
application.  If you're visit the Login link from "main", you're
redirected back to the Login view even after logging in:

1) Visit http://demo-stable-ofbiz.apache.org/ecommerce/control/main
2) Click "Login" in the upper left
3) Login as "DemoCustomer" with a password of "ofbiz"
4) Notice that you're at a new URL, logged in, but the login form is
redrawn.

Compare this with how it's supposed to work:

1) Logout
2) Visit http://demo-stable-ofbiz.apache.org/ecommerce/tiny-gismo-GZ-1000-p
3) Click "Login" in the upper left
4) Login as "DemoCustomer" with a password of "ofbiz"
5) Notice that you're at a new URL, but the product page is redrawn
correctly.

It's just really strange behaviour, quite hard to track down, and I
can't really find a root cause.


> Strange Behaviour of the eCommerice Login Link
> --
>
> Key: OFBIZ-6111
> URL: https://issues.apache.org/jira/browse/OFBIZ-6111
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk, 13.07.01
>Reporter: Forrest Rae
>
> I've noticed some strange behaviour with the Login link in the eCommerce 
> application.  If you're visit the Login link from "main", you're redirected 
> back to the Login view even after logging in:
> 1) Visit http://demo-stable-ofbiz.apache.org/ecommerce/control/main
> 2) Click "Login" in the upper left
> 3) Login as "DemoCustomer" with a password of "ofbiz"
> 4) Notice that you're at a new URL, logged in, but the login form is redrawn.
> Compare this with how it's supposed to work:
> 1) Logout
> 2) Visit http://demo-stable-ofbiz.apache.org/ecommerce/tiny-gismo-GZ-1000-p
> 3) Click "Login" in the upper left
> 4) Login as "DemoCustomer" with a password of "ofbiz"
> 5) Notice that you're at a new URL, but the product page is redrawn correctly.
> It's just really strange behaviour, quite hard to track down, and I can't 
> really find a root cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: OFBiz Community Member Raj Saini

2015-02-25 Thread Jacopo Cappellato
This is really sad, and this community will miss Raj a lot.
My condolences to Raj's family and friends.

Jacopo

On Feb 24, 2015, at 8:36 PM, Adrian Crum  
wrote:

> It is with deep regret that I inform everyone in the OFBiz community that Raj 
> Saini passed away a few days ago.
> 
> Raj was very active on the mailing lists and he contributed much to the 
> project.
> 
> I had the pleasure of working with Raj at 1Tech Ltd. I admired his knowledge 
> of OFBiz and his skill as a systems administrator.
> 
> He will be missed.
> 
> -- 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com



[jira] [Commented] (OFBIZ-6071) Issue in decrypting entity fields where encrypt="true" is used in tenant

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337161#comment-14337161
 ] 

Jacques Le Roux commented on OFBIZ-6071:


Hi Divesh, 

You said this issue was not in R13.07, is this still true, did you test?

> Issue in decrypting entity fields where encrypt="true" is used in tenant 
> -
>
> Key: OFBIZ-6071
> URL: https://issues.apache.org/jira/browse/OFBIZ-6071
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Jacopo Cappellato
>Priority: Blocker
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6071.patch
>
>
> Error while adding a credit card from order manager when logged in with 
> tenant account.
> The error is as following:
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#editcreditcard]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#PaymentMethodDecorator]:
>  org.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Failure in 
> findByCondition operation for entity [CreditCard]: 
> org.ofbiz.entity.GenericEntityException: Error creating GenericValue 
> (org.ofbiz.base.util.GeneralException: javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly padded) 
> (javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded))). Rolling back 
> transaction.org.ofbiz.entity.GenericEntityException: Error creating 
> GenericValue (org.ofbiz.base.util.GeneralException: 
> javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded) (javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly 
> padded))) 
> It seems there is some issue with encryption-decryption mechanism for the 
> fields of an entity for which encrypt="true" is set. From the exception it 
> seemed that incorrect key is being used for decryption i.e. the key is not 
> appropriate with respect to the one which was used for encryption.
> After tracing the process flow we suspect that in SqlJdbcUtil.java while 
> calling 'decryptFieldValue' the delegator which is being used is 
> baseDelegator instead of tenant's delegator, but at the time of encryption 
> using 'encryptFieldValue' the delegator was tenant's delegator. May be this 
> is the reason why it is generating "javax.crypto.BadPaddingException".
> Steps to regenerate:
> 1. Create a tenant and login to tenant's admin account.
> 2. Navigate to ORDER > Order Entry > Sales Order
> 3. Use Demo Customer as Customer and continue.
> 4. Add some item to order and proceed for Quick Finalize Order.
> 5. Try to add new credit card.
> 6. On saving credit card information it will generate the above error. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337222#comment-14337222
 ] 

Jacques Le Roux commented on OFBIZ-5757:


Hi Deepak, 

I recently tried to use 
ant load-tenant
and [the result were not as 
expected|https://issues.apache.org/jira/browse/OFBIZ-6071?focusedCommentId=14320876]

Pierre says that
./ant create-tenant
and
./ant load-tenant-data-readers
are enough and I tend to agree due to this experience. The tenant targets are 
too much and confusing. So I'd like to remove all *main* tenant targets (those 
documented) but those 2. 

Pierre, I wonder about the work done for OFBIZ-3971, still valid right? But 
then should we keep load-tenant-admin-user-login as a main tenant target?



> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337270#comment-14337270
 ] 

Pierre Smits commented on OFBIZ-5757:
-

Jacques,

What/which validity are you questioning? I am confused...

> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5929) wrong Chinese text shown after create New Contact Information

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337277#comment-14337277
 ] 

Jacques Le Roux commented on OFBIZ-5929:


ofbiz_com_cn, this is confusing,

In order component, hence order manager:
{quote}
1. login as admin/ofbiz
2. click setting to create New Contact Information
{quote}

When at http://demo-trunk-ofbiz.apache.org/ordermgr/control/main I see no ways 
to "click setting"


> wrong Chinese  text shown after create New Contact Information
> --
>
> Key: OFBIZ-5929
> URL: https://issues.apache.org/jira/browse/OFBIZ-5929
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, 12.04.04
>Reporter: ofbiz_com_cn
>Priority: Minor
>
> steps to reproduce:
> 1. login as admin/ofbiz
> 2. click setting to create New Contact Information
> 3.  type chinese in the name or shipping address field like: 陈三
> 5. click save to update the ship address info
> 6. You will find that Chinese are replaced with wrong character
> I am not sure if the correct parameter encoded be fetched in file 
> ContactMechServices.java. In the database(postgresql), the Chinese character 
> is stored wrong also. All encode style is UTF-8 for both database and page



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: OFBIZ-5929: wrong Chinese text shown after create New Contact Information

2015-02-25 Thread Jacques Le Roux

setCharacterEncoding() is only called in

1) ControlServlet.doGet()
Before being called (twice almost at the top) no request parameters or reading 
through getReader() are done but
request.getCharacterEncoding();
So I see no pb there

2) WebDAv, ResponseHelper.prepareResponse()
I see no pb there as well


2) RequestHandler.renderView()
Indeed here before being called we have this snippet:
Map paramMap = UtilHttp.getParameterMap(req);
// add in the attributes as well so everything needed for the rendering 
context will be in place if/when we get back to this view
paramMap.putAll(UtilHttp.getAttributeMap(req));
UtilMisc.makeMapSerializable(paramMap);
the rest before the setCharacterEncoding() call is not concerned (attributes)
I guess it's that you are referring to?

Jacques


Le 27/01/2015 05:20, 杜 文吉 a écrit :

I also find that ofbiz’s conponent of ecommerce cann’t process japanese 
properly.

The reason is that httpservletrequest’s mothod setCharacterEncoding is called 
too late.


The spec of method setCharacterEncoding is writed as follow:

Overrides the name of the character encoding used in the body of this request. 
This method must be called prior to reading request parameters or reading input 
using getReader(). Otherwise, it has no effect.


A filer should exist for calling setCharacterEncoding right after http request 
arrived.

and other setCharacterEncoding’s calls should be deleted.


Windows メール から送信


[jira] [Commented] (OFBIZ-2976) view-entity with condition-expr joined with another view-entity as rel-optional=true is treated as rel-optional=false

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337290#comment-14337290
 ] 

Jacques Le Roux commented on OFBIZ-2976:


Unfortunately this patch has been neglected for too long and nothing applies. I 
don't know if it's still an issue. If it is, it's really a pity nobody took 
attention, notably [~adri...@hlmksw.com] who committed r805519 :/

> view-entity with condition-expr joined with another view-entity as 
> rel-optional=true is treated as rel-optional=false
> -
>
> Key: OFBIZ-2976
> URL: https://issues.apache.org/jira/browse/OFBIZ-2976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
> Environment: Java v1.5.0_19-b02-298 MacOS X 10.5.8
>Reporter: Jennifer Weston
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: JIRA-Issue2976.patch
>
>
> If a view-entity is defined with condition-exprs and used as a member-entity 
> in a second view-entity and the view-link is rel-optional=true, the link is 
> treated as rel-optional=false.
> In the following example, the view-entity PPRMinQty is a list of all 
> PriceBreakRules that have a minimum quantity defined. The view-entity 
> ProductPriceBreakMinQty uses PPRMinQty with ProductCategoryMember and 
> ProductPriceCond (this time used for product categories) to create a list of 
> productIds with their productPriceRuleIds and their minimum quantities (if 
> any). The rel-optional=true should mean that even productPriceRuleids that 
> don't have a minimum quantity defined should be included in the result set.
>  package-name="com.mavericklabel"
> title="Minimum qty for a product price rule">
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
> 
> 
> 
>  operator="equals" value="PRIP_QUANTITY"/>
>  operator="equals" value="PRC_GTE"/>
> 
> 
> 
>  package-name="com.mavericklabel"
> title="Price breaks for each product with their minimum quantity (min 
> qty is optional)">
> 
> 
> 
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
>  field="operatorEnumId"/>
> 
> 
> 
>  rel-optional="true">
> 
> 
> 
> 
>  field-name="inputParamEnumId" operator="equals" value="PRIP_PROD_CAT_ID"/>
>  operator="equals" value="PRC_EQ"/>
> 
> 
> 
> The resulting SQL looks like this:
> SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
> PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
> (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
> ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
> PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
> PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, 
> PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND 
> PPC) MINQTY ON PPRCAT.PRODUCT_PRICE_RULE_ID = 
> MINQTY.PPC_PRODUCT_PRICE_RULE_ID WHERE ((PPRCAT.INPUT_PARAM_ENUM_ID = 
> 'PRIP_PROD_CAT_ID' AND PPRCAT.OPERATOR_ENUM_ID = 'PRC_EQ') AND 
> (PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND PPC.OPERATOR_ENUM_ID = 
> 'PRC_GTE'))
> instead of 
> SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
> PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
> (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
> ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
> PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
> PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, 
> PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND 
> PPC WHERE ((PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND 
> PPC.OPERATOR_ENUM_ID = 'PRC_GTE'))) MINQTY ON PPRCAT.PRODUCT_PRICE_RULE_ID = 
> MINQTY.PPC_PRODUCT_PRICE_RULE_ID WHERE ((PPRCAT.INPUT_PARAM_ENUM_ID = 
> 'PRIP_PROD_CAT_ID' AND PPRCAT.OPERATOR_ENUM_ID = 'PRC_EQ'))
> The fact that the conditions from the subquery in the from have been moved to 
> the top level query create the effect of an inner join even though an outer 
> join is specified.
> The top level where is built by GenericDAO through 
> ModelViewEntity.populateViewEntityConditionInformation. The change to 
> ModelViewEntity.populateViewEntityConditionInformation moved this condition 
> to the top was committed in r805519.
> The code that builds the subquery view in the from is 
> SqlJdbcUtil.makeViewWhereClause. It looks like it's never added conditions 
> (only joins) going back to v4

[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337330#comment-14337330
 ] 

Jacques Le Roux commented on OFBIZ-5757:


I simply want to know if we should keep the work done for OFBIZ-3971. It seems 
still valid to me. But then can load-tenant-admin-user-login still be used 
independently (after create-tenant I guess)? Else we should hide its 
description (it would not be a main target, only a called one) to not confused 
users.

> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337344#comment-14337344
 ] 

Pierre Smits commented on OFBIZ-5757:
-

This issue is not about questioning the work done in OFBIZ-3971, nor whether 
load-tenant-admin-user-login could/should be used independently.

This issue is about removing superfluous demo data. The work done in OFBIZ-3971 
enables users to create tenants and load data into a tenant setup (including 
the creation of a tenant-admin and its initial password), regardless whether 
that is for evaluating the multi-tenancy aspect of OFBiz or in a production 
environment.

> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337396#comment-14337396
 ] 

Jacques Le Roux commented on OFBIZ-5757:


Yes, but you also says

With
./ant create-tenant
and
./ant load-tenant-data-readers
I believe we provide ample tools to explore the opportunity to demonstrate the 
multi-tenancy aspects of OFBiz.
{quote}

This seems to imply that we no longer need 
ant load-tenant

And I'd agree with that, because currently it's no longer working as I 
explained above with the link.

> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337396#comment-14337396
 ] 

Jacques Le Roux edited comment on OFBIZ-5757 at 2/25/15 10:57 PM:
--

Yes, but you also says

{quote}
With
./ant create-tenant
and
./ant load-tenant-data-readers
I believe we provide ample tools to explore the opportunity to demonstrate the 
multi-tenancy aspects of OFBiz.
{quote}

This seems to imply that we no longer need 
ant load-tenant

And I'd agree with that, because currently it's no longer working as I 
explained above with the link.


was (Author: jacques.le.roux):
Yes, but you also says

With
./ant create-tenant
and
./ant load-tenant-data-readers
I believe we provide ample tools to explore the opportunity to demonstrate the 
multi-tenancy aspects of OFBiz.
{quote}

This seems to imply that we no longer need 
ant load-tenant

And I'd agree with that, because currently it's no longer working as I 
explained above with the link.

> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337429#comment-14337429
 ] 

Pierre Smits commented on OFBIZ-5757:
-

You have just validated your own conclusion/finding.

> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[PROPOSAL] Change name of birt component

2015-02-25 Thread Pierre Smits
Hi all,

Currently, all component names describe - in one word - what the components
are about and what kind of functionality the user - from a business point
of view - can expect. As examples: accounting is related to the various
accounting (financial, gl, invoicing, payment, , etc) functions and
services, and projectmgr is related to program and project management,
project task assignment and time registration.

The birt component is a bit the odd one out. The name doesn't say in that
one word what it delivers. In stead it is an acronym for a specific third
party integration solution and another open source project with the same
name (birt, see https://en.wikipedia.org/wiki/BIRT_Project ). One could
even say it is the name of a tool, not the name of a business
functionality.

In order to be able to increase awareness of the multitude of business
functionalities (as could be done by using the name of the components) and
improve adoption, I suggest to change the name (and the references to it in
the component and others) to something that is more to the point business
wise.

I propose we rename it to 'reports'.

What do you think?

Best regards,


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com


[jira] [Commented] (OFBIZ-2976) view-entity with condition-expr joined with another view-entity as rel-optional=true is treated as rel-optional=false

2015-02-25 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337536#comment-14337536
 ] 

Adrian Crum commented on OFBIZ-2976:


This issue is almost 5 years old, what does it have to do with me?

> view-entity with condition-expr joined with another view-entity as 
> rel-optional=true is treated as rel-optional=false
> -
>
> Key: OFBIZ-2976
> URL: https://issues.apache.org/jira/browse/OFBIZ-2976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
> Environment: Java v1.5.0_19-b02-298 MacOS X 10.5.8
>Reporter: Jennifer Weston
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: JIRA-Issue2976.patch
>
>
> If a view-entity is defined with condition-exprs and used as a member-entity 
> in a second view-entity and the view-link is rel-optional=true, the link is 
> treated as rel-optional=false.
> In the following example, the view-entity PPRMinQty is a list of all 
> PriceBreakRules that have a minimum quantity defined. The view-entity 
> ProductPriceBreakMinQty uses PPRMinQty with ProductCategoryMember and 
> ProductPriceCond (this time used for product categories) to create a list of 
> productIds with their productPriceRuleIds and their minimum quantities (if 
> any). The rel-optional=true should mean that even productPriceRuleids that 
> don't have a minimum quantity defined should be included in the result set.
>  package-name="com.mavericklabel"
> title="Minimum qty for a product price rule">
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
> 
> 
> 
>  operator="equals" value="PRIP_QUANTITY"/>
>  operator="equals" value="PRC_GTE"/>
> 
> 
> 
>  package-name="com.mavericklabel"
> title="Price breaks for each product with their minimum quantity (min 
> qty is optional)">
> 
> 
> 
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
>  field="operatorEnumId"/>
> 
> 
> 
>  rel-optional="true">
> 
> 
> 
> 
>  field-name="inputParamEnumId" operator="equals" value="PRIP_PROD_CAT_ID"/>
>  operator="equals" value="PRC_EQ"/>
> 
> 
> 
> The resulting SQL looks like this:
> SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
> PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
> (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
> ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
> PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
> PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, 
> PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND 
> PPC) MINQTY ON PPRCAT.PRODUCT_PRICE_RULE_ID = 
> MINQTY.PPC_PRODUCT_PRICE_RULE_ID WHERE ((PPRCAT.INPUT_PARAM_ENUM_ID = 
> 'PRIP_PROD_CAT_ID' AND PPRCAT.OPERATOR_ENUM_ID = 'PRC_EQ') AND 
> (PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND PPC.OPERATOR_ENUM_ID = 
> 'PRC_GTE'))
> instead of 
> SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
> PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
> (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
> ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
> PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
> PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, 
> PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND 
> PPC WHERE ((PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND 
> PPC.OPERATOR_ENUM_ID = 'PRC_GTE'))) MINQTY ON PPRCAT.PRODUCT_PRICE_RULE_ID = 
> MINQTY.PPC_PRODUCT_PRICE_RULE_ID WHERE ((PPRCAT.INPUT_PARAM_ENUM_ID = 
> 'PRIP_PROD_CAT_ID' AND PPRCAT.OPERATOR_ENUM_ID = 'PRC_EQ'))
> The fact that the conditions from the subquery in the from have been moved to 
> the top level query create the effect of an inner join even though an outer 
> join is specified.
> The top level where is built by GenericDAO through 
> ModelViewEntity.populateViewEntityConditionInformation. The change to 
> ModelViewEntity.populateViewEntityConditionInformation moved this condition 
> to the top was committed in r805519.
> The code that builds the subquery view in the from is 
> SqlJdbcUtil.makeViewWhereClause. It looks like it's never added conditions 
> (only joins) going back to v4.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-6112) Incorrect Error Displayed when "Expiring" a Contact Mechanism

2015-02-25 Thread Forrest Rae (JIRA)
Forrest Rae created OFBIZ-6112:
--

 Summary: Incorrect Error Displayed when "Expiring" a Contact 
Mechanism
 Key: OFBIZ-6112
 URL: https://issues.apache.org/jira/browse/OFBIZ-6112
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: 13.07.01, Trunk
Reporter: Forrest Rae


When expiring a contact mechanism, an incorrect error is displayed.  This is 
mostly an error due to code reuse.  There is no reason to redirect back to 
editcontactmech, instead just redirect to viewprofile.  See attached patch.

"The contact information specified does not belong to you, you may not view or 
edit it."

Repro:
1) Login to http://demo-stable-ofbiz.apache.org/ecommerce/control/main as 
DemoCustomer.
2) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/viewprofile
3) Click Expire next to one of the Postal Addresses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6112) Incorrect Error Displayed when "Expiring" a Contact Mechanism

2015-02-25 Thread Forrest Rae (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Forrest Rae updated OFBIZ-6112:
---
Attachment: OFBIZ-6112.patch

> Incorrect Error Displayed when "Expiring" a Contact Mechanism
> -
>
> Key: OFBIZ-6112
> URL: https://issues.apache.org/jira/browse/OFBIZ-6112
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk, 13.07.01
>Reporter: Forrest Rae
> Attachments: OFBIZ-6112.patch
>
>
> When expiring a contact mechanism, an incorrect error is displayed.  This is 
> mostly an error due to code reuse.  There is no reason to redirect back to 
> editcontactmech, instead just redirect to viewprofile.  See attached patch.
> "The contact information specified does not belong to you, you may not view 
> or edit it."
> Repro:
> 1) Login to http://demo-stable-ofbiz.apache.org/ecommerce/control/main as 
> DemoCustomer.
> 2) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/viewprofile
> 3) Click Expire next to one of the Postal Addresses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


RE : [PROPOSAL] Change name of birt component

2015-02-25 Thread Youssef Khaye
Good idea but I prefer report-engine or report-tools. 

 Message d'origine De : Pierre Smits 
 Date :26/02/2015  00:46  (GMT+01:00) 
A : dev@ofbiz.apache.org Objet : [PROPOSAL] Change name 
of birt component 
Hi all,

Currently, all component names describe - in one word - what the components
are about and what kind of functionality the user - from a business point
of view - can expect. As examples: accounting is related to the various
accounting (financial, gl, invoicing, payment, , etc) functions and
services, and projectmgr is related to program and project management,
project task assignment and time registration.

The birt component is a bit the odd one out. The name doesn't say in that
one word what it delivers. In stead it is an acronym for a specific third
party integration solution and another open source project with the same
name (birt, see https://en.wikipedia.org/wiki/BIRT_Project ). One could
even say it is the name of a tool, not the name of a business
functionality.

In order to be able to increase awareness of the multitude of business
functionalities (as could be done by using the name of the components) and
improve adoption, I suggest to change the name (and the references to it in
the component and others) to something that is more to the point business
wise.

I propose we rename it to 'reports'.

What do you think?

Best regards,


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com


Re: [PROPOSAL] Change name of birt component

2015-02-25 Thread Ron Wheeler

Why not get all trendy and 2015ish and call it Analytics

That way it could also produce dashboards and graphs as well as reports.

Ron

On 25/02/2015 6:46 PM, Pierre Smits wrote:

Hi all,

Currently, all component names describe - in one word - what the components
are about and what kind of functionality the user - from a business point
of view - can expect. As examples: accounting is related to the various
accounting (financial, gl, invoicing, payment, , etc) functions and
services, and projectmgr is related to program and project management,
project task assignment and time registration.

The birt component is a bit the odd one out. The name doesn't say in that
one word what it delivers. In stead it is an acronym for a specific third
party integration solution and another open source project with the same
name (birt, see https://en.wikipedia.org/wiki/BIRT_Project ). One could
even say it is the name of a tool, not the name of a business
functionality.

In order to be able to increase awareness of the multitude of business
functionalities (as could be done by using the name of the components) and
improve adoption, I suggest to change the name (and the references to it in
the component and others) to something that is more to the point business
wise.

I propose we rename it to 'reports'.

What do you think?

Best regards,


Pierre Smits

*ORRTIZ.COM *
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



[jira] [Closed] (OFBIZ-6112) Incorrect Error Displayed when "Expiring" a Contact Mechanism

2015-02-25 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6112.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux

Thanks Forrest,

Committed in
trunk r1662361
R14.12 r1662362
R13.07 r1662363
R12.04 r1662364

Please use patches in right format, yours can't be applied as is.




> Incorrect Error Displayed when "Expiring" a Contact Mechanism
> -
>
> Key: OFBIZ-6112
> URL: https://issues.apache.org/jira/browse/OFBIZ-6112
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk, 13.07.01
>Reporter: Forrest Rae
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6112.patch
>
>
> When expiring a contact mechanism, an incorrect error is displayed.  This is 
> mostly an error due to code reuse.  There is no reason to redirect back to 
> editcontactmech, instead just redirect to viewprofile.  See attached patch.
> "The contact information specified does not belong to you, you may not view 
> or edit it."
> Repro:
> 1) Login to http://demo-stable-ofbiz.apache.org/ecommerce/control/main as 
> DemoCustomer.
> 2) Navigate to 
> http://demo-stable-ofbiz.apache.org/ecommerce/control/viewprofile
> 3) Click Expire next to one of the Postal Addresses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337982#comment-14337982
 ] 

Jacques Le Roux commented on OFBIZ-5757:


Initially it was a question, you asked me to elaborate: "should we keep 
load-tenant-admin-user-login as a main tenant target?" In other words, can it 
still be used alone. For instance after create-tenant?

Same question for 
  load-all-tenants
  load-demo-multitenant
  load-tenant
all that is confusing and from my experience, at least load-tenant and 
load-tenant-admin-user-login used in sequence, are no longer working.

In other words are, as you suggested, 
  create-tenant
  load-tenant-data-readers
not enough? 






> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-2976) view-entity with condition-expr joined with another view-entity as rel-optional=true is treated as rel-optional=false

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337993#comment-14337993
 ] 

Jacques Le Roux edited comment on OFBIZ-2976 at 2/26/15 6:41 AM:
-

Then Jennifer reported that it was broken. I must say I did not check then, nor 
yesterday.

She said:
{quote}
The fact that the conditions from the subquery in the from have been moved to 
the top level query create the effect of an inner join even though an outer 
join is specified.

The top level where is built by GenericDAO through 
ModelViewEntity.populateViewEntityConditionInformation. The change to 
ModelViewEntity.populateViewEntityConditionInformation moved this condition to 
the top was committed in r805519.

The code that builds the subquery view in the from is 
SqlJdbcUtil.makeViewWhereClause. It looks like it's never added conditions 
(only joins) going back to v4.0.
{quote}

Maybe it works correctly now, I don't know. If it's not the case, the 
unfortunate aspect is the patch no longer applies at all. It should have been 
reviewed then. Better by you than any other, since you commited r805519. We can 
maybe still use it, but it would be a hand work to extract the relevant lines.


was (Author: jacques.le.roux):
Then Jennifer reported that it was broken. I must say I did not check then, nor 
yesterday.

She said:
{quote}
The fact that the conditions from the subquery in the from have been moved to 
the top level query create the effect of an inner join even though an outer 
join is specified.

The top level where is built by GenericDAO through 
ModelViewEntity.populateViewEntityConditionInformation. The change to 
ModelViewEntity.populateViewEntityConditionInformation moved this condition to 
the top was committed in r805519.

The code that builds the subquery view in the from is 
SqlJdbcUtil.makeViewWhereClause. It looks like it's never added conditions 
(only joins) going back to v4.0.
{quote}

Maybe it works correctly now,I don't know. If it's not the case, the 
unfortunate aspect is the patch no longer applies. It should have been reviewed 
then. Better by you than any other, since you commited r805519. We can maybe 
still use it, but it would be a hand work to extract the relevant lines.

> view-entity with condition-expr joined with another view-entity as 
> rel-optional=true is treated as rel-optional=false
> -
>
> Key: OFBIZ-2976
> URL: https://issues.apache.org/jira/browse/OFBIZ-2976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
> Environment: Java v1.5.0_19-b02-298 MacOS X 10.5.8
>Reporter: Jennifer Weston
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: JIRA-Issue2976.patch
>
>
> If a view-entity is defined with condition-exprs and used as a member-entity 
> in a second view-entity and the view-link is rel-optional=true, the link is 
> treated as rel-optional=false.
> In the following example, the view-entity PPRMinQty is a list of all 
> PriceBreakRules that have a minimum quantity defined. The view-entity 
> ProductPriceBreakMinQty uses PPRMinQty with ProductCategoryMember and 
> ProductPriceCond (this time used for product categories) to create a list of 
> productIds with their productPriceRuleIds and their minimum quantities (if 
> any). The rel-optional=true should mean that even productPriceRuleids that 
> don't have a minimum quantity defined should be included in the result set.
>  package-name="com.mavericklabel"
> title="Minimum qty for a product price rule">
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
> 
> 
> 
>  operator="equals" value="PRIP_QUANTITY"/>
>  operator="equals" value="PRC_GTE"/>
> 
> 
> 
>  package-name="com.mavericklabel"
> title="Price breaks for each product with their minimum quantity (min 
> qty is optional)">
> 
> 
> 
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
>  field="operatorEnumId"/>
> 
> 
> 
>  rel-optional="true">
> 
> 
> 
> 
>  field-name="inputParamEnumId" operator="equals" value="PRIP_PROD_CAT_ID"/>
>  operator="equals" value="PRC_EQ"/>
> 
> 
> 
> The resulting SQL looks like this:
> SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
> PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
> (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
> ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
> PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRO

[jira] [Commented] (OFBIZ-2976) view-entity with condition-expr joined with another view-entity as rel-optional=true is treated as rel-optional=false

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337993#comment-14337993
 ] 

Jacques Le Roux commented on OFBIZ-2976:


Then Jennifer reported that it was broken. I must say I did not check then, nor 
yesterday.

She said:
{quote}
The fact that the conditions from the subquery in the from have been moved to 
the top level query create the effect of an inner join even though an outer 
join is specified.

The top level where is built by GenericDAO through 
ModelViewEntity.populateViewEntityConditionInformation. The change to 
ModelViewEntity.populateViewEntityConditionInformation moved this condition to 
the top was committed in r805519.

The code that builds the subquery view in the from is 
SqlJdbcUtil.makeViewWhereClause. It looks like it's never added conditions 
(only joins) going back to v4.0.
{quote}

Maybe it works correctly now,I don't know. If it's not the case, the 
unfortunate aspect is the patch no longer applies. It should have been reviewed 
then. Better by you than any other, since you commited r805519. We can maybe 
still use it, but it would be a hand work to extract the relevant lines.

> view-entity with condition-expr joined with another view-entity as 
> rel-optional=true is treated as rel-optional=false
> -
>
> Key: OFBIZ-2976
> URL: https://issues.apache.org/jira/browse/OFBIZ-2976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
> Environment: Java v1.5.0_19-b02-298 MacOS X 10.5.8
>Reporter: Jennifer Weston
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: JIRA-Issue2976.patch
>
>
> If a view-entity is defined with condition-exprs and used as a member-entity 
> in a second view-entity and the view-link is rel-optional=true, the link is 
> treated as rel-optional=false.
> In the following example, the view-entity PPRMinQty is a list of all 
> PriceBreakRules that have a minimum quantity defined. The view-entity 
> ProductPriceBreakMinQty uses PPRMinQty with ProductCategoryMember and 
> ProductPriceCond (this time used for product categories) to create a list of 
> productIds with their productPriceRuleIds and their minimum quantities (if 
> any). The rel-optional=true should mean that even productPriceRuleids that 
> don't have a minimum quantity defined should be included in the result set.
>  package-name="com.mavericklabel"
> title="Minimum qty for a product price rule">
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
> 
> 
> 
>  operator="equals" value="PRIP_QUANTITY"/>
>  operator="equals" value="PRC_GTE"/>
> 
> 
> 
>  package-name="com.mavericklabel"
> title="Price breaks for each product with their minimum quantity (min 
> qty is optional)">
> 
> 
> 
> 
>  field="productPriceRuleId"/>
> 
>  field="inputParamEnumId"/>
>  field="operatorEnumId"/>
> 
> 
> 
>  rel-optional="true">
> 
> 
> 
> 
>  field-name="inputParamEnumId" operator="equals" value="PRIP_PROD_CAT_ID"/>
>  operator="equals" value="PRC_EQ"/>
> 
> 
> 
> The resulting SQL looks like this:
> SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
> PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
> (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
> ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
> PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
> PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, 
> PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND 
> PPC) MINQTY ON PPRCAT.PRODUCT_PRICE_RULE_ID = 
> MINQTY.PPC_PRODUCT_PRICE_RULE_ID WHERE ((PPRCAT.INPUT_PARAM_ENUM_ID = 
> 'PRIP_PROD_CAT_ID' AND PPRCAT.OPERATOR_ENUM_ID = 'PRC_EQ') AND 
> (PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND PPC.OPERATOR_ENUM_ID = 
> 'PRC_GTE'))
> instead of 
> SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
> PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
> (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
> ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
> PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
> PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, 
> PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND 
> PPC WHERE ((PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND 
> PPC.OPERATOR_ENUM_ID = 'PRC_G

[jira] [Comment Edited] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336288#comment-14336288
 ] 

Jacques Le Roux edited comment on OFBIZ-6110 at 2/26/15 6:48 AM:
-

Yes I read 
https://cwiki.apache.org/confluence/display/OFBIZ/Roadmap+Diagrams+-+In+Progress
 some time ago, but I have really to think more about it. I'm a bit reluctant 
to do so, at least for now. First thing which comes to my mind is cloned 
web-apps. AFAIK we can have only 1 web-app by web.xml file. I just read that 
[Resin has a special setting for 
that|http://www.caucho.com/resin-4.0/admin/http-web-apps.xtp#definingwebxmlinresinxml],
 but [it's not 
standard|http://docs.oracle.com/cd/E13222_01/wls/docs100/webapp/web_xml.html]


was (Author: jacques.le.roux):
Yes I read https://cwiki.apache.org/confluence/display/OFBIZ/Draft+Roadmaps 
some time ago, but I have really to think more about it. I'm a bit reluctant to 
do so, at least for now. First thing which comes to my mind is cloned web-apps. 
AFAIK we can have only 1 web-app by web.xml file. I just read that [Resin has a 
special setting for 
that|http://www.caucho.com/resin-4.0/admin/http-web-apps.xtp#definingwebxmlinresinxml],
 but [it's not 
standard|http://docs.oracle.com/cd/E13222_01/wls/docs100/webapp/web_xml.html]

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338006#comment-14338006
 ] 

Jacques Le Roux commented on OFBIZ-6110:


>How many installations use eCommerce as opposed to other Base Applications 
>such as Human Resources?
I believe currently there are still much more custom installations which are 
more using the ecommerce component than any applications component.

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6038) Problem with Purchase Order and Create invoice from Purchase Order!

2015-02-25 Thread Storm Trinh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338009#comment-14338009
 ] 

Storm Trinh commented on OFBIZ-6038:


Dear Sharan,

I agree with you when we use "Set Shipment Status to Received". However, when 
we have "tolerance", meaning we accepted tolerance: Quantity Received = 960, 
Quantity Ordered = 1000, tolerance = 5%, the invoice is generated with Quantity 
Invoice = Quantity Ordered = 1000, not equals Quantity Received = 960.

In this case, I think we can use Quantity Invoice = Quantity Ordered, then we 
find reasons and create transactions to it.
(Reason : lost, excess, damaged ... ) 

> Problem with Purchase Order and Create invoice from Purchase Order!
> ---
>
> Key: OFBIZ-6038
> URL: https://issues.apache.org/jira/browse/OFBIZ-6038
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, framework, order
>Reporter: Storm Trinh
>Assignee: Sharan Foga
>
> Following steps i have done:
> 1. Create Purchase Order.
> 2. Approve Purchase Order.
> 3. Quick Receive Purchase Order
> 4. Select Shipment to Receive and Click Receive Selected Shipment
> 5. Receive Selected Products  ( Choose Inventory Item Type,  Quantity 
> Received (as Quantity Accepted), Quantity Rejected  - Reason)
>  - If  ((Quantity Accepted +  Quantity Rejected) >= Quantity Ordered), Ofbiz  
> call service to create accounting transaction for  Quantity Accepted  (not 
> for Quantity Rejected), then create invoice from Order.
>   However, when Quantity Accepted is not  equals Quantity from Order, Invoice 
> from order can't create and can't do it ==> I think it is a bug.
> In the fact that,  Quantity Rejected < Maximum quantity Rejected ( rule of 
> Supplier and Customer) meaning Quantity Accepted is not  equals Quantity from 
> Order,  Invoice from order will be created and create accounting transaction 
> for Quantity Rejected.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-6071) Issue in decrypting entity fields where encrypt="true" is used in tenant

2015-02-25 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-6071:

Comment: was deleted

(was: Yes Jacques, we tested  R13.07 and this issue is not there. )

> Issue in decrypting entity fields where encrypt="true" is used in tenant 
> -
>
> Key: OFBIZ-6071
> URL: https://issues.apache.org/jira/browse/OFBIZ-6071
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Jacopo Cappellato
>Priority: Blocker
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6071.patch
>
>
> Error while adding a credit card from order manager when logged in with 
> tenant account.
> The error is as following:
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#editcreditcard]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#PaymentMethodDecorator]:
>  org.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Failure in 
> findByCondition operation for entity [CreditCard]: 
> org.ofbiz.entity.GenericEntityException: Error creating GenericValue 
> (org.ofbiz.base.util.GeneralException: javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly padded) 
> (javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded))). Rolling back 
> transaction.org.ofbiz.entity.GenericEntityException: Error creating 
> GenericValue (org.ofbiz.base.util.GeneralException: 
> javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded) (javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly 
> padded))) 
> It seems there is some issue with encryption-decryption mechanism for the 
> fields of an entity for which encrypt="true" is set. From the exception it 
> seemed that incorrect key is being used for decryption i.e. the key is not 
> appropriate with respect to the one which was used for encryption.
> After tracing the process flow we suspect that in SqlJdbcUtil.java while 
> calling 'decryptFieldValue' the delegator which is being used is 
> baseDelegator instead of tenant's delegator, but at the time of encryption 
> using 'encryptFieldValue' the delegator was tenant's delegator. May be this 
> is the reason why it is generating "javax.crypto.BadPaddingException".
> Steps to regenerate:
> 1. Create a tenant and login to tenant's admin account.
> 2. Navigate to ORDER > Order Entry > Sales Order
> 3. Use Demo Customer as Customer and continue.
> 4. Add some item to order and proceed for Quick Finalize Order.
> 5. Try to add new credit card.
> 6. On saving credit card information it will generate the above error. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6071) Issue in decrypting entity fields where encrypt="true" is used in tenant

2015-02-25 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338014#comment-14338014
 ] 

Divesh Dutta commented on OFBIZ-6071:
-

Yes Jacques, we tested  R13.07 and this issue is not there. 

> Issue in decrypting entity fields where encrypt="true" is used in tenant 
> -
>
> Key: OFBIZ-6071
> URL: https://issues.apache.org/jira/browse/OFBIZ-6071
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Jacopo Cappellato
>Priority: Blocker
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6071.patch
>
>
> Error while adding a credit card from order manager when logged in with 
> tenant account.
> The error is as following:
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#editcreditcard]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#PaymentMethodDecorator]:
>  org.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Failure in 
> findByCondition operation for entity [CreditCard]: 
> org.ofbiz.entity.GenericEntityException: Error creating GenericValue 
> (org.ofbiz.base.util.GeneralException: javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly padded) 
> (javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded))). Rolling back 
> transaction.org.ofbiz.entity.GenericEntityException: Error creating 
> GenericValue (org.ofbiz.base.util.GeneralException: 
> javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded) (javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly 
> padded))) 
> It seems there is some issue with encryption-decryption mechanism for the 
> fields of an entity for which encrypt="true" is set. From the exception it 
> seemed that incorrect key is being used for decryption i.e. the key is not 
> appropriate with respect to the one which was used for encryption.
> After tracing the process flow we suspect that in SqlJdbcUtil.java while 
> calling 'decryptFieldValue' the delegator which is being used is 
> baseDelegator instead of tenant's delegator, but at the time of encryption 
> using 'encryptFieldValue' the delegator was tenant's delegator. May be this 
> is the reason why it is generating "javax.crypto.BadPaddingException".
> Steps to regenerate:
> 1. Create a tenant and login to tenant's admin account.
> 2. Navigate to ORDER > Order Entry > Sales Order
> 3. Use Demo Customer as Customer and continue.
> 4. Add some item to order and proceed for Quick Finalize Order.
> 5. Try to add new credit card.
> 6. On saving credit card information it will generate the above error. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6071) Issue in decrypting entity fields where encrypt="true" is used in tenant

2015-02-25 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338013#comment-14338013
 ] 

Divesh Dutta commented on OFBIZ-6071:
-

Yes Jacques, we tested  R13.07 and this issue is not there. 

> Issue in decrypting entity fields where encrypt="true" is used in tenant 
> -
>
> Key: OFBIZ-6071
> URL: https://issues.apache.org/jira/browse/OFBIZ-6071
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Jacopo Cappellato
>Priority: Blocker
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6071.patch
>
>
> Error while adding a credit card from order manager when logged in with 
> tenant account.
> The error is as following:
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#editcreditcard]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#PaymentMethodDecorator]:
>  org.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Failure in 
> findByCondition operation for entity [CreditCard]: 
> org.ofbiz.entity.GenericEntityException: Error creating GenericValue 
> (org.ofbiz.base.util.GeneralException: javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly padded) 
> (javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded))). Rolling back 
> transaction.org.ofbiz.entity.GenericEntityException: Error creating 
> GenericValue (org.ofbiz.base.util.GeneralException: 
> javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded) (javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly 
> padded))) 
> It seems there is some issue with encryption-decryption mechanism for the 
> fields of an entity for which encrypt="true" is set. From the exception it 
> seemed that incorrect key is being used for decryption i.e. the key is not 
> appropriate with respect to the one which was used for encryption.
> After tracing the process flow we suspect that in SqlJdbcUtil.java while 
> calling 'decryptFieldValue' the delegator which is being used is 
> baseDelegator instead of tenant's delegator, but at the time of encryption 
> using 'encryptFieldValue' the delegator was tenant's delegator. May be this 
> is the reason why it is generating "javax.crypto.BadPaddingException".
> Steps to regenerate:
> 1. Create a tenant and login to tenant's admin account.
> 2. Navigate to ORDER > Order Entry > Sales Order
> 3. Use Demo Customer as Customer and continue.
> 4. Add some item to order and proceed for Quick Finalize Order.
> 5. Try to add new credit card.
> 6. On saving credit card information it will generate the above error. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-6071) Issue in decrypting entity fields where encrypt="true" is used in tenant

2015-02-25 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-6071:

Comment: was deleted

(was: Yes Jacques, we tested  R13.07 and this issue is not there. )

> Issue in decrypting entity fields where encrypt="true" is used in tenant 
> -
>
> Key: OFBIZ-6071
> URL: https://issues.apache.org/jira/browse/OFBIZ-6071
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Jacopo Cappellato
>Priority: Blocker
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6071.patch
>
>
> Error while adding a credit card from order manager when logged in with 
> tenant account.
> The error is as following:
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#editcreditcard]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#PaymentMethodDecorator]:
>  org.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Failure in 
> findByCondition operation for entity [CreditCard]: 
> org.ofbiz.entity.GenericEntityException: Error creating GenericValue 
> (org.ofbiz.base.util.GeneralException: javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly padded) 
> (javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded))). Rolling back 
> transaction.org.ofbiz.entity.GenericEntityException: Error creating 
> GenericValue (org.ofbiz.base.util.GeneralException: 
> javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded) (javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly 
> padded))) 
> It seems there is some issue with encryption-decryption mechanism for the 
> fields of an entity for which encrypt="true" is set. From the exception it 
> seemed that incorrect key is being used for decryption i.e. the key is not 
> appropriate with respect to the one which was used for encryption.
> After tracing the process flow we suspect that in SqlJdbcUtil.java while 
> calling 'decryptFieldValue' the delegator which is being used is 
> baseDelegator instead of tenant's delegator, but at the time of encryption 
> using 'encryptFieldValue' the delegator was tenant's delegator. May be this 
> is the reason why it is generating "javax.crypto.BadPaddingException".
> Steps to regenerate:
> 1. Create a tenant and login to tenant's admin account.
> 2. Navigate to ORDER > Order Entry > Sales Order
> 3. Use Demo Customer as Customer and continue.
> 4. Add some item to order and proceed for Quick Finalize Order.
> 5. Try to add new credit card.
> 6. On saving credit card information it will generate the above error. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6071) Issue in decrypting entity fields where encrypt="true" is used in tenant

2015-02-25 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338015#comment-14338015
 ] 

Divesh Dutta commented on OFBIZ-6071:
-

Yes Jacques, we tested  R13.07 and this issue is not there. 

> Issue in decrypting entity fields where encrypt="true" is used in tenant 
> -
>
> Key: OFBIZ-6071
> URL: https://issues.apache.org/jira/browse/OFBIZ-6071
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Jacopo Cappellato
>Priority: Blocker
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6071.patch
>
>
> Error while adding a credit card from order manager when logged in with 
> tenant account.
> The error is as following:
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#editcreditcard]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#PaymentMethodDecorator]:
>  org.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Failure in 
> findByCondition operation for entity [CreditCard]: 
> org.ofbiz.entity.GenericEntityException: Error creating GenericValue 
> (org.ofbiz.base.util.GeneralException: javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly padded) 
> (javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded))). Rolling back 
> transaction.org.ofbiz.entity.GenericEntityException: Error creating 
> GenericValue (org.ofbiz.base.util.GeneralException: 
> javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded) (javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly 
> padded))) 
> It seems there is some issue with encryption-decryption mechanism for the 
> fields of an entity for which encrypt="true" is set. From the exception it 
> seemed that incorrect key is being used for decryption i.e. the key is not 
> appropriate with respect to the one which was used for encryption.
> After tracing the process flow we suspect that in SqlJdbcUtil.java while 
> calling 'decryptFieldValue' the delegator which is being used is 
> baseDelegator instead of tenant's delegator, but at the time of encryption 
> using 'encryptFieldValue' the delegator was tenant's delegator. May be this 
> is the reason why it is generating "javax.crypto.BadPaddingException".
> Steps to regenerate:
> 1. Create a tenant and login to tenant's admin account.
> 2. Navigate to ORDER > Order Entry > Sales Order
> 3. Use Demo Customer as Customer and continue.
> 4. Add some item to order and proceed for Quick Finalize Order.
> 5. Try to add new credit card.
> 6. On saving credit card information it will generate the above error. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6071) Issue in decrypting entity fields where encrypt="true" is used in tenant

2015-02-25 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338024#comment-14338024
 ] 

Jacques Le Roux commented on OFBIZ-6071:


Thanks Divesh!

> Issue in decrypting entity fields where encrypt="true" is used in tenant 
> -
>
> Key: OFBIZ-6071
> URL: https://issues.apache.org/jira/browse/OFBIZ-6071
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Jacopo Cappellato
>Priority: Blocker
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6071.patch
>
>
> Error while adding a credit card from order manager when logged in with 
> tenant account.
> The error is as following:
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#editcreditcard]: 
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
> [component://party/widget/partymgr/PaymentMethodScreens.xml#PaymentMethodDecorator]:
>  org.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Failure in 
> findByCondition operation for entity [CreditCard]: 
> org.ofbiz.entity.GenericEntityException: Error creating GenericValue 
> (org.ofbiz.base.util.GeneralException: javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly padded) 
> (javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded))). Rolling back 
> transaction.org.ofbiz.entity.GenericEntityException: Error creating 
> GenericValue (org.ofbiz.base.util.GeneralException: 
> javax.crypto.BadPaddingException: Given final block not properly padded 
> (Given final block not properly padded) (javax.crypto.BadPaddingException: 
> Given final block not properly padded (Given final block not properly 
> padded))) 
> It seems there is some issue with encryption-decryption mechanism for the 
> fields of an entity for which encrypt="true" is set. From the exception it 
> seemed that incorrect key is being used for decryption i.e. the key is not 
> appropriate with respect to the one which was used for encryption.
> After tracing the process flow we suspect that in SqlJdbcUtil.java while 
> calling 'decryptFieldValue' the delegator which is being used is 
> baseDelegator instead of tenant's delegator, but at the time of encryption 
> using 'encryptFieldValue' the delegator was tenant's delegator. May be this 
> is the reason why it is generating "javax.crypto.BadPaddingException".
> Steps to regenerate:
> 1. Create a tenant and login to tenant's admin account.
> 2. Navigate to ORDER > Order Entry > Sales Order
> 3. Use Demo Customer as Customer and continue.
> 4. Add some item to order and proceed for Quick Finalize Order.
> 5. Try to add new credit card.
> 6. On saving credit card information it will generate the above error. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5757) Remove tenant data from the demo data set

2015-02-25 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338046#comment-14338046
 ] 

Pierre Smits commented on OFBIZ-5757:
-

See my comment from 09/Sep/14 08:10. . 

./ant load-tenant-admin-user-login is used as part of ./ant create-tenant, and 
as such it is needed. Like load-admin-user-login is used by ./ant 
create-admin-user-login. 

I have never used any of the other ./ant targets in relation to tenant admin 
activities. If I were the only user of multi-tenancy capabilities I would say 
these others are not needed.




> Remove tenant data from the demo data set
> -
>
> Key: OFBIZ-5757
> URL: https://issues.apache.org/jira/browse/OFBIZ-5757
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tenant
> Attachments: OFBIZ-5757-TenantCleanup.patch
>
>
> The demo data set (in location /framework/entity/data/TenantDemoData.xml) 
> contains elements to load the tenants DEMO1 and DEMO2 into the implemented 
> OFBiz setup.
> This data set is intended to be loaded into the master tables when a user 
> wants to explore multity tenancy. However, when a user also wants/needs to 
> load demo data into the tenant DEMO1 or DEMO2 OFBiz also tries to upload the 
> demo setup data for each tenant. This is not allowed as tenants do not have 
> access to tables:
> # Tenant
> # Tenantdatasource
> # etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2015-02-25 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338053#comment-14338053
 ] 

Pierre Smits commented on OFBIZ-6110:
-

This issue is not about moving applications from one stack to another.

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)